@hypersolid-dev/eslint-config 5.0.0 → 7.0.0

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-dropped-aria-on-text.js

@@ -1,7 +1,7 @@
 import { ARIA_DROPPED_ON_TEXT } from "../constants/accessibility-props.js";
 import { TEXTS } from "../constants/react-native-components.js";
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
 import getProperty from "../utils/get-property.js";
@@ -36,13 +36,13 @@ const noDroppedAriaOnText = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TEXTS,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native/a11y/rules/no-font-scaling-disabled.js

@@ -0,0 +1,47 @@
+import createRule from "../../../shared/create-rule.js";
+import getLiteralPropertyValue from "../utils/get-literal-property-value.js";
+import getProperty from "../utils/get-property.js";
+/** WCAG 1.4.4 asks for text to resize up to 200%. */
+const MINIMUM_MULTIPLIER = 2;
+/** React Native reads `0` as "no maximum", which is the opposite of a cap. */
+const NO_MAXIMUM = 0;
+const noFontScalingDisabled = createRule({
+    name: "no-font-scaling-disabled",
+    meta: {
+        defaultOptions: [],
+        type: "problem",
+        docs: {
+            description: "Disallow opting text out of the system font scale below the level WCAG 1.4.4 requires.",
+        },
+        messages: {
+            fontScalingDisabled: "'allowFontScaling={false}' stops this text respecting the system font size. Cap it with 'maxFontSizeMultiplier' instead if one element cannot grow.",
+            fontScalingCapped: "'maxFontSizeMultiplier={{{ multiplier }}}' caps text below the 200% WCAG 1.4.4 requires. Reserve a cap under {{ minimum }} for chrome whose information is available elsewhere.",
+        },
+        schema: [],
+    },
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const allowFontScaling = getProperty(node, "allowFontScaling");
+            if (allowFontScaling &&
+                getLiteralPropertyValue(node, "allowFontScaling") === false) {
+                context.report({
+                    node: allowFontScaling,
+                    messageId: "fontScalingDisabled",
+                });
+            }
+            const cap = getProperty(node, "maxFontSizeMultiplier");
+            const multiplier = getLiteralPropertyValue(node, "maxFontSizeMultiplier");
+            if (cap &&
+                typeof multiplier === "number" &&
+                multiplier !== NO_MAXIMUM &&
+                multiplier < MINIMUM_MULTIPLIER) {
+                context.report({
+                    node: cap,
+                    messageId: "fontScalingCapped",
+                    data: { multiplier, minimum: MINIMUM_MULTIPLIER },
+                });
+            }
+        },
+    }),
+});
+export default noFontScalingDisabled;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-ineffective-accessibility-props.js

@@ -1,5 +1,5 @@
 import { IMAGES, VIEWS } from "../constants/react-native-components.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getElementName from "../utils/get-element-name.js";
 import getLiteralPropertyValue from "../utils/get-literal-property-value.js";
 import getProperty from "../utils/get-property.js";
@@ -31,46 +31,44 @@ const noIneffectiveAccessibilityProps = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                const role = getLiteralPropertyValue(node, ["accessibilityRole", "role"]);
-                if (role === "listitem") {
-                    context.report({ node, messageId: "listItemRole" });
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const role = getLiteralPropertyValue(node, ["accessibilityRole", "role"]);
+            if (role === "listitem") {
+                context.report({ node, messageId: "listItemRole" });
+            }
+            if (role === "alert") {
+                context.report({ node, messageId: "alertRole" });
+            }
+            const isHidden = isDefinitelyHidden(node);
+            if (isHidden && hasLabelProperty(node)) {
+                context.report({ node, messageId: "hiddenWithLabel" });
+            }
+            if (getLiteralPropertyValue(node, "accessible") === false) {
+                const name = getElementName(node);
+                if (isHidden) {
+                    context.report({ node, messageId: "hiddenWithAccessibleFalse" });
                 }
-                if (role === "alert") {
-                    context.report({ node, messageId: "alertRole" });
-                }
-                const isHidden = isDefinitelyHidden(node);
-                if (isHidden && hasLabelProperty(node)) {
-                    context.report({ node, messageId: "hiddenWithLabel" });
-                }
-                if (getLiteralPropertyValue(node, "accessible") === false) {
-                    const name = getElementName(node);
-                    if (isHidden) {
-                        context.report({ node, messageId: "hiddenWithAccessibleFalse" });
-                    }
-                    else if (name !== undefined &&
-                        DEFAULTS_TO_INACCESSIBLE.has(name) &&
-                        // A spread may carry the `accessible` this one is overriding.
-                        !hasSpreadProps(node)) {
-                        context.report({
-                            node,
-                            messageId: "accessibleFalseIsDefault",
-                            data: { name },
-                        });
-                    }
-                }
-                const labelledBy = getProperty(node, LABELLED_BY_PROPS);
-                if (labelledBy && !hasLabelProperty(node)) {
+                else if (name !== undefined &&
+                    DEFAULTS_TO_INACCESSIBLE.has(name) &&
+                    // A spread may carry the `accessible` this one is overriding.
+                    !hasSpreadProps(node)) {
                     context.report({
                         node,
-                        messageId: "labelledByWithoutLabel",
-                        data: { prop: labelledBy.name.name },
+                        messageId: "accessibleFalseIsDefault",
+                        data: { name },
                     });
                 }
-            },
-        };
-    },
+            }
+            const labelledBy = getProperty(node, LABELLED_BY_PROPS);
+            if (labelledBy && !hasLabelProperty(node)) {
+                context.report({
+                    node,
+                    messageId: "labelledByWithoutLabel",
+                    data: { prop: labelledBy.name.name },
+                });
+            }
+        },
+    }),
 });
 export default noIneffectiveAccessibilityProps;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-invalid-accessibility-state.js

@@ -1,6 +1,6 @@
 import { ASTUtils, AST_NODE_TYPES, } from "@typescript-eslint/utils";
 import { ACCESSIBILITY_STATE_KEYS } from "../constants/accessibility-state.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getProperty from "../utils/get-property.js";
 /** `{ … } as const` and `{ … } satisfies T` are still that object. */
 const unwrap = (node) => {
@@ -44,39 +44,37 @@ const noInvalidAccessibilityState = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                const attribute = getProperty(node, "accessibilityState");
-                if (attribute?.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
-                    return;
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const attribute = getProperty(node, "accessibilityState");
+            if (attribute?.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
+                return;
+            }
+            const { expression } = attribute.value;
+            // An object literal here is already rejected by the React Native types
+            if (expression.type !== AST_NODE_TYPES.Identifier) {
+                return;
+            }
+            const resolved = resolveObjectBinding(context.sourceCode.getScope(expression), expression);
+            if (!resolved) {
+                return;
+            }
+            for (const property of resolved.properties) {
+                if (property.type !== AST_NODE_TYPES.Property ||
+                    property.key.type !== AST_NODE_TYPES.Identifier ||
+                    ACCESSIBILITY_STATE_KEYS.includes(property.key.name)) {
+                    continue;
                 }
-                const { expression } = attribute.value;
-                // An object literal here is already rejected by the React Native types
-                if (expression.type !== AST_NODE_TYPES.Identifier) {
-                    return;
-                }
-                const resolved = resolveObjectBinding(context.sourceCode.getScope(expression), expression);
-                if (!resolved) {
-                    return;
-                }
-                for (const property of resolved.properties) {
-                    if (property.type !== AST_NODE_TYPES.Property ||
-                        property.key.type !== AST_NODE_TYPES.Identifier ||
-                        ACCESSIBILITY_STATE_KEYS.includes(property.key.name)) {
-                        continue;
-                    }
-                    context.report({
-                        node: property,
-                        messageId: "invalidStateKey",
-                        data: {
-                            key: property.key.name,
-                            supported: ACCESSIBILITY_STATE_KEYS.join(", "),
-                        },
-                    });
-                }
-            },
-        };
-    },
+                context.report({
+                    node: property,
+                    messageId: "invalidStateKey",
+                    data: {
+                        key: property.key.name,
+                        supported: ACCESSIBILITY_STATE_KEYS.join(", "),
+                    },
+                });
+            }
+        },
+    }),
 });
 export default noInvalidAccessibilityState;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-nested-focus-stops.js

@@ -1,6 +1,6 @@
 import { TOUCHABLES } from "../constants/react-native-components.js";
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
 import getJsxDescendants from "../utils/get-jsx-descendants.js";
@@ -30,7 +30,7 @@ const noNestedFocusStops = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         // The touchables plus whatever this project wraps them in
         const components = getComponents({
             context,
@@ -44,7 +44,7 @@ const noNestedFocusStops = createRule({
                 hasTouchHandler(node));
         };
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined ||
                     !isDefinitelyGrouped(node) ||

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-press-in-activation.js

@@ -1,6 +1,6 @@
 import { TOUCHABLES } from "../constants/react-native-components.js";
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
 import getProperty from "../utils/get-property.js";
@@ -29,13 +29,13 @@ const noPressInActivation = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TOUCHABLES,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/no-unnamed-interactive.js

@@ -1,7 +1,7 @@
 import { NAME_PROPS } from "../constants/interactive.js";
 import { IMAGES, INPUTS, TEXTS, TOUCHABLES, } from "../constants/react-native-components.js";
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getAmountOfTextChildren from "../utils/get-amount-of-text-children.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
@@ -38,10 +38,10 @@ const noUnnamedInteractive = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({ context });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/require-invert-colors-opt-out.js

@@ -1,6 +1,6 @@
 import { IMAGES } from "../constants/react-native-components.js";
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
 import hasProperty from "../utils/has-property.js";
@@ -29,7 +29,7 @@ const requireInvertColorsOptOut = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         /**
          * Matched on the element name, so an image from expo-image or a wrapper
          * named through additionalComponents is checked the same way. Deliberately
@@ -41,7 +41,7 @@ const requireInvertColorsOptOut = createRule({
             defaultComponents: IMAGES,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/{react-native-a11y → react-native/a11y}/rules/require-modal-a11y-on-sheets.js

@@ -1,5 +1,5 @@
 import schemaProperties from "../constants/schema-properties.js";
-import createRule from "../utils/create-rule.js";
+import createRule from "../../../shared/create-rule.js";
 import getComponents from "../utils/get-components.js";
 import getElementName from "../utils/get-element-name.js";
 import hasProperty from "../utils/has-property.js";
@@ -27,7 +27,7 @@ const requireModalA11yOnSheets = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         /**
          * No default list: a sheet is whatever this project calls one, and
          * hardcoding one library's component names would fire on a codebase that
@@ -35,7 +35,7 @@ const requireModalA11yOnSheets = createRule({
          */
         const components = getComponents({ context });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/{react-native-a11y → react-native/a11y}/utils/get-amount-of-text-children.js

@@ -32,6 +32,20 @@ const branchesOf = (expression) => {
 };
 const isJsxChild = (expression) => expression.type === AST_NODE_TYPES.JSXElement ||
     expression.type === AST_NODE_TYPES.JSXFragment;
+const countExpressionText = (expression, amount) => {
+    if (expression.type === AST_NODE_TYPES.Literal ||
+        expression.type === AST_NODE_TYPES.TemplateLiteral) {
+        return amount + 1;
+    }
+    /**
+     * JSX inside an expression renders like any other child, and a branch
+     * that renders text still names the control
+     */
+    const rendered = (isJsxChild(expression) ? [expression] : branchesOf(expression)).filter(isJsxChild);
+    return rendered.length > 0
+        ? getAmountOfTextChildren(rendered, amount)
+        : amount;
+};
 /**
  * Counts children that render visible text, which is what makes an
  * `accessibilityLabel` redundant. Whitespace between JSX tags is not text, and
@@ -42,19 +56,7 @@ const getAmountOfTextChildren = (children, oldAmount = 0) => children.reduce((am
         return child.value.trim().length > 0 ? amount + 1 : amount;
     }
     if (child.type === AST_NODE_TYPES.JSXExpressionContainer) {
-        const { expression } = child;
-        if (expression.type === AST_NODE_TYPES.Literal ||
-            expression.type === AST_NODE_TYPES.TemplateLiteral) {
-            return amount + 1;
-        }
-        /**
-         * JSX inside an expression renders like any other child, and a branch
-         * that renders text still names the control
-         */
-        const rendered = (isJsxChild(expression) ? [expression] : branchesOf(expression)).filter(isJsxChild);
-        return rendered.length > 0
-            ? getAmountOfTextChildren(rendered, amount)
-            : amount;
+        return countExpressionText(child.expression, amount);
     }
     if (child.type === AST_NODE_TYPES.JSXFragment) {
         return getAmountOfTextChildren(child.children, amount);

package/dist/plugins/{props-destructuring.d.ts → react-native/index.d.ts}

@@ -1,3 +1,4 @@
 import type { ESLint } from 'eslint';
+/** ESLint reads a scoped rule ID up to its last slash as the plugin name. */
 declare const plugin: ESLint.Plugin;
 export default plugin;

package/dist/plugins/react-native/index.js

@@ -0,0 +1,17 @@
+import testIdDefault from './rules/test-id-default.js';
+import testIdFormat from './rules/test-id-format.js';
+import testIdFromProps from './rules/test-id-from-props.js';
+import webviewAllowList from './rules/webview-allow-list.js';
+/** ESLint reads a scoped rule ID up to its last slash as the plugin name. */
+// One object per plugin name: flat config rejects two different objects under the same name.
+const plugin = {
+    meta: { name: '@hypersolid-dev/react-native' },
+    // typescript-eslint's `RuleModule` and ESLint's `Rule.RuleModule` type the same runtime object differently.
+    rules: {
+        'test-id-default': testIdDefault,
+        'test-id-format': testIdFormat,
+        'test-id-from-props': testIdFromProps,
+        'webview-allow-list': webviewAllowList,
+    },
+};
+export default plugin;

package/dist/plugins/{rules → react-native/rules}/test-id-default.js

@@ -1,6 +1,6 @@
 import path from 'node:path';
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
-import createRule from '../utils/create-rule.js';
+import createRule from '../../shared/create-rule.js';
 /**
  * A component's `testID` prop defaults to the component's own name, kebab-cased.
  *
@@ -31,24 +31,20 @@ const PASCAL_CASE_PATTERN = /^[A-Z]/;
 const LOWER_TO_UPPER_PATTERN = /(?<=[a-z0-9])(?=[A-Z])/g;
 const ACRONYM_END_PATTERN = /(?<=[A-Z])(?=[A-Z][a-z])/g;
 /** `CompetitionLogo` -> `competition-logo`, `AdSlotURLBar` -> `ad-slot-url-bar`. */
-function kebab(name) {
-    return name.replaceAll(LOWER_TO_UPPER_PATTERN, '-').replaceAll(ACRONYM_END_PATTERN, '-').toLowerCase();
-}
+const kebab = (name) => name.replaceAll(LOWER_TO_UPPER_PATTERN, '-').replaceAll(ACRONYM_END_PATTERN, '-').toLowerCase();
 /** The component a file is named for: its basename, or its folder's for an `index` file. */
-function componentName(filename) {
+const componentName = (filename) => {
     const name = path.basename(filename).replace(EXTENSION_PATTERN, '').replace(PLATFORM_PATTERN, '');
     return name === 'index' ? path.basename(path.dirname(filename)) : name;
-}
-function isHoc(callee) {
+};
+const isHoc = (callee) => {
     if (callee.type === AST_NODE_TYPES.Identifier)
         return HOC_NAMES.has(callee.name);
     return callee.type === AST_NODE_TYPES.MemberExpression && !callee.computed && HOC_NAMES.has(callee.property.name);
-}
-function isFunction(node) {
-    return Boolean(node && FUNCTION_TYPES.has(node.type));
-}
+};
+const isFunction = (node) => Boolean(node && FUNCTION_TYPES.has(node.type));
 /** Through `memo(…)`, `forwardRef(…)` and type assertions, to the component inside. */
-function unwrapComponent(node) {
+const unwrapComponent = (node) => {
     let current = node ?? undefined;
     while (current) {
         if (TS_WRAPPERS.has(current.type))
@@ -59,31 +55,31 @@ function unwrapComponent(node) {
             return current;
     }
     return current;
-}
+};
 /** What a function is held by, out through the calls and assertions it is declared behind. */
-function heldBy(fn) {
+const heldBy = (fn) => {
     let held = fn.parent;
     while (held && (held.type === AST_NODE_TYPES.CallExpression || TS_WRAPPERS.has(held.type)))
         held = held.parent;
     return held;
-}
+};
 /** Whether a function is the file's own component: named `component`, or an anonymous default export. */
-function isComponent(fn, component) {
+const isComponent = (fn, component) => {
     if (fn.type === AST_NODE_TYPES.FunctionDeclaration)
         return !fn.id || fn.id.name === component;
     const held = heldBy(fn);
     if (held?.type === AST_NODE_TYPES.ExportDefaultDeclaration)
         return true;
     return held?.type === AST_NODE_TYPES.VariableDeclarator && held.id.type === AST_NODE_TYPES.Identifier && held.id.name === component;
-}
+};
 /** The `testID` property of a destructured parameter or declarator. */
-function testIdProperty(pattern) {
+const testIdProperty = (pattern) => {
     if (pattern?.type !== AST_NODE_TYPES.ObjectPattern)
         return undefined;
     return pattern.properties.find((property) => property.type === AST_NODE_TYPES.Property && !property.computed && property.key.type === AST_NODE_TYPES.Identifier && property.key.name === 'testID');
-}
+};
 /** The names a component's props object goes by: the first parameter, or the rest of a destructured one without `testID`. */
-function propsNames(fn) {
+const propsNames = (fn) => {
     const first = fn.params.at(0);
     if (first?.type === AST_NODE_TYPES.Identifier)
         return [first.name];
@@ -91,15 +87,15 @@ function propsNames(fn) {
         return [];
     const rest = first.properties.find((property) => property.type === AST_NODE_TYPES.RestElement);
     return rest?.argument.type === AST_NODE_TYPES.Identifier ? [rest.argument.name] : [];
-}
+};
 /** The file's own component that `node` sits in, however deep in callbacks. */
-function ownComponentAround(node, component) {
+const ownComponentAround = (node, component) => {
     for (let current = node.parent; current; current = current.parent) {
         if (isFunction(current) && isComponent(current, component))
             return current;
     }
     return undefined;
-}
+};
 const testIdDefault = createRule({
     name: 'test-id-default',
     meta: {
@@ -113,7 +109,7 @@ const testIdDefault = createRule({
             wrong: 'Default this to `"{{ expected }}"`, not `{{ actual }}`: the default is the component\'s own name in kebab-case, so a reader can predict the id without opening the file.',
         },
     },
-    create(context) {
+    create: (context) => {
         const component = componentName(context.filename);
         // The file's own component only; anything else in here is private to it.
         if (!PASCAL_CASE_PATTERN.test(component))
@@ -146,7 +142,7 @@ const testIdDefault = createRule({
                 check(testIdProperty(node.params[0]));
         };
         return {
-            VariableDeclarator(node) {
+            VariableDeclarator: (node) => {
                 // `const { testID } = props` inside the file's own component reads the same prop.
                 if (node.id.type === AST_NODE_TYPES.ObjectPattern && node.init?.type === AST_NODE_TYPES.Identifier) {
                     const fn = ownComponentAround(node, component);
@@ -157,20 +153,20 @@ const testIdDefault = createRule({
                 if (node.id.type === AST_NODE_TYPES.Identifier)
                     checkFunction(unwrapComponent(node.init), node.id.name);
             },
-            FunctionDeclaration(node) {
+            FunctionDeclaration: (node) => {
                 if (node.id)
                     checkFunction(node, node.id.name);
                 else if (node.parent.type === AST_NODE_TYPES.ExportDefaultDeclaration)
                     checkFunction(node, component);
             },
             // `export default memo(({ testID }) => …)`: the anonymous component.
-            ExportDefaultDeclaration(node) {
+            ExportDefaultDeclaration: (node) => {
                 const init = unwrapComponent(node.declaration);
                 if (init?.type !== AST_NODE_TYPES.FunctionDeclaration)
                     checkFunction(init, component);
             },
             // `props.testID` read inside the component, with no default anywhere.
-            MemberExpression(node) {
+            MemberExpression: (node) => {
                 if (node.computed || node.property.type !== AST_NODE_TYPES.Identifier || node.property.name !== 'testID')
                     return;
                 if (node.object.type !== AST_NODE_TYPES.Identifier)

package/dist/plugins/{rules → react-native/rules}/test-id-format.js

@@ -1,6 +1,6 @@
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
-import createRule from '../utils/create-rule.js';
-import { leavesOf } from '../utils/expressions.js';
+import createRule from '../../shared/create-rule.js';
+import { leavesOf } from '../../shared/expressions.js';
 /**
  * A `testID` written out in full is lowercase kebab-case: `crest`,
  * `vote-input`, `top-scorers-card-home-crest`.
@@ -29,34 +29,30 @@ const LEADING_SEPARATOR_PATTERN = /^[^A-Za-z0-9]/;
 const TRAILING_SEPARATOR_PATTERN = /[^A-Za-z0-9]$/;
 const TEST_ID = 'testID';
 /** `Match.playerItem_photo` -> `match-player-item-photo`. */
-function kebab(value) {
-    return value
-        .replaceAll(LOWER_TO_UPPER_PATTERN, '-')
-        .replaceAll(ACRONYM_END_PATTERN, '-')
-        .replaceAll(NON_ALPHANUMERIC_RUN_PATTERN, '-')
-        .replaceAll(EDGE_DASHES_PATTERN, '')
-        .toLowerCase();
-}
+const kebab = (value) => value
+    .replaceAll(LOWER_TO_UPPER_PATTERN, '-')
+    .replaceAll(ACRONYM_END_PATTERN, '-')
+    .replaceAll(NON_ALPHANUMERIC_RUN_PATTERN, '-')
+    .replaceAll(EDGE_DASHES_PATTERN, '')
+    .toLowerCase();
 /** A piece between substitutions keeps a separator where it meets one: `_photo` becomes `-photo`. */
-function kebabFragment(value) {
+const kebabFragment = (value) => {
     const core = kebab(value);
     const lead = LEADING_SEPARATOR_PATTERN.test(value) ? '-' : '';
     const trail = TRAILING_SEPARATOR_PATTERN.test(value) ? '-' : '';
     return core ? `${lead}${core}${trail}` : '-';
-}
+};
 /** Whether `inner` is written inside `outer`, rather than elsewhere in the file. */
-function isInside(outer, inner) {
-    return inner.range[0] >= outer.range[0] && inner.range[1] <= outer.range[1];
-}
+const isInside = (outer, inner) => inner.range[0] >= outer.range[0] && inner.range[1] <= outer.range[1];
 /** The written string an expression is, or `undefined` when it is not one. */
-function writtenString(node) {
+const writtenString = (node) => {
     if (node.type === AST_NODE_TYPES.Literal && typeof node.value === 'string')
         return node.value;
     // A template with nothing substituted is a literal written the long way.
     if (node.type === AST_NODE_TYPES.TemplateLiteral && node.expressions.length === 0)
         return node.quasis[0]?.value.cooked ?? undefined;
     return undefined;
-}
+};
 const testIdFormat = createRule({
     name: 'test-id-format',
     meta: {
@@ -68,7 +64,7 @@ const testIdFormat = createRule({
             format: 'Write this `testID` as `{{ suggestion }}`, not "{{ value }}": an id is lowercase kebab-case throughout, depth included. A dot is a wildcard in Maestro\'s `id:` matcher, and a capital is one shift key away from a flake — so a child derives with a dash, `` `${testID}-remote-image` ``, at every level.',
         },
     },
-    create(context) {
+    create: (context) => {
         // Reported on the string when it sits inside the expression, else on the expression a name led from.
         const check = (expression, leaf) => {
             const value = writtenString(leaf);
@@ -101,7 +97,7 @@ const testIdFormat = createRule({
             }
         };
         return {
-            JSXAttribute(node) {
+            JSXAttribute: (node) => {
                 if (node.name.type !== AST_NODE_TYPES.JSXIdentifier || node.name.name !== TEST_ID)
                     return;
                 const { value } = node;
@@ -111,7 +107,7 @@ const testIdFormat = createRule({
                     checkExpression(value.expression);
             },
             // A `testID` default, and a `testID:` in an options or fixture object.
-            Property(node) {
+            Property: (node) => {
                 if (node.computed || node.key.type !== AST_NODE_TYPES.Identifier || node.key.name !== TEST_ID)
                     return;
                 checkExpression(node.value.type === AST_NODE_TYPES.AssignmentPattern ? node.value.right : node.value);