@hypersolid-dev/eslint-config 5.0.0 → 6.0.0

package/CHANGELOG.md

@@ -1,3 +1,18 @@
+## [6.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv5.0.0&targetVersion=GTv6.0.0) (2026-11-10)
+
+### ⚠ BREAKING CHANGES
+
+* **react:** react and react-native report new React Doctor errors.
+* **base:** function declarations and expressions now fail lint.
+* **base:** functions above a cognitive complexity of 15 now fail lint.
+
+### Features
+
+* **base:** enable prefer-arrow-functions ([a1fcf80](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/a1fcf801956aeb42ecd0d123e454bc17f376cbd3)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **base:** enable sonarjs/cognitive-complexity ([8ee0e2a](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/8ee0e2aa70053e513c6df6fbff63cd726d38bfde)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **jest:** add opt-in jest preset ([6f26b68](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/6f26b68552cd9dc0f0651e654d621b539b5d6836)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **react:** add React Doctor rules ([026a2f3](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/026a2f3f8cce13ff74c032cfaa78d9081ddc3fe8)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+
 ## [5.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv4.0.0&targetVersion=GTv5.0.0) (2026-11-10)
 
 ### ⚠ BREAKING CHANGES

package/README.md

@@ -26,6 +26,7 @@ The plugins are regular dependencies of this package, so you don't install them
 | `react-native` | `@hypersolid-dev/eslint-config/react-native` | React Native and Expo. Use instead of `react`. |
 | `node` | `@hypersolid-dev/eslint-config/node` | Node.js services, scripts and CLIs. |
 | `next` | `@hypersolid-dev/eslint-config/next` | Next.js. Stack on top of `react`. |
+| `jest` | `@hypersolid-dev/eslint-config/jest` | Jest and Testing Library suites. Opt-in, on top of the others. |
 
 Each preset is a function that returns an array of config objects. Presets don't include `base`: spread `base` first, then the presets you need, then your own overrides.
 
@@ -58,6 +59,8 @@ import react from '@hypersolid-dev/eslint-config/react';
 export default [...base({ tsconfigRootDir: import.meta.dirname }), ...react()];
 ```
 
+`react` and `react-native` include rules from [React Doctor](https://react.doctor) (`react-doctor/*`); `react-native` adds its `rn-*` rules. They are off in test files.
+
 ### React Native / Expo
 
 ```js
@@ -90,7 +93,19 @@ import react from '@hypersolid-dev/eslint-config/react';
 export default [...base({ tsconfigRootDir: import.meta.dirname }), ...react(), ...next()];
 ```
 
-## Custom rules
+### Jest and Testing Library
+
+```js
+import base from '@hypersolid-dev/eslint-config/base';
+import jest from '@hypersolid-dev/eslint-config/jest';
+import reactNative from '@hypersolid-dev/eslint-config/react-native';
+
+export default [...base({ tsconfigRootDir: import.meta.dirname }), ...reactNative(), ...jest()];
+```
+
+`jest` applies `eslint-plugin-jest`'s recommended set plus a few stricter rules (`it` over `test`, no conditionals in tests, hooks on top) to `*.test.*`, `*.spec.*` and `jest.setup.*` (`JEST_FILES`, exported from `@hypersolid-dev/eslint-config/jest`), and Testing Library's React rules to the suites. The React set also covers React Native Testing Library; `no-await-sync-events` is off because its `fireEvent` returns a promise. `eslint-plugin-jest` reads your installed Jest version; set `settings.jest.version` if Jest isn't resolvable from the config.
+
+
 
 This package ships its own plugin, namespaced `@hypersolid-dev`. The preset column says where each rule is on; `react` rules are on in `react-native` too.
 
@@ -193,6 +208,7 @@ Root files such as `eslint.config.js` or `vite.config.ts` are often outside the
 ## Known issues
 
 - `eslint-plugin-jsx-a11y` (used by `react`) declares support for ESLint 9 only. It works on ESLint 10, but installing prints a peer-dependency warning, and installs with `strict-peer-dependencies` fail.
+- `eslint-plugin-react-doctor` declares no `eslint` peer dependency. It reads the nearest `package.json` to decide which rules apply (the `rn-*` rules need `react-native` there), and skips some rules for files under `test/`, `__tests__/` and similar paths.
 - In `next`, `@next/next/no-html-link-for-pages` prints "Pages directory cannot be found" on App Router projects. Turn it off if you don't use the `pages` directory:
 
   ```js

package/dist/base.js

@@ -3,6 +3,8 @@ import json from '@eslint/json';
 import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
 import { createNodeResolver, flatConfigs as importX } from 'eslint-plugin-import-x';
 import noSecrets from 'eslint-plugin-no-secrets';
+import preferArrowFunctions from 'eslint-plugin-prefer-arrow-functions';
+import sonarjs from 'eslint-plugin-sonarjs';
 import unicorn from 'eslint-plugin-unicorn';
 import { configs as tsConfigs } from 'typescript-eslint';
 import hypersolid from './plugins/hypersolid.js';
@@ -44,7 +46,12 @@ export default function base(options) {
                     tsconfigRootDir: options.tsconfigRootDir,
                 },
             },
-            plugins: { '@hypersolid-dev': hypersolid, 'no-secrets': noSecrets },
+            plugins: {
+                '@hypersolid-dev': hypersolid,
+                'no-secrets': noSecrets,
+                'prefer-arrow-functions': preferArrowFunctions,
+                sonarjs,
+            },
             settings: {
                 'import-x/resolver-next': [createTypeScriptImportResolver(), createNodeResolver()],
             },
@@ -59,6 +66,8 @@ export default function base(options) {
                 'no-nested-ternary': 'error',
                 // Arrow functions as callbacks. Bad: `list.map(function (x) { return x; })`.
                 'prefer-arrow-callback': 'error',
+                // One function form throughout, and no `this` to reason about. Bad: `function load() {}`, `export default function base() {}`.
+                'prefer-arrow-functions/prefer-arrow-functions': ['error', { disallowPrototype: true }],
                 // A rethrow keeps the original error as `cause`. Bad: `catch (error) { throw new Error('failed'); }`.
                 'preserve-caught-error': 'error',
                 // The coercing globals. Bad: `isNaN('x')` (use `Number.isNaN`).
@@ -183,12 +192,16 @@ export default function base(options) {
                 'import-x/namespace': 'off',
                 // High-entropy strings that look like credentials. Bad: `const token = 'ghp_Zx8kQ2vLm9…'`.
                 'no-secrets/no-secrets': 'error',
+                // A function too tangled to follow, nesting weighted over length (limit 15). Bad: a loop holding an `if` holding a `try`.
+                'sonarjs/cognitive-complexity': 'error',
             },
         },
         {
             name: '@hypersolid-dev/base/tests',
             files: TEST_FILES,
             rules: {
+                // A test's setup and table of cases are read once, not maintained as logic.
+                'sonarjs/cognitive-complexity': 'off',
                 // Off: mocks and fixtures are loosely typed by design. Bad: `const user = jest.fn()()` reported.
                 '@typescript-eslint/no-unsafe-assignment': 'off',
                 // Off: mocks and fixtures are loosely typed by design. Bad: `mock.calls[0].user` reported.

package/dist/jest.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from 'eslint';
+export declare const JEST_FILES: string[];
+export default function jest(): Linter.Config[];

package/dist/jest.js

@@ -0,0 +1,56 @@
+import jestPlugin from 'eslint-plugin-jest';
+import testingLibrary from 'eslint-plugin-testing-library';
+import { raiseWarnings } from './shared.js';
+// Test suites and Jest setup. Mocks and stories are left out: `jest/no-export` would reject what they exist to export.
+export const JEST_FILES = ['**/*.{test,spec}.{js,mjs,cjs,jsx,ts,mts,cts,tsx}', '**/jest.setup.*'];
+const SUITE_FILES = ['**/*.{test,spec}.{js,mjs,cjs,jsx,ts,mts,cts,tsx}'];
+export default function jest() {
+    return raiseWarnings([
+        {
+            // Jest's recommended set and its globals; the plugin ships it unscoped. Bad: `it.only(…)`, `expect` inside a `catch`.
+            ...jestPlugin.configs['flat/recommended'],
+            name: '@hypersolid-dev/jest',
+            files: JEST_FILES,
+            rules: {
+                ...jestPlugin.configs['flat/recommended'].rules,
+                // Off: jest/unbound-method replaces it and knows `expect(service.method)` does not call it. Bad: `expect(Alert.alert)` reported.
+                '@typescript-eslint/unbound-method': 'off',
+                // A method passed on loses its `this`, except into `expect`. Bad: `const { save } = service; save()`.
+                'jest/unbound-method': 'error',
+                // A test must assert; `expectX()` helpers count as assertions. Bad: `it('renders', () => { render(<A />); })`.
+                'jest/expect-expect': ['error', { assertFunctionNames: ['expect', 'expect*'] }],
+                // One spelling for a test case. Bad: `test('…')` next to `it('…')`.
+                'jest/consistent-test-it': ['error', { fn: 'it' }],
+                // A conditional in a test means it does not know what it asserts. Bad: `if (items.length) expect(…)`.
+                'jest/no-conditional-in-test': 'error',
+                // Two hooks of a kind in one block run in an order nobody chose. Bad: two `beforeEach` in one `describe`.
+                'jest/no-duplicate-hooks': 'error',
+                // Returning from a test hides an unawaited promise. Bad: `it('loads', () => { return load(); })`.
+                'jest/no-test-return-statement': 'error',
+                // Setup is read before what it sets up. Bad: `beforeEach` below the first `it`.
+                'jest/prefer-hooks-on-top': 'error',
+                // A blank line around each block, hook and assertion group. Bad: `it(…)` directly under `beforeEach(…)`.
+                'jest/padding-around-all': 'error',
+                // `jest.setTimeout` below the top level applies to nothing. Bad: `jest.setTimeout(10_000)` inside a `describe`.
+                'jest/no-confusing-set-timeout': 'error',
+            },
+        },
+        {
+            // Testing Library's React set; it covers React Native Testing Library, which has no flavour of its own. Bad: `container.querySelector(…)`, an unawaited `findBy…`.
+            ...testingLibrary.configs['flat/react'],
+            name: '@hypersolid-dev/jest/testing-library',
+            files: SUITE_FILES,
+            rules: {
+                ...testingLibrary.configs['flat/react'].rules,
+                // Events are awaited. Bad: `userEvent.press(button)` without `await`.
+                'testing-library/await-async-events': 'error',
+                // Testing Library already wraps its utilities in `act`. Bad: `act(() => fireEvent.press(button))`.
+                'testing-library/no-unnecessary-act': 'error',
+                // Off: React Native Testing Library 14's `fireEvent` returns a promise to await. Bad: `await fireEvent.press(button)` reported.
+                'testing-library/no-await-sync-events': 'off',
+                // Off: suites query through `screen`, so it only reaches helpers that return a mock. Bad: `const view = render(<A />)` reported.
+                'testing-library/render-result-naming-convention': 'off',
+            },
+        },
+    ]);
+}

package/dist/plugins/props-destructuring.js

@@ -3,7 +3,7 @@ const WRAPPERS = new Set(['memo', 'forwardRef']);
 const isFunction = (node) => typeof node === 'object' && node !== null && FUNCTION_TYPES.has(node.type);
 const PASCAL_CASE_PATTERN = /^[A-Z]/;
 const isPascalCase = (name) => typeof name === 'string' && PASCAL_CASE_PATTERN.test(name);
-function isJsx(node) {
+const isJsx = (node) => {
     if (typeof node !== 'object' || node === null) {
         return false;
     }
@@ -15,22 +15,22 @@ function isJsx(node) {
         return isJsx(consequent) || isJsx(alternate);
     }
     return type === 'LogicalExpression' && (isJsx(left) || isJsx(right));
-}
+};
 // Searches the function's own return statements; nested functions return for themselves.
-function returnsJsx(node) {
+const isReturningJsx = (node) => {
     if (typeof node !== 'object' || node === null) {
         return false;
     }
     if (Array.isArray(node)) {
-        return node.some(returnsJsx);
+        return node.some(isReturningJsx);
     }
     const current = node;
     return current.type === 'ReturnStatement'
         ? isJsx(current.argument)
-        : Object.entries(current).some(([key, value]) => key !== 'parent' && !isFunction(value) && typeof value === 'object' && returnsJsx(value));
-}
+        : Object.entries(current).some(([key, value]) => key !== 'parent' && !isFunction(value) && typeof value === 'object' && isReturningJsx(value));
+};
 // `memo(fn)`, `React.forwardRef(fn)` and `memo(forwardRef(fn))`.
-function unwrap(node) {
+const unwrap = (node) => {
     if (isFunction(node)) {
         return node;
     }
@@ -41,7 +41,7 @@ function unwrap(node) {
     const { type: calleeType, name, property } = callee;
     const calleeName = calleeType === 'MemberExpression' ? property.name : name;
     return typeof calleeName === 'string' && WRAPPERS.has(calleeName) ? unwrap(args[0]) : undefined;
-}
+};
 const propsDestructuring = {
     meta: {
         type: 'suggestion',
@@ -51,7 +51,7 @@ const propsDestructuring = {
             destructure: 'Destructure the props in the signature: `({ title }: Props)`. A discriminated-union props type may keep `props`.',
         },
     },
-    create(context) {
+    create: (context) => {
         const services = context.sourceCode.parserServices;
         const checker = services.program?.getTypeChecker();
         // Destructuring a union in the signature breaks narrowing (`if (props.kind === 'a') props.aOnly`).
@@ -61,18 +61,18 @@ const propsDestructuring = {
         };
         const check = (fn) => {
             const props = fn?.params[0];
-            if (!fn || props?.type !== 'Identifier' || !returnsJsx(fn.body) && !isJsx(fn.body) || isUnion(props)) {
+            if (!fn || props?.type !== 'Identifier' || !isReturningJsx(fn.body) && !isJsx(fn.body) || isUnion(props)) {
                 return;
             }
             context.report({ node: props, messageId: 'destructure' });
         };
         return {
-            FunctionDeclaration(node) {
+            FunctionDeclaration: (node) => {
                 if (isPascalCase(node.id.name)) {
                     check(node);
                 }
             },
-            VariableDeclarator(node) {
+            VariableDeclarator: (node) => {
                 if (node.id.type === 'Identifier' && isPascalCase(node.id.name)) {
                     check(unwrap(node.init));
                 }

package/dist/plugins/react-native-a11y/rules/accessibility-actions-need-handler.js

@@ -26,7 +26,7 @@ const accessibilityActionsNeedHandler = createRule({
         },
         schema: [],
     },
-    create(context) {
+    create: (context) => {
         const reportUnlabelledActions = (expression) => {
             if (expression.type !== AST_NODE_TYPES.ArrayExpression) {
                 return;
@@ -54,7 +54,7 @@ const accessibilityActionsNeedHandler = createRule({
             }
         };
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 if (hasSpreadProps(node)) {
                     return;
                 }

package/dist/plugins/react-native-a11y/rules/accessibility-hint.js

@@ -33,13 +33,13 @@ const accessibilityHint = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TOUCHABLES,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native-a11y/rules/accessibility-label.js

@@ -35,13 +35,13 @@ const accessibilityLabel = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: [...IMAGES, ...TOUCHABLES, ...INPUTS],
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native-a11y/rules/accessibility-role.js

@@ -31,13 +31,13 @@ const accessibilityRole = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: [...TOUCHABLES, ...IMAGES],
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native-a11y/rules/accessibility-value-needs-range.js

@@ -18,32 +18,30 @@ const accessibilityValueNeedsRange = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                const attribute = getProperty(node, "accessibilityValue");
-                if (attribute?.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
-                    return;
-                }
-                const { expression } = attribute.value;
-                // A value built elsewhere cannot be read here
-                if (expression.type !== AST_NODE_TYPES.ObjectExpression) {
-                    return;
-                }
-                // A spread may carry the range, and cannot be read from here
-                if (expression.properties.some((property) => property.type === AST_NODE_TYPES.SpreadElement)) {
-                    return;
-                }
-                const keys = keysOf(expression);
-                if (!keys.includes("now") || keys.includes("text")) {
-                    return;
-                }
-                if (keys.includes("min") && keys.includes("max")) {
-                    return;
-                }
-                context.report({ node: attribute, messageId: "valueWithoutRange" });
-            },
-        };
-    },
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const attribute = getProperty(node, "accessibilityValue");
+            if (attribute?.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
+                return;
+            }
+            const { expression } = attribute.value;
+            // A value built elsewhere cannot be read here
+            if (expression.type !== AST_NODE_TYPES.ObjectExpression) {
+                return;
+            }
+            // A spread may carry the range, and cannot be read from here
+            if (expression.properties.some((property) => property.type === AST_NODE_TYPES.SpreadElement)) {
+                return;
+            }
+            const keys = keysOf(expression);
+            if (!keys.includes("now") || keys.includes("text")) {
+                return;
+            }
+            if (keys.includes("min") && keys.includes("max")) {
+                return;
+            }
+            context.report({ node: attribute, messageId: "valueWithoutRange" });
+        },
+    }),
 });
 export default accessibilityValueNeedsRange;

package/dist/plugins/react-native-a11y/rules/adjustable-needs-value.js

@@ -18,23 +18,21 @@ const adjustableNeedsValue = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                const role = getLiteralPropertyValue(node, ["accessibilityRole", "role"]);
-                if (typeof role !== "string" || !ROLES_NEEDING_VALUE.has(role)) {
-                    return;
-                }
-                if (hasSpreadProps(node) || hasProperty(node, VALUE_PROPS)) {
-                    return;
-                }
-                context.report({
-                    node,
-                    messageId: "missingAccessibilityValue",
-                    data: { role },
-                });
-            },
-        };
-    },
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const role = getLiteralPropertyValue(node, ["accessibilityRole", "role"]);
+            if (typeof role !== "string" || !ROLES_NEEDING_VALUE.has(role)) {
+                return;
+            }
+            if (hasSpreadProps(node) || hasProperty(node, VALUE_PROPS)) {
+                return;
+            }
+            context.report({
+                node,
+                messageId: "missingAccessibilityValue",
+                data: { role },
+            });
+        },
+    }),
 });
 export default adjustableNeedsValue;

package/dist/plugins/react-native-a11y/rules/gate-announce-for-accessibility.js

@@ -28,7 +28,7 @@ const gateAnnounceForAccessibility = createRule({
         },
         schema: [],
     },
-    create(context) {
+    create: (context) => {
         /**
          * A bare announce is the legitimate cross-platform pattern. The double
          * announcement only happens where a live region covers Android already, so
@@ -38,12 +38,12 @@ const gateAnnounceForAccessibility = createRule({
         const announces = [];
         const platformChecks = [];
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 if (getProperty(node, LIVE_REGION_PROPS)) {
                     hasLiveRegion = true;
                 }
             },
-            MemberExpression(node) {
+            MemberExpression: (node) => {
                 if (node.property.type !== AST_NODE_TYPES.Identifier) {
                     return;
                 }
@@ -58,7 +58,7 @@ const gateAnnounceForAccessibility = createRule({
                     platformChecks.push(node);
                 }
             },
-            "Program:exit"() {
+            "Program:exit": () => {
                 if (!hasLiveRegion) {
                     return;
                 }

package/dist/plugins/react-native-a11y/rules/input-purpose.js

@@ -42,13 +42,13 @@ const inputPurpose = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TEXT_INPUTS,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native-a11y/rules/no-aria-legacy-mix.js

@@ -30,28 +30,26 @@ const noAriaLegacyMix = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                for (const [alias, legacy] of Object.entries(ALIAS_TO_LEGACY)) {
-                    if (!getProperty(node, alias)) {
-                        continue;
-                    }
-                    const stateKey = STATE_ALIAS_KEYS[alias] ?? VALUE_ALIAS_KEYS[alias];
-                    // A grouped prop only clashes on the key the alias maps onto
-                    const isClashes = stateKey
-                        ? hasStateKey(node, legacy, stateKey)
-                        : getProperty(node, legacy) !== undefined;
-                    if (isClashes) {
-                        context.report({
-                            node,
-                            messageId: "ariaLegacyMix",
-                            data: { alias, legacy },
-                        });
-                    }
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            for (const [alias, legacy] of Object.entries(ALIAS_TO_LEGACY)) {
+                if (!getProperty(node, alias)) {
+                    continue;
                 }
-            },
-        };
-    },
+                const stateKey = STATE_ALIAS_KEYS[alias] ?? VALUE_ALIAS_KEYS[alias];
+                // A grouped prop only clashes on the key the alias maps onto
+                const isClashes = stateKey
+                    ? hasStateKey(node, legacy, stateKey)
+                    : getProperty(node, legacy) !== undefined;
+                if (isClashes) {
+                    context.report({
+                        node,
+                        messageId: "ariaLegacyMix",
+                        data: { alias, legacy },
+                    });
+                }
+            }
+        },
+    }),
 });
 export default noAriaLegacyMix;

package/dist/plugins/react-native-a11y/rules/no-deprecated-accessibility-focus.js

@@ -13,19 +13,17 @@ const noDeprecatedAccessibilityFocus = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            // Matched on the property so an aliased import is caught too
-            MemberExpression(node) {
-                if (node.property.type === AST_NODE_TYPES.Identifier &&
-                    node.property.name === "setAccessibilityFocus") {
-                    context.report({
-                        node,
-                        messageId: "deprecatedSetAccessibilityFocus",
-                    });
-                }
-            },
-        };
-    },
+    create: (context) => ({
+        // Matched on the property so an aliased import is caught too
+        MemberExpression: (node) => {
+            if (node.property.type === AST_NODE_TYPES.Identifier &&
+                node.property.name === "setAccessibilityFocus") {
+                context.report({
+                    node,
+                    messageId: "deprecatedSetAccessibilityFocus",
+                });
+            }
+        },
+    }),
 });
 export default noDeprecatedAccessibilityFocus;

package/dist/plugins/react-native-a11y/rules/no-dropped-aria-on-text.js

@@ -36,13 +36,13 @@ const noDroppedAriaOnText = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TEXTS,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;

package/dist/plugins/react-native-a11y/rules/no-font-scaling-disabled.js

@@ -19,31 +19,29 @@ const noFontScalingDisabled = createRule({
         },
         schema: [],
     },
-    create(context) {
-        return {
-            JSXOpeningElement(node) {
-                const allowFontScaling = getProperty(node, "allowFontScaling");
-                if (allowFontScaling &&
-                    getLiteralPropertyValue(node, "allowFontScaling") === false) {
-                    context.report({
-                        node: allowFontScaling,
-                        messageId: "fontScalingDisabled",
-                    });
-                }
-                const cap = getProperty(node, "maxFontSizeMultiplier");
-                const multiplier = getLiteralPropertyValue(node, "maxFontSizeMultiplier");
-                if (cap &&
-                    typeof multiplier === "number" &&
-                    multiplier !== NO_MAXIMUM &&
-                    multiplier < MINIMUM_MULTIPLIER) {
-                    context.report({
-                        node: cap,
-                        messageId: "fontScalingCapped",
-                        data: { multiplier, minimum: MINIMUM_MULTIPLIER },
-                    });
-                }
-            },
-        };
-    },
+    create: (context) => ({
+        JSXOpeningElement: (node) => {
+            const allowFontScaling = getProperty(node, "allowFontScaling");
+            if (allowFontScaling &&
+                getLiteralPropertyValue(node, "allowFontScaling") === false) {
+                context.report({
+                    node: allowFontScaling,
+                    messageId: "fontScalingDisabled",
+                });
+            }
+            const cap = getProperty(node, "maxFontSizeMultiplier");
+            const multiplier = getLiteralPropertyValue(node, "maxFontSizeMultiplier");
+            if (cap &&
+                typeof multiplier === "number" &&
+                multiplier !== NO_MAXIMUM &&
+                multiplier < MINIMUM_MULTIPLIER) {
+                context.report({
+                    node: cap,
+                    messageId: "fontScalingCapped",
+                    data: { multiplier, minimum: MINIMUM_MULTIPLIER },
+                });
+            }
+        },
+    }),
 });
 export default noFontScalingDisabled;