@hypersolid-dev/eslint-config 4.0.0 → 6.0.0

package/CHANGELOG.md

@@ -1,3 +1,42 @@
+## [6.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv5.0.0&targetVersion=GTv6.0.0) (2026-11-10)
+
+### ⚠ BREAKING CHANGES
+
+* **react:** react and react-native report new React Doctor errors.
+* **base:** function declarations and expressions now fail lint.
+* **base:** functions above a cognitive complexity of 15 now fail lint.
+
+### Features
+
+* **base:** enable prefer-arrow-functions ([a1fcf80](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/a1fcf801956aeb42ecd0d123e454bc17f376cbd3)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **base:** enable sonarjs/cognitive-complexity ([8ee0e2a](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/8ee0e2aa70053e513c6df6fbff63cd726d38bfde)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **jest:** add opt-in jest preset ([6f26b68](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/6f26b68552cd9dc0f0651e654d621b539b5d6836)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+* **react:** add React Doctor rules ([026a2f3](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/026a2f3f8cce13ff74c032cfaa78d9081ddc3fe8)), closes [AB#5180](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5180)
+
+## [5.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv4.0.0&targetVersion=GTv5.0.0) (2026-11-10)
+
+### ⚠ BREAKING CHANGES
+
+* **react:** effect dependency findings now come from
+react-hooks/exhaustive-effect-dependencies, so existing
+eslint-disable comments for react-hooks/exhaustive-deps no longer apply.
+* **react-native:** importing `Animated` from `react-native` is now an error in the react-native preset.
+* **react-native:** react-native reports code it accepted before.
+* **react:** react and react-native report code they accepted before.
+* **base:** base reports code it accepted before.
+
+### Features
+
+* **base:** add tier 1 rules from the ESPN Goal pilot ([68d6391](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/68d6391ce228e6b205fd3a7abc77b6bd179569d0)), closes [AB#5179](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5179)
+* port boolean-guard and undefined-check rules ([79f50cc](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/79f50ccf5bfb34ba1683b7d46947a423fbe56ee5))
+* port comment-style, jsdoc-for-props and regex-pattern-const rules ([d039153](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/d03915380754f723bf875cd9874519d291f7532b))
+* port no-markup-variable, no-callback-payload, effect-takes-callback and no-unnecessary-use-callback rules ([dde97ee](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/dde97ee3e6bf97c6337d0b660083acdaf32cc548))
+* port test-id-format, test-id-from-props, test-id-default and webview-allow-list rules ([33d2660](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/33d266031431fa1f37961974d91645c1df553acc))
+* **react-native:** add tier 1 React Native rules from the ESPN Goal pilot ([e61ef0c](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/e61ef0c550638e77b30128e9b776712714706bc8)), closes [AB#5179](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5179)
+* **react-native:** ban Animated from react-native in favour of Reanimated ([19b6952](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/19b6952dde8c462be851e6dd90744167374d80ea)), closes [AB#5179](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5179)
+* **react:** add tier 1 React rules from the ESPN Goal pilot ([b9f9e58](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/b9f9e58ebd6dc6d80454580ae3969daeafe5da2c)), closes [AB#5179](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5179)
+* **react:** check dependency arrays once, with the compiler rules ([5502049](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/5502049745c8e732b30426697325940d11ea44b4)), closes [AB#5179](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5179)
+
 ## [4.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv3.0.0&targetVersion=GTv4.0.0) (2026-11-09)
 
 ### ⚠ BREAKING CHANGES

package/README.md

@@ -26,6 +26,7 @@ The plugins are regular dependencies of this package, so you don't install them
 | `react-native` | `@hypersolid-dev/eslint-config/react-native` | React Native and Expo. Use instead of `react`. |
 | `node` | `@hypersolid-dev/eslint-config/node` | Node.js services, scripts and CLIs. |
 | `next` | `@hypersolid-dev/eslint-config/next` | Next.js. Stack on top of `react`. |
+| `jest` | `@hypersolid-dev/eslint-config/jest` | Jest and Testing Library suites. Opt-in, on top of the others. |
 
 Each preset is a function that returns an array of config objects. Presets don't include `base`: spread `base` first, then the presets you need, then your own overrides.
 
@@ -58,6 +59,8 @@ import react from '@hypersolid-dev/eslint-config/react';
 export default [...base({ tsconfigRootDir: import.meta.dirname }), ...react()];
 ```
 
+`react` and `react-native` include rules from [React Doctor](https://react.doctor) (`react-doctor/*`); `react-native` adds its `rn-*` rules. They are off in test files.
+
 ### React Native / Expo
 
 ```js
@@ -90,13 +93,38 @@ import react from '@hypersolid-dev/eslint-config/react';
 export default [...base({ tsconfigRootDir: import.meta.dirname }), ...react(), ...next()];
 ```
 
-## Custom rules
+### Jest and Testing Library
+
+```js
+import base from '@hypersolid-dev/eslint-config/base';
+import jest from '@hypersolid-dev/eslint-config/jest';
+import reactNative from '@hypersolid-dev/eslint-config/react-native';
+
+export default [...base({ tsconfigRootDir: import.meta.dirname }), ...reactNative(), ...jest()];
+```
+
+`jest` applies `eslint-plugin-jest`'s recommended set plus a few stricter rules (`it` over `test`, no conditionals in tests, hooks on top) to `*.test.*`, `*.spec.*` and `jest.setup.*` (`JEST_FILES`, exported from `@hypersolid-dev/eslint-config/jest`), and Testing Library's React rules to the suites. The React set also covers React Native Testing Library; `no-await-sync-events` is off because its `fireEvent` returns a promise. `eslint-plugin-jest` reads your installed Jest version; set `settings.jest.version` if Jest isn't resolvable from the config.
+
+
 
-This package ships its own plugin, namespaced `@hypersolid-dev`, enabled in `react` and `react-native`.
+This package ships its own plugin, namespaced `@hypersolid-dev`. The preset column says where each rule is on; `react` rules are on in `react-native` too.
 
-| Rule | Enforces |
-| --- | --- |
-| `@hypersolid-dev/props-destructuring` | A component destructures its props in the signature, so its props are readable there. Replaces `react/destructuring-assignment` (`always`, `destructureInSignature: always`), as `eslint-plugin-react` doesn't support ESLint 10. Checks PascalCase functions that return JSX, including those wrapped in `memo` and `forwardRef`. Bad: `const Card = (props: Props) => <h1>{props.title}</h1>`, or `const { title } = props` in the body. Good: `const Card = ({ title }: Props) => …`. When the props type is a union, such as a discriminated union, `props` may stay whole, because destructuring breaks narrowing (`if (props.kind === 'a') props.a`). |
+| Rule | Preset | Enforces |
+| --- | --- | --- |
+| `@hypersolid-dev/props-destructuring` | react | A component destructures its props in the signature, so its props are readable there. Replaces `react/destructuring-assignment` (`always`, `destructureInSignature: always`), as `eslint-plugin-react` doesn't support ESLint 10. Checks PascalCase functions that return JSX, including those wrapped in `memo` and `forwardRef`. Bad: `const Card = (props: Props) => <h1>{props.title}</h1>`, or `const { title } = props` in the body. Good: `const Card = ({ title }: Props) => …`. When the props type is a union, such as a discriminated union, `props` may stay whole, because destructuring breaks narrowing (`if (props.kind === 'a') props.a`). |
+| `@hypersolid-dev/undefined-check` | base | No `x !== undefined` (or `=== undefined`) where `undefined` is the type's only falsy value, so truthiness already decides. Bad: `if (user !== undefined)` with `user: User \| undefined`. Good: `if (user)`. Needs type information. |
+| `@hypersolid-dev/regex-pattern-const` | base | A regex is a module-level `const <NAME>_PATTERN`, so it's read by its name. Bad: `/^\d+$/.test(id)` in a function. Off in tests. |
+| `@hypersolid-dev/comment-style` | base | `//` and `/* */` comments are one row; longer prose is a `/** */` JSDoc block. Directive-only runs (`eslint-disable…`, `@ts-…`) are fine. Option `maxLength` caps each row (unset by default). |
+| `@hypersolid-dev/jsdoc-for-props` | react | A comment on a type member is JSDoc, the form editors show at the call site. Bad: `// The title` above `title: string`. |
+| `@hypersolid-dev/boolean-guard` | react | A JSX `&&` guard can't leak `0` or `''`, which React renders (and which crashes React Native outside `<Text>`). Bad: `{count && <Badge />}`. Good: `{count > 0 && <Badge />}`. Needs type information. Off in tests. |
+| `@hypersolid-dev/no-markup-variable` | react | Styled JSX isn't stored in a variable in a component body; it's its own component, or written where it renders. Off in tests. |
+| `@hypersolid-dev/effect-takes-callback` | react | A `use*Effect` hook takes the callback it runs as its first parameter, like `useEffect`. Off in tests. |
+| `@hypersolid-dev/no-unnecessary-use-callback` | react | A `useCallback` with empty deps that captures nothing from render is a module-level function. Off in tests. |
+| `@hypersolid-dev/no-callback-payload` | react | A component passes a callback prop straight through instead of calling it with a payload built from its own props; the caller binds the payload. Bad: `onPress={() => onSelect(id)}` where `id` is a prop. Off in tests. |
+| `@hypersolid-dev/test-id-format` | react-native | A `testID` is lowercase kebab-case. Bad: `testID="Header.Title"`. |
+| `@hypersolid-dev/test-id-from-props` | react-native | In `**/components/**/*.tsx`, a `testID` comes from the `testID` prop (suffixed for inner nodes), never a fixed string. Off in screens and tests. |
+| `@hypersolid-dev/test-id-default` | react-native | In `**/components/**/*.tsx`, a `testID` prop defaults to the component's kebab-case name. Bad: `({ testID }: Props)` in `Card`. Good: `({ testID = 'card' }: Props)`. |
+| `@hypersolid-dev/webview-allow-list` | react-native | A `react-native-webview` WebView sets `originWhitelist={['*']}` and filters every navigation in an always-present `onShouldStartLoadWithRequest`. |
 
 ## Overriding rules
 
@@ -137,7 +165,7 @@ export default [...base({ tsconfigRootDir: import.meta.dirname }), { ignores: ['
 
 ### Test files
 
-Every preset relaxes a few rules for tests, stories, mocks and test setup (`TEST_FILES`, exported from `@hypersolid-dev/eslint-config/base`): `@typescript-eslint/no-unsafe-assignment`, `no-unsafe-member-access`, `no-invalid-void-type`, `unicorn/no-error-property-assignment` and `no-global-object-property-assignment` in `base`; `@eslint-react/no-unnecessary-use-prefix` in `react` and `react-native`; and the browser-globals list (`no-restricted-globals`) in `react-native`. Source code keeps them all.
+Every preset relaxes a few rules for tests, stories, mocks and test setup (`TEST_FILES`, exported from `@hypersolid-dev/eslint-config/base`): `@typescript-eslint/no-unsafe-assignment`, `no-unsafe-member-access`, `no-invalid-void-type`, `unicorn/no-error-property-assignment` and `no-global-object-property-assignment` in `base`; `@eslint-react/no-unnecessary-use-prefix` in `react` and `react-native`; and the browser-globals list (`no-restricted-globals`) in `react-native`. `unicorn/consistent-function-scoping` and the source-only custom rules marked "Off in tests" above are also off there. Source code keeps them all.
 
 ```js
 import base, { TEST_FILES } from '@hypersolid-dev/eslint-config/base';
@@ -149,7 +177,25 @@ export default [...base({ tsconfigRootDir: import.meta.dirname }), { files: TEST
 
 - `unicorn/consistent-boolean-name` skips function names in every preset; `react` and `react-native` also skip hook (`^use[A-Z]`) and jest mock (`^mock`) names, and `react-native` reads Reanimated's `SharedValue` through `.value`.
 - `no-secrets/no-secrets` ignores `data:` URIs in JSON; in `react-native` it also ignores Expo and native identifiers (`EXPO_*`, `android.settings.*`, `@xml…`, `NSPrivacy*`, i18n `Namespace/Key` paths) in code and JSON.
-- `@typescript-eslint/switch-exhaustiveness-check` accepts a `default` branch as exhaustive (`considerDefaultExhaustiveForUnions`). Set it to `false` to make every new union member fail its switches.
+- `no-restricted-syntax` bans an empty `.catch(() => {})` and `{ default as x }` specifiers in `base`; `react` adds `"use no memo"`, hooks called inside JSX and `React.useX`; `react-native` adds `pointerEvents` as a prop. Each preset restates the earlier entries, because flat config replaces options; spread them the same way when you add your own.
+- `@typescript-eslint/naming-convention`: values camelCase, PascalCase or UPPER_CASE, functions camelCase or PascalCase, types PascalCase; destructured names are exempt. `react` adds that a boolean prop doesn't start with `show`, `display` or `hide`.
+- `@typescript-eslint/no-restricted-imports` bans `InteractionManager` (deprecated in the New Architecture) and `Animated` (runs on the JS thread; use react-native-reanimated) from `react-native`. Type imports are allowed.
+- `@typescript-eslint/switch-exhaustiveness-check` requires a `default` on a switch over a non-union value (`requireDefaultForNonUnion`), and accepts a `default` branch as exhaustive (`considerDefaultExhaustiveForUnions`). Set it to `false` to make every new union member fail its switches.
+
+- `react-hooks/exhaustive-deps` is off: the compiler rules `react-hooks/memo-dependencies` and `react-hooks/exhaustive-effect-dependencies` check the same arrays, and both on would report one missing dependency twice. `eslint-plugin-react-hooks` is pinned to an exact version, so a plugin release can't change what the compiler rules report without a release of this package.
+
+### Component folders
+
+`@hypersolid-dev/no-callback-payload` applies to every component, and the `test-id-*` rules to `**/components/**/*.tsx`. If your components live elsewhere, scope them to your own folders:
+
+```js
+export default [
+  ...base({ tsconfigRootDir: import.meta.dirname }),
+  ...reactNative(),
+  { files: ['**/components/**/*.tsx'], rules: { '@hypersolid-dev/test-id-default': 'off' } },
+  { files: ['src/ui/**/*.tsx'], rules: { '@hypersolid-dev/test-id-default': 'error' } },
+];
+```
 
 ## Formatting and import order
 
@@ -162,6 +208,7 @@ Root files such as `eslint.config.js` or `vite.config.ts` are often outside the
 ## Known issues
 
 - `eslint-plugin-jsx-a11y` (used by `react`) declares support for ESLint 9 only. It works on ESLint 10, but installing prints a peer-dependency warning, and installs with `strict-peer-dependencies` fail.
+- `eslint-plugin-react-doctor` declares no `eslint` peer dependency. It reads the nearest `package.json` to decide which rules apply (the `rn-*` rules need `react-native` there), and skips some rules for files under `test/`, `__tests__/` and similar paths.
 - In `next`, `@next/next/no-html-link-for-pages` prints "Pages directory cannot be found" on App Router projects. Turn it off if you don't use the `pages` directory:
 
   ```js

package/dist/base.js

@@ -3,9 +3,12 @@ import json from '@eslint/json';
 import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
 import { createNodeResolver, flatConfigs as importX } from 'eslint-plugin-import-x';
 import noSecrets from 'eslint-plugin-no-secrets';
+import preferArrowFunctions from 'eslint-plugin-prefer-arrow-functions';
+import sonarjs from 'eslint-plugin-sonarjs';
 import unicorn from 'eslint-plugin-unicorn';
 import { configs as tsConfigs } from 'typescript-eslint';
-import { BOOLEAN_NAME_OPTIONS, CODE_FILES, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, scopeToCode, TEST_FILES } from './shared.js';
+import hypersolid from './plugins/hypersolid.js';
+import { BASE_RESTRICTED_SYNTAX, BOOLEAN_NAME_OPTIONS, CODE_FILES, NAMING_CONVENTION, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, scopeToCode, TEST_FILES, } from './shared.js';
 // The glob the presets relax test-only rules for; reuse it for your own test overrides.
 export { TEST_FILES } from './shared.js';
 export default function base(options) {
@@ -22,9 +25,11 @@ export default function base(options) {
             js.configs.recommended,
             // Type-aware TypeScript rules, the strict set. Bad: `const n: any = data; n.foo()`, `if (alwaysTrue)`.
             ...tsConfigs.strictTypeChecked,
-            // Unicorn's recommended set minus its taste rules (file naming, `no-null`, `no-array-reduce`,
-            // abbreviations, formatting); what remains catches bugs and outdated APIs.
-            // Bad: `array.indexOf(x) !== -1` (use `includes`), `new Error()` without a message.
+            /**
+             * Unicorn's recommended set minus its taste rules (file naming, `no-null`, `no-array-reduce`,
+             * abbreviations, formatting); what remains catches bugs and outdated APIs.
+             * Bad: `array.indexOf(x) !== -1` (use `includes`), `new Error()` without a message.
+             */
             unicorn.configs.unopinionated,
             // Import mistakes. Bad: `import { missing } from './module.js'`, importing the same module twice.
             importX.recommended,
@@ -41,7 +46,12 @@ export default function base(options) {
                     tsconfigRootDir: options.tsconfigRootDir,
                 },
             },
-            plugins: { 'no-secrets': noSecrets },
+            plugins: {
+                '@hypersolid-dev': hypersolid,
+                'no-secrets': noSecrets,
+                'prefer-arrow-functions': preferArrowFunctions,
+                sonarjs,
+            },
             settings: {
                 'import-x/resolver-next': [createTypeScriptImportResolver(), createNodeResolver()],
             },
@@ -56,10 +66,22 @@ export default function base(options) {
                 'no-nested-ternary': 'error',
                 // Arrow functions as callbacks. Bad: `list.map(function (x) { return x; })`.
                 'prefer-arrow-callback': 'error',
+                // One function form throughout, and no `this` to reason about. Bad: `function load() {}`, `export default function base() {}`.
+                'prefer-arrow-functions/prefer-arrow-functions': ['error', { disallowPrototype: true }],
                 // A rethrow keeps the original error as `cause`. Bad: `catch (error) { throw new Error('failed'); }`.
                 'preserve-caught-error': 'error',
                 // The coercing globals. Bad: `isNaN('x')` (use `Number.isNaN`).
                 'no-restricted-globals': ['error', ...NUMBER_GLOBAL_RESTRICTIONS],
+                // The same globals reached through an object, and `Math.pow`. Bad: `globalThis.isNaN(x)`, `Math.pow(2, 8)` (use `2 ** 8`).
+                'no-restricted-properties': [
+                    'error',
+                    ...['global', 'globalThis'].flatMap((object) => NUMBER_GLOBAL_RESTRICTIONS.map(({ name, message }) => ({ object, property: name, message }))),
+                    { object: 'Math', property: 'pow', message: 'Use the `**` operator.' },
+                ],
+                // A silent catch and renamed default specifiers. Bad: `.catch(() => {})`, `import { default as user } from './user.js'`.
+                'no-restricted-syntax': ['error', ...BASE_RESTRICTED_SYNTAX],
+                // `let` only for a reassigned binding, ignoring one read in a closure before its assignment. Bad: `let total = 1` never reassigned.
+                'prefer-const': ['error', { destructuring: 'any', ignoreReadBeforeAssign: true }],
                 // `type` over `interface`. Bad: `interface User { name: string }`.
                 '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
                 // Every promise is awaited or handled; `void` does not count. Bad: `save();`, `void save();`.
@@ -79,8 +101,22 @@ export default function base(options) {
                 ],
                 // No value returned where `void` is expected. Bad: `run(() => 1)` with `run(callback: () => void)`.
                 '@typescript-eslint/strict-void-return': ['error', { allowReturnAny: true }],
-                // A `switch` on a union handles every member or has a `default`. Bad: `switch (shape) { case 'circle': … }` missing `'square'`.
-                '@typescript-eslint/switch-exhaustiveness-check': ['error', { considerDefaultExhaustiveForUnions: true }],
+                /**
+                 * A `switch` on a union handles every member or has a `default`. Bad: `switch (shape) { case 'circle': … }` missing `'square'`.
+                 * and a `switch` on a non-union value has a `default`. Bad: `switch (count) { case 0: … }` without `default`.
+                 */
+                '@typescript-eslint/switch-exhaustiveness-check': [
+                    'error',
+                    { considerDefaultExhaustiveForUnions: true, requireDefaultForNonUnion: true },
+                ],
+                // Rest siblings omit a key, and `_` skips an argument. Bad: `const unused = 1`.
+                '@typescript-eslint/no-unused-vars': ['error', { ignoreRestSiblings: true, argsIgnorePattern: '^_+$' }],
+                // A type the literal already says. Bad: `const count: number = 5`.
+                '@typescript-eslint/no-inferrable-types': 'error',
+                // `startsWith`/`endsWith` state the intent. Bad: `name.indexOf('use') === 0`.
+                '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+                // Values camelCase, PascalCase or UPPER_CASE; functions camelCase or PascalCase; types PascalCase. Bad: `const user_name = ''`, `type props = {}`.
+                '@typescript-eslint/naming-convention': ['error', ...NAMING_CONVENTION],
                 // The caught value is named `error`. Bad: `catch (e)`.
                 'unicorn/catch-error-name': 'error',
                 // A boolean reads as a claim. Bad: `const visible = true` (use `isVisible`).
@@ -108,6 +144,20 @@ export default function base(options) {
                 'unicorn/no-unsafe-promise-all-settled-values': 'error',
                 // An async function already wraps its return value. Bad: `async () => Promise.resolve(1)`.
                 'unicorn/no-useless-promise-resolve-reject': 'error',
+                // No cleartext URLs. Bad: a cleartext `http` URL in a `fetch`.
+                'unicorn/prefer-https': 'error',
+                // `.catch()` over a second `.then()` argument. Bad: `promise.then(render, report)`.
+                'unicorn/prefer-then-catch': 'error',
+                // A helper that closes over nothing belongs at module level. Bad: `function outer() { const double = (x) => x * 2; }`.
+                'unicorn/consistent-function-scoping': 'error',
+                // One escape style for `${` in template literals. Bad: `` `\${a} $\{b}` ``.
+                'unicorn/consistent-template-literal-escape': 'error',
+                // `x !== undefined` where truthiness already decides. Bad: `if (user !== undefined)` with `user: User | undefined`.
+                '@hypersolid-dev/undefined-check': 'error',
+                // A regex is a module-level `*_PATTERN` constant, named for what it matches. Bad: `if (/^\d+$/.test(id))` in a function.
+                '@hypersolid-dev/regex-pattern-const': 'error',
+                // `//` and `/* */` comments stay one row; longer prose is a `/** */` block. Bad: three `//` lines in a row.
+                '@hypersolid-dev/comment-style': 'error',
                 // `undefined` as an argument is often required by the callee's signature. Bad: `let value = undefined`.
                 'unicorn/no-useless-undefined': ['error', { checkArguments: false }],
                 // Off: `.then()` chains are fine. Bad: `fetchUser().then(render)` reported.
@@ -142,12 +192,16 @@ export default function base(options) {
                 'import-x/namespace': 'off',
                 // High-entropy strings that look like credentials. Bad: `const token = 'ghp_Zx8kQ2vLm9…'`.
                 'no-secrets/no-secrets': 'error',
+                // A function too tangled to follow, nesting weighted over length (limit 15). Bad: a loop holding an `if` holding a `try`.
+                'sonarjs/cognitive-complexity': 'error',
             },
         },
         {
             name: '@hypersolid-dev/base/tests',
             files: TEST_FILES,
             rules: {
+                // A test's setup and table of cases are read once, not maintained as logic.
+                'sonarjs/cognitive-complexity': 'off',
                 // Off: mocks and fixtures are loosely typed by design. Bad: `const user = jest.fn()()` reported.
                 '@typescript-eslint/no-unsafe-assignment': 'off',
                 // Off: mocks and fixtures are loosely typed by design. Bad: `mock.calls[0].user` reported.
@@ -158,6 +212,10 @@ export default function base(options) {
                 'unicorn/no-error-property-assignment': 'off',
                 // Off: test setup stubs globals. Bad: `globalThis.fetch = mockFetch` reported.
                 'unicorn/no-global-object-property-assignment': 'off',
+                // Off: helpers inside a `describe` keep each suite readable on its own. Bad: `const render = () => …` in a `describe` reported.
+                'unicorn/consistent-function-scoping': 'off',
+                // Off: a test keeps its inline `toMatch(/…/)` literal. Bad: `expect(id).toMatch(/^\d+$/)` reported.
+                '@hypersolid-dev/regex-pattern-const': 'off',
             },
         },
         {

package/dist/jest.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from 'eslint';
+export declare const JEST_FILES: string[];
+export default function jest(): Linter.Config[];

package/dist/jest.js

@@ -0,0 +1,56 @@
+import jestPlugin from 'eslint-plugin-jest';
+import testingLibrary from 'eslint-plugin-testing-library';
+import { raiseWarnings } from './shared.js';
+// Test suites and Jest setup. Mocks and stories are left out: `jest/no-export` would reject what they exist to export.
+export const JEST_FILES = ['**/*.{test,spec}.{js,mjs,cjs,jsx,ts,mts,cts,tsx}', '**/jest.setup.*'];
+const SUITE_FILES = ['**/*.{test,spec}.{js,mjs,cjs,jsx,ts,mts,cts,tsx}'];
+export default function jest() {
+    return raiseWarnings([
+        {
+            // Jest's recommended set and its globals; the plugin ships it unscoped. Bad: `it.only(…)`, `expect` inside a `catch`.
+            ...jestPlugin.configs['flat/recommended'],
+            name: '@hypersolid-dev/jest',
+            files: JEST_FILES,
+            rules: {
+                ...jestPlugin.configs['flat/recommended'].rules,
+                // Off: jest/unbound-method replaces it and knows `expect(service.method)` does not call it. Bad: `expect(Alert.alert)` reported.
+                '@typescript-eslint/unbound-method': 'off',
+                // A method passed on loses its `this`, except into `expect`. Bad: `const { save } = service; save()`.
+                'jest/unbound-method': 'error',
+                // A test must assert; `expectX()` helpers count as assertions. Bad: `it('renders', () => { render(<A />); })`.
+                'jest/expect-expect': ['error', { assertFunctionNames: ['expect', 'expect*'] }],
+                // One spelling for a test case. Bad: `test('…')` next to `it('…')`.
+                'jest/consistent-test-it': ['error', { fn: 'it' }],
+                // A conditional in a test means it does not know what it asserts. Bad: `if (items.length) expect(…)`.
+                'jest/no-conditional-in-test': 'error',
+                // Two hooks of a kind in one block run in an order nobody chose. Bad: two `beforeEach` in one `describe`.
+                'jest/no-duplicate-hooks': 'error',
+                // Returning from a test hides an unawaited promise. Bad: `it('loads', () => { return load(); })`.
+                'jest/no-test-return-statement': 'error',
+                // Setup is read before what it sets up. Bad: `beforeEach` below the first `it`.
+                'jest/prefer-hooks-on-top': 'error',
+                // A blank line around each block, hook and assertion group. Bad: `it(…)` directly under `beforeEach(…)`.
+                'jest/padding-around-all': 'error',
+                // `jest.setTimeout` below the top level applies to nothing. Bad: `jest.setTimeout(10_000)` inside a `describe`.
+                'jest/no-confusing-set-timeout': 'error',
+            },
+        },
+        {
+            // Testing Library's React set; it covers React Native Testing Library, which has no flavour of its own. Bad: `container.querySelector(…)`, an unawaited `findBy…`.
+            ...testingLibrary.configs['flat/react'],
+            name: '@hypersolid-dev/jest/testing-library',
+            files: SUITE_FILES,
+            rules: {
+                ...testingLibrary.configs['flat/react'].rules,
+                // Events are awaited. Bad: `userEvent.press(button)` without `await`.
+                'testing-library/await-async-events': 'error',
+                // Testing Library already wraps its utilities in `act`. Bad: `act(() => fireEvent.press(button))`.
+                'testing-library/no-unnecessary-act': 'error',
+                // Off: React Native Testing Library 14's `fireEvent` returns a promise to await. Bad: `await fireEvent.press(button)` reported.
+                'testing-library/no-await-sync-events': 'off',
+                // Off: suites query through `screen`, so it only reaches helpers that return a mock. Bad: `const view = render(<A />)` reported.
+                'testing-library/render-result-naming-convention': 'off',
+            },
+        },
+    ]);
+}

package/dist/plugins/hypersolid.d.ts

@@ -0,0 +1,3 @@
+import type { ESLint } from 'eslint';
+declare const plugin: ESLint.Plugin;
+export default plugin;

package/dist/plugins/hypersolid.js

@@ -0,0 +1,38 @@
+import propsDestructuring from './props-destructuring.js';
+import booleanGuard from './rules/boolean-guard.js';
+import commentStyle from './rules/comment-style.js';
+import effectTakesCallback from './rules/effect-takes-callback.js';
+import jsdocForProps from './rules/jsdoc-for-props.js';
+import noCallbackPayload from './rules/no-callback-payload.js';
+import noMarkupVariable from './rules/no-markup-variable.js';
+import noUnnecessaryUseCallback from './rules/no-unnecessary-use-callback.js';
+import regexPatternConst from './rules/regex-pattern-const.js';
+import testIdDefault from './rules/test-id-default.js';
+import testIdFormat from './rules/test-id-format.js';
+import testIdFromProps from './rules/test-id-from-props.js';
+import undefinedCheck from './rules/undefined-check.js';
+import webviewAllowList from './rules/webview-allow-list.js';
+// One plugin object for every preset: flat config rejects two different objects under the same plugin name.
+const plugin = {
+    meta: { name: '@hypersolid-dev/eslint-config' },
+    rules: {
+        ...propsDestructuring.rules,
+        // typescript-eslint's `RuleModule` and ESLint's `Rule.RuleModule` type the same runtime object differently.
+        ...Object.fromEntries(Object.entries({
+            'boolean-guard': booleanGuard,
+            'comment-style': commentStyle,
+            'effect-takes-callback': effectTakesCallback,
+            'jsdoc-for-props': jsdocForProps,
+            'no-callback-payload': noCallbackPayload,
+            'no-markup-variable': noMarkupVariable,
+            'no-unnecessary-use-callback': noUnnecessaryUseCallback,
+            'regex-pattern-const': regexPatternConst,
+            'test-id-default': testIdDefault,
+            'test-id-format': testIdFormat,
+            'test-id-from-props': testIdFromProps,
+            'undefined-check': undefinedCheck,
+            'webview-allow-list': webviewAllowList,
+        })),
+    },
+};
+export default plugin;

package/dist/plugins/props-destructuring.js

@@ -1,8 +1,9 @@
 const FUNCTION_TYPES = new Set(['ArrowFunctionExpression', 'FunctionExpression', 'FunctionDeclaration']);
 const WRAPPERS = new Set(['memo', 'forwardRef']);
 const isFunction = (node) => typeof node === 'object' && node !== null && FUNCTION_TYPES.has(node.type);
-const isPascalCase = (name) => typeof name === 'string' && /^[A-Z]/.test(name);
-function isJsx(node) {
+const PASCAL_CASE_PATTERN = /^[A-Z]/;
+const isPascalCase = (name) => typeof name === 'string' && PASCAL_CASE_PATTERN.test(name);
+const isJsx = (node) => {
     if (typeof node !== 'object' || node === null) {
         return false;
     }
@@ -14,22 +15,22 @@ function isJsx(node) {
         return isJsx(consequent) || isJsx(alternate);
     }
     return type === 'LogicalExpression' && (isJsx(left) || isJsx(right));
-}
+};
 // Searches the function's own return statements; nested functions return for themselves.
-function returnsJsx(node) {
+const isReturningJsx = (node) => {
     if (typeof node !== 'object' || node === null) {
         return false;
     }
     if (Array.isArray(node)) {
-        return node.some(returnsJsx);
+        return node.some(isReturningJsx);
     }
     const current = node;
     return current.type === 'ReturnStatement'
         ? isJsx(current.argument)
-        : Object.entries(current).some(([key, value]) => key !== 'parent' && !isFunction(value) && typeof value === 'object' && returnsJsx(value));
-}
+        : Object.entries(current).some(([key, value]) => key !== 'parent' && !isFunction(value) && typeof value === 'object' && isReturningJsx(value));
+};
 // `memo(fn)`, `React.forwardRef(fn)` and `memo(forwardRef(fn))`.
-function unwrap(node) {
+const unwrap = (node) => {
     if (isFunction(node)) {
         return node;
     }
@@ -40,7 +41,7 @@ function unwrap(node) {
     const { type: calleeType, name, property } = callee;
     const calleeName = calleeType === 'MemberExpression' ? property.name : name;
     return typeof calleeName === 'string' && WRAPPERS.has(calleeName) ? unwrap(args[0]) : undefined;
-}
+};
 const propsDestructuring = {
     meta: {
         type: 'suggestion',
@@ -50,7 +51,7 @@ const propsDestructuring = {
             destructure: 'Destructure the props in the signature: `({ title }: Props)`. A discriminated-union props type may keep `props`.',
         },
     },
-    create(context) {
+    create: (context) => {
         const services = context.sourceCode.parserServices;
         const checker = services.program?.getTypeChecker();
         // Destructuring a union in the signature breaks narrowing (`if (props.kind === 'a') props.aOnly`).
@@ -60,18 +61,18 @@ const propsDestructuring = {
         };
         const check = (fn) => {
             const props = fn?.params[0];
-            if (!fn || props?.type !== 'Identifier' || !returnsJsx(fn.body) && !isJsx(fn.body) || isUnion(props)) {
+            if (!fn || props?.type !== 'Identifier' || !isReturningJsx(fn.body) && !isJsx(fn.body) || isUnion(props)) {
                 return;
             }
             context.report({ node: props, messageId: 'destructure' });
         };
         return {
-            FunctionDeclaration(node) {
+            FunctionDeclaration: (node) => {
                 if (isPascalCase(node.id.name)) {
                     check(node);
                 }
             },
-            VariableDeclarator(node) {
+            VariableDeclarator: (node) => {
                 if (node.id.type === 'Identifier' && isPascalCase(node.id.name)) {
                     check(unwrap(node.init));
                 }

package/dist/plugins/react-native-a11y/index.js

@@ -38,8 +38,10 @@ const rules = {
     "require-invert-colors-opt-out": requireInvertColorsOptOut,
     "require-modal-a11y-on-sheets": requireModalA11yOnSheets,
 };
-// React Native accessibility rules, maintained in-house. Originally @hypersolid-dev/eslint-config (react-native preset) v2.2.0 (MIT), from
-// before Triple became Hypersolid. Rule docs live in ./docs.
+/**
+ * React Native accessibility rules, maintained in-house. Originally @hypersolid-dev/eslint-config (react-native preset) v2.2.0 (MIT), from
+ * before Triple became Hypersolid. Rule docs live in ./docs.
+ */
 const plugin = {
     meta: { name: "@hypersolid-dev/react-native-a11y" },
     rules,

package/dist/plugins/react-native-a11y/rules/accessibility-actions-need-handler.js

@@ -26,7 +26,7 @@ const accessibilityActionsNeedHandler = createRule({
         },
         schema: [],
     },
-    create(context) {
+    create: (context) => {
         const reportUnlabelledActions = (expression) => {
             if (expression.type !== AST_NODE_TYPES.ArrayExpression) {
                 return;
@@ -54,7 +54,7 @@ const accessibilityActionsNeedHandler = createRule({
             }
         };
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 if (hasSpreadProps(node)) {
                     return;
                 }

package/dist/plugins/react-native-a11y/rules/accessibility-hint.js

@@ -33,13 +33,13 @@ const accessibilityHint = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: TOUCHABLES,
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;
@@ -54,8 +54,10 @@ const accessibilityHint = createRule({
                     isInsideFocusStop(node)) {
                     return;
                 }
-                // Visible text already names the control, so the hint has a name to
-                // hang off even without a label
+                /**
+                 * Visible text already names the control, so the hint has a name to
+                 * hang off even without a label
+                 */
                 const { children } = node.parent;
                 if (hasLabelProperty(node) || getAmountOfTextChildren(children) > 0) {
                     return;

package/dist/plugins/react-native-a11y/rules/accessibility-label.js

@@ -35,13 +35,13 @@ const accessibilityLabel = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: [...IMAGES, ...TOUCHABLES, ...INPUTS],
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;
@@ -49,8 +49,10 @@ const accessibilityLabel = createRule({
                 if (!components.includes(componentName)) {
                     return;
                 }
-                // Decorative content is hidden rather than labelled
-                // The surface above answers for its children
+                /**
+                 * Decorative content is hidden rather than labelled
+                 * The surface above answers for its children
+                 */
                 if (isHiddenFromAccessibility(node) ||
                     isNotAFocusStop(node) ||
                     isInsideFocusStop(node)) {
@@ -73,8 +75,10 @@ const accessibilityLabel = createRule({
                 // Visible text already names the control
                 const { children } = node.parent;
                 const amountOfTextChildren = getAmountOfTextChildren(children);
-                // 2.5.3: a spoken command matches the accessible name, so the name
-                // has to contain what the user can read
+                /**
+                 * 2.5.3: a spoken command matches the accessible name, so the name
+                 * has to contain what the user can read
+                 */
                 const label = getLiteralLabel(node);
                 const visible = getLiteralTextChild(children);
                 if (label !== undefined &&

package/dist/plugins/react-native-a11y/rules/accessibility-role.js

@@ -31,13 +31,13 @@ const accessibilityRole = createRule({
             },
         ],
     },
-    create(context) {
+    create: (context) => {
         const components = getComponents({
             context,
             defaultComponents: [...TOUCHABLES, ...IMAGES],
         });
         return {
-            JSXOpeningElement(node) {
+            JSXOpeningElement: (node) => {
                 const componentName = getElementName(node);
                 if (componentName === undefined) {
                     return;
@@ -45,8 +45,10 @@ const accessibilityRole = createRule({
                 if (!components.includes(componentName)) {
                     return;
                 }
-                // Decorative content is hidden rather than given a role
-                // The surface above answers for its children
+                /**
+                 * Decorative content is hidden rather than given a role
+                 * The surface above answers for its children
+                 */
                 if (isHiddenFromAccessibility(node) ||
                     isNotAFocusStop(node) ||
                     isInsideFocusStop(node)) {