@hypersolid-dev/eslint-config 1.0.0 → 2.0.0

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [2.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv1.0.0&targetVersion=GTv2.0.0) (2026-11-09)
+
+### ⚠ BREAKING CHANGES
+
+* **base:** switch-exhaustiveness-check now accepts a default branch as exhaustive.
+
+### Features
+
+* **base:** retune rules after the ESPN Goal rule review ([113775e](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/113775ed1b1ae3abfcac948d55ba33328311b903)), closes [AB#5176](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5176)
+* **react-native:** Reanimated boolean wrappers, Expo no-secrets ignores, browser globals in tests ([86bf9b3](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/86bf9b3149a0696b4cc9114ca7f60c5074c002c0)), closes [AB#5176](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5176)
+* **react:** exempt hook and mock names from consistent-boolean-name, relax use-prefix in tests ([2d96538](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/commit/2d96538f941a9b5cf28b28c9481875b3da2f6a67)), closes [AB#5176](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_workitems/edit/5176)
+
 ## [1.0.0](https://dev.azure.com/wearetriple/Triple%20-%20Webteam/_git/eslint-config-hypersolid/branchCompare?baseVersion=GTv0.1.2&targetVersion=GTv1.0.0) (2026-11-06)
 
 ### ⚠ BREAKING CHANGES

package/README.md

@@ -124,6 +124,22 @@ export default [...base({ tsconfigRootDir: import.meta.dirname }), { ignores: ['
 
 `base` already ignores `node_modules`, `dist`, `build`, `coverage` and lockfiles.
 
+### Test files
+
+Every preset relaxes a few rules for tests, stories, mocks and test setup (`TEST_FILES`, exported from `@hypersolid-dev/eslint-config/base`): `@typescript-eslint/no-unsafe-assignment`, `no-unsafe-member-access`, `no-invalid-void-type`, `unicorn/no-error-property-assignment` and `no-global-object-property-assignment` in `base`; `@eslint-react/no-unnecessary-use-prefix` in `react` and `react-native`; and the browser-globals list (`no-restricted-globals`) in `react-native`. Source code keeps them all.
+
+```js
+import base, { TEST_FILES } from '@hypersolid-dev/eslint-config/base';
+
+export default [...base({ tsconfigRootDir: import.meta.dirname }), { files: TEST_FILES, rules: { 'no-console': 'off' } }];
+```
+
+### Preset-specific options
+
+- `unicorn/consistent-boolean-name` skips function names in every preset; `react` and `react-native` also skip hook (`^use[A-Z]`) and jest mock (`^mock`) names, and `react-native` reads Reanimated's `SharedValue` through `.value`.
+- `no-secrets/no-secrets` ignores `data:` URIs in JSON; in `react-native` it also ignores Expo and native identifiers (`EXPO_*`, `android.settings.*`, `@xml…`, `NSPrivacy*`, i18n `Namespace/Key` paths) in code and JSON.
+- `@typescript-eslint/switch-exhaustiveness-check` accepts a `default` branch as exhaustive (`considerDefaultExhaustiveForUnions`). Set it to `false` to make every new union member fail its switches.
+
 ## Formatting and import order
 
 This config has no formatting or stylistic rules, and it doesn't sort imports (`import-x/order` is off). Use a formatter such as Prettier or Biome for both.

package/dist/base.d.ts

@@ -1,4 +1,5 @@
 import type { Linter } from 'eslint';
+export { TEST_FILES } from './shared.js';
 export type BaseOptions = {
     /** Directory of the consumer's tsconfig, usually `import.meta.dirname`. */
     tsconfigRootDir: string;

package/dist/base.js

@@ -5,7 +5,9 @@ import { createNodeResolver, flatConfigs as importX } from 'eslint-plugin-import
 import noSecrets from 'eslint-plugin-no-secrets';
 import unicorn from 'eslint-plugin-unicorn';
 import { configs as tsConfigs } from 'typescript-eslint';
-import { CODE_FILES, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, scopeToCode } from './shared.js';
+import { BOOLEAN_NAME_OPTIONS, CODE_FILES, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, scopeToCode, TEST_FILES } from './shared.js';
+// The glob the presets relax test-only rules for; reuse it for your own test overrides.
+export { TEST_FILES } from './shared.js';
 export default function base(options) {
     if (!options.tsconfigRootDir) {
         throw new Error('@hypersolid-dev/eslint-config: base() requires tsconfigRootDir');
@@ -66,16 +68,23 @@ export default function base(options) {
                 '@typescript-eslint/no-import-type-side-effects': 'error',
                 // `??` over `||` for defaults, so `0` and `''` survive. Bad: `count || 10`.
                 '@typescript-eslint/prefer-nullish-coalescing': 'error',
-                // `sort()` needs a comparator; the default sorts numbers as strings. Bad: `[10, 9].sort()`.
-                '@typescript-eslint/require-array-sort-compare': 'error',
+                // A void call as an expression; arrow shorthand like `onPress={() => setOpen(true)}` is fine. Bad: `const result = log(x)`.
+                '@typescript-eslint/no-confusing-void-expression': ['error', { ignoreArrowShorthand: true }],
+                // `sort()` needs a comparator, except on strings, where the default order is correct. Bad: `[10, 9].sort()`.
+                '@typescript-eslint/require-array-sort-compare': ['error', { ignoreStringArrays: true }],
+                // Only strings and numbers in template literals (strictTypeChecked's options plus numbers). Bad: `` `${user}` ``, `` `${null}` ``.
+                '@typescript-eslint/restrict-template-expressions': [
+                    'error',
+                    { allowAny: false, allowBoolean: false, allowNever: false, allowNullish: false, allowNumber: true, allowRegExp: false },
+                ],
                 // No value returned where `void` is expected. Bad: `run(() => 1)` with `run(callback: () => void)`.
                 '@typescript-eslint/strict-void-return': ['error', { allowReturnAny: true }],
-                // A `switch` on a union handles every member. Bad: `switch (shape) { case 'circle': … }` missing `'square'`.
-                '@typescript-eslint/switch-exhaustiveness-check': 'error',
+                // A `switch` on a union handles every member or has a `default`. Bad: `switch (shape) { case 'circle': … }` missing `'square'`.
+                '@typescript-eslint/switch-exhaustiveness-check': ['error', { considerDefaultExhaustiveForUnions: true }],
                 // The caught value is named `error`. Bad: `catch (e)`.
                 'unicorn/catch-error-name': 'error',
                 // A boolean reads as a claim. Bad: `const visible = true` (use `isVisible`).
-                'unicorn/consistent-boolean-name': ['error', { checkFunctions: 'never' }],
+                'unicorn/consistent-boolean-name': ['error', BOOLEAN_NAME_OPTIONS],
                 // A compound word is one word. Bad: `callBack`, `dataBase`.
                 'unicorn/consistent-compound-words': 'error',
                 // No non-standard abbreviations. Bad: `btn`, `cfg`. Allowed: `props`, `args`, `fn`, `ref`, `env`, `params`.
@@ -99,12 +108,58 @@ export default function base(options) {
                 'unicorn/no-unsafe-promise-all-settled-values': 'error',
                 // An async function already wraps its return value. Bad: `async () => Promise.resolve(1)`.
                 'unicorn/no-useless-promise-resolve-reject': 'error',
+                // `undefined` as an argument is often required by the callee's signature. Bad: `let value = undefined`.
+                'unicorn/no-useless-undefined': ['error', { checkArguments: false }],
+                // Off: `.then()` chains are fine. Bad: `fetchUser().then(render)` reported.
+                'unicorn/prefer-await': 'off',
+                // Off: an `if`/`else` is often clearer than a ternary. Bad: `if (a) { x = 1 } else { x = 2 }` reported.
+                'unicorn/prefer-ternary': 'off',
+                // Off: a `case` next to `default` documents a known value. Bad: `case 'other': default:` reported.
+                'unicorn/no-useless-switch-case': 'off',
+                // Off: @typescript-eslint/require-array-sort-compare reports it with type information. Bad: `[10, 9].sort()` reported twice.
+                'unicorn/require-array-sort-compare': 'off',
+                // Off: DOM traversal style is taste. Bad: `element.parentNode` reported.
+                'unicorn/better-dom-traversing': 'off',
+                // Off: import style is taste. Bad: `import { join } from 'node:path'` reported.
+                'unicorn/import-style': 'off',
+                // Off: skipping elements by commas is fine. Bad: `const [, second] = list` reported.
+                'unicorn/no-unreadable-array-destructuring': 'off',
+                // Off: nested destructuring is fine. Bad: `const { a: { b } } = value` reported.
+                'unicorn/no-unreadable-object-destructuring': 'off',
+                // Off: `1.0` can document a float. Bad: `const opacity = 1.0` reported.
+                'unicorn/no-zero-fractions': 'off',
+                // Off: rarely relevant, noisy on intentional characters. Bad: a literal no-break space reported.
+                'unicorn/prefer-escaped-irregular-whitespace': 'off',
+                // Off: `window` and `global` are clearer where the platform is known. Bad: `window.location` reported.
+                'unicorn/prefer-global-this': 'off',
+                // Off: escaped strings are fine. Bad: `'C:\\temp'` reported.
+                'unicorn/prefer-string-raw': 'off',
+                // Off: rarely relevant. Bad: `Array(3).fill('-').join('')` reported.
+                'unicorn/prefer-string-repeat': 'off',
                 // Import order is formatting, out of scope (AGENTS.md).
                 'import-x/order': 'off',
+                // Off: TypeScript checks namespace members, and the rule is slow. Bad: `import * as math from './math.js'; math.missing` reported twice.
+                'import-x/namespace': 'off',
                 // High-entropy strings that look like credentials. Bad: `const token = 'ghp_Zx8kQ2vLm9…'`.
                 'no-secrets/no-secrets': 'error',
             },
         },
+        {
+            name: '@hypersolid-dev/base/tests',
+            files: TEST_FILES,
+            rules: {
+                // Off: mocks and fixtures are loosely typed by design. Bad: `const user = jest.fn()()` reported.
+                '@typescript-eslint/no-unsafe-assignment': 'off',
+                // Off: mocks and fixtures are loosely typed by design. Bad: `mock.calls[0].user` reported.
+                '@typescript-eslint/no-unsafe-member-access': 'off',
+                // Off: mock signatures use `void` as a generic. Bad: `jest.fn<void, []>()` reported.
+                '@typescript-eslint/no-invalid-void-type': 'off',
+                // Off: tests build errors by hand. Bad: `error.code = 'ENOENT'` reported.
+                'unicorn/no-error-property-assignment': 'off',
+                // Off: test setup stubs globals. Bad: `globalThis.fetch = mockFetch` reported.
+                'unicorn/no-global-object-property-assignment': 'off',
+            },
+        },
         {
             name: '@hypersolid-dev/base/json',
             files: ['**/*.json'],
@@ -113,8 +168,8 @@ export default function base(options) {
             rules: {
                 // JSON correctness. Bad: `{ "name": "a", "name": "b" }`.
                 ...json.configs.recommended.rules,
-                // Letters-only strings are keys and words (`verbatimModuleSyntax`), not credentials.
-                'no-secrets/no-secrets': ['error', { ignoreContent: ['^[A-Za-z]+$'] }],
+                // Letters-only strings are keys and words (`verbatimModuleSyntax`), and `data:` URIs are embedded images; neither is a credential.
+                'no-secrets/no-secrets': ['error', { ignoreContent: ['^[A-Za-z]+$', '^data:'] }],
             },
         },
     ]);

package/dist/react-native.js

@@ -1,11 +1,21 @@
 import globals from 'globals';
-import { CODE_FILES, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, reactConfigs } from './shared.js';
+import noSecrets from 'eslint-plugin-no-secrets';
+import { CODE_FILES, NUMBER_GLOBAL_RESTRICTIONS, raiseWarnings, REACT_BOOLEAN_NAME_OPTIONS, reactConfigs, TEST_FILES, } from './shared.js';
 // Derived instead of hardcoded: the frozen `confusing-browser-globals` list (last released 2021) misses `document`,
 // `localStorage` and `getComputedStyle`, and bans `self`, which React Native defines. `globals` is maintained,
 // so new browser APIs are picked up without editing this file.
 // Globals Hermes provides that `globals['react-native']` does not list yet; remove a name once `globals` adds it.
 const HERMES_GLOBALS = new Set(['atob', 'btoa', 'TextEncoder']);
 const BROWSER_GLOBALS = Object.keys(globals.browser).filter((name) => !(name in globals['react-native']) && !HERMES_GLOBALS.has(name));
+// High-entropy strings in Expo and native config that are identifiers, not credentials.
+const NO_SECRETS_IGNORE = [
+    '^android\\.settings\\.', // Android intent actions
+    '^EXPO_', // env var names
+    '^@xml', // Android resource references
+    '^NSPrivacy[A-Za-z]+$', // iOS privacy manifest keys
+    '^[A-Z][A-Za-z0-9]*\\/[A-Z][A-Za-z0-9]*$', // i18n `Namespace/Key` paths
+    '^data:', // Lottie and embedded images
+];
 export default function reactNative() {
     return raiseWarnings([
         {
@@ -16,6 +26,7 @@ export default function reactNative() {
         {
             name: '@hypersolid-dev/react-native',
             files: CODE_FILES,
+            plugins: { 'no-secrets': noSecrets },
             rules: {
                 // Browser globals React Native lacks, and the coercing number globals. Bad: `document.title`, `isNaN(value)`.
                 'no-restricted-globals': [
@@ -48,6 +59,30 @@ export default function reactNative() {
                 'unicorn/prefer-event-target': 'off',
                 // Metro emits CommonJS, so top-level await does not bundle. Bad: `await init();` at module scope.
                 'unicorn/prefer-top-level-await': 'off',
+                // A boolean reads as a claim; Reanimated's `SharedValue<boolean>` is read through `.value`. Bad: `const visible = useSharedValue(true)`.
+                'unicorn/consistent-boolean-name': [
+                    'error',
+                    { ...REACT_BOOLEAN_NAME_OPTIONS, wrappers: { SharedValue: 'value' } },
+                ],
+                // High-entropy strings that look like credentials, minus Expo and native identifiers. Bad: `const token = 'ghp_Zx8kQ2vLm9…'`.
+                'no-secrets/no-secrets': ['error', { ignoreContent: NO_SECRETS_IGNORE }],
+            },
+        },
+        {
+            name: '@hypersolid-dev/react-native/json',
+            files: ['**/*.json'],
+            plugins: { 'no-secrets': noSecrets },
+            rules: {
+                // Credentials in JSON, minus letters-only words and Expo and native identifiers. Bad: `{ "token": "ghp_Zx8kQ2vLm9…" }`.
+                'no-secrets/no-secrets': ['error', { ignoreContent: ['^[A-Za-z]+$', ...NO_SECRETS_IGNORE] }],
+            },
+        },
+        {
+            name: '@hypersolid-dev/react-native/tests',
+            files: TEST_FILES,
+            rules: {
+                // Off: tests stub browser globals. Bad: `document.title = 'x'` in a jsdom test reported.
+                'no-restricted-globals': 'off',
             },
         },
     ]);

package/dist/shared.d.ts

@@ -1,5 +1,13 @@
 import type { Linter } from 'eslint';
 export declare const CODE_FILES: string[];
+export declare const TEST_FILES: string[];
+export declare const BOOLEAN_NAME_OPTIONS: {
+    checkFunctions: string;
+};
+export declare const REACT_BOOLEAN_NAME_OPTIONS: {
+    ignore: string[];
+    checkFunctions: string;
+};
 export declare const NUMBER_GLOBAL_RESTRICTIONS: {
     name: string;
     message: string;

package/dist/shared.js

@@ -1,7 +1,18 @@
 import eslintReact from '@eslint-react/eslint-plugin';
 import reactHooks from 'eslint-plugin-react-hooks';
+import unicorn from 'eslint-plugin-unicorn';
 import hypersolid from './plugins/props-destructuring.js';
 export const CODE_FILES = ['**/*.{js,mjs,cjs,jsx,ts,mts,cts,tsx}'];
+// Tests, stories, mocks and test setup: each preset relaxes a few rules here that test doubles break by design.
+export const TEST_FILES = [
+    '**/*.{test,spec,stories}.{js,mjs,cjs,jsx,ts,mts,cts,tsx}',
+    '**/__mocks__/**',
+    '**/{jest,vitest}.setup.*',
+];
+// `unicorn/consistent-boolean-name` options per preset; a later config replaces options, so each preset states them all.
+export const BOOLEAN_NAME_OPTIONS = { checkFunctions: 'never' };
+// Hooks (`useIsOpen`) and jest mock factories (`mockIsReady`) are named by convention, not as claims.
+export const REACT_BOOLEAN_NAME_OPTIONS = { ...BOOLEAN_NAME_OPTIONS, ignore: ['^use[A-Z]', '^mock'] };
 // Shared by every preset that sets `no-restricted-globals`: a later config replaces the rule's options, not merges them.
 export const NUMBER_GLOBAL_RESTRICTIONS = ['isFinite', 'isNaN'].map((name) => ({
     name,
@@ -39,7 +50,7 @@ export function reactConfigs() {
         {
             name: '@hypersolid-dev/react',
             files: CODE_FILES,
-            plugins: { '@hypersolid-dev': hypersolid },
+            plugins: { '@hypersolid-dev': hypersolid, unicorn },
             languageOptions: { parserOptions: { ecmaFeatures: { jsx: true } } },
             rules: {
                 // Off: react-hooks/exhaustive-deps reports it. Bad: `useEffect(() => log(id), [])` reported twice.
@@ -72,6 +83,16 @@ export function reactConfigs() {
                 '@eslint-react/no-unstable-context-value': 'error',
                 // Props are readable from the component's signature; a union props type may keep `props`. Bad: `const Card = (props: Props) => <h1>{props.title}</h1>`.
                 '@hypersolid-dev/props-destructuring': 'error',
+                // A boolean reads as a claim; hook and mock names are exempt. Bad: `const visible = true` (use `isVisible`).
+                'unicorn/consistent-boolean-name': ['error', REACT_BOOLEAN_NAME_OPTIONS],
+            },
+        },
+        {
+            name: '@hypersolid-dev/react/tests',
+            files: TEST_FILES,
+            rules: {
+                // Off: a mocked hook keeps the `use` name of the hook it replaces. Bad: `const useUser = () => fakeUser` in a mock.
+                '@eslint-react/no-unnecessary-use-prefix': 'off',
             },
         },
     ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hypersolid-dev/eslint-config",
-  "version": "1.0.0",
+  "version": "2.0.0",
   "description": "Shared ESLint flat config for Hypersolid TypeScript projects",
   "license": "MIT",
   "keywords": [