@hyperframes/studio 0.8.143 → 0.8.145
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/assets/{hyperframes-player-BXSuksFh.js → hyperframes-player-DZ5JrMDg.js} +3 -3
- package/dist/assets/{index-FgyO_5Kv.js → index-BOs6C0aZ.js} +1 -1
- package/dist/assets/{index-BgOVCqjo.js → index-BqFRhNZa.js} +1 -1
- package/dist/assets/{index-J7jpL4pj.js → index-D8W0a0Z9.js} +149 -149
- package/dist/{chunk-TFLU2MGI.js → chunk-6JY3MTIX.js} +108 -2
- package/dist/chunk-6JY3MTIX.js.map +1 -0
- package/dist/{chunk-H2DUOXTF.js → chunk-NZPJUZKT.js} +100 -4
- package/dist/chunk-NZPJUZKT.js.map +1 -0
- package/dist/{chunk-UYWON5AX.js → chunk-TP6D3U37.js} +7 -100
- package/dist/chunk-TP6D3U37.js.map +1 -0
- package/dist/{chunk-LOVBLSMR.js → chunk-Y2OHHNM2.js} +35 -19
- package/dist/chunk-Y2OHHNM2.js.map +1 -0
- package/dist/{domEditingLayers-KBTPQKGA.js → domEditingLayers-PTP2ICGM.js} +3 -3
- package/dist/index.d.ts +8 -5
- package/dist/index.html +1 -1
- package/dist/index.js +545 -495
- package/dist/index.js.map +1 -1
- package/dist/player.js +3 -3
- package/dist/ui.d.ts +4 -5
- package/dist/ui.js +1 -1
- package/package.json +8 -8
- package/src/components/StudioLeftPanels.tsx +2 -2
- package/src/components/editor/DomEditSelectionChrome.test.tsx +103 -0
- package/src/components/editor/DomEditSelectionChrome.tsx +42 -16
- package/src/components/editor/LayersPanel.test.ts +4 -4
- package/src/components/editor/LayersPanel.tsx +2 -2
- package/src/components/editor/TopologyLens.test.tsx +5 -4
- package/src/components/editor/anchoredResizeCommitFeedsOffset.test.ts +36 -0
- package/src/components/editor/domEditOverlayGestures.ts +1 -0
- package/src/components/editor/domEditOverlayStartGesture.ts +5 -0
- package/src/components/editor/domEditResizeLocal.test.ts +81 -1
- package/src/components/editor/domEditResizeLocal.ts +27 -3
- package/src/components/editor/domEditingLayers.ts +4 -1
- package/src/components/editor/domEditingTextFields.test.ts +18 -0
- package/src/components/editor/manualEditsDom.ts +12 -12
- package/src/components/editor/previewGestureStarts.ts +14 -5
- package/src/components/editor/resizeDraft.ts +13 -4
- package/src/components/editor/useDomEditOverlayGestures.ts +5 -3
- package/src/components/renders/GpuEncodingToggle.tsx +28 -0
- package/src/components/renders/RenderQueue.test.tsx +20 -2
- package/src/components/renders/RenderQueue.tsx +13 -1
- package/src/components/renders/RenderQueuePanel.tsx +2 -1
- package/src/components/renders/renderSettings.ts +5 -2
- package/src/components/renders/useRenderQueue.ts +3 -0
- package/src/components/renders/useRenderQueueComposition.test.tsx +12 -0
- package/src/components/ui/Menu.test.tsx +67 -5
- package/src/components/ui/Menu.tsx +21 -4
- package/src/components/ui/Popover.tsx +11 -5
- package/src/hooks/gsapResizeIntercept.test.ts +46 -11
- package/src/hooks/gsapResizeIntercept.ts +25 -20
- package/src/hooks/useConsoleErrorCapture.test.tsx +21 -2
- package/src/hooks/useConsoleErrorCapture.ts +3 -2
- package/src/hooks/useThumbnailStripSize.test.tsx +123 -0
- package/src/hooks/useThumbnailStripSize.ts +19 -8
- package/src/index.ts +1 -0
- package/src/player/components/CompositionThumbnail.test.ts +3 -0
- package/src/player/components/ImageThumbnail.test.tsx +4 -1
- package/src/player/components/Player.test.ts +44 -0
- package/src/player/components/Player.tsx +11 -0
- package/src/player/components/VideoThumbnail.test.tsx +13 -2
- package/src/player/hooks/timelineSyncHydration.ts +2 -1
- package/src/player/lib/playbackTypes.ts +1 -0
- package/src/player/sceneSwap.test.ts +27 -1
- package/src/player/sceneSwap.ts +16 -2
- package/src/utils/authoredSource.test.ts +25 -0
- package/src/utils/authoredSource.ts +3 -5
- package/src/utils/rounding.ts +7 -0
- package/dist/chunk-H2DUOXTF.js.map +0 -1
- package/dist/chunk-LOVBLSMR.js.map +0 -1
- package/dist/chunk-TFLU2MGI.js.map +0 -1
- package/dist/chunk-UYWON5AX.js.map +0 -1
- /package/dist/{domEditingLayers-KBTPQKGA.js.map → domEditingLayers-PTP2ICGM.js.map} +0 -0
|
@@ -1,5 +1,11 @@
|
|
|
1
1
|
import { describe, expect, it } from "vitest";
|
|
2
|
+
import { Window } from "happy-dom";
|
|
3
|
+
import {
|
|
4
|
+
PREVIEW_RASTER_ATTR,
|
|
5
|
+
STUDIO_PREVIEW_UPCOMING_ATTR,
|
|
6
|
+
} from "@hyperframes/core/studio-preview-mark";
|
|
2
7
|
import { serializeDomEditTextFields } from "./domEditing";
|
|
8
|
+
import { collectDomEditTextFields } from "./domEditingLayers";
|
|
3
9
|
|
|
4
10
|
describe("serializeDomEditTextFields — mixed content", () => {
|
|
5
11
|
it("round-trips text-node + child element fields", () => {
|
|
@@ -58,3 +64,15 @@ describe("serializeDomEditTextFields — mixed content", () => {
|
|
|
58
64
|
).toBe("A < B & C > D");
|
|
59
65
|
});
|
|
60
66
|
});
|
|
67
|
+
|
|
68
|
+
describe("collectDomEditTextFields — preview marks", () => {
|
|
69
|
+
it("keeps preview-only attributes out of a saved text edit", () => {
|
|
70
|
+
const { document } = new Window();
|
|
71
|
+
document.body.innerHTML = `<h1>Hello <span class="word" ${PREVIEW_RASTER_ATTR} ${STUDIO_PREVIEW_UPCOMING_ATTR}>world</span></h1>`;
|
|
72
|
+
const heading = document.querySelector("h1") as unknown as HTMLElement;
|
|
73
|
+
const saved = serializeDomEditTextFields(collectDomEditTextFields(heading));
|
|
74
|
+
expect(saved).toContain('<span class="word" data-hf-text-key=');
|
|
75
|
+
expect(saved).not.toContain(PREVIEW_RASTER_ATTR);
|
|
76
|
+
expect(saved).not.toContain(STUDIO_PREVIEW_UPCOMING_ATTR);
|
|
77
|
+
});
|
|
78
|
+
});
|
|
@@ -36,7 +36,7 @@ import {
|
|
|
36
36
|
} from "./manualEditsTypes";
|
|
37
37
|
import { gsapWritesChannels } from "../../hooks/gsapRuntimeKeyframes";
|
|
38
38
|
import { splitTopLevelWhitespace } from "./manualEditsStyleHelpers";
|
|
39
|
-
import { roundTo3,
|
|
39
|
+
import { roundTo3, roundToLayoutSize } from "../../utils/rounding";
|
|
40
40
|
import { BOX_SIZE_STYLE_PROPS } from "./manualEditsDomPatches";
|
|
41
41
|
|
|
42
42
|
/* ── Gesture tracking ─────────────────────────────────────────────── */
|
|
@@ -402,7 +402,7 @@ function readParentFlexBasisPixels(
|
|
|
402
402
|
if (display !== "flex" && display !== "inline-flex") return null;
|
|
403
403
|
|
|
404
404
|
const direction = readStyleOrComputed(parent, "flex-direction").trim();
|
|
405
|
-
return
|
|
405
|
+
return direction.startsWith("column") ? size.height : size.width;
|
|
406
406
|
}
|
|
407
407
|
|
|
408
408
|
function restoreStaleStudioScaleResize(element: HTMLElement): void {
|
|
@@ -477,22 +477,21 @@ function writeStudioBoxSizeVars(
|
|
|
477
477
|
}
|
|
478
478
|
|
|
479
479
|
element.setAttribute(STUDIO_BOX_SIZE_ATTR, "true");
|
|
480
|
-
element.style.setProperty(STUDIO_WIDTH_PROP, `${
|
|
481
|
-
element.style.setProperty(STUDIO_HEIGHT_PROP, `${
|
|
480
|
+
element.style.setProperty(STUDIO_WIDTH_PROP, `${size.width}px`);
|
|
481
|
+
element.style.setProperty(STUDIO_HEIGHT_PROP, `${size.height}px`);
|
|
482
482
|
}
|
|
483
483
|
|
|
484
484
|
function applyStudioBoxSizeDimensions(
|
|
485
485
|
element: HTMLElement,
|
|
486
|
-
|
|
487
|
-
):
|
|
486
|
+
wantedSize: { width: number; height: number },
|
|
487
|
+
): { width: number; height: number } {
|
|
488
|
+
const size = roundToLayoutSize(wantedSize);
|
|
488
489
|
writeStudioBoxSizeVars(element, size);
|
|
489
490
|
restoreStaleStudioScaleResize(element);
|
|
490
491
|
|
|
491
|
-
const width = roundToLayoutPx(Math.max(1, size.width));
|
|
492
|
-
const height = roundToLayoutPx(Math.max(1, size.height));
|
|
493
492
|
element.style.setProperty("box-sizing", "border-box");
|
|
494
|
-
element.style.setProperty("width", `${width}px`);
|
|
495
|
-
element.style.setProperty("height", `${height}px`);
|
|
493
|
+
element.style.setProperty("width", `${size.width}px`);
|
|
494
|
+
element.style.setProperty("height", `${size.height}px`);
|
|
496
495
|
element.style.setProperty("min-width", "0px");
|
|
497
496
|
element.style.setProperty("min-height", "0px");
|
|
498
497
|
element.style.setProperty("max-width", "none");
|
|
@@ -507,6 +506,7 @@ function applyStudioBoxSizeDimensions(
|
|
|
507
506
|
if (computedDisplay === "inline") {
|
|
508
507
|
element.style.setProperty("display", "inline-block");
|
|
509
508
|
}
|
|
509
|
+
return size;
|
|
510
510
|
}
|
|
511
511
|
|
|
512
512
|
export function applyStudioBoxSize(
|
|
@@ -533,12 +533,12 @@ export function forgetStudioBoxSizeDraftBase(element: HTMLElement): void {
|
|
|
533
533
|
export function applyStudioBoxSizeDraft(
|
|
534
534
|
element: HTMLElement,
|
|
535
535
|
size: { width: number; height: number },
|
|
536
|
-
):
|
|
536
|
+
): { width: number; height: number } {
|
|
537
537
|
if (!boxSizeDraftBases.has(element)) {
|
|
538
538
|
boxSizeDraftBases.set(element, { width: element.offsetWidth, height: element.offsetHeight });
|
|
539
539
|
}
|
|
540
540
|
promoteInlineForTransform(element);
|
|
541
|
-
applyStudioBoxSizeDimensions(element, size);
|
|
541
|
+
return applyStudioBoxSizeDimensions(element, size);
|
|
542
542
|
}
|
|
543
543
|
|
|
544
544
|
/* ── Rotation apply ───────────────────────────────────────────────── */
|
|
@@ -99,10 +99,10 @@ export function createPreviewGestureStarts(
|
|
|
99
99
|
const drawPressedBox = (origin: OverlayRect | null): WaitingPressState["draw"] =>
|
|
100
100
|
origin && ((dx, dy) => opts.setOverlayRect(shiftedOverlayRect(origin, dx, dy)));
|
|
101
101
|
|
|
102
|
-
// A corner resize scales about the element's centre by the
|
|
102
|
+
// A corner resize scales about the element's centre by the grabbed corner's distance from it, as the resize does.
|
|
103
103
|
const drawResizedBox = (
|
|
104
104
|
origin: OverlayRect | null,
|
|
105
|
-
|
|
105
|
+
grabbed: { x: number; y: number },
|
|
106
106
|
): WaitingPressState["draw"] => {
|
|
107
107
|
if (!origin) return null;
|
|
108
108
|
const bounds = opts.overlayRef.current?.getBoundingClientRect();
|
|
@@ -111,8 +111,12 @@ export function createPreviewGestureStarts(
|
|
|
111
111
|
y: (bounds?.top ?? 0) + origin.top + origin.height / 2,
|
|
112
112
|
};
|
|
113
113
|
return (dx, dy) => {
|
|
114
|
-
const pointer = { x:
|
|
115
|
-
const scale = resolveCenterResizeScale({
|
|
114
|
+
const pointer = { x: grabbed.x + dx, y: grabbed.y + dy };
|
|
115
|
+
const scale = resolveCenterResizeScale({
|
|
116
|
+
pointer,
|
|
117
|
+
pointerStart: grabbed,
|
|
118
|
+
centerStart: centre,
|
|
119
|
+
});
|
|
116
120
|
const [width, height] = [origin.width * scale, origin.height * scale];
|
|
117
121
|
opts.setOverlayRect({
|
|
118
122
|
...origin,
|
|
@@ -248,6 +252,7 @@ export function createPreviewGestureStarts(
|
|
|
248
252
|
selection?: DomEditSelection;
|
|
249
253
|
rect?: OverlayRect | null;
|
|
250
254
|
resizeHandle?: ResizeHandle;
|
|
255
|
+
resizeCorner?: { x: number; y: number };
|
|
251
256
|
},
|
|
252
257
|
) => {
|
|
253
258
|
// A replay edits what was pressed, though another element may be selected by then.
|
|
@@ -255,7 +260,10 @@ export function createPreviewGestureStarts(
|
|
|
255
260
|
let draw: WaitingPressState["draw"] = null;
|
|
256
261
|
if (kind === "drag") draw = drawPressedBox(opts.overlayRectRef.current);
|
|
257
262
|
if (kind === "resize")
|
|
258
|
-
draw = drawResizedBox(
|
|
263
|
+
draw = drawResizedBox(
|
|
264
|
+
opts.overlayRectRef.current,
|
|
265
|
+
options?.resizeCorner ?? { x: e.clientX, y: e.clientY },
|
|
266
|
+
);
|
|
259
267
|
return startOnShownPreview(
|
|
260
268
|
e,
|
|
261
269
|
() => {
|
|
@@ -272,6 +280,7 @@ export function createPreviewGestureStarts(
|
|
|
272
280
|
selection,
|
|
273
281
|
rect,
|
|
274
282
|
resizeHandle: options?.resizeHandle,
|
|
283
|
+
resizeCorner: options?.resizeCorner,
|
|
275
284
|
at,
|
|
276
285
|
})
|
|
277
286
|
);
|
|
@@ -6,14 +6,15 @@ import {
|
|
|
6
6
|
elementCornerOverlayPoints,
|
|
7
7
|
overlayCornersCentroid,
|
|
8
8
|
} from "./domEditOverlayGeometry";
|
|
9
|
-
import { computeNextResizeAnchor } from "./domEditResizeLocal";
|
|
9
|
+
import { computeNextResizeAnchor, resizeRemainderShift } from "./domEditResizeLocal";
|
|
10
|
+
import type { ResizeDraftSizes } from "./domEditResizeLocal";
|
|
10
11
|
import { applyManualOffsetDragDraft } from "./manualOffsetDrag";
|
|
11
12
|
|
|
12
13
|
type Corners = ReturnType<typeof elementCornerOverlayPoints>;
|
|
13
14
|
|
|
14
15
|
/**
|
|
15
16
|
* The residual center-pin offset for this frame. With measurable corners and a
|
|
16
|
-
* fixed-center start, accumulate `fixedStart - centerNow` onto the previous
|
|
17
|
+
* fixed-center start, accumulate `fixedStart + shift - centerNow` onto the previous
|
|
17
18
|
* anchor so it CONVERGES rather than oscillating: `applyManualOffsetDragDraft`
|
|
18
19
|
* treats its argument as the absolute offset, and `centerNow` (measured on the
|
|
19
20
|
* live element) already carries the previous frame's offset, so the difference
|
|
@@ -25,10 +26,15 @@ function resolveResizeAnchor(
|
|
|
25
26
|
g: GestureState,
|
|
26
27
|
corners: Corners | null,
|
|
27
28
|
measureOrientedRect: () => OverlayRect | null,
|
|
29
|
+
sizes: ResizeDraftSizes,
|
|
28
30
|
): { dx: number; dy: number } {
|
|
29
31
|
const fixedStart = g.resizeFixedCenterStart;
|
|
30
32
|
if (corners && fixedStart) {
|
|
31
|
-
|
|
33
|
+
const press = g.resizePressFromCorner ?? { x: 0, y: 0 };
|
|
34
|
+
const grab = { x: g.startX - press.x - g.centerX, y: g.startY - press.y - g.centerY };
|
|
35
|
+
const shift = resizeRemainderShift(corners, grab, sizes);
|
|
36
|
+
const target = { x: fixedStart.x + shift.x, y: fixedStart.y + shift.y };
|
|
37
|
+
return computeNextResizeAnchor(g.lastResizeAnchor, target, overlayCornersCentroid(corners));
|
|
32
38
|
}
|
|
33
39
|
const fallbackRect = measureOrientedRect();
|
|
34
40
|
return resolveResizeCenterAnchorOffset({
|
|
@@ -52,11 +58,12 @@ function resolveAnchoredResizeDraft(
|
|
|
52
58
|
overlayEl: HTMLDivElement | null,
|
|
53
59
|
iframe: HTMLIFrameElement | null,
|
|
54
60
|
measureOrientedRect: () => OverlayRect | null,
|
|
61
|
+
sizes: ResizeDraftSizes,
|
|
55
62
|
): OverlayRect {
|
|
56
63
|
// Measure real corners ONCE — reused for the anchor and the fallback size.
|
|
57
64
|
const corners =
|
|
58
65
|
overlayEl && iframe ? elementCornerOverlayPoints(overlayEl, iframe, element) : null;
|
|
59
|
-
const anchor = resolveResizeAnchor(g, corners, measureOrientedRect);
|
|
66
|
+
const anchor = resolveResizeAnchor(g, corners, measureOrientedRect, sizes);
|
|
60
67
|
g.lastResizeAnchor = anchor;
|
|
61
68
|
applyManualOffsetDragDraft(member, anchor.dx, anchor.dy);
|
|
62
69
|
// Re-measure AFTER the anchor translate so it hugs the element every frame.
|
|
@@ -80,6 +87,7 @@ export function resolveResizeDraftRect(
|
|
|
80
87
|
overlayEl: HTMLDivElement | null,
|
|
81
88
|
iframe: HTMLIFrameElement | null,
|
|
82
89
|
measureOrientedRect: () => OverlayRect | null,
|
|
90
|
+
sizes: ResizeDraftSizes,
|
|
83
91
|
): OverlayRect {
|
|
84
92
|
if (g.pathOffsetMember) {
|
|
85
93
|
return resolveAnchoredResizeDraft(
|
|
@@ -89,6 +97,7 @@ export function resolveResizeDraftRect(
|
|
|
89
97
|
overlayEl,
|
|
90
98
|
iframe,
|
|
91
99
|
measureOrientedRect,
|
|
100
|
+
sizes,
|
|
92
101
|
);
|
|
93
102
|
}
|
|
94
103
|
// Re-measure the element's oriented box AFTER the size write. The size draft
|
|
@@ -250,14 +250,15 @@ export function createDomEditOverlayGestureHandlers(opts: UseDomEditOverlayGestu
|
|
|
250
250
|
if (g.pathOffsetMember) applyManualOffsetDragDraft(g.pathOffsetMember, dx, dy);
|
|
251
251
|
} else {
|
|
252
252
|
// Corner resize scales proportionally about the center, without edge snapping.
|
|
253
|
+
const grab = g.resizePressFromCorner ?? { x: 0, y: 0 };
|
|
253
254
|
const nextSize = resolveCenterResizeSize({
|
|
254
255
|
baseWidth: g.actualWidth,
|
|
255
256
|
baseHeight: g.actualHeight,
|
|
256
|
-
pointer: { x: e.clientX, y: e.clientY },
|
|
257
|
-
pointerStart: { x: g.startX, y: g.startY },
|
|
257
|
+
pointer: { x: e.clientX - grab.x, y: e.clientY - grab.y },
|
|
258
|
+
pointerStart: { x: g.startX - grab.x, y: g.startY - grab.y },
|
|
258
259
|
centerStart: { x: g.centerX, y: g.centerY },
|
|
259
260
|
});
|
|
260
|
-
applyStudioBoxSizeDraft(sel.element, nextSize);
|
|
261
|
+
const writtenSize = applyStudioBoxSizeDraft(sel.element, nextSize);
|
|
261
262
|
|
|
262
263
|
const overlayEl = opts.overlayRef.current;
|
|
263
264
|
const iframe = opts.iframeRef.current;
|
|
@@ -270,6 +271,7 @@ export function createDomEditOverlayGestureHandlers(opts: UseDomEditOverlayGestu
|
|
|
270
271
|
overlayEl,
|
|
271
272
|
iframe,
|
|
272
273
|
measureOrientedRect,
|
|
274
|
+
{ wanted: nextSize, written: writtenSize },
|
|
273
275
|
);
|
|
274
276
|
logResizeMove({
|
|
275
277
|
pointer: { x: e.clientX, y: e.clientY },
|
|
@@ -0,0 +1,28 @@
|
|
|
1
|
+
export function GpuEncodingToggle({
|
|
2
|
+
format,
|
|
3
|
+
checked,
|
|
4
|
+
disabled,
|
|
5
|
+
onToggle,
|
|
6
|
+
}: {
|
|
7
|
+
format: "mp4" | "webm" | "mov";
|
|
8
|
+
checked: boolean;
|
|
9
|
+
disabled: boolean;
|
|
10
|
+
onToggle: () => void;
|
|
11
|
+
}) {
|
|
12
|
+
// GPU encoders exist for H.264/H.265 only, so only MP4 can use one.
|
|
13
|
+
if (format !== "mp4") return null;
|
|
14
|
+
return (
|
|
15
|
+
<label
|
|
16
|
+
className={`flex items-center gap-2 text-step-10 text-text-4 ${disabled ? "opacity-40 cursor-not-allowed" : "cursor-pointer"}`}
|
|
17
|
+
>
|
|
18
|
+
<input
|
|
19
|
+
type="checkbox"
|
|
20
|
+
checked={checked}
|
|
21
|
+
disabled={disabled}
|
|
22
|
+
onChange={onToggle}
|
|
23
|
+
className="accent-studio-accent"
|
|
24
|
+
/>
|
|
25
|
+
<span>Use GPU encoding</span>
|
|
26
|
+
</label>
|
|
27
|
+
);
|
|
28
|
+
}
|
|
@@ -142,7 +142,7 @@ describe("RenderQueue controls", () => {
|
|
|
142
142
|
exportButtonIn(host).dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
143
143
|
});
|
|
144
144
|
|
|
145
|
-
expect(onStartRender).toHaveBeenCalledWith("mp4", "standard", "landscape-4k", 30);
|
|
145
|
+
expect(onStartRender).toHaveBeenCalledWith("mp4", "standard", "landscape-4k", 30, false);
|
|
146
146
|
});
|
|
147
147
|
|
|
148
148
|
it("refuses a resolution the composition cannot reach, and says why", async () => {
|
|
@@ -172,7 +172,23 @@ describe("RenderQueue controls", () => {
|
|
|
172
172
|
exportButtonIn(host).dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
173
173
|
});
|
|
174
174
|
|
|
175
|
-
expect(onStartRender).toHaveBeenCalledWith("mp4", "standard", "auto", 30);
|
|
175
|
+
expect(onStartRender).toHaveBeenCalledWith("mp4", "standard", "auto", 30, false);
|
|
176
|
+
});
|
|
177
|
+
|
|
178
|
+
it("exports with GPU encoding once the box is ticked, and remembers it", () => {
|
|
179
|
+
const onStartRender: Mock<StartRenderHandler> = vi.fn();
|
|
180
|
+
const host = mountRenderQueue(onStartRender);
|
|
181
|
+
const gpu = [...host.querySelectorAll("label")].find((label) =>
|
|
182
|
+
label.textContent?.includes("Use GPU encoding"),
|
|
183
|
+
);
|
|
184
|
+
|
|
185
|
+
act(() => gpu?.querySelector("input")?.click());
|
|
186
|
+
act(() => {
|
|
187
|
+
exportButtonIn(host).dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
188
|
+
});
|
|
189
|
+
|
|
190
|
+
expect(onStartRender).toHaveBeenCalledWith("mp4", "standard", "auto", 30, true);
|
|
191
|
+
expect(getPersistedRenderSettings().gpu).toBe(true);
|
|
176
192
|
});
|
|
177
193
|
|
|
178
194
|
it("persists a changed format as the literal union value", async () => {
|
|
@@ -185,7 +201,9 @@ describe("RenderQueue controls", () => {
|
|
|
185
201
|
format: "mov",
|
|
186
202
|
quality: "standard",
|
|
187
203
|
fps: 30,
|
|
204
|
+
gpu: false,
|
|
188
205
|
});
|
|
206
|
+
expect(host.textContent).not.toContain("Use GPU encoding");
|
|
189
207
|
});
|
|
190
208
|
});
|
|
191
209
|
|
|
@@ -11,6 +11,7 @@ import { Tooltip } from "../ui/Tooltip";
|
|
|
11
11
|
import { resolveFloatingPanelPosition, type FloatingPosition } from "../editor/floatingPanel";
|
|
12
12
|
import type { RenderJob, ResolutionPreset } from "./useRenderQueue";
|
|
13
13
|
import { getPersistedRenderSettings, persistRenderSettings } from "./renderSettings";
|
|
14
|
+
import { GpuEncodingToggle } from "./GpuEncodingToggle";
|
|
14
15
|
import { trackStudioEvent } from "../../utils/studioTelemetry";
|
|
15
16
|
|
|
16
17
|
export interface CompositionDimensions {
|
|
@@ -23,6 +24,7 @@ export type StartRenderHandler = (
|
|
|
23
24
|
quality: "draft" | "standard" | "high",
|
|
24
25
|
resolution: ResolutionPreset | "auto",
|
|
25
26
|
fps: 24 | 30 | 60,
|
|
27
|
+
gpu?: boolean,
|
|
26
28
|
) => void | Promise<void>;
|
|
27
29
|
|
|
28
30
|
export interface RenderQueueProps {
|
|
@@ -303,6 +305,7 @@ function FormatExportButton({
|
|
|
303
305
|
const [quality, setQuality] = useState<"draft" | "standard" | "high">(persisted.quality);
|
|
304
306
|
const [resolution, setResolution] = useState<RenderScale>("auto");
|
|
305
307
|
const [fps, setFps] = useState<24 | 30 | 60>(persisted.fps);
|
|
308
|
+
const [gpu, setGpu] = useState(persisted.gpu);
|
|
306
309
|
|
|
307
310
|
// Only a definite "not installed" blocks Export. A null status means the
|
|
308
311
|
// probe gave no answer, and refusing to export on no answer would break
|
|
@@ -385,6 +388,15 @@ function FormatExportButton({
|
|
|
385
388
|
</div>
|
|
386
389
|
)}
|
|
387
390
|
</div>
|
|
391
|
+
<GpuEncodingToggle
|
|
392
|
+
format={format}
|
|
393
|
+
checked={gpu}
|
|
394
|
+
disabled={isRendering}
|
|
395
|
+
onToggle={() => {
|
|
396
|
+
setGpu(!gpu);
|
|
397
|
+
persistRenderSettings(format, quality, fps, !gpu);
|
|
398
|
+
}}
|
|
399
|
+
/>
|
|
388
400
|
<Button
|
|
389
401
|
variant="primary"
|
|
390
402
|
size="md"
|
|
@@ -398,7 +410,7 @@ function FormatExportButton({
|
|
|
398
410
|
if (isRendering || missingFfmpeg) return;
|
|
399
411
|
const outputResolution = resolveResolution(resolution, compositionDimensions);
|
|
400
412
|
trackStudioEvent("render_start", { format, quality, resolution: outputResolution, fps });
|
|
401
|
-
void onStartRender(format, quality, outputResolution, fps);
|
|
413
|
+
void onStartRender(format, quality, outputResolution, fps, gpu);
|
|
402
414
|
}}
|
|
403
415
|
// Width only. A type size or a weight here would win the merge against
|
|
404
416
|
// the size recipe and leave this Export a step away from the header's
|
|
@@ -29,7 +29,7 @@ export const RenderQueuePanel = memo(function RenderQueuePanel() {
|
|
|
29
29
|
ffmpeg={renderQueue.ffmpeg}
|
|
30
30
|
ffmpegChecking={renderQueue.ffmpegChecking}
|
|
31
31
|
onRecheckFfmpeg={renderQueue.recheckFfmpeg}
|
|
32
|
-
onStartRender={async (format, quality, resolution, fps) => {
|
|
32
|
+
onStartRender={async (format, quality, resolution, fps, gpu) => {
|
|
33
33
|
await waitForPendingDomEditSaves();
|
|
34
34
|
// No `composition`: startRender targets the active one by default.
|
|
35
35
|
await renderQueue.startRender({
|
|
@@ -37,6 +37,7 @@ export const RenderQueuePanel = memo(function RenderQueuePanel() {
|
|
|
37
37
|
quality,
|
|
38
38
|
format,
|
|
39
39
|
resolution,
|
|
40
|
+
gpu,
|
|
40
41
|
// Render what the user is previewing: active variable overrides
|
|
41
42
|
// from the Variables panel ride along (undefined = defaults).
|
|
42
43
|
variables: usePreviewVariablesStore.getState().values ?? undefined,
|
|
@@ -4,6 +4,7 @@ export interface PersistedRenderSettings {
|
|
|
4
4
|
format: "mp4" | "webm" | "mov";
|
|
5
5
|
quality: "draft" | "standard" | "high";
|
|
6
6
|
fps: 24 | 30 | 60;
|
|
7
|
+
gpu: boolean;
|
|
7
8
|
}
|
|
8
9
|
|
|
9
10
|
export function getPersistedRenderSettings(): PersistedRenderSettings {
|
|
@@ -17,21 +18,23 @@ export function getPersistedRenderSettings(): PersistedRenderSettings {
|
|
|
17
18
|
? parsed.quality
|
|
18
19
|
: "standard",
|
|
19
20
|
fps: [24, 30, 60].includes(parsed.fps) ? parsed.fps : 30,
|
|
21
|
+
gpu: parsed.gpu === true,
|
|
20
22
|
};
|
|
21
23
|
}
|
|
22
24
|
} catch {
|
|
23
25
|
/* ignore */
|
|
24
26
|
}
|
|
25
|
-
return { format: "mp4", quality: "standard", fps: 30 };
|
|
27
|
+
return { format: "mp4", quality: "standard", fps: 30, gpu: false };
|
|
26
28
|
}
|
|
27
29
|
|
|
28
30
|
export function persistRenderSettings(
|
|
29
31
|
format: PersistedRenderSettings["format"],
|
|
30
32
|
quality: PersistedRenderSettings["quality"],
|
|
31
33
|
fps: PersistedRenderSettings["fps"],
|
|
34
|
+
gpu: boolean = getPersistedRenderSettings().gpu,
|
|
32
35
|
): void {
|
|
33
36
|
try {
|
|
34
|
-
localStorage.setItem(RENDER_SETTINGS_KEY, JSON.stringify({ format, quality, fps }));
|
|
37
|
+
localStorage.setItem(RENDER_SETTINGS_KEY, JSON.stringify({ format, quality, fps, gpu }));
|
|
35
38
|
} catch {
|
|
36
39
|
/* ignore */
|
|
37
40
|
}
|
|
@@ -32,6 +32,7 @@ export interface StartRenderOptions {
|
|
|
32
32
|
format?: "mp4" | "webm" | "mov";
|
|
33
33
|
/** `"auto"` (default) renders at the composition's authored dimensions. */
|
|
34
34
|
resolution?: ResolutionPreset | "auto";
|
|
35
|
+
gpu?: boolean;
|
|
35
36
|
/**
|
|
36
37
|
* Render a specific composition file. Omit it to render the composition the
|
|
37
38
|
* user currently has open — only the sidebar's per-composition Render button
|
|
@@ -234,6 +235,7 @@ export function useRenderQueue(
|
|
|
234
235
|
resolution?: string;
|
|
235
236
|
composition?: string;
|
|
236
237
|
variables?: Record<string, unknown>;
|
|
238
|
+
gpu?: boolean;
|
|
237
239
|
telemetryDistinctId?: string;
|
|
238
240
|
telemetryOptOut?: boolean;
|
|
239
241
|
} = {
|
|
@@ -258,6 +260,7 @@ export function useRenderQueue(
|
|
|
258
260
|
}
|
|
259
261
|
if (resolution && resolution !== "auto") body.resolution = resolution;
|
|
260
262
|
if (composition) body.composition = composition;
|
|
263
|
+
if (opts.gpu) body.gpu = true;
|
|
261
264
|
if (opts.variables && Object.keys(opts.variables).length > 0) {
|
|
262
265
|
body.variables = opts.variables;
|
|
263
266
|
}
|
|
@@ -53,3 +53,15 @@ describe("render target composition", () => {
|
|
|
53
53
|
expect(body["composition"]).toBeUndefined();
|
|
54
54
|
});
|
|
55
55
|
});
|
|
56
|
+
|
|
57
|
+
describe("GPU encoding", () => {
|
|
58
|
+
it("asks the server for GPU encoding when the export asks for it", async () => {
|
|
59
|
+
const body = await renderBody(null, { format: "mp4", gpu: true });
|
|
60
|
+
expect(body["gpu"]).toBe(true);
|
|
61
|
+
});
|
|
62
|
+
|
|
63
|
+
it("leaves GPU encoding off by default", async () => {
|
|
64
|
+
const body = await renderBody(null, { format: "mp4" });
|
|
65
|
+
expect(body["gpu"]).toBeUndefined();
|
|
66
|
+
});
|
|
67
|
+
});
|
|
@@ -48,6 +48,13 @@ function clickWithMouse(target: Element): void {
|
|
|
48
48
|
});
|
|
49
49
|
}
|
|
50
50
|
|
|
51
|
+
function rightClick(target: Element): void {
|
|
52
|
+
const init = { bubbles: true, cancelable: true, composed: true };
|
|
53
|
+
act(() => {
|
|
54
|
+
target.dispatchEvent(new MouseEvent("contextmenu", init));
|
|
55
|
+
});
|
|
56
|
+
}
|
|
57
|
+
|
|
51
58
|
function key(k: string, target: Element | null = document.activeElement): void {
|
|
52
59
|
const init = { key: k, bubbles: true, cancelable: true, composed: true };
|
|
53
60
|
act(() => {
|
|
@@ -241,11 +248,7 @@ describe("ContextMenu", () => {
|
|
|
241
248
|
expect(trigger().textContent).toBe("clip");
|
|
242
249
|
expect(popup()).toBeNull();
|
|
243
250
|
|
|
244
|
-
|
|
245
|
-
trigger().dispatchEvent(
|
|
246
|
-
new MouseEvent("contextmenu", { bubbles: true, cancelable: true, composed: true }),
|
|
247
|
-
);
|
|
248
|
-
});
|
|
251
|
+
rightClick(trigger());
|
|
249
252
|
await settle();
|
|
250
253
|
expect(popup()).not.toBeNull();
|
|
251
254
|
|
|
@@ -257,6 +260,65 @@ describe("ContextMenu", () => {
|
|
|
257
260
|
});
|
|
258
261
|
});
|
|
259
262
|
|
|
263
|
+
describe("container={null}", () => {
|
|
264
|
+
/** Rendered inline means inside the trigger's own parent, not a portal on the body. */
|
|
265
|
+
function expectInlineBeside(menu: HTMLElement | null): void {
|
|
266
|
+
expect(menu).not.toBeNull();
|
|
267
|
+
expect(trigger().parentElement?.contains(menu)).toBe(true);
|
|
268
|
+
}
|
|
269
|
+
|
|
270
|
+
it("opens a Menu inline, next to its trigger, and closes on Escape", async () => {
|
|
271
|
+
render(
|
|
272
|
+
<div>
|
|
273
|
+
<Menu container={null} trigger={<button data-testid="trigger">Actions</button>}>
|
|
274
|
+
<MenuItem>Bring to front</MenuItem>
|
|
275
|
+
</Menu>
|
|
276
|
+
</div>,
|
|
277
|
+
);
|
|
278
|
+
clickWithMouse(trigger());
|
|
279
|
+
await settle();
|
|
280
|
+
expectInlineBeside(popup());
|
|
281
|
+
|
|
282
|
+
key("Escape");
|
|
283
|
+
await settle();
|
|
284
|
+
expect(popup()).toBeNull();
|
|
285
|
+
});
|
|
286
|
+
|
|
287
|
+
it("opens a ContextMenu inline, next to its area", async () => {
|
|
288
|
+
render(
|
|
289
|
+
<div>
|
|
290
|
+
<ContextMenu container={null} trigger={<div data-testid="trigger">clip</div>}>
|
|
291
|
+
<MenuItem>Split</MenuItem>
|
|
292
|
+
</ContextMenu>
|
|
293
|
+
</div>,
|
|
294
|
+
);
|
|
295
|
+
rightClick(trigger());
|
|
296
|
+
await settle();
|
|
297
|
+
expectInlineBeside(popup());
|
|
298
|
+
});
|
|
299
|
+
|
|
300
|
+
it("opens a Popover inline on its first render", async () => {
|
|
301
|
+
render(
|
|
302
|
+
<div>
|
|
303
|
+
<Popover
|
|
304
|
+
container={null}
|
|
305
|
+
defaultOpen
|
|
306
|
+
trigger={<button data-testid="trigger">Speed</button>}
|
|
307
|
+
>
|
|
308
|
+
<span>1x</span>
|
|
309
|
+
</Popover>
|
|
310
|
+
</div>,
|
|
311
|
+
);
|
|
312
|
+
await settle();
|
|
313
|
+
expectInlineBeside(document.querySelector<HTMLElement>("[role=dialog]"));
|
|
314
|
+
});
|
|
315
|
+
|
|
316
|
+
it("still portals to the body when no container is passed", async () => {
|
|
317
|
+
await openActionMenu();
|
|
318
|
+
expect(trigger().parentElement?.contains(popup())).toBe(false);
|
|
319
|
+
});
|
|
320
|
+
});
|
|
321
|
+
|
|
260
322
|
describe("Popover", () => {
|
|
261
323
|
it("leaves the keys of a text field inside it alone", async () => {
|
|
262
324
|
// The Menu owns ArrowDown and typeahead; a Popover must not, or the rename
|
|
@@ -5,6 +5,7 @@
|
|
|
5
5
|
|
|
6
6
|
import { ContextMenu as BaseContextMenu } from "@base-ui/react/context-menu";
|
|
7
7
|
import { Menu as BaseMenu } from "@base-ui/react/menu";
|
|
8
|
+
import { useRef } from "react";
|
|
8
9
|
import type { ComponentPropsWithoutRef, ElementType, ReactElement, ReactNode } from "react";
|
|
9
10
|
import { cn } from "./cn";
|
|
10
11
|
|
|
@@ -20,7 +21,19 @@ type StyledProps<T extends ElementType> = Omit<ComponentPropsWithoutRef<T>, "cla
|
|
|
20
21
|
export type PopupPreviewState = "open";
|
|
21
22
|
|
|
22
23
|
/** Where the portal puts the popup. `null` keeps it inline, next to its trigger. */
|
|
23
|
-
type PortalContainer = ComponentPropsWithoutRef<typeof BaseMenu.Portal>["container"];
|
|
24
|
+
export type PortalContainer = ComponentPropsWithoutRef<typeof BaseMenu.Portal>["container"];
|
|
25
|
+
|
|
26
|
+
const CONTENTS = { display: "contents" } as const;
|
|
27
|
+
|
|
28
|
+
/** Base UI reads a `null` container as "not resolved yet" and renders nothing, so give `null` a host by the trigger. */
|
|
29
|
+
export function useInlinePortal(container: PortalContainer) {
|
|
30
|
+
const host = useRef<HTMLSpanElement>(null);
|
|
31
|
+
if (container !== null) return { host: null, portal: { container } };
|
|
32
|
+
return {
|
|
33
|
+
host: <span ref={host} style={CONTENTS} />,
|
|
34
|
+
portal: { container: host, style: CONTENTS },
|
|
35
|
+
};
|
|
36
|
+
}
|
|
24
37
|
|
|
25
38
|
/** Matches Tooltip's gap from its trigger, and its viewport margin. */
|
|
26
39
|
const SIDE_OFFSET = 6;
|
|
@@ -77,7 +90,7 @@ interface PositionedProps {
|
|
|
77
90
|
side?: "top" | "bottom" | "left" | "right";
|
|
78
91
|
align?: "start" | "center" | "end";
|
|
79
92
|
sideOffset?: number;
|
|
80
|
-
/** Portal target. Pass the shadow root when the trigger lives in one. */
|
|
93
|
+
/** Portal target. Pass the shadow root when the trigger lives in one; `null` keeps it inline. */
|
|
81
94
|
container?: PortalContainer;
|
|
82
95
|
/** Names the popup for assistive tech. A menu with no name is unlabelled. */
|
|
83
96
|
"aria-label"?: string;
|
|
@@ -109,10 +122,12 @@ export function Menu({
|
|
|
109
122
|
"data-preview-state": previewState,
|
|
110
123
|
...root
|
|
111
124
|
}: MenuProps) {
|
|
125
|
+
const inline = useInlinePortal(container);
|
|
112
126
|
return (
|
|
113
127
|
<BaseMenu.Root {...root}>
|
|
114
128
|
<BaseMenu.Trigger render={trigger} />
|
|
115
|
-
|
|
129
|
+
{inline.host}
|
|
130
|
+
<BaseMenu.Portal {...inline.portal}>
|
|
116
131
|
<BaseMenu.Positioner
|
|
117
132
|
side={side}
|
|
118
133
|
align={align}
|
|
@@ -153,10 +168,12 @@ export function ContextMenu({
|
|
|
153
168
|
"data-preview-state": previewState,
|
|
154
169
|
...root
|
|
155
170
|
}: Omit<ContextMenuProps, "side" | "align" | "sideOffset">) {
|
|
171
|
+
const inline = useInlinePortal(container);
|
|
156
172
|
return (
|
|
157
173
|
<BaseContextMenu.Root {...root}>
|
|
158
174
|
<BaseContextMenu.Trigger render={trigger} />
|
|
159
|
-
|
|
175
|
+
{inline.host}
|
|
176
|
+
<BaseContextMenu.Portal {...inline.portal}>
|
|
160
177
|
<BaseContextMenu.Positioner collisionPadding={VIEWPORT_MARGIN} className={POPUP_LAYER}>
|
|
161
178
|
<BaseContextMenu.Popup
|
|
162
179
|
aria-label={ariaLabel}
|
|
@@ -6,9 +6,13 @@
|
|
|
6
6
|
import { Popover as BasePopover } from "@base-ui/react/popover";
|
|
7
7
|
import type { ComponentPropsWithoutRef, ReactElement, ReactNode } from "react";
|
|
8
8
|
import { cn } from "./cn";
|
|
9
|
-
import {
|
|
10
|
-
|
|
11
|
-
|
|
9
|
+
import {
|
|
10
|
+
POPUP_LAYER,
|
|
11
|
+
popupSurface,
|
|
12
|
+
useInlinePortal,
|
|
13
|
+
type PopupPreviewState,
|
|
14
|
+
type PortalContainer,
|
|
15
|
+
} from "./Menu";
|
|
12
16
|
|
|
13
17
|
/** Matches Menu's gap from its trigger, and its viewport margin. */
|
|
14
18
|
const SIDE_OFFSET = 6;
|
|
@@ -33,7 +37,7 @@ interface PopoverProps extends Omit<ComponentPropsWithoutRef<typeof BasePopover.
|
|
|
33
37
|
sideOffset?: number;
|
|
34
38
|
/** Points the popup at its trigger. Off by default; the default gap from the trigger grows by the arrow's height. */
|
|
35
39
|
arrow?: boolean;
|
|
36
|
-
/** Portal target. Pass the shadow root when the trigger lives in one. */
|
|
40
|
+
/** Portal target. Pass the shadow root when the trigger lives in one; `null` keeps it inline. */
|
|
37
41
|
container?: PortalContainer;
|
|
38
42
|
/** Names the popup for assistive tech. */
|
|
39
43
|
"aria-label"?: string;
|
|
@@ -60,10 +64,12 @@ export function Popover({
|
|
|
60
64
|
"data-preview-state": previewState,
|
|
61
65
|
...root
|
|
62
66
|
}: PopoverProps) {
|
|
67
|
+
const inline = useInlinePortal(container);
|
|
63
68
|
return (
|
|
64
69
|
<BasePopover.Root {...root}>
|
|
65
70
|
<BasePopover.Trigger render={trigger} />
|
|
66
|
-
|
|
71
|
+
{inline.host}
|
|
72
|
+
<BasePopover.Portal {...inline.portal}>
|
|
67
73
|
<BasePopover.Positioner
|
|
68
74
|
side={side}
|
|
69
75
|
align={align}
|