@hyperframes/studio 0.8.105 → 0.8.106

package/src/utils/typingTarget.test.ts

@@ -1,7 +1,7 @@
 // @vitest-environment happy-dom
 
 import { afterEach, describe, expect, it } from "vitest";
-import { isTypingTarget } from "./typingTarget";
+import { isTypingTarget, ownsPlainKeys } from "./typingTarget";
 import { isEditableTarget } from "./timelineDiscovery";
 
 afterEach(() => {
@@ -41,6 +41,13 @@ describe("isTypingTarget", () => {
     expect(isTypingTarget(mount('<div role="combobox"></div>'))).toBe(true);
   });
 
+  it("gives a focused slider its plain keys but leaves Cmd shortcuts to the app", () => {
+    const slider = mount('<div role="slider" tabindex="0"></div>');
+    expect(ownsPlainKeys(slider)).toBe(true);
+    // Undo, copy and group still reach the app while a slider has focus.
+    expect(isTypingTarget(slider)).toBe(false);
+  });
+
   it("leaves the keys alone for anything that is not being typed into", () => {
     expect(isTypingTarget(mount("<div>plain</div>"))).toBe(false);
     expect(isTypingTarget(mount("<button>press</button>"))).toBe(false);

package/src/utils/typingTarget.ts

@@ -21,6 +21,11 @@ export function isTypingTarget(target: EventTarget | null): boolean {
   return element.closest(TYPING_SELECTOR) !== null;
 }
 
+/** Plain keys (arrows, Delete) also belong to a focused slider; Cmd shortcuts still do not. */
+export function ownsPlainKeys(target: EventTarget | null): boolean {
+  return isTypingTarget(target) || asElement(target)?.closest("[role='slider']") != null;
+}
+
 /**
  * Things a keystroke belongs to rather than to a shortcut. `contenteditable` is
  * matched by value as well, for a host whose own property is not yet true.