@hyperframes/lint 0.8.75 → 0.8.76

package/dist/index.js

@@ -2469,6 +2469,81 @@ function collectDeclaredVariableIds(htmlTagRaw) {
   }
   return declared;
 }
+function variablesDeclarationFindings(tag, tags) {
+  const raw = readJsonAttr(tag.raw, "data-composition-variables");
+  if (!raw) return [];
+  let parsed;
+  try {
+    parsed = JSON.parse(raw);
+  } catch (err) {
+    const reason = err instanceof Error ? err.message : "unknown";
+    return [
+      {
+        code: "invalid_composition_variables_declaration",
+        severity: "error",
+        message: `data-composition-variables is not valid JSON (${reason}).`,
+        fixHint: `Provide a JSON array of variable declarations: data-composition-variables='[{"id":"title","type":"string","label":"Title","default":"Hello"}]'.`,
+        snippet: truncateSnippet(tag.raw)
+      }
+    ];
+  }
+  if (!Array.isArray(parsed)) {
+    return [
+      {
+        code: "invalid_composition_variables_declaration",
+        severity: "error",
+        message: "data-composition-variables must be a JSON array of variable declarations.",
+        fixHint: `Wrap declarations in [] and give each an id, type, label, and default: '[{"id":"title","type":"string","label":"Title","default":"Hello"}]'.`,
+        snippet: truncateSnippet(tag.raw)
+      }
+    ];
+  }
+  const findings = [];
+  const knownTypes = new Set(COMPOSITION_VARIABLE_TYPES);
+  const varSrcIds = /* @__PURE__ */ new Set();
+  for (const other of tags) {
+    const bound = readAttr(other.raw, "data-var-src");
+    if (bound) varSrcIds.add(bound);
+  }
+  for (let i = 0; i < parsed.length; i += 1) {
+    const entry = parsed[i];
+    if (!entry || typeof entry !== "object" || Array.isArray(entry)) {
+      findings.push({
+        code: "invalid_composition_variables_declaration",
+        severity: "error",
+        message: `data-composition-variables entry [${i}] must be an object with id, type, label, and default.`,
+        snippet: truncateSnippet(tag.raw)
+      });
+      continue;
+    }
+    const e = entry;
+    const missing = [];
+    if (typeof e.id !== "string") missing.push("id");
+    if (typeof e.type !== "string" || !knownTypes.has(e.type)) missing.push("type");
+    if (typeof e.label !== "string") missing.push("label");
+    if (!("default" in e)) missing.push("default");
+    if (missing.length > 0) {
+      findings.push({
+        code: "invalid_composition_variables_declaration",
+        severity: "error",
+        message: `data-composition-variables entry [${i}] is missing or has invalid: ${missing.join(", ")}. Type must be one of string, number, color, boolean, enum, font, image.`,
+        snippet: truncateSnippet(tag.raw)
+      });
+      continue;
+    }
+    const id = String(e.id);
+    if ((e.type === "image" || varSrcIds.has(id)) && typeof e.default === "string" && e.default.length > 0 && !isSafeMediaUrl(e.default)) {
+      findings.push({
+        code: "unloadable_media_variable_default",
+        severity: "error",
+        message: `Variable "${id}" defaults to a URL the runtime will refuse to load, so any element bound to it renders its authored fallback src instead and the render still exits 0.`,
+        fixHint: `Media URLs must be relative, http(s), blob:, or a data:image/* URI. Copy the file into the project and reference it relatively (e.g. "assets/bg.png") rather than by absolute path.`,
+        snippet: truncateSnippet(tag.raw)
+      });
+    }
+  }
+  return findings;
+}
 function collectAllDeclaredVariableIds(tags) {
   const all = /* @__PURE__ */ new Set();
   for (const tag of tags) {
@@ -2944,84 +3019,8 @@ var compositionRules = [
   // on any structural problem. Surface JSON / shape failures so authors
   // catch them at lint time rather than wondering why their `getVariables()`
   // defaults aren't applied.
-  // fallow-ignore-next-line complexity
-  ({ tags }) => {
-    const htmlTag = findHtmlTag(tags);
-    if (!htmlTag) return [];
-    const raw = readJsonAttr(htmlTag.raw, "data-composition-variables");
-    if (!raw) return [];
-    let parsed;
-    try {
-      parsed = JSON.parse(raw);
-    } catch (err) {
-      const reason = err instanceof Error ? err.message : "unknown";
-      return [
-        {
-          code: "invalid_composition_variables_declaration",
-          severity: "error",
-          message: `data-composition-variables is not valid JSON (${reason}).`,
-          fixHint: `Provide a JSON array of variable declarations: data-composition-variables='[{"id":"title","type":"string","label":"Title","default":"Hello"}]'.`,
-          snippet: truncateSnippet(htmlTag.raw)
-        }
-      ];
-    }
-    if (!Array.isArray(parsed)) {
-      return [
-        {
-          code: "invalid_composition_variables_declaration",
-          severity: "error",
-          message: "data-composition-variables must be a JSON array of variable declarations.",
-          fixHint: `Wrap declarations in [] and give each an id, type, label, and default: '[{"id":"title","type":"string","label":"Title","default":"Hello"}]'.`,
-          snippet: truncateSnippet(htmlTag.raw)
-        }
-      ];
-    }
-    const findings = [];
-    const knownTypes = new Set(COMPOSITION_VARIABLE_TYPES);
-    const varSrcIds = /* @__PURE__ */ new Set();
-    for (const tag of tags) {
-      const bound = readAttr(tag.raw, "data-var-src");
-      if (bound) varSrcIds.add(bound);
-    }
-    for (let i = 0; i < parsed.length; i += 1) {
-      const entry = parsed[i];
-      if (!entry || typeof entry !== "object" || Array.isArray(entry)) {
-        findings.push({
-          code: "invalid_composition_variables_declaration",
-          severity: "error",
-          message: `data-composition-variables entry [${i}] must be an object with id, type, label, and default.`,
-          snippet: truncateSnippet(htmlTag.raw)
-        });
-        continue;
-      }
-      const e = entry;
-      const missing = [];
-      if (typeof e.id !== "string") missing.push("id");
-      if (typeof e.type !== "string" || !knownTypes.has(e.type)) missing.push("type");
-      if (typeof e.label !== "string") missing.push("label");
-      if (!("default" in e)) missing.push("default");
-      if (missing.length > 0) {
-        findings.push({
-          code: "invalid_composition_variables_declaration",
-          severity: "error",
-          message: `data-composition-variables entry [${i}] is missing or has invalid: ${missing.join(", ")}. Type must be one of string, number, color, boolean, enum, font, image.`,
-          snippet: truncateSnippet(htmlTag.raw)
-        });
-        continue;
-      }
-      const id = String(e.id);
-      if ((e.type === "image" || varSrcIds.has(id)) && typeof e.default === "string" && e.default.length > 0 && !isSafeMediaUrl(e.default)) {
-        findings.push({
-          code: "unloadable_media_variable_default",
-          severity: "error",
-          message: `Variable "${id}" defaults to a URL the runtime will refuse to load, so any element bound to it renders its authored fallback src instead and the render still exits 0.`,
-          fixHint: `Media URLs must be relative, http(s), blob:, or a data:image/* URI. Copy the file into the project and reference it relatively (e.g. "assets/bg.png") rather than by absolute path.`,
-          snippet: truncateSnippet(htmlTag.raw)
-        });
-      }
-    }
-    return findings;
-  },
+  // Checked on every element that declares: <html>, or the composition root.
+  ({ tags }) => tags.filter((tag) => readJsonAttr(tag.raw, "data-composition-variables")).flatMap((tag) => variablesDeclarationFindings(tag, tags)),
   // html_dir_attribute_breaks_render — valid non-LTR dir values on
   // <html> renders correctly in preview/snapshot but produces a fully
   // blank/black video from render, with no other lint/validate/inspect