@hyperframes/lint 0.8.2 → 0.8.4

package/dist/browser.js

@@ -1402,8 +1402,29 @@ var mediaRules = [
   // imperative_media_control
   findImperativeMediaControlFindings,
   // audio_volume_double_automation
-  findVolumeDoubleAutomationFindings
+  findVolumeDoubleAutomationFindings,
+  // audio_volume_tween_overrides_gain
+  findVolumeTweenOverridesGainFindings
 ];
+function findVolumeTweenOverridesGainFindings(ctx) {
+  const boosted = ctx.tags.filter((tag) => isMediaTag(tag.name)).map((tag) => ({ tag, volume: Number(readAttr(tag.raw, "data-volume") ?? "1") })).filter((entry) => Number.isFinite(entry.volume) && entry.volume !== 1).filter((entry) => !readDecodedAttr(entry.tag.raw, "data-automation")).map((entry) => ({ ...entry, id: readAttr(entry.tag.raw, "id") })).filter((entry) => Boolean(entry.id));
+  if (boosted.length === 0) return [];
+  const script = ctx.scripts.map((block) => stripJsComments(block.content)).join("\n");
+  const findings = [];
+  for (const { tag, id, volume } of boosted) {
+    if (!tweensVolumeInSameCall(script, id)) continue;
+    const db = volume > 0 ? `${(20 * Math.log10(volume)).toFixed(1)} dB` : "silence";
+    findings.push({
+      code: "audio_volume_tween_overrides_gain",
+      severity: "warning",
+      message: `#${id} has data-volume="${volume}" (${db}) and a GSAP tween on \`volume\`. Tween values are absolute \u2014 they REPLACE this gain rather than scale it \u2014 so wherever the tween names a value the clip plays at that value, not at ${db}.`,
+      elementId: id,
+      fixHint: "Write the tween's targets in the same absolute gain (e.g. `volume: 1.95`, not `volume: 1`), or reset data-volume to 1 and let the tween carry the level on its own.",
+      snippet: truncateSnippet(tag.raw)
+    });
+  }
+  return findings;
+}
 function findVolumeDoubleAutomationFindings(ctx) {
   const automated = ctx.tags.filter((tag) => isMediaTag(tag.name)).map((tag) => ({ tag, automation: readDecodedAttr(tag.raw, "data-automation") })).filter((entry) => entry.automation && /"target"\s*:\s*"volume"/.test(entry.automation)).map((entry) => ({ ...entry, id: readAttr(entry.tag.raw, "id") })).filter((entry) => Boolean(entry.id));
   if (automated.length === 0) return [];