@hyperframes/lint 0.8.142 → 0.8.143

package/dist/index.js

@@ -108,10 +108,7 @@ function hasUnquotedLessThan(attrs) {
   return false;
 }
 function readAttr(tagSource, attr) {
-  if (!tagSource) return null;
-  const escaped = attr.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-  const match = tagSource.match(new RegExp(`(?<![\\w-])${escaped}\\s*=\\s*["']([^"']+)["']`, "i"));
-  return match?.[1] || null;
+  return readAttributeValue(tagSource, attr, false) || null;
 }
 function hasAttrName(tagSource, attr) {
   return readDecodedAttr(tagSource, attr) !== null;
@@ -134,15 +131,18 @@ function mediaWindowsOverlap(a, b) {
   return a.start < b.end && b.start < a.end;
 }
 function readDecodedAttr(tagSource, attr) {
+  return readAttributeValue(tagSource, attr, true);
+}
+function readAttributeValue(tagSource, attr, decodeEntities) {
   if (!tagSource) return null;
   let value = null;
   const parser = new Parser(
     {
-      onattribute(name, decodedValue) {
-        if (value === null && name.toLowerCase() === attr.toLowerCase()) value = decodedValue;
+      onattribute(name, attributeValue) {
+        if (value === null && name.toLowerCase() === attr.toLowerCase()) value = attributeValue;
       }
     },
-    { decodeEntities: true, lowerCaseAttributeNames: false, lowerCaseTags: true }
+    { decodeEntities, lowerCaseAttributeNames: false, lowerCaseTags: true }
   );
   parser.end(tagSource);
   return value;
@@ -748,6 +748,12 @@ import {
   HTML_BODY_CSS_HEIGHT_FIRST_RE,
   VIEWPORT_META_SIZE_RE
 } from "@hyperframes/parsers/composition";
+var SCRIPT_SYNTAX_EXEMPT_TYPES = /* @__PURE__ */ new Set([
+  "application/json",
+  "application/hyperframes-slideshow+json",
+  "importmap",
+  "module"
+]);
 function repeatedDescendantId(selector) {
   let repeated = null;
   const requiredPseudoIds = (pseudo) => {
@@ -1366,10 +1372,8 @@ var coreRules = [
   ({ scripts, locate }) => {
     const findings = [];
     for (const script of scripts) {
-      const attrs = script.attrs || "";
-      if (/\bsrc\s*=/.test(attrs) || /\btype\s*=\s*["'](?:application\/json|application\/hyperframes-slideshow\+json|importmap|module)["']/.test(
-        attrs
-      ))
+      const type = readDecodedAttr(script.raw, "type")?.trim().toLowerCase() ?? "";
+      if (readDecodedAttr(script.raw, "src") !== null || SCRIPT_SYNTAX_EXEMPT_TYPES.has(type))
         continue;
       const syntaxError = getInlineScriptSyntaxError(script.content);
       if (!syntaxError) continue;
@@ -1786,6 +1790,7 @@ function findImperativeMediaControlFindings(ctx) {
   };
   if (mediaTags.length === 0 || ctx.scripts.length === 0) return findings;
   for (const script of ctx.scripts) {
+    const code = stripJsCode(script.content);
     const mediaVars = /* @__PURE__ */ new Map();
     const assignmentPatterns = [
       {
@@ -1802,6 +1807,7 @@ function findImperativeMediaControlFindings(ctx) {
     for (const { pattern, variableIndex, targetIndex } of assignmentPatterns) {
       let match;
       while ((match = pattern.exec(script.content)) !== null) {
+        if (code[match.index] !== script.content[match.index]) continue;
         const variableName = match[variableIndex];
         const target = match[targetIndex];
         if (!variableName || !target) continue;
@@ -1812,12 +1818,12 @@ function findImperativeMediaControlFindings(ctx) {
     }
     const directIdPatterns = [
       {
-        pattern: /\b(?:document|window\.document)\.getElementById\(\s*["']([^"']+)["']\s*\)\.play\s*\(/g,
+        pattern: /\b(?:document|window\.document)\.getElementById\(\s*["']([^"']+)["']\s*\)\s*(?:\?\.|\.)\s*play\s*(?:\?\.\s*)?\(/g,
         kind: "play()",
         targetIndex: 1
       },
       {
-        pattern: /\b(?:document|window\.document)\.getElementById\(\s*["']([^"']+)["']\s*\)\.pause\s*\(/g,
+        pattern: /\b(?:document|window\.document)\.getElementById\(\s*["']([^"']+)["']\s*\)\s*(?:\?\.|\.)\s*pause\s*(?:\?\.\s*)?\(/g,
         kind: "pause()",
         targetIndex: 1
       },
@@ -1832,12 +1838,12 @@ function findImperativeMediaControlFindings(ctx) {
         targetIndex: 1
       },
       {
-        pattern: /\b(?:document|window\.document)\.querySelector\(\s*(["'])([\s\S]*?)\1\s*\)\.play\s*\(/g,
+        pattern: /\b(?:document|window\.document)\.querySelector\(\s*(["'])([\s\S]*?)\1\s*\)\s*(?:\?\.|\.)\s*play\s*(?:\?\.\s*)?\(/g,
         kind: "play()",
         targetIndex: 2
       },
       {
-        pattern: /\b(?:document|window\.document)\.querySelector\(\s*(["'])([\s\S]*?)\1\s*\)\.pause\s*\(/g,
+        pattern: /\b(?:document|window\.document)\.querySelector\(\s*(["'])([\s\S]*?)\1\s*\)\s*(?:\?\.|\.)\s*pause\s*(?:\?\.\s*)?\(/g,
         kind: "pause()",
         targetIndex: 2
       },
@@ -1855,6 +1861,7 @@ function findImperativeMediaControlFindings(ctx) {
     for (const { pattern, kind, targetIndex } of directIdPatterns) {
       let match;
       while ((match = pattern.exec(script.content)) !== null) {
+        if (code[match.index] !== script.content[match.index]) continue;
         const target = match[targetIndex];
         if (!target) continue;
         const elementId = mediaIndex.ids.has(target) ? target : selectorTargetsManagedMedia(target, mediaIndex) ? void 0 : null;
@@ -1872,8 +1879,20 @@ function findImperativeMediaControlFindings(ctx) {
     for (const [variableName, elementId] of mediaVars) {
       const escapedVar = escapeRegExp(variableName);
       const variablePatterns = [
-        { pattern: new RegExp(`\\b${escapedVar}\\.play\\s*\\(`, "g"), kind: "play()" },
-        { pattern: new RegExp(`\\b${escapedVar}\\.pause\\s*\\(`, "g"), kind: "pause()" },
+        {
+          pattern: new RegExp(
+            `\\b${escapedVar}\\s*(?:\\?\\.|\\.)\\s*play\\s*(?:\\?\\.\\s*)?\\(`,
+            "g"
+          ),
+          kind: "play()"
+        },
+        {
+          pattern: new RegExp(
+            `\\b${escapedVar}\\s*(?:\\?\\.|\\.)\\s*pause\\s*(?:\\?\\.\\s*)?\\(`,
+            "g"
+          ),
+          kind: "pause()"
+        },
         { pattern: new RegExp(`\\b${escapedVar}\\.currentTime\\s*=`, "g"), kind: "currentTime" },
         {
           pattern: new RegExp(`\\b${escapedVar}\\.muted\\s*=`, "g"),
@@ -1883,6 +1902,7 @@ function findImperativeMediaControlFindings(ctx) {
       for (const { pattern, kind } of variablePatterns) {
         let match;
         while ((match = pattern.exec(script.content)) !== null) {
+          if (code[match.index] !== script.content[match.index]) continue;
           findings.push({
             code: "imperative_media_control",
             severity: "error",