@hyperframes/lint 0.8.13 → 0.8.15

package/dist/index.js

@@ -96,13 +96,7 @@ function readDecodedAttr(tagSource, attr) {
   return value;
 }
 function readJsonAttr(tagSource, attr) {
-  if (!tagSource) return null;
-  const escaped = attr.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-  const match = tagSource.match(
-    new RegExp(`(?<![\\w-])${escaped}\\s*=\\s*(?:"([^"]*)"|'([^']*)')`, "i")
-  );
-  if (!match) return null;
-  return match[1] ?? match[2] ?? null;
+  return readDecodedAttr(tagSource, attr);
 }
 function collectCompositionIds(tags) {
   const ids = /* @__PURE__ */ new Set();
@@ -531,7 +525,7 @@ var coreRules = [
       }
     ];
   },
-  // missing_timeline_registry + timeline_registry_missing_init
+  // missing_timeline_registry
   // fallow-ignore-next-line complexity
   ({ source, rawSource, rootTag, options }) => {
     if (options.isSubComposition || rawSource.trimStart().toLowerCase().startsWith("<template")) {
@@ -547,14 +541,6 @@ var coreRules = [
         fixHint: "Register each composition timeline on `window.__timelines[compositionId]`."
       });
     }
-    if (TIMELINE_REGISTRY_ASSIGN_PATTERN.test(source) && !TIMELINE_REGISTRY_INIT_PATTERN.test(source)) {
-      findings.push({
-        code: "timeline_registry_missing_init",
-        severity: "error",
-        message: "`window.__timelines[\u2026] = \u2026` is used without initializing `window.__timelines` first.",
-        fixHint: "Add `window.__timelines = window.__timelines || {};` before any timeline assignment."
-      });
-    }
     return findings;
   },
   // timeline_id_mismatch
@@ -1108,9 +1094,9 @@ var mediaRules = [
             findings.push({
               code: "video_nested_in_timed_element",
               severity: "error",
-              message: `<video> with data-start is nested inside <${parent.name}${parent.id ? ` id="${parent.id}"` : ""}> which also has data-start. The framework cannot manage playback of nested media \u2014 video will be FROZEN in renders.`,
+              message: `<video> with data-start is nested inside <${parent.name}${parent.id ? ` id="${parent.id}"` : ""}> which also has data-start. The frame extractor resolves the video's start from its own data-start without the wrapper's offset, while visibility uses the wrapper's window, so the two disagree: the clip shows the wrong source frames and then disappears partway through its slot.`,
               elementId: readAttr(tag.raw, "id") || void 0,
-              fixHint: "Move the <video> to be a direct child of the stage, or remove data-start from the wrapper div (use it as a non-timed visual container).",
+              fixHint: "Time the wrapper OR the video, never both: remove data-start from the wrapper (use it as a non-timed visual container), or move the <video> up to be a direct child of the stage.",
               snippet: truncateSnippet(tag.raw)
             });
             break;
@@ -3638,7 +3624,7 @@ var compositionRules = [
           severity: "error",
           message: `<${tag.name}${elementId ? ` id="${elementId}"` : ""}> uses data-layer instead of data-track-index.`,
           elementId,
-          fixHint: "Replace data-layer with data-track-index. The runtime reads data-track-index.",
+          fixHint: "Replace data-layer with data-track-index, which is the canonical name Studio and the linter read. Neither name is read by the render.",
           snippet: truncateSnippet(tag.raw)
         });
       }
@@ -4036,10 +4022,13 @@ var compositionRules = [
   // can't leak styles into each other. A rule whose LEFTMOST selector is the ROOT
   // element's own class (e.g. `.frame { ... }` on the same element that carries
   // data-composition-id) therefore becomes a DESCENDANT selector that can never
-  // match the root — the whole scene renders unstyled (tiny text top-left, images
-  // at natural size). lint/validate/inspect evaluate the file in isolation (no
-  // scoping) and Studio previews each scene in its own iframe (no scoping), so the
-  // break is invisible until the composited MP4 render. Style the root via `#root`
+  // match the SCOPED element itself. NOTE on the symptom: since #1886 the producer
+  // preserves the authored root as a `data-hf-inner-root` wrapper INSIDE the scoped
+  // element (regression fixture packages/producer/tests/sub-comp-class-selector),
+  // so the class still matches as a descendant and the scene no longer renders
+  // unstyled. This rule is now a consistency constraint, not a render-bug guard:
+  // `#root` is the shape the registry blocks model and the one the scoper
+  // special-cases. Style the root via `#root`
   // (the scoper special-cases the root id) and descendants via plain selectors,
   // like the registry blocks — the runtime already scopes each scene by id, so a
   // class namespace on the root is redundant.
@@ -4056,9 +4045,9 @@ var compositionRules = [
       {
         code: "subcomposition_root_styled_by_class",
         severity: "error",
-        message: `Root element has class="${rootClasses.join(" ")}" and is styled by ${offenders.length} rule(s) keyed off that class (e.g. ${example}). At render, every sub-composition rule is scoped to [data-composition-id="${rootCompositionId}"] <selector>, so a selector whose leftmost part is the ROOT's own class becomes a descendant selector that cannot match the root \u2014 the scene renders unstyled (tiny text top-left, full-size images). lint/validate/inspect and Studio's per-frame iframe preview do not scope, so this passes every static check and looks correct in preview.`,
+        message: `Root element has class="${rootClasses.join(" ")}" and is styled by ${offenders.length} rule(s) keyed off that class (e.g. ${example}). At render, every sub-composition rule is scoped to [data-composition-id="${rootCompositionId}"] <selector>, so a selector whose leftmost part is the ROOT's own class becomes a descendant selector that cannot match the scoped element itself. Since #1886 the producer preserves the authored root as an inner wrapper, so this no longer renders the scene unstyled, but #root is the shape the scoper special-cases and the registry blocks model. Use it so preview, render, and Studio agree.`,
         selector: example,
-        fixHint: `Give the root id="root" and style it with \`#root { ... }\` plus plain descendant selectors (\`.kicker\`, \`#hero\`) \u2014 the runtime already scopes each sub-composition by data-composition-id, so a class namespace on the root is redundant and breaks under scoping.`,
+        fixHint: `Give the root id="root" and style it with \`#root { ... }\` plus plain descendant selectors (\`.kicker\`, \`#hero\`) \u2014 the runtime already scopes each sub-composition by data-composition-id, so a class namespace on the root is redundant.`,
         snippet: truncateSnippet(rootTag.raw)
       }
     ];
@@ -4804,6 +4793,7 @@ import { checkSubCompositionUsability } from "@hyperframes/parsers/sub-compositi
 import { parseHTML } from "linkedom";
 import {
   cleanAssetUrl as cleanAssetUrl2,
+  collectSubCompositionSrcs,
   isRemoteOrInlineUrl as isRemoteOrInlineUrl2,
   isUnresolvedAssetPlaceholder as isUnresolvedAssetPlaceholder2,
   isWithinProjectRoot,
@@ -5306,13 +5296,7 @@ function lintMissingOrEmptySubComposition(projectDir, rootHtml) {
   const checked = /* @__PURE__ */ new Map();
   const visited = /* @__PURE__ */ new Set();
   const walk = (html) => {
-    const compositionSrcRe = /<[^>]*\bdata-composition-src\s*=\s*["']([^"']+)["'][^>]*>/gi;
-    const scannable = maskNonScannableRanges2(html);
-    let match;
-    while ((match = compositionSrcRe.exec(scannable)) !== null) {
-      const srcPath = (match[1] ?? "").trim();
-      if (!srcPath) continue;
-      if (isUnresolvedAssetPlaceholder2(srcPath)) continue;
+    for (const srcPath of collectSubCompositionSrcs(html)) {
       const filePath = resolve(projectDir, srcPath);
       if (visited.has(filePath)) continue;
       visited.add(filePath);