@hydranium/core 1.0.0-next.32 → 1.0.0-next.33

package/src/locale/server-locale.ts

@@ -53,9 +53,19 @@ export class ServerLocale {
     *
     * Override to ignore the argument, which is how a host pins a locale it
     * already knows but has no LSP client to declare.
+    *
+    * **The line is at `info`, which is a deliberate exception to the
+    * per-service default.** A locale is written once per process and it is the
+    * one setting that silently changes every user-facing sentence the server
+    * produces, so a reader trying to explain an unexpected language has nothing
+    * else to look at: the framework ships no catalogue, so "no entry for this
+    * code" and "no locale declared" both render the English and are
+    * indistinguishable in the output. At `debug` the line is below the default
+    * threshold and therefore absent from exactly the log someone would be
+    * reading.
     */
    accept(locale: string): void {
       this.current = locale;
-      this.tracer.debug(`locale set to '${locale}'`);
+      this.tracer.info(`rendering messages in locale '${locale}'`);
    }
 }

package/src/messages/carriers.ts

@@ -29,6 +29,13 @@ import { Diagnostic } from 'vscode-languageserver-protocol';
  * be able to request a quick fix. The identity is merged OVER whatever they
  * pass, which makes the two conventions co-exist rather than compete.
  *
+ * `data` admits adopter-owned keys beside Langium's, which is why the index
+ * signature is there rather than a bare `Partial<DiagnosticData>`. Langium's
+ * shape is closed, and a diagnostic that carries a COMPANION payload for its own
+ * surface to read — the field a form must highlight, say — has nowhere else to
+ * put it: an encoder projecting that payload reads `diagnostic.data`, so the
+ * narrower type made the identity and the companion mutually exclusive.
+ *
  * The identity lands in both `code` and `data.hydranium` on purpose. `code` is
  * what survives to the editor surface; Theia's converter drops `data` before the
  * squiggle, so a parameterised diagnostic falls back to the server's English
@@ -44,10 +51,13 @@ export function acceptMessage<S extends string, N extends AstNode, P extends Pro
    accept: ValidationAcceptor,
    severity: 'error' | 'warning' | 'info' | 'hint',
    message: MessageDefinition<S>,
-   info: Omit<DiagnosticInfo<N, P>, 'code' | 'data'> & { data?: Partial<DiagnosticData> },
+   info: Omit<DiagnosticInfo<N, P>, 'code' | 'data'> & { data?: Partial<DiagnosticData> & Record<string, unknown> },
    ...params: ParamsArg<S>
 ): void {
-   const data: HydraniumMessageData & Partial<DiagnosticData> = { ...info.data, ...messageData(message, ...params) };
+   const data: HydraniumMessageData & Partial<DiagnosticData> & Record<string, unknown> = {
+      ...info.data,
+      ...messageData(message, ...params)
+   };
    accept(severity, message.format(...params), { ...info, code: message.code, data });
 }
 

package/src/messages/index.ts

@@ -22,6 +22,6 @@ export * from './renderer.js';
 
 export { MODEL_UPDATE_EDIT } from '../langium/model-service/model-service.js';
 export { SEPARATOR_IN_NAME } from '../langium/naming/name-separator-validation.js';
-export { UNRESOLVED_REFERENCE } from '../langium/validation/document-validator.js';
+export { LEXING_ERROR, UNRESOLVED_REFERENCE } from '../langium/validation/document-validator.js';
 export { NO_LOADABLE_CONTENT } from '../langium/workspace/langium-documents.js';
 export { NO_SUCH_FILE, NO_SUCH_PATH } from '../langium/workspace/in-memory-file-system-provider.js';