@hybridlabor-api/aos 4.8.0 → 4.9.0

package/skills/global_config/dockerfile-generator/scripts/generate_python.sh

@@ -0,0 +1,218 @@
+#!/usr/bin/env bash
+# Generate a production-ready Python Dockerfile with multi-stage build
+
+set -euo pipefail
+
+# Default values
+PYTHON_VERSION="${PYTHON_VERSION:-3.12}"
+PORT="${PORT:-8000}"
+OUTPUT_FILE="${OUTPUT_FILE:-Dockerfile}"
+LEGACY_ENTRY="${APP_ENTRY:-app.py}"
+LEGACY_ENTRY_SET="false"
+ENTRY_CMD="${ENTRY_CMD:-}"
+ENTRY_ARGS=()
+
+# Usage
+usage() {
+    cat <<EOF
+Usage: $0 [OPTIONS]
+
+Generate a production-ready Python Dockerfile with multi-stage build.
+
+OPTIONS:
+    -v, --version VERSION     Python version (default: 3.12)
+    -p, --port PORT          Port to expose (default: 8000)
+    -o, --output FILE        Output file (default: Dockerfile)
+    -e, --entry COMMAND      Legacy entry syntax (simple whitespace split only)
+        --entry-cmd COMMAND  Preferred command binary/executable
+        --entry-arg ARG      Preferred command argument (repeatable; preserves spaces)
+    -h, --help               Show this help message
+
+EXAMPLES:
+    # Basic Python app
+    $0
+
+    # FastAPI app
+    $0 --version 3.12 --port 8000
+
+    # Django app
+    $0 --port 8080 --entry "python manage.py runserver 0.0.0.0:8080"
+
+    # Preferred structured entrypoint (preserves quoted args exactly)
+    $0 --entry-cmd python --entry-arg -m --entry-arg uvicorn --entry-arg main:app --entry-arg --log-config --entry-arg "configs/logging prod.yaml"
+
+EOF
+    exit 0
+}
+
+# Parse arguments
+while [[ $# -gt 0 ]]; do
+    case $1 in
+        -v|--version)
+            PYTHON_VERSION="$2"
+            shift 2
+            ;;
+        -p|--port)
+            PORT="$2"
+            shift 2
+            ;;
+        -o|--output)
+            OUTPUT_FILE="$2"
+            shift 2
+            ;;
+        -e|--entry)
+            LEGACY_ENTRY="$2"
+            LEGACY_ENTRY_SET="true"
+            shift 2
+            ;;
+        --entry-cmd)
+            ENTRY_CMD="$2"
+            shift 2
+            ;;
+        --entry-arg)
+            ENTRY_ARGS+=("$2")
+            shift 2
+            ;;
+        -h|--help)
+            usage
+            ;;
+        *)
+            echo "Unknown option: $1"
+            usage
+            ;;
+    esac
+done
+
+# Escape values that are inserted into JSON-form CMD arrays.
+escape_json_string() {
+    local input="$1"
+    input="${input//\\/\\\\}"
+    input="${input//\"/\\\"}"
+    printf '%s' "$input"
+}
+
+# Escape values that are inserted into sed replacement strings.
+escape_sed_replacement() {
+    local input="$1"
+    input="${input//\\/\\\\}"
+    input="${input//&/\\&}"
+    input="${input//|/\\|}"
+    printf '%s' "$input"
+}
+
+# Validate mutually exclusive entrypoint interfaces.
+if [[ -n "$ENTRY_CMD" && "$LEGACY_ENTRY_SET" == "true" ]]; then
+    echo "ERROR: use either --entry or --entry-cmd/--entry-arg, not both." >&2
+    exit 1
+fi
+
+if [[ -z "$ENTRY_CMD" && ${#ENTRY_ARGS[@]} -gt 0 ]]; then
+    echo "ERROR: --entry-arg requires --entry-cmd." >&2
+    exit 1
+fi
+
+# Build CMD instruction.
+# Preferred mode:
+#   --entry-cmd <cmd> --entry-arg <arg> --entry-arg <arg>
+# Legacy mode:
+#   --entry "<simple whitespace-delimited command>"
+# Quoted legacy entries are rejected because they cannot be parsed safely.
+if [[ -n "$ENTRY_CMD" ]]; then
+    CMD_PARTS=("$ENTRY_CMD" "${ENTRY_ARGS[@]}")
+else
+    if [[ "$LEGACY_ENTRY" == *"\""* || "$LEGACY_ENTRY" == *"'"* ]]; then
+        echo "ERROR: quoted --entry values are not supported. Use --entry-cmd/--entry-arg." >&2
+        exit 1
+    fi
+
+    if [[ "$LEGACY_ENTRY" =~ [[:space:]] ]]; then
+        read -r -a CMD_PARTS <<< "$LEGACY_ENTRY"
+    else
+        CMD_PARTS=("python" "$LEGACY_ENTRY")
+    fi
+fi
+
+if [[ -z "${CMD_PARTS[0]:-}" ]]; then
+    echo "ERROR: entry command cannot be empty." >&2
+    exit 1
+fi
+
+_json_parts=()
+for _token in "${CMD_PARTS[@]}"; do
+    _json_parts+=("\"$(escape_json_string "$_token")\"")
+done
+CMD_INSTRUCTION="CMD [$(IFS=', '; echo "${_json_parts[*]}")]"
+CMD_INSTRUCTION_SED="$(escape_sed_replacement "$CMD_INSTRUCTION")"
+
+# Generate Dockerfile
+cat > "$OUTPUT_FILE" <<'EOF'
+# syntax=docker/dockerfile:1
+
+# Build stage
+FROM python:PYTHON_VERSION-slim AS builder
+WORKDIR /app
+
+# Install build dependencies
+# hadolint ignore=DL3008
+RUN apt-get update && apt-get install -y --no-install-recommends \
+    gcc \
+    && rm -rf /var/lib/apt/lists/*
+
+# Copy dependency files
+COPY requirements.txt .
+
+# Install Python dependencies
+RUN pip install --no-cache-dir --user -r requirements.txt
+
+# Production stage
+FROM python:PYTHON_VERSION-slim AS production
+WORKDIR /app
+
+# Create non-root user
+RUN useradd -m -u 1001 app
+
+# Copy dependencies from builder
+COPY --from=builder /root/.local /home/app/.local
+
+# Copy application code
+COPY --chown=app:app . .
+
+# Update PATH and set Python production env vars
+ENV PATH=/home/app/.local/bin:$PATH \
+    PYTHONUNBUFFERED=1 \
+    PYTHONDONTWRITEBYTECODE=1
+
+# Switch to non-root user
+USER app
+
+# Expose port
+EXPOSE PORT_NUMBER
+
+# Health check
+HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
+    CMD python -c "import urllib.request; urllib.request.urlopen('http://localhost:PORT_NUMBER/health').read()" || exit 1
+
+# Start application
+CMD_INSTRUCTION_PLACEHOLDER
+EOF
+
+# Replace placeholders
+sed -i.bak "s/PYTHON_VERSION/$PYTHON_VERSION/g" "$OUTPUT_FILE"
+sed -i.bak "s/PORT_NUMBER/$PORT/g" "$OUTPUT_FILE"
+sed -i.bak "s|CMD_INSTRUCTION_PLACEHOLDER|$CMD_INSTRUCTION_SED|g" "$OUTPUT_FILE"
+
+# Clean up backup files
+rm -f "${OUTPUT_FILE}.bak"
+
+echo "✓ Generated Python Dockerfile: $OUTPUT_FILE"
+echo "  Python version: $PYTHON_VERSION"
+echo "  Port: $PORT"
+if [[ -n "$ENTRY_CMD" ]]; then
+    ENTRY_DISPLAY="$ENTRY_CMD"
+    for _arg in "${ENTRY_ARGS[@]}"; do
+        ENTRY_DISPLAY+=" $(printf '%q' "$_arg")"
+    done
+else
+    ENTRY_DISPLAY="$LEGACY_ENTRY"
+fi
+echo "  Entry point: $ENTRY_DISPLAY"

package/skills/global_config/dockerfile-generator/scripts/test_generator.sh

@@ -0,0 +1,210 @@
+#!/usr/bin/env bash
+#
+# Regression tests for dockerfile-generator scripts and examples.
+#
+# Covers:
+#   1. Node/Python structured entrypoint args (--entry-cmd/--entry-arg)
+#   2. Legacy --entry behavior and quote rejection
+#   3. Node multistage example dependency/build flow consistency
+#
+# Exit 0 when all assertions pass; non-zero otherwise.
+#
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+readonly SCRIPT_DIR
+readonly SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+readonly NODE_GENERATOR="$SCRIPT_DIR/generate_nodejs.sh"
+readonly PYTHON_GENERATOR="$SCRIPT_DIR/generate_python.sh"
+readonly NODE_EXAMPLE="$SKILL_DIR/examples/nodejs-multistage.Dockerfile"
+
+PASS=0
+FAIL=0
+OUTPUT=""
+EXIT_CODE=0
+
+pass() { echo "  PASS: $1"; PASS=$((PASS + 1)); }
+fail() { echo "  FAIL: $1"; FAIL=$((FAIL + 1)); }
+
+run_capture() {
+    EXIT_CODE=0
+    OUTPUT=$("$@" 2>&1) || EXIT_CODE=$?
+}
+
+assert_exit() {
+    local label="$1"
+    local expected="$2"
+    if [[ "$EXIT_CODE" -eq "$expected" ]]; then
+        pass "$label (exit $EXIT_CODE)"
+    else
+        fail "$label — expected exit $expected, got $EXIT_CODE"
+        echo "$OUTPUT" | sed 's/^/    /'
+    fi
+}
+
+assert_output_contains() {
+    local label="$1"
+    local pattern="$2"
+    if echo "$OUTPUT" | grep -qE -- "$pattern"; then
+        pass "$label"
+    else
+        fail "$label — pattern not found: $pattern"
+        echo "$OUTPUT" | sed 's/^/    /'
+    fi
+}
+
+assert_file_contains() {
+    local label="$1"
+    local file="$2"
+    local pattern="$3"
+    if grep -qE -- "$pattern" "$file"; then
+        pass "$label"
+    else
+        fail "$label — pattern '$pattern' not found in $file"
+        sed 's/^/    /' "$file"
+    fi
+}
+
+assert_file_not_contains() {
+    local label="$1"
+    local file="$2"
+    local pattern="$3"
+    if grep -qE -- "$pattern" "$file"; then
+        fail "$label — unexpected pattern '$pattern' found in $file"
+        grep -nE -- "$pattern" "$file" | sed 's/^/    /'
+    else
+        pass "$label"
+    fi
+}
+
+TMP_DIR="$(mktemp -d)"
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+echo "Running dockerfile-generator regression tests..."
+
+echo ""
+echo "[shell syntax checks]"
+if bash -n "$NODE_GENERATOR"; then
+    pass "node generator passes bash -n"
+else
+    fail "node generator has syntax errors"
+fi
+
+if bash -n "$PYTHON_GENERATOR"; then
+    pass "python generator passes bash -n"
+else
+    fail "python generator has syntax errors"
+fi
+
+echo ""
+echo "[node generator]"
+NODE_STRUCTURED_OUT="$TMP_DIR/node-structured.Dockerfile"
+run_capture \
+    bash "$NODE_GENERATOR" \
+    --output "$NODE_STRUCTURED_OUT" \
+    --entry-cmd node \
+    --entry-arg server.js \
+    --entry-arg --message \
+    --entry-arg "hello world"
+assert_exit "structured node entry generation succeeds" 0
+assert_file_contains \
+    "structured node entry preserves spaced arg" \
+    "$NODE_STRUCTURED_OUT" \
+    'CMD \["node","server\.js","--message","hello world"\]'
+
+NODE_LEGACY_OUT="$TMP_DIR/node-legacy.Dockerfile"
+run_capture \
+    bash "$NODE_GENERATOR" \
+    --output "$NODE_LEGACY_OUT" \
+    --entry "npm start"
+assert_exit "legacy node entry generation succeeds" 0
+assert_file_contains \
+    "legacy node entry still tokenizes simple commands" \
+    "$NODE_LEGACY_OUT" \
+    'CMD \["npm","start"\]'
+
+run_capture \
+    bash "$NODE_GENERATOR" \
+    --output "$TMP_DIR/node-legacy-quoted.Dockerfile" \
+    --entry "node server.js --message \"hello world\""
+assert_exit "legacy quoted node entry is rejected" 1
+assert_output_contains \
+    "legacy quoted node rejection message is clear" \
+    'ERROR: quoted --entry values are not supported\. Use --entry-cmd/--entry-arg\.'
+
+run_capture \
+    bash "$NODE_GENERATOR" \
+    --output "$TMP_DIR/node-invalid-args.Dockerfile" \
+    --entry-arg server.js
+assert_exit "--entry-arg without --entry-cmd fails for node" 1
+assert_output_contains \
+    "node --entry-arg validation message is clear" \
+    'ERROR: --entry-arg requires --entry-cmd\.'
+
+echo ""
+echo "[python generator]"
+PY_STRUCTURED_OUT="$TMP_DIR/python-structured.Dockerfile"
+run_capture \
+    bash "$PYTHON_GENERATOR" \
+    --output "$PY_STRUCTURED_OUT" \
+    --entry-cmd python \
+    --entry-arg -m \
+    --entry-arg uvicorn \
+    --entry-arg main:app \
+    --entry-arg --log-config \
+    --entry-arg "configs/logging prod.yaml"
+assert_exit "structured python entry generation succeeds" 0
+assert_file_contains \
+    "structured python entry preserves spaced arg" \
+    "$PY_STRUCTURED_OUT" \
+    'CMD \["python","-m","uvicorn","main:app","--log-config","configs/logging prod\.yaml"\]'
+
+PY_LEGACY_OUT="$TMP_DIR/python-legacy.Dockerfile"
+run_capture \
+    bash "$PYTHON_GENERATOR" \
+    --output "$PY_LEGACY_OUT" \
+    --entry "python app.py"
+assert_exit "legacy python entry generation succeeds" 0
+assert_file_contains \
+    "legacy python entry still tokenizes simple commands" \
+    "$PY_LEGACY_OUT" \
+    'CMD \["python","app\.py"\]'
+
+run_capture \
+    bash "$PYTHON_GENERATOR" \
+    --output "$TMP_DIR/python-legacy-quoted.Dockerfile" \
+    --entry "python app.py --message \"hello world\""
+assert_exit "legacy quoted python entry is rejected" 1
+assert_output_contains \
+    "legacy quoted python rejection message is clear" \
+    'ERROR: quoted --entry values are not supported\. Use --entry-cmd/--entry-arg\.'
+
+echo ""
+echo "[node example]"
+assert_file_contains \
+    "node example installs full deps before build" \
+    "$NODE_EXAMPLE" \
+    'RUN npm ci &&'
+assert_file_contains \
+    "node example prunes dev dependencies after build" \
+    "$NODE_EXAMPLE" \
+    'npm prune --omit=dev'
+assert_file_not_contains \
+    "node example avoids mixed only=production build flow" \
+    "$NODE_EXAMPLE" \
+    'npm ci --only=production'
+assert_file_contains \
+    "node example runs compiled output" \
+    "$NODE_EXAMPLE" \
+    'CMD \["node", "dist/index\.js"\]'
+
+echo ""
+echo "Passed: $PASS"
+echo "Failed: $FAIL"
+
+if [[ "$FAIL" -gt 0 ]]; then
+    exit 1
+fi
+
+echo "All dockerfile-generator regression tests passed."