@hybridlabor-api/aos 4.7.2 → 4.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (166) hide show
  1. package/.agents/agents.md +1 -1
  2. package/.agents/nodes.json +1 -1
  3. package/.agents/vendor-manifest.json +23 -1
  4. package/.claude/agents/godmode-media-eventtech.md +1 -1
  5. package/.claude/hooks/conventional-commits.mjs +125 -0
  6. package/.claude/hooks/env-file-protection.mjs +105 -0
  7. package/.claude/hooks/go-gate.mjs +101 -81
  8. package/.claude/settings.json +13 -0
  9. package/.opencode/agents/godmode-media-eventtech.md +1 -1
  10. package/.opencode/plugins/bdb-aos.js +31 -4
  11. package/README.de.md +1 -1
  12. package/README.md +1 -1
  13. package/README.pt.md +1 -1
  14. package/THIRD_PARTY_NOTICES.md +88 -0
  15. package/docs/skills_table.md +1 -1
  16. package/installer.js +309 -101
  17. package/package.json +6 -2
  18. package/packages/aos-cli/README.md +80 -0
  19. package/packages/aos-cli/bin/aos-cli.mjs +134 -0
  20. package/packages/aos-cli/core-skills.json +12 -0
  21. package/packages/aos-cli/extensions/aos.ts +321 -0
  22. package/packages/aos-cli/package-lock.json +1923 -0
  23. package/packages/aos-cli/package.json +29 -0
  24. package/packages/aos-cli/scripts/check-theme.mjs +63 -0
  25. package/packages/aos-cli/themes/aos.json +97 -0
  26. package/scripts/build-plugin-manifest.mjs +131 -0
  27. package/scripts/validate-skills.mjs +81 -6
  28. package/skills/basic/ao-orchestrator/SKILL.md +116 -0
  29. package/skills/global_config/agenttrail/SKILL.md +6 -1
  30. package/skills/global_config/ask-tim/SKILL.md +4 -4
  31. package/skills/global_config/bash-script-generator/SKILL.md +201 -0
  32. package/skills/global_config/bash-script-generator/assets/templates/standard-template.sh +96 -0
  33. package/skills/global_config/bash-script-generator/docs/bash-scripting-guide.md +729 -0
  34. package/skills/global_config/bash-script-generator/docs/generation-best-practices.md +193 -0
  35. package/skills/global_config/bash-script-generator/docs/script-patterns.md +566 -0
  36. package/skills/global_config/bash-script-generator/docs/text-processing-guide.md +437 -0
  37. package/skills/global_config/bash-script-generator/examples/log-analyzer.sh +92 -0
  38. package/skills/global_config/bash-script-generator/scripts/generate_script_template.sh +123 -0
  39. package/skills/global_config/bash-script-generator/scripts/run_ci_checks.sh +172 -0
  40. package/skills/global_config/bash-script-generator/scripts/test_generator.sh +413 -0
  41. package/skills/global_config/bash-script-validator/SKILL.md +249 -0
  42. package/skills/global_config/bash-script-validator/docs/awk-reference.md +449 -0
  43. package/skills/global_config/bash-script-validator/docs/bash-reference.md +468 -0
  44. package/skills/global_config/bash-script-validator/docs/common-mistakes.md +623 -0
  45. package/skills/global_config/bash-script-validator/docs/grep-reference.md +395 -0
  46. package/skills/global_config/bash-script-validator/docs/regex-reference.md +391 -0
  47. package/skills/global_config/bash-script-validator/docs/sed-reference.md +454 -0
  48. package/skills/global_config/bash-script-validator/docs/shell-reference.md +463 -0
  49. package/skills/global_config/bash-script-validator/docs/shellcheck-reference.md +399 -0
  50. package/skills/global_config/bash-script-validator/examples/bad-bash.sh +55 -0
  51. package/skills/global_config/bash-script-validator/examples/bad-shell.sh +54 -0
  52. package/skills/global_config/bash-script-validator/examples/good-bash.sh +71 -0
  53. package/skills/global_config/bash-script-validator/examples/good-shell.sh +69 -0
  54. package/skills/global_config/bash-script-validator/scripts/run_ci_checks.sh +23 -0
  55. package/skills/global_config/bash-script-validator/scripts/shellcheck_wrapper.sh +174 -0
  56. package/skills/global_config/bash-script-validator/scripts/test_validate.sh +446 -0
  57. package/skills/global_config/bash-script-validator/scripts/validate.sh +512 -0
  58. package/skills/global_config/ci-pipeline/SKILL.md +135 -0
  59. package/skills/global_config/dispatching-parallel-agents/SKILL.md +170 -0
  60. package/skills/global_config/dockerfile-generator/SKILL.md +1038 -0
  61. package/skills/global_config/dockerfile-generator/examples/example.dockerignore +95 -0
  62. package/skills/global_config/dockerfile-generator/examples/golang-distroless.Dockerfile +34 -0
  63. package/skills/global_config/dockerfile-generator/examples/java-springboot.Dockerfile +45 -0
  64. package/skills/global_config/dockerfile-generator/examples/nextjs-production.Dockerfile +49 -0
  65. package/skills/global_config/dockerfile-generator/examples/nodejs-multistage.Dockerfile +55 -0
  66. package/skills/global_config/dockerfile-generator/examples/python-fastapi.Dockerfile +48 -0
  67. package/skills/global_config/dockerfile-generator/references/language_specific_guides.md +510 -0
  68. package/skills/global_config/dockerfile-generator/references/multistage_builds.md +570 -0
  69. package/skills/global_config/dockerfile-generator/references/optimization_patterns.md +492 -0
  70. package/skills/global_config/dockerfile-generator/references/security_best_practices.md +375 -0
  71. package/skills/global_config/dockerfile-generator/scripts/generate_dockerignore.sh +199 -0
  72. package/skills/global_config/dockerfile-generator/scripts/generate_golang.sh +172 -0
  73. package/skills/global_config/dockerfile-generator/scripts/generate_java.sh +185 -0
  74. package/skills/global_config/dockerfile-generator/scripts/generate_nodejs.sh +279 -0
  75. package/skills/global_config/dockerfile-generator/scripts/generate_python.sh +218 -0
  76. package/skills/global_config/dockerfile-generator/scripts/test_generator.sh +210 -0
  77. package/skills/global_config/dockerfile-validator/SKILL.md +300 -0
  78. package/skills/global_config/dockerfile-validator/examples/.dockerignore.example +34 -0
  79. package/skills/global_config/dockerfile-validator/examples/bad-example.Dockerfile +37 -0
  80. package/skills/global_config/dockerfile-validator/examples/golang-distroless.Dockerfile +50 -0
  81. package/skills/global_config/dockerfile-validator/examples/good-example.Dockerfile +52 -0
  82. package/skills/global_config/dockerfile-validator/examples/python-optimized.Dockerfile +53 -0
  83. package/skills/global_config/dockerfile-validator/examples/security-issues.Dockerfile +42 -0
  84. package/skills/global_config/dockerfile-validator/references/docker_best_practices.md +348 -0
  85. package/skills/global_config/dockerfile-validator/references/optimization_guide.md +473 -0
  86. package/skills/global_config/dockerfile-validator/references/security_checklist.md +208 -0
  87. package/skills/global_config/dockerfile-validator/scripts/dockerfile-validate.sh +699 -0
  88. package/skills/global_config/dockerfile-validator/scripts/test_validate.sh +35 -0
  89. package/skills/global_config/dockerfile-validator/tests/fixtures/copy-before-yarn-lock-read.Dockerfile +6 -0
  90. package/skills/global_config/dockerfile-validator/tests/fixtures/copy-before-yarn.Dockerfile +6 -0
  91. package/skills/global_config/dockerfile-validator/tests/fixtures/from-platform-nonroot.Dockerfile +7 -0
  92. package/skills/global_config/dockerfile-validator/tests/test_regression.sh +164 -0
  93. package/skills/global_config/finishing-a-development-branch/SKILL.md +228 -0
  94. package/skills/global_config/github-actions-generator/SKILL.md +353 -0
  95. package/skills/global_config/github-actions-generator/assets/templates/action/composite/action.yml +82 -0
  96. package/skills/global_config/github-actions-generator/assets/templates/action/docker/Dockerfile +25 -0
  97. package/skills/global_config/github-actions-generator/assets/templates/action/docker/action.yml +42 -0
  98. package/skills/global_config/github-actions-generator/assets/templates/action/docker/entrypoint.sh +27 -0
  99. package/skills/global_config/github-actions-generator/assets/templates/action/javascript/action.yml +33 -0
  100. package/skills/global_config/github-actions-generator/assets/templates/action/javascript/index.js +50 -0
  101. package/skills/global_config/github-actions-generator/assets/templates/action/javascript/package.json +27 -0
  102. package/skills/global_config/github-actions-generator/assets/templates/workflow/basic_workflow.yml +242 -0
  103. package/skills/global_config/github-actions-generator/assets/templates/workflow/reusable_workflow.yml +106 -0
  104. package/skills/global_config/github-actions-generator/examples/README.md +147 -0
  105. package/skills/global_config/github-actions-generator/examples/actions/setup-node-cached/action.yml +93 -0
  106. package/skills/global_config/github-actions-generator/examples/caching/docker-buildkit.yml +256 -0
  107. package/skills/global_config/github-actions-generator/examples/security/dependency-review.yml +62 -0
  108. package/skills/global_config/github-actions-generator/examples/security/sbom-attestation.yml +119 -0
  109. package/skills/global_config/github-actions-generator/examples/triggers/chatops-commands.yml +475 -0
  110. package/skills/global_config/github-actions-generator/examples/triggers/repository-dispatch.yml +418 -0
  111. package/skills/global_config/github-actions-generator/examples/triggers/workflow-orchestration.yml +404 -0
  112. package/skills/global_config/github-actions-generator/examples/workflows/docker-build-push.yml +68 -0
  113. package/skills/global_config/github-actions-generator/examples/workflows/go-ci.yml +161 -0
  114. package/skills/global_config/github-actions-generator/examples/workflows/monorepo-ci.yml +340 -0
  115. package/skills/global_config/github-actions-generator/examples/workflows/multi-environment-deploy.yml +406 -0
  116. package/skills/global_config/github-actions-generator/examples/workflows/nodejs-ci.yml +122 -0
  117. package/skills/global_config/github-actions-generator/examples/workflows/python-ci.yml +157 -0
  118. package/skills/global_config/github-actions-generator/examples/workflows/scheduled-tasks.yml +376 -0
  119. package/skills/global_config/github-actions-generator/references/advanced-triggers.md +917 -0
  120. package/skills/global_config/github-actions-generator/references/best-practices.md +755 -0
  121. package/skills/global_config/github-actions-generator/references/common-actions.md +715 -0
  122. package/skills/global_config/github-actions-generator/references/custom-actions.md +320 -0
  123. package/skills/global_config/github-actions-generator/references/expressions-and-contexts.md +688 -0
  124. package/skills/global_config/github-actions-generator/references/modern-features.md +421 -0
  125. package/skills/global_config/github-actions-generator/scripts/test_generator.sh +344 -0
  126. package/skills/global_config/github-actions-templates/SKILL.md +7 -0
  127. package/skills/global_config/github-actions-validator/SKILL.md +576 -0
  128. package/skills/global_config/github-actions-validator/examples/README.md +88 -0
  129. package/skills/global_config/github-actions-validator/examples/outdated-versions.yml +76 -0
  130. package/skills/global_config/github-actions-validator/examples/valid-ci.yml +79 -0
  131. package/skills/global_config/github-actions-validator/examples/with-errors.yml +47 -0
  132. package/skills/global_config/github-actions-validator/references/act_usage.md +233 -0
  133. package/skills/global_config/github-actions-validator/references/action_versions.md +122 -0
  134. package/skills/global_config/github-actions-validator/references/actionlint_usage.md +343 -0
  135. package/skills/global_config/github-actions-validator/references/common_errors.md +512 -0
  136. package/skills/global_config/github-actions-validator/references/modern_features.md +384 -0
  137. package/skills/global_config/github-actions-validator/references/runners.md +317 -0
  138. package/skills/global_config/github-actions-validator/scripts/install_tools.sh +113 -0
  139. package/skills/global_config/github-actions-validator/scripts/validate_workflow.sh +910 -0
  140. package/skills/global_config/github-actions-validator/tests/test_validate_workflow.sh +237 -0
  141. package/skills/global_config/makefile-generator/SKILL.md +614 -0
  142. package/skills/global_config/makefile-generator/assets/templates/.gitkeep +1 -0
  143. package/skills/global_config/makefile-generator/docs/makefile-structure.md +530 -0
  144. package/skills/global_config/makefile-generator/docs/optimization-guide.md +784 -0
  145. package/skills/global_config/makefile-generator/docs/patterns-guide.md +642 -0
  146. package/skills/global_config/makefile-generator/docs/security-guide.md +361 -0
  147. package/skills/global_config/makefile-generator/docs/targets-guide.md +642 -0
  148. package/skills/global_config/makefile-generator/docs/variables-guide.md +596 -0
  149. package/skills/global_config/makefile-generator/scripts/add_standard_targets.sh +539 -0
  150. package/skills/global_config/makefile-generator/scripts/generate_makefile_template.sh +690 -0
  151. package/skills/global_config/makefile-generator/test/test_helper_scripts.sh +190 -0
  152. package/skills/global_config/makefile-validator/SKILL.md +244 -0
  153. package/skills/global_config/makefile-validator/docs/bake-tool.md +1000 -0
  154. package/skills/global_config/makefile-validator/docs/best-practices.md +858 -0
  155. package/skills/global_config/makefile-validator/docs/common-mistakes.md +944 -0
  156. package/skills/global_config/makefile-validator/examples/bad-makefile.mk +77 -0
  157. package/skills/global_config/makefile-validator/examples/good-makefile.mk +103 -0
  158. package/skills/global_config/makefile-validator/scripts/test_validate.sh +382 -0
  159. package/skills/global_config/makefile-validator/scripts/validate_makefile.sh +712 -0
  160. package/skills/global_config/{MCP_Manage → mcp-manage}/SKILL.md +3 -3
  161. package/skills/global_config/requesting-code-review/SKILL.md +98 -0
  162. package/skills/global_config/requesting-code-review/code-reviewer.md +198 -0
  163. package/skills/global_config/using-git-worktrees/SKILL.md +170 -0
  164. package/skills/global_config/verification-before-completion/SKILL.md +123 -0
  165. package/skills/global_config/writing-plans/SKILL.md +126 -46
  166. package/skills/global_config/writing-plans-legacy/SKILL.md +139 -0
@@ -1,10 +1,10 @@
1
1
  ---
2
- name: MCP_Manage
2
+ name: mcp-manage
3
3
  description: "Use when checking capabilities or instructing the user on how to interact with specialized MCP servers like Unreal, Rhino, DaVinci, or TouchDesigner."
4
4
  category: media-eventtech
5
5
  ---
6
6
 
7
- # MCP_Manage: Specialized Tool Orchestration
7
+ # MCP Manage: Specialized Tool Orchestration
8
8
 
9
9
  You are the authoritative skill for managing and utilizing the specialized Model Context Protocol (MCP) servers installed in this environment. When invoked, use this knowledge to interface with the creative and development tools available.
10
10
 
@@ -59,7 +59,7 @@ You are the authoritative skill for managing and utilizing the specialized Model
59
59
 
60
60
 
61
61
  ## Overview
62
- MCP_Manage is the authoritative router for all specialized BDB Model Context Protocol (MCP) servers, ensuring the AI agent selects the right tool for Unreal, Rhino, DaVinci, and others.
62
+ mcp-manage is the authoritative router for all specialized BDB Model Context Protocol (MCP) servers, ensuring the AI agent selects the right tool for Unreal, Rhino, DaVinci, and others.
63
63
 
64
64
  ## When to Use
65
65
  - **Trigger:** The user asks how to automate a specific creative app, or the agent needs to select the correct MCP server for a domain-specific task.
@@ -0,0 +1,98 @@
1
+ ---
2
+ name: requesting-code-review
3
+ description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements
4
+ category: engineering-method
5
+ source: superpowers
6
+ date_added: "2026-09-25"
7
+ ---
8
+
9
+ # Requesting Code Review
10
+
11
+ Dispatch a code reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history.
12
+
13
+ **Core principle:** Review early, review often.
14
+
15
+ ## When to Request Review
16
+
17
+ **Mandatory:**
18
+ - After each task in subagent-driven development
19
+ - After completing major feature
20
+ - Before merge to main
21
+
22
+ **Optional but valuable:**
23
+ - When stuck (fresh perspective)
24
+ - Before refactoring (baseline check)
25
+ - After fixing complex bug
26
+
27
+ ## How to Request
28
+
29
+ **1. Get git SHAs:**
30
+ ```bash
31
+ BASE_SHA=$(git rev-parse HEAD~1) # or: git merge-base origin/main HEAD
32
+ HEAD_SHA=$(git rev-parse HEAD)
33
+ ```
34
+
35
+ **2. Dispatch code reviewer subagent:**
36
+
37
+ Dispatch a `general-purpose` subagent, filling the template at [code-reviewer.md](code-reviewer.md)
38
+
39
+ **Placeholders:**
40
+ - `{DESCRIPTION}` - Brief summary of what you built
41
+ - `{PLAN_OR_REQUIREMENTS}` - What it should do
42
+ - `{BASE_SHA}` - Starting commit
43
+ - `{HEAD_SHA}` - Ending commit
44
+
45
+ **3. Act on feedback:**
46
+ - Fix Critical issues immediately
47
+ - Fix Important issues before proceeding
48
+ - Note Minor issues for later
49
+ - Push back if reviewer is wrong (with reasoning)
50
+
51
+ ## Example
52
+
53
+ ```
54
+ [Just completed Task 2: Add verification function]
55
+
56
+ You: Let me request code review before proceeding.
57
+
58
+ BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
59
+ HEAD_SHA=$(git rev-parse HEAD)
60
+
61
+ [Dispatch code reviewer subagent]
62
+ DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
63
+ PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
64
+ BASE_SHA: a7981ec
65
+ HEAD_SHA: 3df7661
66
+
67
+ [Subagent returns]:
68
+ Strengths: Clean architecture, real tests
69
+ Issues:
70
+ Important: Missing progress indicators
71
+ Minor: Magic number (100) for reporting interval
72
+ Assessment: Ready to proceed
73
+
74
+ You: [Fix progress indicators]
75
+ [Continue to Task 3]
76
+ ```
77
+
78
+ ## Common Rationalizations
79
+
80
+ | Excuse | Reality |
81
+ |--------|---------|
82
+ | "I'll just review the diff myself instead of dispatching a reviewer" | You're the coordinator — reviewing the diff inline burns the context window you need to keep driving the work. Dispatch a reviewer subagent: the diff and the evaluation live in its context, and only the findings come back to you. |
83
+ | "The reviewer needs my whole session history to understand the change" | Hand it precisely crafted context, never your session's history. That keeps the reviewer on the work product, not your thought process. |
84
+
85
+ ## Red Flags
86
+
87
+ **Never:**
88
+ - Skip review because "it's simple"
89
+ - Ignore Critical issues
90
+ - Proceed with unfixed Important issues
91
+ - Argue with valid technical feedback
92
+
93
+ **If reviewer wrong:**
94
+ - Push back with technical reasoning
95
+ - Show code/tests that prove it works
96
+ - Request clarification
97
+
98
+ See template at: [code-reviewer.md](code-reviewer.md)
@@ -0,0 +1,198 @@
1
+ # Code Reviewer Prompt Template
2
+
3
+ Use this template when dispatching a code reviewer subagent.
4
+
5
+ **Purpose:** Review completed work against requirements and code quality standards before it cascades into more work.
6
+
7
+ ```
8
+ Subagent (general-purpose):
9
+ description: "Review code changes"
10
+ prompt: |
11
+ You are a Senior Code Reviewer with expertise in software architecture,
12
+ design patterns, and best practices. Your job is to review completed work
13
+ against its plan or requirements and identify issues before they cascade.
14
+
15
+ ## What Was Implemented
16
+
17
+ [DESCRIPTION]
18
+
19
+ ## Requirements / Plan
20
+
21
+ [PLAN_OR_REQUIREMENTS]
22
+
23
+ ## Git Range to Review
24
+
25
+ **Base:** [BASE_SHA]
26
+ **Head:** [HEAD_SHA]
27
+
28
+ ```bash
29
+ git diff --stat [BASE_SHA]..[HEAD_SHA]
30
+ git diff [BASE_SHA]..[HEAD_SHA]
31
+ ```
32
+
33
+ ## The spec is a vision document
34
+
35
+ The spec says what the software must do. It does not enumerate every
36
+ input, environment, or condition the software will meet. For behavior
37
+ the spec is silent on, judge by what a reasonable person using this
38
+ software would expect: a reasonable person's expectation is a
39
+ requirement, and a spec's silence is not permission. Grade such
40
+ findings by their effect on that person, not by whether the spec
41
+ mentions the trigger.
42
+
43
+ ## Declined to judge
44
+
45
+ Before your verdict, list every behavior you considered and set aside
46
+ as outside the plan or spec, one line each, with the reason. The
47
+ executor rules on each line; nothing you set aside is dropped
48
+ silently. An empty list means you set nothing aside.
49
+
50
+ ## Read-Only Review
51
+
52
+ Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.
53
+
54
+ ## You Do Not Dispatch Subagents
55
+
56
+ Do all of this review yourself. Never spawn a subagent to review part
57
+ of the diff, and never spawn another reviewer for a second opinion.
58
+ This process already provides every review seat the work gets; a
59
+ reviewer you spawn duplicates one of them at full cost, and its
60
+ verdict counts for nothing. If the diff feels too large for one
61
+ pass, review it in passes yourself and say so in your report.
62
+
63
+ ## What to Check
64
+
65
+ **Plan alignment:**
66
+ - Does the implementation match the plan / requirements?
67
+ - Are deviations justified improvements, or problematic departures?
68
+ - Is all planned functionality present?
69
+
70
+ **Code quality:**
71
+ - Clean separation of concerns?
72
+ - Proper error handling?
73
+ - Type safety where applicable?
74
+ - DRY without premature abstraction?
75
+ - Edge cases handled?
76
+
77
+ **Architecture:**
78
+ - Sound design decisions?
79
+ - Reasonable scalability and performance?
80
+ - Security concerns?
81
+ - Integrates cleanly with surrounding code?
82
+
83
+ **Testing:**
84
+ - Tests verify real behavior, not mocks?
85
+ - Edge cases covered?
86
+ - Integration tests where they matter?
87
+ - All tests passing?
88
+
89
+ **Production readiness:**
90
+ - Migration strategy if schema changed?
91
+ - Backward compatibility considered?
92
+ - Documentation complete?
93
+ - No obvious bugs?
94
+
95
+ ## Calibration
96
+
97
+ Categorize issues by actual severity. Not everything is Critical.
98
+ Acknowledge what was done well before listing issues — accurate praise
99
+ helps the implementer trust the rest of the feedback.
100
+
101
+ If you find significant deviations from the plan, flag them specifically
102
+ so the implementer can confirm whether the deviation was intentional.
103
+ If you find issues with the plan itself rather than the implementation,
104
+ say so.
105
+
106
+ ## Output Format
107
+
108
+ ### Strengths
109
+ [What's well done? Be specific.]
110
+
111
+ ### Issues
112
+
113
+ #### Critical (Must Fix)
114
+ [Bugs, security issues, data loss risks, broken functionality]
115
+
116
+ #### Important (Should Fix)
117
+ [Architecture problems, missing features, poor error handling, test gaps]
118
+
119
+ #### Minor (Nice to Have)
120
+ [Code style, optimization opportunities, documentation polish]
121
+
122
+ For each issue:
123
+ - File:line reference
124
+ - What's wrong
125
+ - Why it matters
126
+ - How to fix (if not obvious)
127
+
128
+ ### Recommendations
129
+ [Improvements for code quality, architecture, or process]
130
+
131
+ ### Assessment
132
+
133
+ **Ready to merge?** [Yes | No | With fixes]
134
+
135
+ **Reasoning:** [1-2 sentence technical assessment]
136
+
137
+ ## Critical Rules
138
+
139
+ **DO:**
140
+ - Categorize by actual severity
141
+ - Be specific (file:line, not vague)
142
+ - Explain WHY each issue matters
143
+ - Acknowledge strengths
144
+ - Give a clear verdict
145
+
146
+ **DON'T:**
147
+ - Say "looks good" without checking
148
+ - Mark nitpicks as Critical
149
+ - Give feedback on code you didn't actually read
150
+ - Be vague ("improve error handling")
151
+ - Avoid giving a clear verdict
152
+ ```
153
+
154
+ **Placeholders:**
155
+ - `[DESCRIPTION]` — brief summary of what was built
156
+ - `[PLAN_OR_REQUIREMENTS]` — what it should do (plan file path, task text, or requirements)
157
+ - `[BASE_SHA]` — starting commit
158
+ - `[HEAD_SHA]` — ending commit
159
+
160
+ **Reviewer returns:** Strengths, Issues (Critical / Important / Minor), Recommendations, Assessment
161
+
162
+ ## Example Output
163
+
164
+ ```
165
+ ### Strengths
166
+ - Clean database schema with proper migrations (db.ts:15-42)
167
+ - Comprehensive test coverage (18 tests, all edge cases)
168
+ - Good error handling with fallbacks (summarizer.ts:85-92)
169
+
170
+ ### Issues
171
+
172
+ #### Important
173
+ 1. **Missing help text in CLI wrapper**
174
+ - File: index-conversations:1-31
175
+ - Issue: No --help flag, users won't discover --concurrency
176
+ - Fix: Add --help case with usage examples
177
+
178
+ 2. **Date validation missing**
179
+ - File: search.ts:25-27
180
+ - Issue: Invalid dates silently return no results
181
+ - Fix: Validate ISO format, throw error with example
182
+
183
+ #### Minor
184
+ 1. **Progress indicators**
185
+ - File: indexer.ts:130
186
+ - Issue: No "X of Y" counter for long operations
187
+ - Impact: Users don't know how long to wait
188
+
189
+ ### Recommendations
190
+ - Add progress reporting for user experience
191
+ - Consider config file for excluded projects (portability)
192
+
193
+ ### Assessment
194
+
195
+ **Ready to merge: With fixes**
196
+
197
+ **Reasoning:** Core implementation is solid with good architecture and tests. Important issues (help text, date validation) are easily fixed and don't affect core functionality.
198
+ ```
@@ -0,0 +1,170 @@
1
+ ---
2
+ name: using-git-worktrees
3
+ description: Use when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback
4
+ category: engineering-method
5
+ source: superpowers
6
+ date_added: "2026-09-25"
7
+ ---
8
+
9
+ # Using Git Worktrees
10
+
11
+ ## Overview
12
+
13
+ Ensure work happens in an isolated workspace. Prefer your platform's native worktree tools. Fall back to manual git worktrees only when no native tool is available.
14
+
15
+ **Core principle:** Detect existing isolation first. Then use native tools. Then fall back to git. Never fight the harness.
16
+
17
+ **Announce at start:** "I'm using the using-git-worktrees skill to set up an isolated workspace."
18
+
19
+ ## Step 0: Detect Existing Isolation
20
+
21
+ **Before creating anything, check if you are already in an isolated workspace.**
22
+
23
+ ```bash
24
+ GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
25
+ GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
26
+ BRANCH=$(git branch --show-current)
27
+ ```
28
+
29
+ **Submodule guard:** `GIT_DIR != GIT_COMMON` is also true inside git submodules. Before concluding "already in a worktree," verify you are not in a submodule:
30
+
31
+ ```bash
32
+ # If this returns a path, you're in a submodule, not a worktree — treat as normal repo
33
+ git rev-parse --show-superproject-working-tree 2>/dev/null
34
+ ```
35
+
36
+ **If `GIT_DIR != GIT_COMMON` (and not a submodule):** You are already in a linked worktree. Skip to Step 2 (Project Setup). Do NOT create another worktree.
37
+
38
+ Report with branch state:
39
+ - On a branch: "Already in isolated workspace at `<path>` on branch `<name>`."
40
+ - Detached HEAD: "Already in isolated workspace at `<path>` (detached HEAD, externally managed). Branch creation needed at finish time."
41
+
42
+ **If `GIT_DIR == GIT_COMMON` (or in a submodule):** You are in a normal repo checkout.
43
+
44
+ Has the user already indicated their worktree preference in your instructions? If not, ask for consent before creating a worktree:
45
+
46
+ > "Would you like me to set up an isolated worktree? It protects your current branch from changes."
47
+
48
+ Honor any existing declared preference without asking. If the user declines consent, work in place and skip to Step 2.
49
+
50
+ ## Step 1: Create Isolated Workspace
51
+
52
+ **You have two mechanisms. Try them in this order.**
53
+
54
+ ### 1a. Native Worktree Tools (preferred)
55
+
56
+ The user has asked for an isolated workspace (Step 0 consent). Do you already have a way to create a worktree? It might be a tool with a name like `EnterWorktree`, `WorktreeCreate`, a `/worktree` command, or a `--worktree` flag. If you do, use it and skip to Step 2.
57
+
58
+ Native tools handle directory placement, branch creation, and cleanup automatically. Using `git worktree add` when you have a native tool creates phantom state your harness can't see or manage.
59
+
60
+ Only proceed to Step 1b if you have no native worktree tool available.
61
+
62
+ ### 1b. Git Worktree Fallback
63
+
64
+ **Only use this if Step 1a does not apply** — you have no native worktree tool available. Create a worktree manually using git.
65
+
66
+ #### Directory Selection
67
+
68
+ Follow this priority order. Explicit user preference always beats observed filesystem state.
69
+
70
+ 1. **Check your instructions for a declared worktree directory preference.** If the user has already specified one, use it without asking.
71
+
72
+ 2. **Check for an existing project-local worktree directory:**
73
+ ```bash
74
+ ls -d .worktrees 2>/dev/null # Preferred (hidden)
75
+ ls -d worktrees 2>/dev/null # Alternative
76
+ ```
77
+ If found, use it. If both exist, `.worktrees` wins.
78
+
79
+ 3. **If there is no other guidance available**, default to `.worktrees/` at the project root.
80
+
81
+ #### Safety Verification (project-local directories only)
82
+
83
+ **MUST verify directory is ignored before creating worktree:**
84
+
85
+ ```bash
86
+ git check-ignore -q .worktrees 2>/dev/null || git check-ignore -q worktrees 2>/dev/null
87
+ ```
88
+
89
+ **If NOT ignored:** Add to .gitignore, commit the change, then proceed.
90
+
91
+ **Why critical:** Prevents accidentally committing worktree contents to repository.
92
+
93
+ #### Create the Worktree
94
+
95
+ ```bash
96
+ # Determine path based on chosen location
97
+ path="$LOCATION/$BRANCH_NAME"
98
+
99
+ git worktree add "$path" -b "$BRANCH_NAME"
100
+ cd "$path"
101
+ ```
102
+
103
+ **Sandbox fallback:** If `git worktree add` fails with a permission error (sandbox denial), tell the user the sandbox blocked worktree creation and you're working in the current directory instead. Then run setup and baseline tests in place.
104
+
105
+ ## Step 2: Project Setup
106
+
107
+ Auto-detect and run appropriate setup:
108
+
109
+ ```bash
110
+ # Node.js
111
+ if [ -f package.json ]; then npm install; fi
112
+
113
+ # Rust
114
+ if [ -f Cargo.toml ]; then cargo build; fi
115
+
116
+ # Python
117
+ if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
118
+ if [ -f pyproject.toml ]; then poetry install; fi
119
+
120
+ # Go
121
+ if [ -f go.mod ]; then go mod download; fi
122
+ ```
123
+
124
+ ## Step 3: Verify Clean Baseline
125
+
126
+ Run tests to ensure workspace starts clean:
127
+
128
+ ```bash
129
+ # Use project-appropriate command
130
+ npm test / cargo test / pytest / go test ./...
131
+ ```
132
+
133
+ **If tests fail:** Report failures, ask whether to proceed or investigate.
134
+
135
+ **If tests pass:** Report ready.
136
+
137
+ ### Report
138
+
139
+ ```
140
+ Worktree ready at <full-path>
141
+ Tests passing (<N> tests, 0 failures)
142
+ Ready to implement <feature-name>
143
+ ```
144
+
145
+ ## Quick Reference
146
+
147
+ | Situation | Action |
148
+ |-----------|--------|
149
+ | Already in linked worktree | Skip creation (Step 0) |
150
+ | In a submodule | Treat as normal repo (Step 0 guard) |
151
+ | Native worktree tool available | Use it (Step 1a) |
152
+ | No native tool | Git worktree fallback (Step 1b) |
153
+ | `.worktrees/` exists | Use it (verify ignored) |
154
+ | `worktrees/` exists | Use it (verify ignored) |
155
+ | Both exist | Use `.worktrees/` |
156
+ | Neither exists | Check instruction file, then default `.worktrees/` |
157
+ | Directory not ignored | Add to .gitignore + commit |
158
+ | Permission error on create | Sandbox fallback, work in place |
159
+ | Tests fail during baseline | Report failures + ask |
160
+ | No package.json/Cargo.toml | Skip dependency install |
161
+
162
+ ## Common Rationalizations
163
+
164
+ | Excuse | Reality |
165
+ |--------|---------|
166
+ | "I'm obviously not in a worktree — no need to check" | Run Step 0. Harness-created isolation and submodules both fool eyeballing; the detection commands settle it. |
167
+ | "`git worktree add` is quicker than hunting for a native tool" | A native tool (e.g. `EnterWorktree`) owns placement, branching, and cleanup. Bypassing it is the #1 mistake — it creates phantom state your harness can't see or manage. |
168
+ | "The worktree directory is surely ignored already" | Run `git check-ignore`. An unignored worktree directory commits the whole tree into the repo. |
169
+ | "Any directory name works" | Explicit instructions beat an existing project-local directory, which beats the `.worktrees/` default. |
170
+ | "The workspace is fresh — baseline tests can wait" | A dirty baseline makes every later failure ambiguous. Run the tests now; proceeding past failures is your human partner's call. |
@@ -0,0 +1,123 @@
1
+ ---
2
+ name: verification-before-completion
3
+ description: Use when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always
4
+ category: engineering-method
5
+ source: superpowers
6
+ date_added: "2026-09-25"
7
+ ---
8
+
9
+ # Verification Before Completion
10
+
11
+ ## Overview
12
+
13
+ **Core principle:** Evidence before claims, always.
14
+
15
+ **Violating the letter of this rule is violating the spirit of this rule.**
16
+
17
+ ## The Iron Law
18
+
19
+ ```
20
+ NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE
21
+ ```
22
+
23
+ If you haven't run the verification command in this message, you cannot claim it passes.
24
+
25
+ ## The Gate Function
26
+
27
+ ```
28
+ BEFORE claiming any status or expressing satisfaction:
29
+
30
+ 1. IDENTIFY: What command proves this claim?
31
+ 2. RUN: Execute the FULL command (fresh, complete)
32
+ 3. READ: Full output, check exit code, count failures
33
+ 4. VERIFY: Does output confirm the claim?
34
+ - If NO: State actual status with evidence
35
+ - If YES: State claim WITH evidence
36
+ 5. ONLY THEN: Make the claim
37
+
38
+ Skip any step = lying, not verifying
39
+ ```
40
+
41
+ ## Common Failures
42
+
43
+ | Claim | Requires | Not Sufficient |
44
+ |-------|----------|----------------|
45
+ | Tests pass | Test command output: 0 failures | Previous run, "should pass" |
46
+ | Linter clean | Linter output: 0 errors | Partial check, extrapolation |
47
+ | Build succeeds | Build command: exit 0 | Linter passing, logs look good |
48
+ | Bug fixed | Test original symptom: passes | Code changed, assumed fixed |
49
+ | Regression test works | Red-green cycle verified | Test passes once |
50
+ | Agent completed | VCS diff shows changes | Agent reports "success" |
51
+ | Requirements met | Line-by-line checklist | Tests passing |
52
+
53
+ ## Red Flags - STOP
54
+
55
+ - Using "should", "probably", "seems to"
56
+ - Expressing satisfaction before verification ("Great!", "Perfect!", "Done!", etc.)
57
+ - About to commit/push/PR without verification
58
+ - Trusting agent success reports
59
+ - Relying on partial verification
60
+ - Thinking "just this once"
61
+ - Tired and wanting work over
62
+ - **ANY wording implying success without having run verification**
63
+
64
+ ## Rationalization Prevention
65
+
66
+ | Excuse | Reality |
67
+ |--------|---------|
68
+ | "Should work now" | RUN the verification |
69
+ | "I'm confident" | Confidence ≠ evidence |
70
+ | "Just this once" | No exceptions |
71
+ | "Linter passed" | Linter ≠ compiler |
72
+ | "Agent said success" | Verify independently |
73
+ | "I'm tired" | Exhaustion ≠ excuse |
74
+ | "Partial check is enough" | Partial proves nothing |
75
+ | "Different words so rule doesn't apply" | Spirit over letter |
76
+
77
+ ## Key Patterns
78
+
79
+ **Tests:**
80
+ ```
81
+ ✅ [Run test command] [See: 34/34 pass] "All tests pass"
82
+ ❌ "Should pass now" / "Looks correct"
83
+ ```
84
+
85
+ **Regression tests (TDD Red-Green):**
86
+ ```
87
+ ✅ Write → Run (pass) → Revert fix → Run (MUST FAIL) → Restore → Run (pass)
88
+ ❌ "I've written a regression test" (without red-green verification)
89
+ ```
90
+
91
+ **Build:**
92
+ ```
93
+ ✅ [Run build] [See: exit 0] "Build passes"
94
+ ❌ "Linter passed" (linter doesn't check compilation)
95
+ ```
96
+
97
+ **Requirements:**
98
+ ```
99
+ ✅ Re-read plan → Create checklist → Verify each → Report gaps or completion
100
+ ❌ "Tests pass, phase complete"
101
+ ```
102
+
103
+ **Agent delegation:**
104
+ ```
105
+ ✅ Agent reports success → Check VCS diff → Verify changes → Report actual state
106
+ ❌ Trust agent report
107
+ ```
108
+
109
+ ## When To Apply
110
+
111
+ **ALWAYS before:**
112
+ - ANY variation of success/completion claims
113
+ - ANY expression of satisfaction
114
+ - ANY positive statement about work state
115
+ - Committing, PR creation, task completion
116
+ - Moving to next task
117
+ - Delegating to agents
118
+
119
+ **Rule applies to:**
120
+ - Exact phrases
121
+ - Paraphrases and synonyms
122
+ - Implications of success
123
+ - ANY communication suggesting completion/correctness