@huseynsnmz/pi-modes 0.1.3 → 0.1.4

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.1.4]
+
+### Fixed
+
+- Fixed a false "Auto has no permission judge" warning when `pi-permission-classifier` loads after `pi-permission-system`, where it only registers during the first prompt.
+- Moved the "could not take control" check to after every extension has had the chance to register.
+
 ## [0.1.3]
 
 ### Changed

package/README.md

@@ -20,7 +20,7 @@ Requires Pi 1.5 or newer.
 1. Install it:
 
    ```bash
-   pi install npm:@huseynsnmz/pi-modes@0.1.3
+   pi install npm:@huseynsnmz/pi-modes@0.1.4
    ```
 
 2. Move it above `@gotgenes/pi-permission-system`, because `pi install` adds packages last. Otherwise, in `plan` and `read-only` you may be asked to approve an action that is then blocked anyway. It stays blocked either way, and the extension warns you at startup. Skip this step if you don't use that package.
@@ -39,7 +39,7 @@ Requires Pi 1.5 or newer.
 
 4. Restart Pi. The footer shows `mode: normal`, and `Shift+Tab` changes the mode.
 
-To install from git instead, use `pi install git:github.com/huseynsnmz/pi-modes@v0.1.3`.
+To install from git instead, use `pi install git:github.com/huseynsnmz/pi-modes@v0.1.4`.
 
 ## Commands
 
@@ -67,7 +67,7 @@ In plan mode the agent calls the `submit_plan` tool. You then choose one of:
 
 **`@gotgenes/pi-permission-system`:** still runs in every mode. This extension only adds restrictions, so a `deny` rule always wins.
 
-**`pi-permission-classifier`:** runs only in `auto`. In every other mode it defers, and the request goes to your normal prompt. Set it up as its README describes, with `permission-judge` in `authorizerChain`. Its `perm-judge:` footer entry stays visible in all modes, so go by the `mode:` entry.
+**`pi-permission-classifier`:** runs only in `auto`. In every other mode it defers, and the request goes to your normal prompt. Set it up as its README describes, with `permission-judge` in `authorizerChain`. Its `perm-judge:` footer entry stays visible in all modes, so go by the `mode:` entry. If the classifier is listed after `pi-permission-system`, it only registers during your first prompt, and `auto` starts working from then on.
 
 Without a classifier, `auto` behaves like `normal`, and the extension warns you when you switch to it.
 
@@ -104,7 +104,7 @@ The end-to-end test drives real Pi in a real terminal against a fake model, usin
 
 ```bash
 npm run e2e:solo   # only this extension
-npm run e2e        # with the five packages it was built for, in both load orders
+npm run e2e        # with the five packages it was built for, in three load orders
 ```
 
 `npm run e2e` installs those packages from npm with scripts disabled, then starts them.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@huseynsnmz/pi-modes",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "Shift+Tab permission modes for Pi: normal, auto, plan and read-only",
   "type": "module",
   "license": "MIT",
@@ -32,7 +32,7 @@
     "check": "tsc --noEmit",
     "test": "node --test test/*.test.ts",
     "e2e:solo": "python3 test/e2e/run.py solo",
-    "e2e": "python3 test/e2e/run.py modes-first && python3 test/e2e/run.py modes-last"
+    "e2e": "python3 test/e2e/run.py modes-first && python3 test/e2e/run.py modes-last && python3 test/e2e/run.py classifier-last"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": "*",

package/src/index.ts

@@ -69,7 +69,9 @@ export default function piModes(pi: ExtensionAPI): void {
     apply(next, ctx);
     pi.appendEntry(ENTRY_TYPE, { mode: next });
     if (!ctx.hasUI) return;
-    if (next === "auto" && !judgeGated(ctx.sessionManager.getSessionId())) {
+    // A judge named in the chain may not have registered yet: some load orders
+    // only register it during the first prompt. agent_start checks that case.
+    if (next === "auto" && !judgeGated(ctx.sessionManager.getSessionId()) && !chainNamesJudge()) {
       ctx.ui.notify(
         "Auto has no permission judge, so it behaves like normal. Set up pi-permission-classifier to use it.",
         "warning",
@@ -102,8 +104,10 @@ export default function piModes(pi: ExtensionAPI): void {
     clearGate(ctx.sessionManager.getSessionId());
   });
 
-  pi.on("before_agent_start", (event, ctx) => {
-    warnIfJudgeUncontrolled(ctx);
+  // Runs after every before_agent_start handler, which is the judge's last chance to register.
+  pi.on("agent_start", (_event, ctx) => warnIfJudgeUncontrolled(ctx));
+
+  pi.on("before_agent_start", (event) => {
     const prompt = modePrompt(mode);
     return prompt ? { systemPrompt: `${event.systemPrompt}\n\n${prompt}` } : undefined;
   });