@humanbased/crosscheck 1.2.0-beta.80 → 1.2.0

package/assets/skills/code-review-skill/scripts/test_pr_analyzer.py

@@ -1,380 +0,0 @@
-#!/usr/bin/env python3
-"""Tests for pr-analyzer.py (stdlib unittest, no extra deps)."""
-
-import importlib.util
-import os
-import unittest
-
-# The script has a hyphen in its name, so load it by path.
-_HERE = os.path.dirname(os.path.abspath(__file__))
-_spec = importlib.util.spec_from_file_location(
-    'pr_analyzer', os.path.join(_HERE, 'pr-analyzer.py')
-)
-pr_analyzer = importlib.util.module_from_spec(_spec)
-_spec.loader.exec_module(pr_analyzer)
-
-# Convenient aliases
-FileStats = pr_analyzer.FileStats
-
-
-# ═══════════════════════════════════════════════════════════════
-# parse_diff — filename extraction (existing tests)
-# ═══════════════════════════════════════════════════════════════
-
-class ParseDiffFilenameTest(unittest.TestCase):
-    def test_lib_prefixed_path(self):
-        # "lib/" embeds a literal "b/" that the old regex swallowed.
-        diff = (
-            "diff --git a/lib/foo.py b/lib/foo.py\n"
-            "index 1234567..89abcde 100644\n"
-            "--- a/lib/foo.py\n"
-            "+++ b/lib/foo.py\n"
-            "@@ -1,2 +1,3 @@\n"
-            " unchanged\n"
-            "+added line\n"
-            "-removed line\n"
-        )
-        files = pr_analyzer.parse_diff(diff)
-        self.assertEqual(len(files), 1)
-        self.assertEqual(files[0].filename, 'lib/foo.py')
-        self.assertEqual(files[0].additions, 1)
-        self.assertEqual(files[0].deletions, 1)
-
-    def test_normal_path(self):
-        diff = (
-            "diff --git a/src/main.py b/src/main.py\n"
-            "index 1111111..2222222 100644\n"
-            "--- a/src/main.py\n"
-            "+++ b/src/main.py\n"
-            "@@ -0,0 +1 @@\n"
-            "+print('hi')\n"
-        )
-        files = pr_analyzer.parse_diff(diff)
-        self.assertEqual(len(files), 1)
-        self.assertEqual(files[0].filename, 'src/main.py')
-
-    def test_other_embedded_b_slash_prefixes(self):
-        # web/ and db/ also contain a literal "b/".
-        diff = (
-            "diff --git a/web/x.js b/web/x.js\n"
-            "+++ b/web/x.js\n"
-            "+console.log(1)\n"
-            "diff --git a/db/y.sql b/db/y.sql\n"
-            "+++ b/db/y.sql\n"
-            "+SELECT 1;\n"
-        )
-        files = pr_analyzer.parse_diff(diff)
-        self.assertEqual([f.filename for f in files], ['web/x.js', 'db/y.sql'])
-
-    def test_rename_falls_back_to_b_side(self):
-        diff = (
-            "diff --git a/old/name.py b/new/name.py\n"
-            "similarity index 100%\n"
-            "rename from old/name.py\n"
-            "rename to new/name.py\n"
-        )
-        files = pr_analyzer.parse_diff(diff)
-        self.assertEqual(len(files), 1)
-        self.assertEqual(files[0].filename, 'new/name.py')
-
-
-# ═══════════════════════════════════════════════════════════════
-# detect_language
-# ═══════════════════════════════════════════════════════════════
-
-class DetectLanguageTest(unittest.TestCase):
-    def test_common_extensions(self):
-        cases = {
-            'app.py': 'Python',
-            'index.ts': 'TypeScript',
-            'main.rs': 'Rust',
-            'handler.go': 'Go',
-            'App.java': 'Java',
-            'Activity.kt': 'Kotlin',
-            'ViewController.swift': 'Swift',
-            'app.tsx': 'TypeScript/React',
-            'style.css': 'CSS',
-            'query.sql': 'SQL',
-        }
-        for filename, expected in cases.items():
-            with self.subTest(filename=filename):
-                self.assertEqual(pr_analyzer.detect_language(filename), expected)
-
-    def test_unknown_extension(self):
-        self.assertEqual(pr_analyzer.detect_language('data.xyz'), 'unknown')
-        self.assertEqual(pr_analyzer.detect_language('Makefile'), 'unknown')
-
-    def test_cpp_variants(self):
-        for ext in ('.cpp', '.hpp', '.cc', '.cxx', '.hh', '.hxx'):
-            with self.subTest(ext=ext):
-                self.assertEqual(pr_analyzer.detect_language(f'file{ext}'), 'C++')
-
-
-# ═══════════════════════════════════════════════════════════════
-# is_test_file
-# ═══════════════════════════════════════════════════════════════
-
-class IsTestFileTest(unittest.TestCase):
-    def test_python_test_prefix(self):
-        self.assertTrue(pr_analyzer.is_test_file('tests/test_handler.py'))
-        self.assertTrue(pr_analyzer.is_test_file('test_utils.py'))
-
-    def test_python_test_suffix(self):
-        self.assertTrue(pr_analyzer.is_test_file('handler_test.py'))
-
-    def test_rust_test_suffix(self):
-        self.assertTrue(pr_analyzer.is_test_file('src/my_module_test.rs'))
-        self.assertTrue(pr_analyzer.is_test_file('parser_test.rs'))
-
-    def test_go_test_suffix(self):
-        self.assertTrue(pr_analyzer.is_test_file('handler_test.go'))
-        self.assertTrue(pr_analyzer.is_test_file('pkg/auth_test.go'))
-
-    def test_js_ts_test_and_spec(self):
-        self.assertTrue(pr_analyzer.is_test_file('handler.test.ts'))
-        self.assertTrue(pr_analyzer.is_test_file('utils.spec.js'))
-        self.assertTrue(pr_analyzer.is_test_file('App.test.tsx'))
-
-    def test_tests_directory(self):
-        self.assertTrue(pr_analyzer.is_test_file('tests/conftest.py'))
-        self.assertTrue(pr_analyzer.is_test_file('test/helpers.js'))
-
-    def test_dunder_tests_directory(self):
-        self.assertTrue(pr_analyzer.is_test_file('__tests__/Button.test.tsx'))
-
-    def test_non_test_files_rejected(self):
-        self.assertFalse(pr_analyzer.is_test_file('handler.go'))
-        self.assertFalse(pr_analyzer.is_test_file('module.rs'))
-        self.assertFalse(pr_analyzer.is_test_file('src/utils.py'))
-        self.assertFalse(pr_analyzer.is_test_file('lib/parser.js'))
-        self.assertFalse(pr_analyzer.is_test_file('contest.py'))
-
-    def test_test_substring_not_matched(self):
-        """Files containing 'test_' as substring must NOT be flagged."""
-        self.assertFalse(pr_analyzer.is_test_file('latest_report.py'))
-        self.assertFalse(pr_analyzer.is_test_file('contest_utils.py'))
-        self.assertFalse(pr_analyzer.is_test_file('src/latest_handler.py'))
-
-
-# ═══════════════════════════════════════════════════════════════
-# is_config_file
-# ═══════════════════════════════════════════════════════════════
-
-class IsConfigFileTest(unittest.TestCase):
-    def test_known_json_configs(self):
-        self.assertTrue(pr_analyzer.is_config_file('package.json'))
-        self.assertTrue(pr_analyzer.is_config_file('tsconfig.json'))
-        self.assertTrue(pr_analyzer.is_config_file('.eslintrc.json'))
-
-    def test_known_yaml_configs(self):
-        self.assertTrue(pr_analyzer.is_config_file('docker-compose.yml'))
-        self.assertTrue(pr_analyzer.is_config_file('.github/workflows/ci.yml'))
-        self.assertTrue(pr_analyzer.is_config_file('.prettierrc.yml'))
-
-    def test_known_toml_configs(self):
-        self.assertTrue(pr_analyzer.is_config_file('Cargo.toml'))
-        self.assertTrue(pr_analyzer.is_config_file('pyproject.toml'))
-
-    def test_env_files(self):
-        self.assertTrue(pr_analyzer.is_config_file('.env'))
-        self.assertTrue(pr_analyzer.is_config_file('.env.local'))
-        self.assertTrue(pr_analyzer.is_config_file('.env.production'))
-
-    def test_config_in_filename(self):
-        self.assertTrue(pr_analyzer.is_config_file('app.config.ts'))
-        self.assertTrue(pr_analyzer.is_config_file('database_config.yml'))
-
-    def test_data_files_rejected(self):
-        """Data files must NOT be flagged as config."""
-        self.assertFalse(pr_analyzer.is_config_file('data.json'))
-        self.assertFalse(pr_analyzer.is_config_file('openapi.yaml'))
-        self.assertFalse(pr_analyzer.is_config_file('swagger.json'))
-        self.assertFalse(pr_analyzer.is_config_file('fixtures/sample.yml'))
-        self.assertFalse(pr_analyzer.is_config_file('translations.json'))
-        self.assertFalse(pr_analyzer.is_config_file('schema.toml'))
-
-    def test_config_directory(self):
-        self.assertTrue(pr_analyzer.is_config_file('config/settings.yaml'))
-        self.assertTrue(pr_analyzer.is_config_file('config/database.yml'))
-        self.assertTrue(pr_analyzer.is_config_file('src/config/settings.json'))
-
-    def test_source_files_rejected(self):
-        self.assertFalse(pr_analyzer.is_config_file('src/index.ts'))
-        self.assertFalse(pr_analyzer.is_config_file('lib/utils.py'))
-
-
-# ═══════════════════════════════════════════════════════════════
-# calculate_complexity
-# ═══════════════════════════════════════════════════════════════
-
-class CalculateComplexityTest(unittest.TestCase):
-    def test_empty_files(self):
-        self.assertEqual(pr_analyzer.calculate_complexity([]), 0.0)
-
-    def test_small_simple_change(self):
-        files = [FileStats(filename='app.py', additions=5, deletions=2,
-                           language='Python')]
-        score = pr_analyzer.calculate_complexity(files)
-        self.assertLess(score, 0.3)
-
-    def test_large_multi_language_change(self):
-        files = [
-            FileStats(filename='app.py', additions=300, deletions=100, language='Python'),
-            FileStats(filename='main.rs', additions=200, deletions=50, language='Rust'),
-            FileStats(filename='index.ts', additions=150, deletions=80, language='TypeScript'),
-            FileStats(filename='handler.go', additions=100, deletions=30, language='Go'),
-            FileStats(filename='App.tsx', additions=50, deletions=20, language='TypeScript/React'),
-        ]
-        score = pr_analyzer.calculate_complexity(files)
-        self.assertGreater(score, 0.5)
-
-    def test_test_heavy_change_is_lower(self):
-        """Changes with high test ratio should have lower complexity."""
-        prod_files = [FileStats(filename='app.py', additions=100, deletions=50,
-                                language='Python')]
-        test_files = [
-            FileStats(filename='app.py', additions=100, deletions=50,
-                      language='Python'),
-            FileStats(filename='tests/test_app.py', additions=100, deletions=0,
-                      language='Python', is_test=True),
-        ]
-        score_prod = pr_analyzer.calculate_complexity(prod_files)
-        score_test = pr_analyzer.calculate_complexity(test_files)
-        self.assertLess(score_test, score_prod)
-
-
-# ═══════════════════════════════════════════════════════════════
-# identify_risk_factors
-# ═══════════════════════════════════════════════════════════════
-
-class IdentifyRiskFactorsTest(unittest.TestCase):
-    def test_large_pr_flagged(self):
-        files = [FileStats(filename='big.py', additions=300, deletions=200,
-                           language='Python')]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertTrue(any('Large PR' in r for r in risks))
-
-    def test_no_tests_flagged(self):
-        files = [FileStats(filename='app.py', additions=40, deletions=20,
-                           language='Python')]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertTrue(any(pr_analyzer.RISK_NO_TESTS in r for r in risks))
-
-    def test_with_tests_not_flagged(self):
-        files = [
-            FileStats(filename='app.py', additions=40, deletions=20,
-                      language='Python'),
-            FileStats(filename='tests/test_app.py', additions=30, deletions=0,
-                      language='Python', is_test=True),
-        ]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertFalse(any(pr_analyzer.RISK_NO_TESTS in r for r in risks))
-
-    def test_security_sensitive_file(self):
-        files = [FileStats(filename='src/auth/login.py', additions=10, deletions=5,
-                           language='Python')]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertTrue(any('Security-sensitive' in r for r in risks))
-
-    def test_database_migration(self):
-        files = [FileStats(filename='migrations/001_init.sql', additions=20, deletions=0,
-                           language='SQL')]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertTrue(any('Database' in r for r in risks))
-
-    def test_test_substring_files_still_flag_no_tests(self):
-        """Files like latest_report.py must not suppress NO_TEST_CHANGES."""
-        files = [
-            FileStats(filename='latest_report.py', additions=40, deletions=20,
-                      language='Python'),
-            FileStats(filename='contest_utils.py', additions=30, deletions=10,
-                      language='Python'),
-        ]
-        risks = pr_analyzer.identify_risk_factors(files)
-        self.assertTrue(any(pr_analyzer.RISK_NO_TESTS in r for r in risks))
-
-
-# ═══════════════════════════════════════════════════════════════
-# generate_suggestions
-# ═══════════════════════════════════════════════════════════════
-
-class GenerateSuggestionsTest(unittest.TestCase):
-    def test_returns_list(self):
-        files = [FileStats(filename='app.py', additions=10, deletions=5,
-                           language='Python')]
-        result = pr_analyzer.generate_suggestions(files, 0.1, [])
-        self.assertIsInstance(result, list)
-        self.assertGreater(len(result), 0)
-
-    def test_large_pr_split_suggestion(self):
-        files = [FileStats(filename='big.py', additions=600, deletions=300,
-                           language='Python')]
-        result = pr_analyzer.generate_suggestions(files, 0.3, [])
-        self.assertTrue(any('splitting' in s.lower() for s in result))
-
-    def test_no_tests_suggestion(self):
-        files = [FileStats(filename='app.py', additions=40, deletions=20,
-                           language='Python')]
-        risks = [f"{pr_analyzer.RISK_NO_TESTS}: no tests"]
-        result = pr_analyzer.generate_suggestions(files, 0.2, risks)
-        self.assertTrue(any('test' in s.lower() for s in result))
-
-    def test_rust_suggestion(self):
-        files = [FileStats(filename='lib.rs', additions=10, deletions=5,
-                           language='Rust')]
-        result = pr_analyzer.generate_suggestions(files, 0.1, [])
-        self.assertTrue(any('unwrap' in s.lower() for s in result))
-
-
-# ═══════════════════════════════════════════════════════════════
-# analyze_pr — end-to-end integration
-# ═══════════════════════════════════════════════════════════════
-
-class AnalyzePRTest(unittest.TestCase):
-    def test_end_to_end(self):
-        diff = (
-            "diff --git a/src/app.py b/src/app.py\n"
-            "index 1111111..2222222 100644\n"
-            "--- a/src/app.py\n"
-            "+++ b/src/app.py\n"
-            "@@ -1,3 +1,5 @@\n"
-            " import os\n"
-            "+import sys\n"
-            "+import json\n"
-            " def main():\n"
-            "+    print('hello')\n"
-            "+    return 0\n"
-            "diff --git a/tests/test_app.py b/tests/test_app.py\n"
-            "new file mode 100644\n"
-            "--- /dev/null\n"
-            "+++ b/tests/test_app.py\n"
-            "@@ -0,0 +1,3 @@\n"
-            "+from app import main\n"
-            "+def test_main():\n"
-            "+    assert main() == 0\n"
-        )
-        analysis = pr_analyzer.analyze_pr(diff)
-
-        self.assertEqual(analysis.total_files, 2)
-        self.assertEqual(analysis.total_additions, 7)  # 4 + 3
-        self.assertEqual(analysis.total_deletions, 0)
-        self.assertGreater(len(analysis.suggestions), 0)
-        self.assertIn('XS (Extra Small)', analysis.size_category)
-
-        # Verify test file was detected
-        test_file = [f for f in analysis.files if 'test' in f.filename][0]
-        self.assertTrue(test_file.is_test)
-
-        # Verify no "NO_TEST_CHANGES" risk since tests are present
-        self.assertFalse(
-            any(pr_analyzer.RISK_NO_TESTS in r for r in analysis.risk_factors)
-        )
-
-    def test_empty_diff(self):
-        analysis = pr_analyzer.analyze_pr("")
-        self.assertEqual(analysis.total_files, 0)
-        self.assertEqual(analysis.complexity_score, 0.0)
-
-
-if __name__ == '__main__':
-    unittest.main()

package/assets/skills/codebase-design/.crosscheck-skill.json

@@ -1,9 +0,0 @@
-{
-  "schemaVersion": 1,
-  "name": "codebase-design",
-  "author": "mattpocock",
-  "license": "MIT",
-  "source": "https://github.com/mattpocock/skills",
-  "revision": "2ab958093e83e0ec752e6c1c5932da465bf23e0c",
-  "integrity": "sha256:de9cabc2c28f4597fd9534e734974ffbdf1713f6a8411aa1ea87d602fc956e82"
-}

package/assets/skills/codebase-design/DEEPENING.md

@@ -1,37 +0,0 @@
-# Deepening
-
-How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md) — **module**, **interface**, **seam**, **adapter**.
-
-## Dependency categories
-
-When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
-
-### 1. In-process
-
-Pure computation, in-memory state, no I/O. Always deepenable — merge the modules and test through the new interface directly. No adapter needed.
-
-### 2. Local-substitutable
-
-Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
-
-### 3. Remote but owned (Ports & Adapters)
-
-Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
-
-Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
-
-### 4. True external (Mock)
-
-Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
-
-## Seam discipline
-
-- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
-- **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
-
-## Testing strategy: replace, don't layer
-
-- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist — delete them.
-- Write new tests at the deepened module's interface. The **interface is the test surface**.
-- Tests assert on observable outcomes through the interface, not internal state.
-- Tests should survive internal refactors — they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.

package/assets/skills/codebase-design/DESIGN-IT-TWICE.md

@@ -1,44 +0,0 @@
-# Design It Twice
-
-When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout) — your first idea is unlikely to be the best.
-
-Uses the vocabulary in [SKILL.md](SKILL.md) — **module**, **interface**, **seam**, **adapter**, **leverage**.
-
-## Process
-
-### 1. Frame the problem space
-
-Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
-
-- The constraints any new interface would need to satisfy
-- The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md))
-- A rough illustrative code sketch to ground the constraints — not a proposal, just a way to make the constraints concrete
-
-Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
-
-### 2. Spawn sub-agents
-
-Spawn 3+ sub-agents in parallel using the Agent tool. Each must produce a **radically different** interface for the deepened module.
-
-Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
-
-- Agent 1: "Minimize the interface — aim for 1–3 entry points max. Maximise leverage per entry point."
-- Agent 2: "Maximise flexibility — support many use cases and extension."
-- Agent 3: "Optimise for the most common caller — make the default case trivial."
-- Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
-
-Include both [SKILL.md](SKILL.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
-
-Each sub-agent outputs:
-
-1. Interface (types, methods, params — plus invariants, ordering, error modes)
-2. Usage example showing how callers use it
-3. What the implementation hides behind the seam
-4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md))
-5. Trade-offs — where leverage is high, where it's thin
-
-### 3. Present and compare
-
-Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
-
-After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated — the user wants a strong read, not a menu.

package/assets/skills/codebase-design/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Matt Pocock
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/assets/skills/codebase-design/SKILL.md

@@ -1,114 +0,0 @@
----
-name: codebase-design
-description: Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary.
----
-
-# Codebase Design
-
-Design **deep modules**: a lot of behaviour behind a small interface, placed at a clean seam, testable through that interface. Use this language and these principles wherever code is being designed or restructured. The aim is leverage for callers, locality for maintainers, and testability for everyone.
-
-## Glossary
-
-Use these terms exactly — don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point.
-
-**Module** — anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service.
-
-**Interface** — everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow — they refer only to the type-level surface).
-
-**Implementation** — what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise.
-
-**Depth** — leverage at the interface: the amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation.
-
-**Seam** _(Michael Feathers)_ — a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context).
-
-**Adapter** — a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside).
-
-**Leverage** — what callers get from depth: more capability per unit of interface they learn. One implementation pays back across N call sites and M tests.
-
-**Locality** — what maintainers get from depth: change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere.
-
-## Deep vs shallow
-
-**Deep module** = small interface + lots of implementation:
-
-```
-┌─────────────────────┐
-│   Small Interface   │  ← Few methods, simple params
-├─────────────────────┤
-│                     │
-│  Deep Implementation│  ← Complex logic hidden
-│                     │
-└─────────────────────┘
-```
-
-**Shallow module** = large interface + little implementation (avoid):
-
-```
-┌─────────────────────────────────┐
-│       Large Interface           │  ← Many methods, complex params
-├─────────────────────────────────┤
-│  Thin Implementation            │  ← Just passes through
-└─────────────────────────────────┘
-```
-
-When designing an interface, ask:
-
-- Can I reduce the number of methods?
-- Can I simplify the parameters?
-- Can I hide more complexity inside?
-
-## Principles
-
-- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts — they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface.
-- **The deletion test.** Imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep.
-- **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape.
-- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it.
-
-## Designing for testability
-
-Good interfaces make testing natural:
-
-1. **Accept dependencies, don't create them.**
-
-   ```typescript
-   // Testable
-   function processOrder(order, paymentGateway) {}
-
-   // Hard to test
-   function processOrder(order) {
-     const gateway = new StripeGateway();
-   }
-   ```
-
-2. **Return results, don't produce side effects.**
-
-   ```typescript
-   // Testable
-   function calculateDiscount(cart): Discount {}
-
-   // Hard to test
-   function applyDiscount(cart): void {
-     cart.total -= discount;
-   }
-   ```
-
-3. **Small surface area.** Fewer methods = fewer tests needed. Fewer params = simpler test setup.
-
-## Relationships
-
-- A **Module** has exactly one **Interface** (the surface it presents to callers and tests).
-- **Depth** is a property of a **Module**, measured against its **Interface**.
-- A **Seam** is where a **Module**'s **Interface** lives.
-- An **Adapter** sits at a **Seam** and satisfies the **Interface**.
-- **Depth** produces **Leverage** for callers and **Locality** for maintainers.
-
-## Rejected framings
-
-- **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead.
-- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow — interface here includes every fact a caller must know.
-- **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**.
-
-## Going deeper
-
-- **Deepening a cluster given its dependencies** — see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing.
-- **Exploring alternative interfaces** — see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement.

package/assets/skills/codebase-design/agents/openai.yaml

@@ -1,3 +0,0 @@
-interface:
-  display_name: "Codebase Design"
-  short_description: "Vocabulary for deep-module design"

package/assets/skills/diagnosing-bugs/.crosscheck-skill.json

@@ -1,9 +0,0 @@
-{
-  "schemaVersion": 1,
-  "name": "diagnosing-bugs",
-  "author": "mattpocock",
-  "license": "MIT",
-  "source": "https://github.com/mattpocock/skills",
-  "revision": "2ab958093e83e0ec752e6c1c5932da465bf23e0c",
-  "integrity": "sha256:970eac3fd8742eb4e3e3a3c4320ef84bff928fb253377ff109fcc1ea06cfdd78"
-}

package/assets/skills/diagnosing-bugs/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Matt Pocock
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.