@hubspot/ui-extensions-dev-server 1.0.2 → 1.1.1

package/dist/lib/__tests__/plugins/devBuildPlugin.spec.js

@@ -253,4 +253,93 @@ describe('devBuildPlugin', () => {
             }).not.toThrow();
         });
     });
+    describe('handleBuildError', () => {
+        it('should not crash if websocket is not initialized during configureServer', async () => {
+            // Remove the websocket to simulate it not being initialized yet
+            // @ts-expect-error Setting private property for testing
+            options.devServerState._mutableState.extensionsWebSocket = null;
+            const error = {
+                plugin: 'vite:esbuild',
+                errors: ['build error'],
+                frame: 'Error on this line',
+                loc: { column: 1, line: 5 },
+                id: 'src/file.ts',
+            };
+            vi.mocked(build).mockImplementationOnce(() => {
+                throw error;
+            });
+            // Should not throw even though websocket doesn't exist
+            await expect(
+            // @ts-expect-error TS thinks this isn't a function
+            plugin.configureServer(server)).resolves.not.toThrow();
+            // Verify broadcast was NOT called (since websocket doesn't exist)
+            expect(mockWebSocket.broadcast).not.toHaveBeenCalled();
+        });
+        it('should broadcast error when websocket exists and browser connects', async () => {
+            // Websocket is already set up in beforeEach
+            const error = {
+                plugin: 'vite:esbuild',
+                errors: ['build error'],
+                frame: 'Error on this line',
+                loc: { column: 1, line: 5 },
+                id: 'src/file.ts',
+            };
+            vi.mocked(build).mockImplementationOnce(() => {
+                throw error;
+            });
+            // @ts-expect-error TS thinks this isn't a function
+            await plugin.configureServer(server);
+            options.devServerState.triggerWebSocketSetup();
+            // Get the connection handler
+            const connectionHandler = mockWebSocket.onConnection.mock.calls[0][0];
+            // Simulate browser connection - should broadcast the stored error
+            connectionHandler();
+            expect(mockWebSocket.broadcast).toHaveBeenCalledWith(expect.objectContaining({
+                event: 'error',
+                error: expect.objectContaining({
+                    details: expect.objectContaining({
+                        file: error.id,
+                    }),
+                }),
+            }));
+        });
+        it('should broadcast error after websocket is initialized and browser connects', async () => {
+            // Remove the websocket to simulate it not being initialized yet
+            // @ts-expect-error Setting private property for testing
+            options.devServerState._mutableState.extensionsWebSocket = null;
+            const error = {
+                plugin: 'vite:esbuild',
+                errors: ['build error'],
+                frame: 'Error on this line',
+                loc: { column: 1, line: 5 },
+                id: 'src/file.ts',
+            };
+            vi.mocked(build).mockImplementationOnce(() => {
+                throw error;
+            });
+            // configureServer runs with error, but websocket doesn't exist yet
+            // @ts-expect-error TS thinks this isn't a function
+            await plugin.configureServer(server);
+            // At this point, broadcast should not have been called
+            expect(mockWebSocket.broadcast).not.toHaveBeenCalled();
+            // Now initialize the websocket (simulating what happens in server.ts)
+            // @ts-expect-error Setting private property for testing
+            options.devServerState._mutableState.extensionsWebSocket =
+                mockWebSocket;
+            // Trigger the websocket setup callback
+            options.devServerState.triggerWebSocketSetup();
+            // Get the connection handler
+            const connectionHandler = mockWebSocket.onConnection.mock.calls[0][0];
+            // Simulate browser connection - should NOW broadcast the stored error
+            connectionHandler();
+            expect(mockWebSocket.broadcast).toHaveBeenCalledWith(expect.objectContaining({
+                event: 'error',
+                error: expect.objectContaining({
+                    details: expect.objectContaining({
+                        file: error.id,
+                    }),
+                }),
+            }));
+        });
+    });
 });

package/dist/lib/__tests__/plugins/friendlyLoggingPlugin.spec.js

@@ -59,7 +59,7 @@ describe('friendlyLoggingPlugin', () => {
             });
             expect(result).toBe(false);
             expect(logger.error).toHaveBeenCalledTimes(1);
-            expect(logger.error).toHaveBeenCalledWith('@hubspot/extensions is imported by import.jsx, but @hubspot/extensions cannot be resolved. Make sure @hubspot/extensions is installed.');
+            expect(logger.error).toHaveBeenCalledWith('@hubspot/extensions is imported by import.jsx, but @hubspot/extensions cannot be resolved. Make sure @hubspot/extensions is installed by running `hs project install-deps`.');
         });
     });
 });

package/dist/lib/plugins/friendlyLoggingPlugin.js

@@ -4,7 +4,7 @@ const unfriendlyCodeMapper = Object.freeze({
         const { exporter, id } = loggable;
         const { base: extension } = path.parse(id);
         return {
-            message: `${exporter} is imported by ${extension}, but ${exporter} cannot be resolved. Make sure ${exporter} is installed.`,
+            message: `${exporter} is imported by ${extension}, but ${exporter} cannot be resolved. Make sure ${exporter} is installed by running \`hs project install-deps\`.`,
             level: 'error',
         };
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hubspot/ui-extensions-dev-server",
-  "version": "1.0.2",
+  "version": "1.1.1",
   "description": "",
   "type": "module",
   "bin": {