@hubspot/ui-extensions-dev-server 0.7.1 → 0.7.3-canary.8

package/lib/build.js

@@ -31,8 +31,17 @@ async function buildSingleExtension({
   emptyOutDir = true,
   minify = false,
   root = process.cwd(), // This is the vite default, so using that as our default
+  logger = console,
+  injectOverrides = true,
 }) {
   const output = getUrlSafeFileName(file);
+
+  const plugins = [manifestPlugin({ minify, output, logger })];
+
+  if (injectOverrides) {
+    plugins.push(codeInjectionPlugin({ file }));
+  }
+
   await build({
     root,
     define: {
@@ -49,7 +58,7 @@ async function buildSingleExtension({
       },
       rollupOptions: {
         ...ROLLUP_OPTIONS,
-        plugins: [manifestPlugin({ output }), codeInjectionPlugin({ file })],
+        plugins,
       },
       outDir: outputDir,
       emptyOutDir,
@@ -58,23 +67,26 @@ async function buildSingleExtension({
   });
 }
 
-async function remoteBuild(root, entryPoint, outputDir = OUTPUT_DIR) {
+async function remoteBuild({
+  root,
+  entryPoint,
+  outputDir = OUTPUT_DIR,
+  injectOverrides = true,
+  logger = console,
+}) {
   const fileInfo = path.parse(entryPoint);
 
   if (!allowedExtensions.includes(fileInfo.ext)) {
     throw new Error(`${extensionErrorBaseMessage} ${fileInfo.ext}`);
   }
 
-  const output = getUrlSafeFileName(entryPoint);
   await buildSingleExtension({
     file: entryPoint,
-    outputFileName: output,
     outputDir,
-    plugins: {
-      rollup: [manifestPlugin({ minify: true, output })],
-    },
     minify: true,
     root,
+    logger,
+    injectOverrides,
   });
 }
 

package/lib/dev.js

@@ -29,6 +29,9 @@ async function _createViteDevServer(
         ignored: [
           path.join(outputDir, '/**/*'),
           '**/src/app/app.functions/**/*',
+          '**/app.json',
+          '**/package.json',
+          '**/package-lock.json',
         ],
       },
     },

package/lib/plugins/codeCheckingPlugin.js

@@ -0,0 +1,26 @@
+const fs = require('fs');
+const { logger } = require('@hubspot/cli-lib/logger');
+
+function codeCheckingPlugin(options = {}) {
+  const { output } = options;
+  return {
+    name: 'ui-extensions-code-checking-plugin',
+    enforce: 'post',
+    writeBundle(__options, __bundle) {
+      try {
+        const code = fs.readFileSync(output).toString();
+        if (
+          !code.includes('const extend = (...args) => self.extend(...args);')
+        ) {
+          logger.warn(
+            'Unable to determine if your extension entry point is calling hubspot.extend, this may prevent it from rendering as expected'
+          );
+        }
+      } catch (e) {
+        logger.error('Unable to load bundle for code checking');
+      }
+    },
+  };
+}
+
+module.exports = codeCheckingPlugin;

package/lib/plugins/codeInjectionPlugin.js

@@ -1,16 +1,13 @@
 const path = require('path');
 
-function codeInjectionPlugin(options = {}) {
-  const { file, root = process.cwd() } = options;
+function codeInjectionPlugin() {
   return {
     name: 'ui-extensions-code-injection-plugin',
     enforce: 'post', // run after default rollup plugins
-    transform(code, fileBeingTransformed) {
-      const absoluteFilePath = path.isAbsolute(file)
-        ? file
-        : path.join(root, file);
+    transform(code, file) {
+      const { dir } = path.parse(file);
 
-      if (fileBeingTransformed !== absoluteFilePath) {
+      if (dir.includes('node_modules')) {
         return { code, map: null }; // Not the file we care about, return the same code
       }
 

package/lib/plugins/devBuildPlugin.js

@@ -2,6 +2,8 @@ const { ROLLUP_OPTIONS, WEBSOCKET_MESSAGE_VERSION } = require('../constants');
 const { build } = require('vite');
 const manifestPlugin = require('./manifestPlugin');
 const { stripAnsiColorCodes } = require('../utils');
+const codeCheckingPlugin = require('./codeCheckingPlugin');
+const path = require('path');
 const { logger } = require('@hubspot/cli-lib/logger');
 
 function devBuildPlugin(options = {}) {
@@ -65,6 +67,9 @@ function devBuildPlugin(options = {}) {
                 minify: false,
                 output: extensionConfig.output,
               }),
+              codeCheckingPlugin({
+                output: path.join(outputDir, extensionConfig.output),
+              }),
             ],
             output: {
               ...ROLLUP_OPTIONS.output,

package/package.json

@@ -1,10 +1,11 @@
 {
   "name": "@hubspot/ui-extensions-dev-server",
-  "version": "0.7.1",
+  "version": "0.7.3-canary.8+f0ea707c",
   "description": "",
   "main": "index.js",
   "scripts": {
     "test": "jest",
+    "build": "echo 'no build step for @hubspot/ui-extensions-dev-server'",
     "jest": "jest --watch"
   },
   "publishConfig": {
@@ -32,7 +33,7 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "@hubspot/app-functions-dev-server": "^0.7.0",
+    "@hubspot/app-functions-dev-server": "^0.7.2",
     "@hubspot/cli-lib": "^4.1.6",
     "command-line-args": "^5.2.1",
     "command-line-usage": "^7.0.1",
@@ -67,5 +68,5 @@
       "optional": true
     }
   },
-  "gitHead": "f3c6bfa9f758bdb23179e953a1826d1f0c3bd90f"
+  "gitHead": "f0ea707c3fdcb5cd043e5e34fb82354364ca156b"
 }