@hubspot/project-parsing-lib 0.2.0-experimental.1 → 0.2.0-experimental.3

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@hubspot/project-parsing-lib",
-    "version": "0.2.0-experimental.1",
+    "version": "0.2.0-experimental.3",
     "description": "Parsing library for converting projects directory structures to their intermediate representation",
     "license": "Apache-2.0",
     "type": "module",
@@ -47,8 +47,8 @@
         "@inquirer/prompts": "^7.1.0",
         "@types/node": "^24.9.0",
         "@types/semver": "^7.5.8",
-        "@typescript-eslint/eslint-plugin": "^8.11.0",
-        "@typescript-eslint/parser": "^8.11.0",
+        "@typescript-eslint/eslint-plugin": "8.46.3",
+        "@typescript-eslint/parser": "8.46.3",
         "eslint": "^9.38.0",
         "eslint-plugin-import": "^2.31.0",
         "husky": "^9.1.7",

package/src/lib/constants.js

@@ -36,6 +36,13 @@ const SUB_COMPONENT_FIELDS = {
     userFriendlyType: 'feature',
     userFriendlyTypePlural: 'features',
 };
+const PAGE_COMPONENT = {
+    dir: 'pages',
+    parentComponent: APP_KEY,
+    ...SUB_COMPONENT_FIELDS,
+    userFriendlyName: 'Page',
+    singularComponent: true,
+};
 export const Components = {
     [APP_KEY]: {
         dir: APP_KEY,
@@ -55,20 +62,8 @@ export const Components = {
         ...SUB_COMPONENT_FIELDS,
         userFriendlyName: 'App Object Association',
     },
-    [PAGE_KEY]: {
-        dir: 'pages',
-        parentComponent: APP_KEY,
-        ...SUB_COMPONENT_FIELDS,
-        userFriendlyName: 'Page',
-        singularComponent: true,
-    },
-    [PAGES_KEY]: {
-        dir: 'pages',
-        parentComponent: APP_KEY,
-        ...SUB_COMPONENT_FIELDS,
-        userFriendlyName: 'Pages',
-        singularComponent: true,
-    },
+    [PAGE_KEY]: PAGE_COMPONENT,
+    [PAGES_KEY]: PAGE_COMPONENT,
     [THEME_KEY]: {
         dir: THEME_KEY,
         userFriendlyName: 'Theme',

package/src/lib/migrate.js

@@ -2,7 +2,7 @@ import { walk } from '@hubspot/local-dev-lib/fs';
 import path from 'path';
 import fs from 'fs';
 import { mapToUserFacingType } from './transform.js';
-import { METAFILE_EXTENSION, Components, HS_PROJECT_JSON_FILENAME, } from './constants.js';
+import { METAFILE_EXTENSION, Components, HS_PROJECT_JSON_FILENAME, APP_FUNCTIONS_PACKAGE_KEY, APP_FUNCTIONS_KEY, } from './constants.js';
 import { translate } from './translate.js';
 import { loadJsonFile } from './utils.js';
 const IR_FILENAME = 'ir.json';
@@ -35,20 +35,25 @@ export async function migrate(inputDir, outputDir) {
         const irDirName = path.dirname(filename);
         const IR = loadJsonFile(filename);
         const { metaFilePath } = IR;
-        const projectConfig = convertIRToProjectConfig(IR);
-        const fullOutputPath = path.join(sourceCodeOutputDir, getTargetDirectoryFromComponentType(projectConfig.type));
+        const component = convertIRToProjectConfig(IR);
+        const fullOutputPath = path.join(sourceCodeOutputDir, getTargetDirectoryFromComponentType(component.type));
         // Ensure the output directory exists
         const currentFilesDirectory = path.join(irDirName, filesDirectory);
         ensureDirExists(currentFilesDirectory);
         fs.cpSync(currentFilesDirectory, fullOutputPath, {
             recursive: true,
         });
+        // In the current component is a APP_FUNCTIONS_PACKAGE we don't want to write a hsmeta.json file
+        // since it is an auto generate component
+        if (component.type === APP_FUNCTIONS_PACKAGE_KEY) {
+            return;
+        }
         // Use the metaFilePath if provided, otherwise use the project UID
         const hsmetaFilePath = path.join(fullOutputPath, metaFilePath
             ? path.basename(metaFilePath)
-            : `${projectConfig.uid}${METAFILE_EXTENSION}`);
+            : `${component.uid}${METAFILE_EXTENSION}`);
         // Write the hsmeta file to the output directory
-        fs.writeFileSync(hsmetaFilePath, JSON.stringify(projectConfig, null, 2));
+        fs.writeFileSync(hsmetaFilePath, JSON.stringify(component, null, 2));
     });
     const IR = await translate({
         projectSourceDir: sourceCodeOutputDir,
@@ -78,7 +83,10 @@ function convertIRToProjectConfig(IR) {
     };
 }
 function getTargetDirectoryFromComponentType(componentType) {
-    const component = Components[componentType];
+    let component = Components[componentType];
+    if (componentType === APP_FUNCTIONS_PACKAGE_KEY) {
+        component = Components[APP_FUNCTIONS_KEY];
+    }
     if (!component) {
         throw Error('Unsupported component type');
     }

package/src/lib/project.js

@@ -9,18 +9,25 @@ export async function getProjectMetadata(projectSrcDir) {
     if (fs.existsSync(projectSrcDir)) {
         metafiles = await locateHsMetaFiles(projectSrcDir, { silent: true });
     }
+    const seenComponentPaths = new Map();
     Object.keys(Components).forEach(componentType => {
         const { parentComponent, singularComponent, dir } = Components[componentType];
         const componentPath = path.join(projectSrcDir, parentComponent ? path.join(parentComponent, dir) : dir);
+        if (seenComponentPaths.has(componentPath)) {
+            components[componentType] = seenComponentPaths.get(componentPath);
+            return;
+        }
         const metaFilesByType = metafiles
             .filter(metafile => path.parse(metafile.file).dir === componentPath)
             .map(metaFile => metaFile.file);
-        hsMetaFiles.push(...metaFilesByType);
-        components[componentType] = {
+        const metadata = {
             hsMetaFiles: metaFilesByType,
             count: metaFilesByType.length,
             maxCount: singularComponent ? 1 : Infinity,
         };
+        hsMetaFiles.push(...metaFilesByType);
+        seenComponentPaths.set(componentPath, metadata);
+        components[componentType] = metadata;
     });
     return {
         hsMetaFiles,

package/src/lib/transform.js

@@ -2,11 +2,11 @@ import path from 'path';
 import fs from 'fs';
 import { logger } from '@hubspot/local-dev-lib/logger';
 import { applyHsProfileVariables, getHsProfileVariables } from './profiles.js';
-import { APP_KEY, APP_OBJECT_KEY, Components, PROJECT_STRUCTURE, APP_FUNCTIONS_KEY, APP_FUNCTIONS_PACKAGE_KEY, USER_FACING_TO_INTERNAL_TYPE, INTERNAL_TYPE_TO_USER_FACING, PACKAGE_JSON, PACKAGE_LOCK_JSON, PROFILE_VARIABLE_TYPES, } from './constants.js';
+import { APP_KEY, APP_OBJECT_KEY, CARDS_KEY, Components, PROJECT_STRUCTURE, APP_FUNCTIONS_KEY, APP_FUNCTIONS_PACKAGE_KEY, USER_FACING_TO_INTERNAL_TYPE, INTERNAL_TYPE_TO_USER_FACING, PACKAGE_JSON, PACKAGE_LOCK_JSON, PROFILE_VARIABLE_TYPES, } from './constants.js';
 import { errorMessages } from '../lang/copy.js';
 import { getJavaNumberType } from './utils.js';
 import { convertPathToPosixPath } from './files.js';
-function calculateComponentDeps(fileValidationResult, parentComponents, appObjects, appFunctionsPackageUid) {
+function calculateComponentDeps(fileValidationResult, parentComponents, appObjects, appFunctions, appFunctionsPackageUid) {
     let dependencies = {};
     // If there are dependencies in the config file, pass them through
     if (!fileValidationResult.content?.dependencies) {
@@ -32,6 +32,14 @@ function calculateComponentDeps(fileValidationResult, parentComponents, appObjec
         if (type === APP_FUNCTIONS_KEY && appFunctionsPackageUid) {
             dependencies.serverlessPackage = appFunctionsPackageUid;
         }
+        if (type === CARDS_KEY) {
+            if (appFunctionsPackageUid) {
+                dependencies.serverlessPackage = appFunctionsPackageUid;
+            }
+            if (appFunctions.length > 0) {
+                dependencies.allAppFunctions = appFunctions;
+            }
+        }
     }
     return { dependencies };
 }
@@ -54,6 +62,7 @@ export function transform(fileParseResults, translationContext, hsProfileContent
     const parentTypes = Object.keys(PROJECT_STRUCTURE);
     const parentComponents = {};
     const allAppObjects = [];
+    const allAppFunctions = [];
     let appUid = '';
     let appFunctionsDirectory;
     // Apply the profile variable overrides to the config
@@ -73,6 +82,7 @@ export function transform(fileParseResults, translationContext, hsProfileContent
         }
         if (file.content?.type === APP_FUNCTIONS_KEY) {
             appFunctionsDirectory = path.dirname(file.file);
+            allAppFunctions.push(file.content.uid);
         }
     });
     const autoGeneratedComponents = [];
@@ -96,7 +106,7 @@ export function transform(fileParseResults, translationContext, hsProfileContent
             };
         }
         const { config, uid, type } = currentFile.content;
-        const { dependencies, errors } = calculateComponentDeps(currentFile, parentComponents, allAppObjects, serverlessPackageUid);
+        const { dependencies, errors } = calculateComponentDeps(currentFile, parentComponents, allAppObjects, allAppFunctions, serverlessPackageUid);
         if (errors) {
             currentFile.errors?.push(...errors);
         }