@hubspot/local-dev-lib 3.15.0 → 3.16.1-beta.0

package/config/config_DEPRECATED.d.ts

@@ -81,7 +81,7 @@ export declare function loadConfigFromEnvironment({ useEnv, }?: {
 }): {
     portals: Array<CLIAccount_DEPRECATED>;
 } | undefined;
-export declare function isConfigFlagEnabled(flag: keyof CLIConfig_DEPRECATED): boolean;
+export declare function isConfigFlagEnabled(flag: keyof CLIConfig_DEPRECATED, defaultValue?: boolean): boolean;
 export declare function hasLocalStateFlag(flag: string): boolean;
 export declare function addLocalStateFlag(flag: string): void;
 export declare function removeLocalStateFlag(flag: string): void;

package/config/config_DEPRECATED.js

@@ -698,12 +698,12 @@ function loadEnvironmentVariableConfig(options) {
     logger_1.logger.debug(`Loaded config from environment variables for account ${portalId}`);
     return setConfig(handleLegacyCmsPublishMode(envConfig));
 }
-function isConfigFlagEnabled(flag) {
+function isConfigFlagEnabled(flag, defaultValue = false) {
     if (!configFileExists() || configFileIsBlank()) {
-        return false;
+        return defaultValue;
     }
     const config = getAndLoadConfigIfNeeded();
-    return Boolean(config[flag] || false);
+    return Boolean(config[flag] || defaultValue);
 }
 exports.isConfigFlagEnabled = isConfigFlagEnabled;
 function handleLegacyCmsPublishMode(config) {

package/config/index.d.ts

@@ -28,7 +28,7 @@ export declare function updateAllowAutoUpdates(enabled: boolean): void;
 export declare function updateAllowUsageTracking(isEnabled: boolean): void;
 export declare function updateAutoOpenBrowser(isEnabled: boolean): void;
 export declare function deleteConfigFile(): void;
-export declare function isConfigFlagEnabled(flag: keyof CLIConfig): boolean;
+export declare function isConfigFlagEnabled(flag: keyof CLIConfig, defaultValue?: boolean): boolean;
 export declare function isTrackingAllowed(): boolean;
 export declare function getEnv(nameOrId?: string | number): import("../types/Config").Environment;
 export declare function getAccountType(accountType?: AccountType, sandboxAccountType?: string | null): AccountType;

package/config/index.js

@@ -220,11 +220,11 @@ function deleteConfigFile() {
     }
 }
 exports.deleteConfigFile = deleteConfigFile;
-function isConfigFlagEnabled(flag) {
+function isConfigFlagEnabled(flag, defaultValue = false) {
     if (CLIConfiguration_1.CLIConfiguration.isActive()) {
-        return CLIConfiguration_1.CLIConfiguration.isConfigFlagEnabled(flag);
+        return CLIConfiguration_1.CLIConfiguration.isConfigFlagEnabled(flag, defaultValue);
     }
-    return config_DEPRECATED.isConfigFlagEnabled(flag);
+    return config_DEPRECATED.isConfigFlagEnabled(flag, defaultValue);
 }
 exports.isConfigFlagEnabled = isConfigFlagEnabled;
 function isTrackingAllowed() {

package/lib/cms/uploadFolder.js

@@ -38,6 +38,16 @@ function getFileType(filePath) {
             return files_1.FILE_TYPES.other;
     }
 }
+function isMetaJsonFile(filePath) {
+    return path_1.default.basename(filePath).toLowerCase() === 'meta.json';
+}
+function resolveUploadPath(file, fieldsJsPaths, tmpDirRegex, regex, dest) {
+    const fieldsJsFileInfo = fieldsJsPaths.find(f => f.outputPath === file);
+    const relativePath = file.replace(fieldsJsFileInfo ? tmpDirRegex : regex, '');
+    const destPath = (0, path_2.convertToUnixPath)(path_1.default.join(dest, relativePath));
+    const originalFilePath = fieldsJsFileInfo ? fieldsJsFileInfo.filePath : file;
+    return { fieldsJsFileInfo, relativePath, destPath, originalFilePath };
+}
 async function getFilesByType(filePaths, projectDir, rootWriteDir, commandOptions) {
     const { convertFields, fieldOptions } = commandOptions;
     const projectDirRegex = new RegExp(`^${(0, escapeRegExp_1.escapeRegExp)(projectDir)}`);
@@ -106,6 +116,12 @@ const defaultUploadFinalErrorCallback = (accountId, file, destPath, error) => {
         payload: file,
     });
 };
+async function uploadMetaJsonFiles(moduleFiles, uploadFile) {
+    const moduleMetaJsonFiles = moduleFiles.filter(isMetaJsonFile);
+    if (moduleMetaJsonFiles.length > 0) {
+        await queue.addAll(moduleMetaJsonFiles.map(uploadFile));
+    }
+}
 async function uploadFolder(accountId, src, dest, fileMapperOptions, commandOptions = {}, filePaths = [], cmsPublishMode = null) {
     const { saveOutput, convertFields, onAttemptCallback, onSuccessCallback, onFirstErrorCallback, onRetryCallback, onFinalErrorCallback, } = commandOptions;
     const _onAttemptCallback = onAttemptCallback || defaultUploadAttemptCallback;
@@ -120,23 +136,15 @@ async function uploadFolder(accountId, src, dest, fileMapperOptions, commandOpti
     const apiOptions = (0, fileMapper_1.getFileMapperQueryValues)(cmsPublishMode, fileMapperOptions);
     const failures = [];
     let fieldsJsPaths = [];
-    let tmpDirRegex;
+    const tmpDirRegex = new RegExp(`^${(0, escapeRegExp_1.escapeRegExp)(tmpDir || '')}`);
     const [filesByType, fieldsJsObjects] = await getFilesByType(filePaths, src, tmpDir, commandOptions);
-    const fileList = Object.values(filesByType);
     if (fieldsJsObjects.length) {
         fieldsJsPaths = fieldsJsObjects.map(fieldsJs => {
             return { outputPath: fieldsJs.outputPath, filePath: fieldsJs.filePath };
         });
-        tmpDirRegex = new RegExp(`^${(0, escapeRegExp_1.escapeRegExp)(tmpDir || '')}`);
     }
     function uploadFile(file) {
-        const fieldsJsFileInfo = fieldsJsPaths.find(f => f.outputPath === file);
-        const originalFilePath = fieldsJsFileInfo
-            ? fieldsJsFileInfo.filePath
-            : file;
-        // files in fieldsJsPaths always belong to the tmp directory.
-        const relativePath = file.replace(fieldsJsFileInfo ? tmpDirRegex : regex, '');
-        const destPath = (0, path_2.convertToUnixPath)(path_1.default.join(dest, relativePath));
+        const { originalFilePath, destPath } = resolveUploadPath(file, fieldsJsPaths, tmpDirRegex, regex, dest);
         return async () => {
             _onAttemptCallback(originalFilePath, destPath);
             try {
@@ -155,9 +163,23 @@ async function uploadFolder(accountId, src, dest, fileMapperOptions, commandOpti
             }
         };
     }
-    for (let i = 0; i < fileList.length; i++) {
-        const filesToUpload = fileList[i];
-        await queue.addAll(filesToUpload.map(uploadFile));
+    // Upload all meta.json files first
+    await uploadMetaJsonFiles(filesByType[files_1.FILE_TYPES.module] || [], uploadFile);
+    // Collect all remaining files for upload
+    const deferredFiles = [];
+    Object.entries(filesByType).forEach(([fileType, files]) => {
+        if (fileType === files_1.FILE_TYPES.module) {
+            // Add non-meta.json module files
+            deferredFiles.push(...files.filter(f => !isMetaJsonFile(f)));
+        }
+        else {
+            // Add all non-module files
+            deferredFiles.push(...files);
+        }
+    });
+    // Upload all remaining files concurrently
+    if (deferredFiles.length > 0) {
+        await queue.addAll(deferredFiles.map(uploadFile));
     }
     const results = await queue
         .addAll(failures.map(({ file, destPath }) => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@hubspot/local-dev-lib",
-    "version": "3.15.0",
+    "version": "3.16.1-beta.0",
     "description": "Provides library functionality for HubSpot local development tooling, including the HubSpot CLI",
     "repository": {
         "type": "git",