@hubspot/cli 8.1.0 → 8.1.2-experimental.0

package/commands/testAccount/create.js

@@ -3,15 +3,16 @@ import path from 'path';
 import { getValidEnv } from '@hubspot/local-dev-lib/environment';
 import { getConfigAccountEnvironment } from '@hubspot/local-dev-lib/config';
 import { getCwd } from '@hubspot/local-dev-lib/path';
+import { makeWrappedYargsHandler } from '../../lib/yargs/makeWrappedYargsHandler.js';
 import { makeYargsBuilder } from '../../lib/yargsUtils.js';
 import { promptUser, listPrompt } from '../../lib/prompts/promptUtils.js';
 import { EXIT_CODES } from '../../lib/enums/exitCodes.js';
 import { uiLogger } from '../../lib/ui/logger.js';
-import { trackCommandUsage } from '../../lib/usageTracking.js';
 import { fileExists } from '../../lib/validation.js';
 import { commands } from '../../lang/en.js';
 import { createDeveloperTestAccountConfigPrompt } from '../../lib/prompts/createDeveloperTestAccountConfigPrompt.js';
 import { debugError, logError } from '../../lib/errorHandlers/index.js';
+import { isPromptExitError } from '../../lib/errors/PromptExitError.js';
 import SpinniesManager from '../../lib/ui/SpinniesManager.js';
 import { createDeveloperTestAccountV2, saveAccountToConfig, } from '../../lib/buildAccount.js';
 import { ACCOUNT_LEVEL_CHOICES, ACCOUNT_LEVELS } from '../../lib/constants.js';
@@ -28,31 +29,29 @@ function hasAnyFlags(args) {
         contentLevel ||
         commerceLevel);
 }
-async function readConfigFile(configPath) {
+function readConfigFile(configPath) {
     const absoluteConfigPath = path.resolve(getCwd(), configPath);
     if (!fileExists(absoluteConfigPath)) {
-        uiLogger.error(commands.testAccount.create.errors.configFileNotFound(absoluteConfigPath));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.create.errors.configFileNotFound(absoluteConfigPath));
     }
     try {
         return JSON.parse(fs.readFileSync(absoluteConfigPath, 'utf8'));
     }
     catch (err) {
-        uiLogger.error(commands.testAccount.create.errors.configFileParseFailed(absoluteConfigPath));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.create.errors.configFileParseFailed(absoluteConfigPath));
     }
 }
 async function promptForConfigPath() {
     const createTestAccountFromConfig = await listPrompt(commands.testAccount.create.createTestAccountFromConfigPrompt, {
         choices: [
-            {
-                name: commands.testAccount.create.createFromConfigOption,
-                value: true,
-            },
             {
                 name: commands.testAccount.create.createFromScratchOption,
                 value: false,
             },
+            {
+                name: commands.testAccount.create.createFromConfigOption,
+                value: true,
+            },
         ],
     });
     if (createTestAccountFromConfig) {
@@ -89,10 +88,16 @@ async function buildTestAccountConfig(args) {
     });
 }
 async function handler(args) {
-    const { derivedAccountId, formatOutputAsJson } = args;
-    trackCommandUsage('test-account-create', {}, derivedAccountId);
+    const { derivedAccountId, formatOutputAsJson, exit } = args;
     const env = getValidEnv(getConfigAccountEnvironment(derivedAccountId));
-    const testAccountConfig = await buildTestAccountConfig(args);
+    let testAccountConfig;
+    try {
+        testAccountConfig = await buildTestAccountConfig(args);
+    }
+    catch (error) {
+        logError(error);
+        return exit(EXIT_CODES.ERROR);
+    }
     const resultJson = {};
     SpinniesManager.init({
         succeedColor: 'white',
@@ -111,7 +116,7 @@ async function handler(args) {
         SpinniesManager.fail('createTestAccount', {
             text: commands.testAccount.create.polling.createFailure,
         });
-        process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
     SpinniesManager.succeed('createTestAccount', {
         text: commands.testAccount.create.polling.success(testAccountConfig.accountName, resultJson.accountId, derivedAccountId),
@@ -130,12 +135,15 @@ async function handler(args) {
             }
         }
         catch (e) {
+            if (isPromptExitError(e)) {
+                throw e;
+            }
             debugError(e);
             uiLogger.error(commands.testAccount.create.errors.saveAccountToConfigFailure(testAccountConfig.accountName));
-            process.exit(EXIT_CODES.ERROR);
+            return exit(EXIT_CODES.ERROR);
         }
     }
-    process.exit(EXIT_CODES.SUCCESS);
+    return exit(EXIT_CODES.SUCCESS);
 }
 function createTestAccountBuilder(yargs) {
     yargs.option('config-path', {
@@ -222,7 +230,7 @@ const builder = makeYargsBuilder(createTestAccountBuilder, command, describe, {
 const createTestAccountCommand = {
     command,
     describe,
-    handler,
+    handler: makeWrappedYargsHandler('test-account-create', handler),
     builder,
 };
 export default createTestAccountCommand;

package/commands/testAccount/createConfig.js

@@ -1,19 +1,18 @@
 import fs from 'fs-extra';
 import path from 'path';
 import { getCwd } from '@hubspot/local-dev-lib/path';
+import { makeWrappedYargsHandler } from '../../lib/yargs/makeWrappedYargsHandler.js';
 import { makeYargsBuilder } from '../../lib/yargsUtils.js';
 import { promptUser } from '../../lib/prompts/promptUtils.js';
 import { EXIT_CODES } from '../../lib/enums/exitCodes.js';
 import { uiLogger } from '../../lib/ui/logger.js';
-import { trackCommandUsage } from '../../lib/usageTracking.js';
 import { commands } from '../../lang/en.js';
 import { createDeveloperTestAccountConfigPrompt } from '../../lib/prompts/createDeveloperTestAccountConfigPrompt.js';
 import { fileExists } from '../../lib/validation.js';
 const command = 'create-config';
 const describe = commands.testAccount.createConfig.describe;
 async function handler(args) {
-    const { derivedAccountId, name, description, path: configPath } = args;
-    trackCommandUsage('test-account-create-config', {}, derivedAccountId);
+    const { name, description, path: configPath, exit } = args;
     let accountConfigPath = configPath;
     const testAccountConfig = await createDeveloperTestAccountConfigPrompt({
         name,
@@ -43,21 +42,21 @@ async function handler(args) {
     }
     if (!accountConfigPath) {
         uiLogger.error(commands.testAccount.createConfig.errors.pathError);
-        process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
     if (fileExists(accountConfigPath)) {
         uiLogger.error(commands.testAccount.createConfig.errors.pathExistsError);
-        process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
     try {
         fs.writeFileSync(path.resolve(getCwd(), accountConfigPath), JSON.stringify(testAccountConfig, null, 2), 'utf8');
     }
     catch (err) {
         uiLogger.error(commands.testAccount.createConfig.errors.failedToCreate);
-        process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
     uiLogger.success(commands.testAccount.createConfig.success.configFileCreated(accountConfigPath));
-    process.exit(EXIT_CODES.SUCCESS);
+    return exit(EXIT_CODES.SUCCESS);
 }
 function createTestAccountConfigBuilder(yargs) {
     yargs.option('name', {
@@ -86,7 +85,7 @@ const builder = makeYargsBuilder(createTestAccountConfigBuilder, command, descri
 const createTestAccountConfigCommand = {
     command,
     describe,
-    handler,
+    handler: makeWrappedYargsHandler('test-account-create-config', handler),
     builder,
 };
 export default createTestAccountConfigCommand;

package/commands/testAccount/delete.js

@@ -1,12 +1,12 @@
 import { fetchDeveloperTestAccounts, deleteDeveloperTestAccount, } from '@hubspot/local-dev-lib/api/developerTestAccounts';
+import { makeWrappedYargsHandler } from '../../lib/yargs/makeWrappedYargsHandler.js';
 import { makeYargsBuilder } from '../../lib/yargsUtils.js';
 import { EXIT_CODES } from '../../lib/enums/exitCodes.js';
 import { uiLogger } from '../../lib/ui/logger.js';
-import { trackCommandUsage } from '../../lib/usageTracking.js';
 import { commands } from '../../lang/en.js';
 import { removeAccountFromConfig, getConfigAccountById, getConfigAccountIfExists, setConfigAccountAsDefault, getConfigDefaultAccountIfExists, } from '@hubspot/local-dev-lib/config';
 import { promptUser } from '../../lib/prompts/promptUtils.js';
-import { debugError } from '../../lib/errorHandlers/index.js';
+import { debugError, logError } from '../../lib/errorHandlers/index.js';
 const command = 'delete [test-account]';
 const describe = commands.testAccount.delete.describe;
 async function getAccountPromptOptions(derivedAccountId) {
@@ -25,8 +25,7 @@ async function getAccountPromptOptions(derivedAccountId) {
 async function accountToDeleteSelectionPrompt(derivedAccountId) {
     const accountData = await getAccountPromptOptions(derivedAccountId);
     if (accountData.length === 0) {
-        uiLogger.error(commands.testAccount.delete.errors.noAccountsToDelete(derivedAccountId));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.delete.errors.noAccountsToDelete(derivedAccountId));
     }
     const { testAccountToDelete } = await promptUser([
         {
@@ -79,33 +78,35 @@ async function deleteTestAccountFromConfig(testAccountId, parentAccountName, acc
         uiLogger.error(commands.testAccount.delete.errors.failedToDeleteFromConfig(testAccountId));
     }
 }
-async function validateTestAccountConfigs(testAccountId) {
+function validateTestAccountConfigs(testAccountId) {
     if (!testAccountId) {
-        uiLogger.error(commands.testAccount.delete.errors.testAccountNotFound(testAccountId));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.delete.errors.testAccountNotFound(testAccountId));
     }
     const testAccountConfig = getConfigAccountById(testAccountId);
     if (!testAccountConfig) {
-        uiLogger.error(commands.testAccount.delete.errors.testAccountNotFound(testAccountId));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.delete.errors.testAccountNotFound(testAccountId));
     }
     const parentAccountConfig = getConfigAccountById(testAccountConfig.parentAccountId);
     if (!parentAccountConfig) {
-        uiLogger.error(commands.testAccount.delete.errors.parentAccountNotFound(testAccountId));
-        process.exit(EXIT_CODES.ERROR);
+        throw new Error(commands.testAccount.delete.errors.parentAccountNotFound(testAccountId));
     }
     const parentAccountName = parentAccountConfig.name;
     return { testAccountConfig, parentAccountName };
 }
 async function handler(args) {
-    const { derivedAccountId, testAccount, force } = args;
-    trackCommandUsage('test-account-delete', {}, derivedAccountId);
+    const { derivedAccountId, testAccount, force, exit } = args;
     let testAccountIdToDelete = 0;
     // See if the account exists
     if (testAccount) {
         const account = getConfigAccountIfExists(testAccount);
         const accountId = account?.accountId || null;
-        await validateTestAccountConfigs(accountId);
+        try {
+            validateTestAccountConfigs(accountId);
+        }
+        catch (error) {
+            logError(error);
+            return exit(EXIT_CODES.ERROR);
+        }
         if (accountId) {
             testAccountIdToDelete = accountId;
         }
@@ -119,10 +120,18 @@ async function handler(args) {
         catch (err) {
             debugError(err);
             uiLogger.error(commands.testAccount.delete.errors.failedToSelectAccount);
-            process.exit(EXIT_CODES.ERROR);
+            return exit(EXIT_CODES.ERROR);
         }
     }
-    const { testAccountConfig, parentAccountName } = await validateTestAccountConfigs(testAccountIdToDelete);
+    let testAccountConfig;
+    let parentAccountName;
+    try {
+        ({ testAccountConfig, parentAccountName } = validateTestAccountConfigs(testAccountIdToDelete));
+    }
+    catch (error) {
+        logError(error);
+        return exit(EXIT_CODES.ERROR);
+    }
     // If --force, don't prompt user; else confirm deletion
     let shouldDeleteAccount;
     if (force) {
@@ -139,7 +148,7 @@ async function handler(args) {
     else {
         uiLogger.info(commands.testAccount.delete.info.deletionCanceled);
     }
-    process.exit(EXIT_CODES.SUCCESS);
+    return exit(EXIT_CODES.SUCCESS);
 }
 function deleteTestAccountBuilder(yargs) {
     yargs.positional('test-account', {
@@ -182,7 +191,7 @@ const builder = makeYargsBuilder(deleteTestAccountBuilder, command, describe, {
 const deleteTestAccountCommand = {
     command,
     describe,
-    handler,
+    handler: makeWrappedYargsHandler('test-account-delete', handler),
     builder,
 };
 export default deleteTestAccountCommand;

package/commands/testAccount/importData.js

@@ -1,7 +1,7 @@
 import { getImportDataRequest } from '@hubspot/local-dev-lib/crm';
 import { logError } from '../../lib/errorHandlers/index.js';
+import { makeWrappedYargsHandler } from '../../lib/yargs/makeWrappedYargsHandler.js';
 import { makeYargsBuilder } from '../../lib/yargsUtils.js';
-import { trackCommandUsage } from '../../lib/usageTracking.js';
 import { EXIT_CODES } from '../../lib/enums/exitCodes.js';
 import { importDataFilePathPrompt } from '../../lib/prompts/importDataFilePathPrompt.js';
 import { handleImportData, handleTargetTestAccountSelectionFlow, } from '../../lib/importData.js';
@@ -10,8 +10,7 @@ import { commands } from '../../lang/en.js';
 export const command = 'import-data';
 export const describe = commands.testAccount.subcommands.importData.describe;
 async function handler(args) {
-    const { derivedAccountId, userProvidedAccount, filePath: providedFilePath, skipConfirm, } = args;
-    trackCommandUsage('crm-import-data', {}, derivedAccountId);
+    const { derivedAccountId, userProvidedAccount, filePath: providedFilePath, skipConfirm, exit, } = args;
     let targetAccountId;
     try {
         targetAccountId = await handleTargetTestAccountSelectionFlow(derivedAccountId, userProvidedAccount);
@@ -20,15 +19,15 @@ async function handler(args) {
         const confirmImportData = skipConfirm ||
             (await confirmImportDataPrompt(targetAccountId, dataFileNames));
         if (!confirmImportData) {
-            process.exit(EXIT_CODES.SUCCESS);
+            return exit(EXIT_CODES.SUCCESS);
         }
         await handleImportData(targetAccountId, dataFileNames, importRequest);
     }
     catch (error) {
         logError(error);
-        process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
-    process.exit(EXIT_CODES.SUCCESS);
+    return exit(EXIT_CODES.SUCCESS);
 }
 function crmImportDataBuilder(yargs) {
     yargs.example([['$0 test-account import-data']]);
@@ -56,6 +55,6 @@ const crmImportDataCommand = {
     command,
     describe,
     builder,
-    handler,
+    handler: makeWrappedYargsHandler('crm-import-data', handler),
 };
 export default crmImportDataCommand;

package/commands/upgrade.js

@@ -1,7 +1,7 @@
 import { isConfigFlagEnabled } from '@hubspot/local-dev-lib/config';
 import { CONFIG_FLAGS } from '@hubspot/local-dev-lib/constants/config';
-import { trackCommandUsage } from '../lib/usageTracking.js';
 import { EXIT_CODES } from '../lib/enums/exitCodes.js';
+import { makeWrappedYargsHandler } from '../lib/yargs/makeWrappedYargsHandler.js';
 import { makeYargsBuilder } from '../lib/yargsUtils.js';
 import { uiLogger } from '../lib/ui/logger.js';
 import { commands } from '../lang/en.js';
@@ -14,8 +14,7 @@ import { debugError } from '../lib/errorHandlers/index.js';
 const command = ['upgrade [version]', 'update [version]'];
 const describe = commands.upgrade.describe;
 const handler = async (args) => {
-    const { version, force, beta, derivedAccountId } = args;
-    trackCommandUsage('upgrade', {}, derivedAccountId);
+    const { version, force, beta, exit } = args;
     SpinniesManager.init({
         succeedColor: 'white',
     });
@@ -27,7 +26,7 @@ const handler = async (args) => {
             const latestVersion = beta ? nextCliVersion : latestCliVersion;
             if (!latestVersion) {
                 uiLogger.error(commands.upgrade.errors.unableToDetermineLatestVersion);
-                return process.exit(EXIT_CODES.ERROR);
+                return exit(EXIT_CODES.ERROR);
             }
             targetVersion = latestVersion;
         }
@@ -40,20 +39,20 @@ const handler = async (args) => {
             else {
                 uiLogger.log(commands.upgrade.alreadyLatest(currentVersion, beta));
             }
-            return process.exit(EXIT_CODES.SUCCESS);
+            return exit(EXIT_CODES.SUCCESS);
         }
         // Check if globally installed
         const isGlobal = await canCliBeAutoUpgraded();
         if (!isGlobal) {
             uiLogger.log(commands.upgrade.autoUpgradeNotAvailable(targetVersion));
-            return process.exit(EXIT_CODES.SUCCESS);
+            return exit(EXIT_CODES.SUCCESS);
         }
         // Prompt for confirmation unless --force is used
         if (!force) {
             const shouldUpgrade = await confirmPrompt(commands.upgrade.confirmPrompt(currentVersion, targetVersion), { defaultAnswer: true });
             if (!shouldUpgrade) {
                 uiLogger.log(commands.upgrade.cancelled);
-                return process.exit(EXIT_CODES.SUCCESS);
+                return exit(EXIT_CODES.SUCCESS);
             }
         }
         SpinniesManager.add('upgrade', {
@@ -68,7 +67,7 @@ const handler = async (args) => {
         });
         uiLogger.log('');
         uiLogger.error(commands.upgrade.errors.generic);
-        return process.exit(EXIT_CODES.ERROR);
+        return exit(EXIT_CODES.ERROR);
     }
     SpinniesManager.succeed('upgrade', {
         text: commands.upgrade.success(targetVersion),
@@ -85,7 +84,7 @@ const handler = async (args) => {
         uiLogger.log('');
         uiLogger.log(commands.upgrade.autoUpgradeMessage);
     }
-    return process.exit(EXIT_CODES.SUCCESS);
+    return exit(EXIT_CODES.SUCCESS);
 };
 function upgradeBuilder(yargs) {
     yargs
@@ -113,7 +112,7 @@ const builder = makeYargsBuilder(upgradeBuilder, command, describe, {
 const upgradeCommand = {
     command,
     describe,
-    handler,
+    handler: makeWrappedYargsHandler('upgrade', handler),
     builder,
 };
 export default upgradeCommand;