@hubspot/cli 7.6.0-beta.5 → 7.6.0-beta.7

package/lib/projects/__tests__/LocalDevProcess.test.js

@@ -1,31 +1,27 @@
-"use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-const path_1 = __importDefault(require("path"));
-const project_parsing_lib_1 = require("@hubspot/project-parsing-lib");
-const upload_1 = require("../upload");
-const config_1 = require("../config");
-const LocalDevProcess_1 = __importDefault(require("../localDev/LocalDevProcess"));
-const LocalDevLogger_1 = __importDefault(require("../localDev/LocalDevLogger"));
-const DevServerManagerV2_1 = __importDefault(require("../localDev/DevServerManagerV2"));
-const environments_1 = require("@hubspot/local-dev-lib/constants/environments");
-const vitest_1 = require("vitest");
+import path from 'path';
+import { translateForLocalDev } from '@hubspot/project-parsing-lib';
+import { handleProjectUpload } from '../upload.js';
+import { getProjectConfig } from '../config.js';
+import LocalDevProcess from '../localDev/LocalDevProcess.js';
+import LocalDevLogger from '../localDev/LocalDevLogger.js';
+import DevServerManagerV2 from '../localDev/DevServerManagerV2.js';
+import { ENVIRONMENTS } from '@hubspot/local-dev-lib/constants/environments';
+import { vi } from 'vitest';
 // Mock @hubspot/ui-extensions-dev-server
-vitest_1.vi.mock('@hubspot/ui-extensions-dev-server', () => ({
+vi.mock('@hubspot/ui-extensions-dev-server', () => ({
     DevModeUnifiedInterface: {
-        setup: vitest_1.vi.fn().mockResolvedValue(undefined),
-        start: vitest_1.vi.fn().mockResolvedValue(undefined),
-        fileChange: vitest_1.vi.fn().mockResolvedValue(undefined),
-        cleanup: vitest_1.vi.fn().mockResolvedValue(undefined),
+        setup: vi.fn().mockResolvedValue(undefined),
+        start: vi.fn().mockResolvedValue(undefined),
+        fileChange: vi.fn().mockResolvedValue(undefined),
+        cleanup: vi.fn().mockResolvedValue(undefined),
     },
 }));
-vitest_1.vi.mock('@hubspot/project-parsing-lib');
-vitest_1.vi.mock('../upload');
-vitest_1.vi.mock('../config');
-vitest_1.vi.mock('../localDev/LocalDevLogger');
-vitest_1.vi.mock('../localDev/DevServerManagerV2');
+vi.mock('open');
+vi.mock('@hubspot/project-parsing-lib');
+vi.mock('../upload');
+vi.mock('../config');
+vi.mock('../localDev/LocalDevLogger');
+vi.mock('../localDev/DevServerManagerV2');
 // Tests for LocalDevProcess and LocalDevState
 describe('LocalDevProcess', () => {
     let mockLocalDevLogger;
@@ -36,100 +32,53 @@ describe('LocalDevProcess', () => {
         srcDir: 'src',
         platformVersion: '1.0.0',
     };
-    const mockSubbuildStatus = {
-        buildName: 'component1',
-        buildType: 'APP',
-        errorMessage: '',
-        finishedAt: new Date().toISOString(),
-        rootPath: '/test/path',
-        startedAt: new Date().toISOString(),
-        status: 'SUCCESS',
-        id: '123',
-        standardError: null,
-        visible: true,
-    };
-    const mockBuild = {
-        activitySource: { type: 'HUBSPOT' },
-        projectName: 'test-project',
-        uploadMessage: 'test-upload-message',
-        autoDeployId: 123,
-        buildId: 123,
-        createdAt: new Date().toISOString(),
-        deployableState: 'DEPLOYED',
-        finishedAt: new Date().toISOString(),
-        startedAt: new Date().toISOString(),
-        status: 'SUCCESS',
-        subbuildStatuses: [
-            { ...mockSubbuildStatus, buildName: 'component1' },
-            { ...mockSubbuildStatus, buildName: 'component2' },
-        ],
-        deployStatusTaskLocator: {
-            id: '123',
-            links: [],
-        },
-        enqueuedAt: new Date().toISOString(),
-        isAutoDeployEnabled: false,
-        portalId: 123,
-    };
     const mockOptions = {
         projectDir: '/test/project',
         projectConfig: mockProjectConfig,
         targetProjectAccountId: 123,
         targetTestingAccountId: 456,
         projectId: 789,
-        isGithubLinked: false,
         initialProjectNodes: {},
-        env: environments_1.ENVIRONMENTS.PROD,
-        deployedBuild: mockBuild,
+        env: ENVIRONMENTS.PROD,
         projectName: 'test-project',
     };
     beforeEach(() => {
-        vitest_1.vi.clearAllMocks();
+        vi.clearAllMocks();
         mockLocalDevLogger = {
-            resetSpinnies: vitest_1.vi.fn(),
-            devServerSetupError: vitest_1.vi.fn(),
-            devServerStartError: vitest_1.vi.fn(),
-            devServerCleanupError: vitest_1.vi.fn(),
-            missingComponentsWarning: vitest_1.vi.fn(),
-            noDeployedBuild: vitest_1.vi.fn(),
-            startupMessage: vitest_1.vi.fn(),
-            monitorConsoleOutput: vitest_1.vi.fn(),
-            cleanupStart: vitest_1.vi.fn(),
-            cleanupError: vitest_1.vi.fn(),
-            cleanupSuccess: vitest_1.vi.fn(),
-            uploadInitiated: vitest_1.vi.fn(),
-            projectConfigMismatch: vitest_1.vi.fn(),
-            uploadError: vitest_1.vi.fn(),
-            uploadSuccess: vitest_1.vi.fn(),
-            clearUploadWarnings: vitest_1.vi.fn(),
-            fileChangeError: vitest_1.vi.fn(),
-            uploadWarning: vitest_1.vi.fn(),
+            resetSpinnies: vi.fn(),
+            devServerSetupError: vi.fn(),
+            devServerStartError: vi.fn(),
+            devServerCleanupError: vi.fn(),
+            missingComponentsWarning: vi.fn(),
+            startupMessage: vi.fn(),
+            monitorConsoleOutput: vi.fn(),
+            cleanupStart: vi.fn(),
+            cleanupError: vi.fn(),
+            cleanupSuccess: vi.fn(),
+            uploadInitiated: vi.fn(),
+            projectConfigMismatch: vi.fn(),
+            uploadError: vi.fn(),
+            uploadSuccess: vi.fn(),
+            fileChangeError: vi.fn(),
+            uploadWarning: vi.fn(),
         };
         mockDevServerManager = {
-            setup: vitest_1.vi.fn().mockResolvedValue(undefined),
-            start: vitest_1.vi.fn().mockResolvedValue(undefined),
-            cleanup: vitest_1.vi.fn().mockResolvedValue(undefined),
-            fileChange: vitest_1.vi.fn().mockResolvedValue(undefined),
+            setup: vi.fn().mockResolvedValue(undefined),
+            start: vi.fn().mockResolvedValue(undefined),
+            cleanup: vi.fn().mockResolvedValue(undefined),
+            fileChange: vi.fn().mockResolvedValue(undefined),
         };
         // Mock constructors
-        LocalDevLogger_1.default.mockImplementation(() => mockLocalDevLogger);
-        DevServerManagerV2_1.default.mockImplementation(() => mockDevServerManager);
+        LocalDevLogger.mockImplementation(() => mockLocalDevLogger);
+        DevServerManagerV2.mockImplementation(() => mockDevServerManager);
         // Create process instance
-        process = new LocalDevProcess_1.default(mockOptions);
+        process = new LocalDevProcess(mockOptions);
         // Mock process.exit
-        vitest_1.vi.spyOn(global.process, 'exit').mockImplementation((code) => {
+        vi.spyOn(global.process, 'exit').mockImplementation((code) => {
             throw new Error(`Process.exit called with code ${code}`);
         });
     });
     describe('start()', () => {
-        it('should exit if no deployed build exists', async () => {
-            const processWithoutBuild = new LocalDevProcess_1.default({
-                ...mockOptions,
-                deployedBuild: undefined,
-            });
-            await expect(processWithoutBuild.start()).rejects.toThrow('Process.exit called with code 0');
-            expect(mockLocalDevLogger.noDeployedBuild).toHaveBeenCalled();
-        });
         it('should exit if dev server setup fails', async () => {
             mockDevServerManager.setup.mockRejectedValue(new Error('Setup failed'));
             await expect(process.start()).rejects.toThrow('Process.exit called with code 1');
@@ -142,31 +91,6 @@ describe('LocalDevProcess', () => {
             expect(mockLocalDevLogger.monitorConsoleOutput).toHaveBeenCalled();
             expect(mockLocalDevLogger.missingComponentsWarning).not.toHaveBeenCalled();
         });
-        it('should warn about missing components', async () => {
-            const mockNode = {
-                uid: 'component3',
-                componentType: 'APP',
-                localDev: {
-                    componentRoot: '/test/path',
-                    componentConfigPath: '/test/path/config.json',
-                    configUpdatedSinceLastUpload: false,
-                },
-                componentDeps: {},
-                metaFilePath: '/test/path',
-                config: {},
-                files: [],
-            };
-            const processWithNode = new LocalDevProcess_1.default({
-                ...mockOptions,
-                initialProjectNodes: {
-                    component3: mockNode,
-                },
-            });
-            await processWithNode.start();
-            expect(mockLocalDevLogger.missingComponentsWarning).toHaveBeenCalledWith([
-                '[App] component3',
-            ]);
-        });
     });
     describe('stop()', () => {
         it('should exit with error if cleanup fails', async () => {
@@ -187,13 +111,13 @@ describe('LocalDevProcess', () => {
     describe('updateProjectNodes()', () => {
         it('should update project nodes with translated representation', async () => {
             const mockNodes = { node1: { uid: 'node1' } };
-            project_parsing_lib_1.translateForLocalDev.mockResolvedValue({
+            translateForLocalDev.mockResolvedValue({
                 intermediateNodesIndexedByUid: mockNodes,
             });
             // @ts-expect-error testing private method
             await process.updateProjectNodes();
-            expect(project_parsing_lib_1.translateForLocalDev).toHaveBeenCalledWith({
-                projectSourceDir: path_1.default.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
+            expect(translateForLocalDev).toHaveBeenCalledWith({
+                projectSourceDir: path.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
                 platformVersion: mockOptions.projectConfig.platformVersion,
                 accountId: mockOptions.targetProjectAccountId,
             }, { projectNodesAtLastUpload: {} });
@@ -202,18 +126,18 @@ describe('LocalDevProcess', () => {
     });
     describe('uploadProject()', () => {
         it('should not upload if project config is invalid', async () => {
-            config_1.getProjectConfig.mockResolvedValue({
+            getProjectConfig.mockResolvedValue({
                 projectConfig: null,
             });
             await process.uploadProject();
             expect(mockLocalDevLogger.projectConfigMismatch).toHaveBeenCalled();
-            expect(upload_1.handleProjectUpload).not.toHaveBeenCalled();
+            expect(handleProjectUpload).not.toHaveBeenCalled();
         });
         it('should handle upload error', async () => {
-            config_1.getProjectConfig.mockResolvedValue({
+            getProjectConfig.mockResolvedValue({
                 projectConfig: mockOptions.projectConfig,
             });
-            upload_1.handleProjectUpload.mockResolvedValue({
+            handleProjectUpload.mockResolvedValue({
                 uploadError: new Error('Upload failed'),
             });
             const success = await process.uploadProject();
@@ -222,15 +146,16 @@ describe('LocalDevProcess', () => {
         });
         it('should handle successful upload', async () => {
             await process.handleConfigFileChange();
-            config_1.getProjectConfig.mockResolvedValue({
+            getProjectConfig.mockResolvedValue({
                 projectConfig: mockOptions.projectConfig,
             });
-            upload_1.handleProjectUpload.mockResolvedValue({
+            handleProjectUpload.mockResolvedValue({
                 uploadError: null,
             });
             const success = await process.uploadProject();
             expect(mockLocalDevLogger.uploadSuccess).toHaveBeenCalled();
-            expect(mockLocalDevLogger.clearUploadWarnings).toHaveBeenCalled();
+            // @ts-expect-error accessing private property for testing
+            expect(process.state.uploadWarnings.size).toBe(0);
             expect(success).toBe(true);
         });
         it('should reset projectNodesAtLastUpload', async () => {
@@ -238,19 +163,19 @@ describe('LocalDevProcess', () => {
             const initialProjectNodes = { existingNode: { uid: 'existingNode' } };
             // @ts-expect-error accessing private property for testing
             process.state._projectNodesAtLastUpload = initialProjectNodes;
-            config_1.getProjectConfig.mockResolvedValue({
+            getProjectConfig.mockResolvedValue({
                 projectConfig: mockOptions.projectConfig,
             });
-            upload_1.handleProjectUpload.mockResolvedValue({
+            handleProjectUpload.mockResolvedValue({
                 uploadError: null,
             });
-            project_parsing_lib_1.translateForLocalDev.mockResolvedValue({
+            translateForLocalDev.mockResolvedValue({
                 intermediateNodesIndexedByUid: mockNodes,
             });
             const success = await process.uploadProject();
             // Verify translateForLocalDev was called without projectNodesAtLastUpload option
-            expect(project_parsing_lib_1.translateForLocalDev).toHaveBeenCalledWith({
-                projectSourceDir: path_1.default.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
+            expect(translateForLocalDev).toHaveBeenCalledWith({
+                projectSourceDir: path.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
                 platformVersion: mockOptions.projectConfig.platformVersion,
                 accountId: mockOptions.targetProjectAccountId,
             }, { projectNodesAtLastUpload: undefined });
@@ -281,14 +206,14 @@ describe('LocalDevProcess', () => {
     });
     describe('handleConfigFileChange()', () => {
         beforeEach(() => {
-            project_parsing_lib_1.translateForLocalDev.mockResolvedValue({
+            translateForLocalDev.mockResolvedValue({
                 intermediateNodesIndexedByUid: {},
             });
         });
         it('should update project nodes and show upload warning', async () => {
             await process.handleConfigFileChange();
-            expect(project_parsing_lib_1.translateForLocalDev).toHaveBeenCalledWith({
-                projectSourceDir: path_1.default.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
+            expect(translateForLocalDev).toHaveBeenCalledWith({
+                projectSourceDir: path.join(mockOptions.projectDir, mockOptions.projectConfig.srcDir),
                 platformVersion: mockOptions.projectConfig.platformVersion,
                 accountId: mockOptions.targetProjectAccountId,
             }, { projectNodesAtLastUpload: {} });
@@ -297,18 +222,33 @@ describe('LocalDevProcess', () => {
     });
     describe('addStateListener()', () => {
         it('should add state listener', () => {
-            const listener = vitest_1.vi.fn();
+            const listener = vi.fn();
             const key = 'projectNodes';
             process.addStateListener(key, listener);
             // @ts-expect-error
             process.state.projectNodes = {};
             expect(listener).toHaveBeenCalled();
         });
-        it('should call listener immediately when callOnInit is true', () => {
-            const listener = vitest_1.vi.fn();
+        it('should call listener immediately', () => {
+            const listener = vi.fn();
             const key = 'projectNodes';
-            process.addStateListener(key, listener, true);
+            process.addStateListener(key, listener);
             expect(listener).toHaveBeenCalledWith(process.projectNodes);
         });
     });
+    describe('removeStateListener()', () => {
+        it('should remove state listener', () => {
+            const listener = vi.fn();
+            const key = 'projectNodes';
+            // Add the listener first
+            process.addStateListener(key, listener);
+            expect(listener).toHaveBeenCalledTimes(1);
+            // Remove the listener
+            process.removeStateListener(key, listener);
+            // Trigger state change again to verify listener is no longer called
+            // @ts-expect-error
+            process.state.projectNodes = { newNode: { uid: 'newNode' } };
+            expect(listener).toHaveBeenCalledTimes(1);
+        });
+    });
 });