@hubspot/cli 5.2.0 → 5.2.1-beta.0

package/commands/project/dev.js

@@ -62,10 +62,10 @@ const { getHubSpotWebsiteOrigin } = require('@hubspot/local-dev-lib/urls');
 const {
   logApiErrorInstance,
   ApiErrorContext,
-  isSpecifiedError, // Migrate isSpecifiedError to local-dev-lib version only after uploadProject is migrated to local-dev-lib
 } = require('../../lib/errorHandlers/apiErrors');
 const {
   isMissingScopeError,
+  isSpecifiedError,
 } = require('@hubspot/local-dev-lib/errors/apiErrors');
 const { logErrorInstance } = require('../../lib/errorHandlers/standardErrors');
 const { isDeveloperTestAccount } = require('../../lib/developerTestAccounts');

package/commands/project/upload.js

@@ -19,11 +19,11 @@ const {
 } = require('../../lib/projects');
 const { i18n } = require('../../lib/lang');
 const { getAccountConfig } = require('@hubspot/local-dev-lib/config');
+const { isSpecifiedError } = require('@hubspot/local-dev-lib/errors/apiErrors');
 const { PROJECT_ERROR_TYPES } = require('../../lib/constants');
 const {
   logApiErrorInstance,
   ApiErrorContext,
-  isSpecifiedError,
 } = require('../../lib/errorHandlers/apiErrors');
 const { EXIT_CODES } = require('../../lib/enums/exitCodes');
 

package/lib/errorHandlers/apiErrors.js

@@ -1,7 +1,10 @@
 const { logger } = require('@hubspot/local-dev-lib/logger');
 const { getAccountConfig } = require('@hubspot/local-dev-lib/config');
 const {
+  isMissingScopeError,
+  isApiUploadValidationError,
   getAxiosErrorWithContext,
+  parseValidationErrors,
 } = require('@hubspot/local-dev-lib/errors/apiErrors');
 const {
   SCOPE_GROUPS,
@@ -18,80 +21,6 @@ const { i18n } = require('../lang');
 
 const i18nKey = 'cli.lib.errorHandlers.apiErrors';
 
-const isApiStatusCodeError = err =>
-  err.name === 'StatusCodeError' ||
-  (err.statusCode >= 100 && err.statusCode < 600);
-
-const isApiUploadValidationError = err =>
-  !!(
-    err.statusCode === 400 &&
-    err.response &&
-    err.response.body &&
-    (err.response.body.message || err.response.body.errors)
-  );
-
-const isMissingScopeError = err =>
-  err.name === 'StatusCodeError' &&
-  err.statusCode === 403 &&
-  err.error &&
-  err.error.category === 'MISSING_SCOPES';
-
-const isGatingError = err =>
-  isSpecifiedError(err, { statusCode: 403, category: 'GATED' });
-
-const isSpecifiedError = (err, { statusCode, category, subCategory } = {}) => {
-  const statusCodeErr = !statusCode || err.statusCode === statusCode;
-  const categoryErr =
-    !category || (err.error && err.error.category === category);
-  const subCategoryErr =
-    !subCategory || (err.error && err.error.subCategory === subCategory);
-
-  return (
-    err.name === 'StatusCodeError' &&
-    statusCodeErr &&
-    categoryErr &&
-    subCategoryErr
-  );
-};
-
-const isSpecifiedHubSpotAuthError = (
-  err,
-  { statusCode, category, subCategory }
-) => {
-  const statusCodeErr = !statusCode || err.statusCode === statusCode;
-  const categoryErr = !category || err.category === category;
-  const subCategoryErr = !subCategory || err.subCategory === subCategory;
-  return (
-    err.name === 'HubSpotAuthError' &&
-    statusCodeErr &&
-    categoryErr &&
-    subCategoryErr
-  );
-};
-
-const parseValidationErrors = (responseBody = {}) => {
-  const errorMessages = [];
-
-  const { errors, message } = responseBody;
-
-  if (message) {
-    errorMessages.push(message);
-  }
-
-  if (errors) {
-    const specificErrors = errors.map(error => {
-      let errorMessage = error.message;
-      if (error.errorTokens && error.errorTokens.line) {
-        errorMessage = `line ${error.errorTokens.line}: ${errorMessage}`;
-      }
-      return errorMessage;
-    });
-    errorMessages.push(...specificErrors);
-  }
-
-  return errorMessages;
-};
-
 class ApiErrorContext extends ErrorContext {
   constructor(props = {}) {
     super(props);
@@ -110,139 +39,10 @@ class ApiErrorContext extends ErrorContext {
  */
 function logValidationErrors(error, context) {
   const { response = {} } = error;
-  const validationErrors = parseValidationErrors(response.body);
+  const validationErrors = parseValidationErrors(response.data);
   if (validationErrors.length) {
-    validationErrors.forEach(err => {
-      logger.error(err);
-    });
-  }
-  debugErrorAndContext(error, context);
-}
-
-/**
- * Message segments for API messages.
- *
- * @enum {string}
- */
-const ApiMethodVerbs = {
-  DEFAULT: 'request',
-  DELETE: 'delete',
-  GET: 'request',
-  PATCH: 'update',
-  POST: 'post',
-  PUT: 'update',
-};
-
-/**
- * Message segments for API messages.
- *
- * @enum {string}
- */
-const ApiMethodPrepositions = {
-  DEFAULT: 'for',
-  DELETE: 'of',
-  GET: 'for',
-  PATCH: 'to',
-  POST: 'to',
-  PUT: 'to',
-};
-
-/**
- * Logs messages for an error instance resulting from API interaction.
- *
- * @param {StatusCodeError} error
- * @param {ApiErrorContext} context
- */
-function logApiStatusCodeError(error, context) {
-  const { statusCode } = error;
-  const { method } = error.options || {};
-  const { projectName } = context;
-  const isPutOrPost = method === 'PUT' || method === 'POST';
-  const action = ApiMethodVerbs[method] || ApiMethodVerbs.DEFAULT;
-  const preposition =
-    ApiMethodPrepositions[method] || ApiMethodPrepositions.DEFAULT;
-  let messageDetail = '';
-  {
-    const request = context.request
-      ? `${action} ${preposition} "${context.request}"`
-      : action;
-    messageDetail = `${request} in account ${context.accountId}`;
-  }
-  const errorMessage = [];
-  if (isPutOrPost && context.payload) {
-    errorMessage.push(`Unable to upload "${context.payload}".`);
-  }
-  const isProjectMissingScopeError = isMissingScopeError(error) && projectName;
-  const isProjectGatingError = isGatingError(error) && projectName;
-  switch (statusCode) {
-    case 400:
-      errorMessage.push(i18n(`${i18nKey}.codes.400`, { messageDetail }));
-      break;
-    case 401:
-      errorMessage.push(i18n(`${i18nKey}.codes.401`, { messageDetail }));
-      break;
-    case 403:
-      if (isProjectMissingScopeError) {
-        errorMessage.push(
-          i18n(`${i18nKey}.codes.403MissingScope`, {
-            accountId: context.accountId || '',
-          })
-        );
-      } else if (isProjectGatingError) {
-        errorMessage.push(
-          i18n(`${i18nKey}.codes.403Gating`, {
-            accountId: context.accountId || '',
-          })
-        );
-      } else {
-        errorMessage.push(i18n(`${i18nKey}.codes.403`, { messageDetail }));
-      }
-      break;
-    case 404:
-      if (context.request) {
-        errorMessage.push(
-          i18n(`${i18nKey}.codes.404Request`, {
-            action: action || 'request',
-            request: context.request,
-            account: context.accountId || '',
-          })
-        );
-      } else {
-        errorMessage.push(i18n(`${i18nKey}.codes.404`, { messageDetail }));
-      }
-      break;
-    case 429:
-      errorMessage.push(i18n(`${i18nKey}.codes.429`, { messageDetail }));
-      break;
-    case 503:
-      errorMessage.push(i18n(`${i18nKey}.codes.503`, { messageDetail }));
-      break;
-    default:
-      if (statusCode >= 500 && statusCode < 600) {
-        errorMessage.push(
-          i18n(`${i18nKey}.codes.500Generic`, { messageDetail })
-        );
-      } else if (statusCode >= 400 && statusCode < 500) {
-        i18n(`${i18nKey}.codes.400Generic`, { messageDetail });
-      } else {
-        errorMessage.push(i18n(`${i18nKey}.codes.generic`, { messageDetail }));
-      }
-      break;
+    logger.error(validationErrors.join('\n- '));
   }
-  if (
-    error.error &&
-    error.error.message &&
-    !isProjectMissingScopeError &&
-    !isProjectGatingError
-  ) {
-    errorMessage.push(error.error.message);
-  }
-  if (error.error && error.error.errors) {
-    error.error.errors.forEach(err => {
-      errorMessage.push('\n- ' + err.message);
-    });
-  }
-  logger.error(errorMessage.join(' '));
   debugErrorAndContext(error, context);
 }
 
@@ -253,19 +53,12 @@ function logApiStatusCodeError(error, context) {
  * @param {ApiErrorContext}          context
  */
 function logApiErrorInstance(error, context) {
-  // Use the new local-dev-lib error handler
-  // NOTE: This will eventually replace the logic in logApiStatusCodeError
   if (error.isAxiosError) {
     if (overrideErrors(error)) return;
     const errorWithContext = getAxiosErrorWithContext(error, context);
     logger.error(errorWithContext.message);
     return;
   }
-  // StatusCodeError
-  if (isApiStatusCodeError(error)) {
-    logApiStatusCodeError(error, context);
-    return;
-  }
   logErrorInstance(error, context);
 }
 
@@ -342,12 +135,7 @@ async function logServerlessFunctionApiErrorInstance(
     return;
   }
 
-  // StatusCodeError
-  if (isApiStatusCodeError(error)) {
-    logApiStatusCodeError(error, context);
-    return;
-  }
-  logErrorInstance(error, context);
+  logApiErrorInstance(error, context);
 }
 
 module.exports = {
@@ -356,7 +144,4 @@ module.exports = {
   logApiErrorInstance,
   logApiUploadErrorInstance,
   logServerlessFunctionApiErrorInstance,
-  isMissingScopeError,
-  isSpecifiedError,
-  isSpecifiedHubSpotAuthError,
 };

package/lib/errorHandlers/fileSystemErrors.js

@@ -1,24 +1,7 @@
-const { logger } = require('@hubspot/local-dev-lib/logger');
 const {
-  ErrorContext,
-  isSystemError,
-  debugErrorAndContext,
-} = require('./standardErrors');
-const { i18n } = require('../lang');
-
-const i18nKey = 'cli.lib.errorHandlers.fileSystemErrors';
-
-class FileSystemErrorContext extends ErrorContext {
-  constructor(props = {}) {
-    super(props);
-    /** @type {string} */
-    this.filepath = props.filepath || '';
-    /** @type {boolean} */
-    this.read = !!props.read;
-    /** @type {boolean} */
-    this.write = !!props.write;
-  }
-}
+  getFileSystemError,
+} = require('@hubspot/local-dev-lib/errors/fileSystemErrors');
+const { debugErrorAndContext, logErrorInstance } = require('./standardErrors');
 
 /**
  * Logs a message for an error instance resulting from filesystem interaction.
@@ -27,29 +10,11 @@ class FileSystemErrorContext extends ErrorContext {
  * @param {FileSystemErrorContext}   context
  */
 function logFileSystemErrorInstance(error, context) {
-  let fileAction = '';
-  if (context.read) {
-    fileAction = 'reading from';
-  } else if (context.write) {
-    fileAction = 'writing to';
-  } else {
-    fileAction = 'accessing';
-  }
-  const filepath = context.filepath
-    ? `"${context.filepath}"`
-    : 'a file or folder';
-  const message = [i18n(`${i18nKey}.errorOccurred`, { fileAction, filepath })];
-  // Many `fs` errors will be `SystemError`s
-  if (isSystemError(error)) {
-    message.push(
-      i18n(`${i18nKey}.errorExplanation`, { errorMessage: error.message })
-    );
-  }
-  logger.error(message.join(' '));
+  const fileSystemError = getFileSystemError(error, context);
+  logErrorInstance(fileSystemError.message, context);
   debugErrorAndContext(error, context);
 }
 
 module.exports = {
-  FileSystemErrorContext,
   logFileSystemErrorInstance,
 };

package/lib/errorHandlers/standardErrors.js

@@ -1,16 +1,12 @@
 const util = require('util');
-const {
-  HubSpotAuthError,
-} = require('@hubspot/local-dev-lib/models/HubSpotAuthError');
 const { logger } = require('@hubspot/local-dev-lib/logger');
+const {
+  isSystemError,
+} = require('@hubspot/local-dev-lib/errors/standardErrors');
 const { i18n } = require('../lang');
 
 const i18nKey = 'cli.lib.errorHandlers.standardErrors';
 
-const isSystemError = err =>
-  err.errno != null && err.code != null && err.syscall != null;
-const isFatalError = err => err instanceof HubSpotAuthError;
-
 // TODO: Make these TS interfaces
 class ErrorContext {
   constructor(props = {}) {
@@ -103,7 +99,5 @@ function logErrorInstance(error, context) {
 module.exports = {
   debugErrorAndContext,
   ErrorContext,
-  isFatalError,
-  isSystemError,
   logErrorInstance,
 };

package/lib/projects.js

@@ -27,7 +27,10 @@ const {
   fetchProject,
   uploadProject,
 } = require('@hubspot/local-dev-lib/api/projects');
-const { isSpecifiedError } = require('@hubspot/local-dev-lib/errors/apiErrors');
+const {
+  isSpecifiedError,
+  isSpecifiedHubSpotAuthError,
+} = require('@hubspot/local-dev-lib/errors/apiErrors');
 const { shouldIgnoreFile } = require('@hubspot/local-dev-lib/ignoreRules');
 const { getCwd, getAbsoluteFilePath } = require('@hubspot/local-dev-lib/path');
 const { downloadGithubRepoContents } = require('@hubspot/local-dev-lib/github');
@@ -39,7 +42,6 @@ const SpinniesManager = require('./ui/SpinniesManager');
 const {
   logApiErrorInstance,
   ApiErrorContext,
-  isSpecifiedHubSpotAuthError,
 } = require('./errorHandlers/apiErrors');
 const { HUBSPOT_PROJECT_COMPONENTS_GITHUB_PATH } = require('./constants');
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hubspot/cli",
-  "version": "5.2.0",
+  "version": "5.2.1-beta.0",
   "description": "CLI for working with HubSpot",
   "license": "Apache-2.0",
   "repository": {
@@ -8,10 +8,10 @@
     "url": "https://github.com/HubSpot/hubspot-cms-tools"
   },
   "dependencies": {
-    "@hubspot/local-dev-lib": "^0.3.10",
-    "@hubspot/serverless-dev-runtime": "5.1.4-beta.6",
+    "@hubspot/local-dev-lib": "^0.3.13",
+    "@hubspot/serverless-dev-runtime": "5.2.1-beta.0",
     "@hubspot/theme-preview-dev-server": "0.0.4",
-    "@hubspot/ui-extensions-dev-server": "0.8.11",
+    "@hubspot/ui-extensions-dev-server": "0.8.12",
     "archiver": "^5.3.0",
     "chalk": "^4.1.2",
     "chokidar": "^3.0.1",
@@ -45,5 +45,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b617fec2c05af70815192d7a41127d90f5c6b6d2"
+  "gitHead": "ce6013a55ac84a69335200abbcbc6fc8080585b7"
 }