@hublo/sentinel 1.5.0-alpha.27 → 1.5.0-alpha.28

package/dist/bin/sentinel.js

@@ -15,10 +15,10 @@ import {
   palette,
   registerAdapters,
   resolve
-} from "../chunk-LDW6VLUY.js";
+} from "../chunk-BYV4XD5W.js";
 import {
   resolveContext
-} from "../chunk-ZMVI65FF.js";
+} from "../chunk-OS5TMEKH.js";
 import {
   ensureWorkspacePrep,
   findWorkspaceRoot,
@@ -148,7 +148,7 @@ async function runValidate(ctx) {
     );
   }
   if (!ctx.targets.includes("test")) return 1;
-  const { validateModuleTests } = await import("../validate-AOJGDBHA.js");
+  const { validateModuleTests } = await import("../validate-3KEHAU66.js");
   const outcomes = modules.flatMap(
     (module) => validateModuleTests(module.name, module.root)
   );

package/dist/{chunk-LDW6VLUY.js → chunk-BYV4XD5W.js}

@@ -52,8 +52,9 @@ import {
   rewriteToolchainImports,
   selfCommand,
   splitToolArgs,
-  walk
-} from "./chunk-ZMVI65FF.js";
+  walk,
+  writtenFileFormatter
+} from "./chunk-OS5TMEKH.js";
 import {
   DEFAULT_MAX_DIAGNOSTICS,
   WORKSPACE_ROOT_MARKER,
@@ -7284,6 +7285,59 @@ var JscpdAdapter = class extends BaseAdapter {
     if (emitting) await emit(report, shape, ctx.cwd, graph, coverage);
     return { ok: true, code: 0, metrics: metricsOf(report) };
   }
+  /**
+   * Format what `--init` wrote, with the MODULE's own formatter.
+   *
+   * ⛔ Found by adopting the role on `libs/front/ui`, where the module's `lint` target is
+   * `prettier --check . && eslint .`. Adoption turned it red on the two files adoption itself had
+   * just written:
+   *
+   *     [warn] package.json
+   *     [warn] static-analysis.config.mjs
+   *
+   * So a team adopting this role is handed a red lint on a target the adoption never touched, for
+   * something the adoption caused. That is what the test role already refuses in its own words:
+   * "the migration handing its own consequence to whoever adopts, which is the one thing this role
+   * must not do". It had the mechanism and this role did not use it.
+   *
+   * ⚠️ The blast radius is small and measured: **2 modules of 243** run `prettier --check` in their
+   * own lint without having adopted our format role, `apps/front/host-admin` and `libs/front/ui`.
+   * Small is not a reason to leave it: the two are exactly the modules a team would adopt by hand.
+   *
+   * The formatter is borrowed from the test role rather than written again, the same way the size
+   * gauge borrows `resolveOxlint` from the lint role: it already knows how a module declares a
+   * style, including the case where that style IS ours.
+   *
+   * ⛔ Never fatal. Adoption succeeded; only the tidy-up did not. Reverting an adoption over a
+   * formatting pass would be the wrong trade, so a failure here is reported as what it is.
+   *
+   * No batching, unlike the test role: `--init` writes two files, and the OOM that forced batches
+   * there came from handing a formatter 273 at once.
+   */
+  async afterInit(ctx) {
+    const written = ctx.written ?? [];
+    if (written.length === 0) return Promise.resolve();
+    const formatter = writtenFileFormatter(ctx.cwd);
+    if (formatter === void 0) {
+      this.say(
+        `no style is declared here, by this module or its workspace, so the ${written.length} file(s) this wrote keep the shape they were written in. Run your own formatter over them before committing.`
+      );
+      return Promise.resolve();
+    }
+    const pass = spawnSync6(formatter.bin, [...formatter.args, ...written], {
+      cwd: ctx.cwd,
+      encoding: "utf8"
+    });
+    this.say(
+      pass.status === 0 ? `formatted the ${written.length} file(s) this wrote with ${formatter.origin}, so a format check passes on files it did not write itself.` : `${formatter.origin} could not run over the ${written.length} file(s) this wrote. Adoption itself is applied; run your formatter before committing.`
+    );
+    return Promise.resolve();
+  }
+  /** One line, prefixed like every other message this role writes. */
+  say(message) {
+    process.stderr.write(`sentinel static-analysis(jscpd): ${message}
+`);
+  }
   /** `--run`: measure and show it. */
   async run(ctx) {
     return this.measure(ctx, true);
@@ -7518,7 +7572,7 @@ function safeParseDeadCode(text) {
     return void 0;
   }
 }
-function placesToLook(product, tests, dead, complexity, graph, size) {
+function placesToLook(product, tests, dead, complexity, graph, size, unreadable) {
   const at = (side) => `${side?.name ?? "(unknown)"}${side?.start === void 0 ? "" : `:${side.start}`}`;
   const clones = (outcome, metric) => outcome.kind === "figures" ? outcome.duplicates.map((entry) => ({
     metric,
@@ -7543,7 +7597,7 @@ function placesToLook(product, tests, dead, complexity, graph, size) {
       name: fn.name,
       value: fn.complexity
     })),
-    ...dead.kind === "figures" ? dead.findings.map((finding) => ({
+    ...dead.kind === "figures" && !unreadable ? dead.findings.map((finding) => ({
       metric: deadMetric[finding.category ?? ""] ?? "deadLinesPercent",
       path: finding.path ?? "(unknown)",
       ...finding.name ? { name: finding.name } : {},
@@ -7555,7 +7609,7 @@ function placesToLook(product, tests, dead, complexity, graph, size) {
     // One finding per GROUP of mutually importing files, not per cycle path: see `graph/scan.ts`.
     // The first file names the finding and the rest go in `other`, which is the shape the report
     // already renders for a clone's two sides.
-    ...graph.cycles.map((cycle) => ({
+    ...(unreadable ? [] : graph.cycles).map((cycle) => ({
       metric: "cycles",
       path: cycle.files[0] ?? "(unknown)",
       other: cycle.files.slice(1).join(", "),
@@ -7593,7 +7647,7 @@ function placesToLook(product, tests, dead, complexity, graph, size) {
     })),
     // ⛔ Context, not defects. Every module has a most-imported file, and nothing here says the
     // count is too high: the caveat on the metric says so in the reader's own words.
-    ...graph.mostImported.map((file) => ({
+    ...(unreadable ? [] : graph.mostImported).map((file) => ({
       metric: "mostImported",
       path: file.path,
       value: file.importedBy,
@@ -7779,17 +7833,22 @@ function assembleReport(ctx, config, product, tests, dead, complexity, graph, co
        * 2% of the files, so the reader looks for a big generated or seed file instead of concluding
        * anything about the code they write. Nothing is computed that the pass did not hand over.
        *
-       * ⚠️ "`;` ... unreachable IN FULL" and not "in N files", which is what this said first. The
+       * ⚠️ "N files UNREACHABLE IN FULL" and not "in N files", which is what this said first. The
        * two numbers do NOT contain one another: dead lines also come from exports and symbols that
        * are dead inside files the walk DOES reach. Measured on `apps/front/console`, 0 files are
        * unreachable and 0.64% of lines are still dead, which read as a contradiction. On `agency`
        * the wording looked right only by coincidence, because 13 files carried 53 233 of its
        * 53 242 dead lines.
+       *
+       * ⛔ And a COMMA, not a semicolon. The markdown recap truncates a unit at its first `;`,
+       * because the bundle units carry a second comparison that pushes a table row past readable
+       * width. A semicolon here meant the recap silently dropped the very denominator this comment
+       * exists for, which is the shape of defect the denominator was added to prevent.
        */
       {
         metric: "deadLinesPercent",
         value: share(stats),
-        unit: `% of lines; ${(stats.files ?? 0) - (stats.reachableFiles ?? 0)} of ${stats.files ?? 0} files are unreachable in full`
+        unit: `% of lines, ${(stats.files ?? 0) - (stats.reachableFiles ?? 0)} of ${stats.files ?? 0} files unreachable in full`
       },
       // ⛔ Minus the files the TOOL itself labels `used-only-by-tests`. They were counted as
       // unreachable while the tool knew better: measured on `libs/nest/auth`, 5 of the 20. A file a
@@ -7897,7 +7956,7 @@ function assembleReport(ctx, config, product, tests, dead, complexity, graph, co
     rows,
     notes,
     settings,
-    findings: placesToLook(product, tests, dead, complexity, graph, size),
+    findings: placesToLook(product, tests, dead, complexity, graph, size, unreadable),
     byLanguage
   };
 }

package/dist/{chunk-ZMVI65FF.js → chunk-OS5TMEKH.js}

@@ -6553,6 +6553,7 @@ export {
   oxlintPath,
   oxlintSearchPath,
   walk,
+  writtenFileFormatter,
   readTestAdoption,
   resolveContext,
   moduleEnvironment,

package/dist/index.js

@@ -6,10 +6,10 @@ import {
   registerAdapters,
   resolve,
   setDefaultRunner
-} from "./chunk-LDW6VLUY.js";
+} from "./chunk-BYV4XD5W.js";
 import {
   BaseAdapter
-} from "./chunk-ZMVI65FF.js";
+} from "./chunk-OS5TMEKH.js";
 import "./chunk-JEYGPPSL.js";
 import "./chunk-GCHCLR7P.js";
 import "./chunk-O7REVMOC.js";

package/dist/{validate-AOJGDBHA.js → validate-3KEHAU66.js}

@@ -7,7 +7,7 @@ import {
   readTestAdoption,
   resolveVitest,
   suiteOf
-} from "./chunk-ZMVI65FF.js";
+} from "./chunk-OS5TMEKH.js";
 import "./chunk-JEYGPPSL.js";
 import "./chunk-O7REVMOC.js";
 import "./chunk-QXFCZON7.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hublo/sentinel",
-  "version": "1.5.0-alpha.27",
+  "version": "1.5.0-alpha.28",
   "description": "One CLI that guards code health across Hublo repos: shared lint/typescript/build/test presets, static & dynamic analysis, and architecture checks.",
   "type": "module",
   "license": "MIT",