@hublo/sentinel 1.5.0-alpha.25 → 1.5.0-alpha.26

package/dist/bin/sentinel.js

@@ -15,7 +15,7 @@ import {
   palette,
   registerAdapters,
   resolve
-} from "../chunk-I3IEZLBG.js";
+} from "../chunk-WDZRBHMH.js";
 import {
   resolveContext
 } from "../chunk-ZMVI65FF.js";

package/dist/{chunk-I3IEZLBG.js → chunk-WDZRBHMH.js}

@@ -5488,8 +5488,8 @@ var metricsHelp = {
   },
   deadLinesPercent: {
     label: "Unreachable lines",
-    what: "The share of scanned lines the reachability walk never reached from an entry point.",
-    read: "Higher is worse, and only once the entry-point count above says the question was decidable. Read it next to the four counts below rather than alone: one number covering files, exports, symbols and imports hides four different kinds of work.",
+    what: "The share of scanned lines the reachability walk never reached from an entry point, with the share of FILES those lines sit in beside it.",
+    read: "\u26D4 Read the two denominators together or the figure misleads, and that is measured rather than feared. On `apps/nest/microservices/agency` the line share is 60.21%, which reads as a rotten module or a broken tool; neither is true. 490 of its 504 files are reachable, and ONE unreachable file, a seed data table, holds 52 210 lines, 59.3% of the module by itself. A large line share over a small file share means a generated or seed file, not code anyone writes. Higher is worse, and only once the entry-point count above says the question was decidable. Read it next to the four counts below rather than alone: one number covering files, exports, symbols and imports hides four different kinds of work.",
     caveat: "Unreachable here means unreachable WITHIN this module, and that is a measured limitation rather than a theoretical one. A library is consumed from outside the scan, so its files look unreachable: on a sample of 12 files reported dead, 9 of `libs/front/components` and 7 of `libs/nest/auth` are cited elsewhere in the repository, one of them in 356 files. Test, fixture and story files are also outside the reachability graph, verified on a fixture, so a file reached only by a story is reported unreachable; it is true of the product and false of the repository, and `libs/front/components` has one such file of 915 lines.",
     source: "jscpd's dead-code engine, `deadLines` over `totalLines`. The library figures were measured per module with the workspace's own path aliases, and the story case was isolated on a four-file fixture where the only importer was a `.stories.tsx`."
   },
@@ -6017,7 +6017,7 @@ function renderMarkdown(report) {
     const row = report.rows.find((candidate) => candidate.metric === family.headline);
     const marker = row?.status === void 0 ? "" : ` (${row.status})`;
     const shown = row?.unit.split(";")[0] ?? "";
-    const unit = shown === "" ? "" : `${shown === "%" ? "" : " "}${shown}`;
+    const unit = shown === "" ? "" : `${shown.startsWith("%") ? "" : " "}${shown}`;
     const value = row === void 0 ? "--" : `${figure(row)}${unit}${marker}`;
     const label = helpFor(family.headline)?.label ?? family.label;
     return `| ${label} | ${value} | ${places.get(family.label) ?? 0} |`;
@@ -7774,7 +7774,25 @@ function assembleReport(ctx, config, product, tests, dead, complexity, graph, co
         value: stats.entryPoints ?? 0,
         unit: `of ${stats.files ?? 0} files`
       },
-      { metric: "deadLinesPercent", value: share(stats), unit: "%" },
+      /**
+       * ⛔ The share of LINES, with the share of FILES beside it, because one without the other
+       * misleads and this was measured rather than imagined.
+       *
+       * On `apps/nest/microservices/agency` the line share reads **60.21%**, which in a
+       * pull-request comment says the module is rotten or the tool is broken. Neither is true:
+       * 490 of its 504 files are reachable, and a SINGLE unreachable file,
+       * `app/database/seed/data/legacy-agencies.ts`, holds **52 210 lines**, 59.3% of the module on
+       * its own. Twelve files carry 53 233 of the 53 242 dead lines.
+       *
+       * With both denominators the sentence reads correctly at a glance: 60% of the lines sit in
+       * 2% of the files, so the reader looks for a big generated or seed file instead of concluding
+       * anything about the code they write. Nothing is computed that the pass did not hand over.
+       */
+      {
+        metric: "deadLinesPercent",
+        value: share(stats),
+        unit: `% of lines, in ${(stats.files ?? 0) - (stats.reachableFiles ?? 0)} of ${stats.files ?? 0} files`
+      },
       // ⛔ Minus the files the TOOL itself labels `used-only-by-tests`. They were counted as
       // unreachable while the tool knew better: measured on `libs/nest/auth`, 5 of the 20. A file a
       // spec reaches is not unreachable, and leaving it in the headline count meant the figure

package/dist/index.js

@@ -6,7 +6,7 @@ import {
   registerAdapters,
   resolve,
   setDefaultRunner
-} from "./chunk-I3IEZLBG.js";
+} from "./chunk-WDZRBHMH.js";
 import {
   BaseAdapter
 } from "./chunk-ZMVI65FF.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hublo/sentinel",
-  "version": "1.5.0-alpha.25",
+  "version": "1.5.0-alpha.26",
   "description": "One CLI that guards code health across Hublo repos: shared lint/typescript/build/test presets, static & dynamic analysis, and architecture checks.",
   "type": "module",
   "license": "MIT",