@hublo/sentinel 1.2.0 → 1.3.0

package/dist/bin/sentinel.js

@@ -9,6 +9,7 @@ import {
   WORKSPACE_ROOT_MARKER,
   availableTargets,
   buildConfigFile,
+  correctingSignal,
   declaredPresetFor,
   describeFramework,
   dispatch,
@@ -22,7 +23,7 @@ import {
   registerAdapters,
   resolve,
   resolveBin
-} from "../chunk-Z5I6SEKF.js";
+} from "../chunk-676GBPMS.js";
 
 // bin/sentinel.ts
 import { program } from "commander";
@@ -235,6 +236,7 @@ async function analyse(params) {
           ) + "\n"
         );
       }
+      preset2 = correctingSignal(preset2, module.root)?.preset ?? preset2;
     }
     for (const target of params.targets) {
       let adapter;
@@ -655,7 +657,10 @@ program.name("sentinel").description("One CLI that guards code health: presets,
     "  sentinel --run --json                              # from root \u2192 all types, machine output",
     "  sentinel --run --ci                                # from root \u2192 affected only",
     "  sentinel --inspect --typescript                    # from root \u2192 adoption + what is deferred",
-    "  sentinel --init --preset react                     # adopt EVERY role: lint, format, typescript",
+    // Deliberately not enumerated here. A hand-written list drifts, and this one did: it
+    // still said "lint, format, typescript" after the build role shipped, so the help told
+    // adopters the build was not covered when it was. "Available now", below, is derived.
+    "  sentinel --init --preset react                     # adopt every available role (see below)",
     "  sentinel --init --typescript --preset react       # set up the current module + workspace",
     "  sentinel --run --typescript -- --noImplicitAny     # ask the tool a question of your own"
   ].join("\n")

package/dist/{chunk-Z5I6SEKF.js → chunk-676GBPMS.js}

@@ -1503,6 +1503,7 @@ var NATIVE_TS_ALIAS = "@typescript/native";
 var WORKSPACE_YAML = "pnpm-workspace.yaml";
 var RELEASE_AGE_KEY = "minimumReleaseAgeExclude";
 var LIST_ITEM = /^(\s*)-\s+(.*?)\s*$/;
+var MAP_ENTRY = /^(\s+)(.*?):\s+(.*?)\s*$/;
 function findWorkspaceRoot(startDir) {
   let dir = startDir;
   for (; ; ) {
@@ -1524,14 +1525,50 @@ function ensureI18nextSingleton(root, dryRun) {
   const pkg = JSON.parse(readFileSync10(pkgPath, "utf8"));
   const want = declaredNativeTs(pkg);
   if (!want) return void 0;
-  const have = pkg.pnpm?.overrides?.[OVERRIDE_KEY];
-  if (have === want) return void 0;
-  if (dryRun) return `would pin ${OVERRIDE_KEY} to ${want} (i18next singleton)`;
-  pkg.pnpm ??= {};
-  pkg.pnpm.overrides ??= {};
-  pkg.pnpm.overrides[OVERRIDE_KEY] = want;
-  writeFileSync(pkgPath, JSON.stringify(pkg, null, 2) + "\n");
-  return `pinned ${OVERRIDE_KEY} to ${want} in package.json (i18next singleton)`;
+  const yamlPath = join12(root, WORKSPACE_YAML);
+  if (!existsSync12(yamlPath)) return void 0;
+  const lines = readFileSync10(yamlPath, "utf8").split("\n");
+  const entry = findOverrideEntry(lines);
+  if (entry.valueIdx !== void 0 && entry.value === want) return void 0;
+  if (dryRun) return `would pin ${OVERRIDE_KEY} to ${want} in ${WORKSPACE_YAML} (i18next singleton)`;
+  applyOverride(lines, entry, want);
+  writeFileSync(yamlPath, lines.join("\n"));
+  return `pinned ${OVERRIDE_KEY} to ${want} in ${WORKSPACE_YAML} (i18next singleton)`;
+}
+function findOverrideEntry(lines) {
+  const blockIdx = lines.findIndex((line) => line.replace(/\s+$/, "") === "overrides:");
+  if (blockIdx === -1) return { indent: "  " };
+  let lastEntryIdx = blockIdx;
+  let indent = "  ";
+  for (let i = blockIdx + 1; i < lines.length; i++) {
+    const match = lines[i]?.match(MAP_ENTRY);
+    if (!match) break;
+    indent = match[1] ?? indent;
+    lastEntryIdx = i;
+    if ((match[2] ?? "").replace(/^['"]|['"]$/g, "") === OVERRIDE_KEY) {
+      return {
+        valueIdx: i,
+        value: (match[3] ?? "").replace(/^['"]|['"]$/g, ""),
+        blockIdx,
+        lastEntryIdx,
+        indent
+      };
+    }
+  }
+  return { blockIdx, lastEntryIdx, indent };
+}
+function applyOverride(lines, entry, want) {
+  const line = `${entry.indent}'${OVERRIDE_KEY}': ${want}`;
+  if (entry.valueIdx !== void 0) {
+    lines[entry.valueIdx] = line;
+    return;
+  }
+  if (entry.lastEntryIdx !== void 0) {
+    lines.splice(entry.lastEntryIdx + 1, 0, line);
+    return;
+  }
+  while (lines.length > 0 && lines[lines.length - 1] === "") lines.pop();
+  lines.push("overrides:", line, "");
 }
 function ensureReleaseAgeAllowList(root, dryRun) {
   const yamlPath = join12(root, WORKSPACE_YAML);
@@ -1620,18 +1657,25 @@ function inspectWorkspacePrep(root) {
       pkg = {};
     }
   }
-  const pinned = pkg.pnpm?.overrides?.[OVERRIDE_KEY];
+  const yamlPath = join12(root, WORKSPACE_YAML);
+  const yaml = existsSync12(yamlPath) ? readFileSync10(yamlPath, "utf8") : void 0;
+  const pinned = yaml === void 0 ? void 0 : findOverrideEntry(yaml.split("\n")).value;
   if (pinned !== void 0) {
     const stillForks = declaredNativeTs(pkg);
     entries.push({
-      rule: `package.json \u2192 pnpm.overrides.${OVERRIDE_KEY}`,
+      rule: `${WORKSPACE_YAML} \u2192 overrides.${OVERRIDE_KEY}`,
       reason: stillForks === void 0 ? `pinned to ${pinned}, but the root no longer declares ${NATIVE_TS_ALIAS}, so nothing forks any more. This override is now dead config and can be removed.` : `pinned to ${pinned}, matching the second TypeScript the root declares (${NATIVE_TS_ALIAS}). It re-resolves i18next for EVERY module that depends on it, not only adopted ones. It retires with the second TypeScript.`
     });
   }
+  const legacy = pkg.pnpm?.overrides?.[OVERRIDE_KEY];
+  if (legacy !== void 0) {
+    entries.push({
+      rule: `package.json \u2192 pnpm.overrides.${OVERRIDE_KEY}`,
+      reason: `pinned to ${legacy}, but pnpm 11 no longer reads the \`pnpm\` field of package.json and says nothing about it, so this override is not applied. Move it to ${WORKSPACE_YAML} under \`overrides:\`, which pnpm 10 and 11 both read.`
+    });
+  }
   const own = readOwnPackage().name;
-  const yamlPath = join12(root, WORKSPACE_YAML);
-  if (existsSync12(yamlPath)) {
-    const yaml = readFileSync10(yamlPath, "utf8");
+  if (yaml !== void 0) {
     const listed = new RegExp(`^\\s*-\\s*['"]?${own.replace("/", "\\/")}['"]?\\s*$`, "m").test(yaml);
     if (listed) {
       const gated = new RegExp(`^\\s*minimumReleaseAge\\s*:`, "m").test(yaml);
@@ -1951,6 +1995,7 @@ function toModulePattern(pattern) {
   const trimmed = pattern.trim();
   if (trimmed.startsWith("!")) return void 0;
   if (trimmed.startsWith("/**/")) return trimmed.slice(1);
+  if (trimmed.startsWith("**/")) return trimmed;
   if (trimmed.startsWith("/")) return void 0;
   return trimmed.replace(/\/$/, "").includes("/") ? void 0 : trimmed;
 }
@@ -6475,7 +6520,11 @@ var PATH_SIGNALS = [
   }
 ];
 var DEPENDENCY_SIGNALS = [
-  { preset: "react", pattern: /^(react|react-dom|@types\/react)$|^eslint-plugin-react/ },
+  // Runtime dependencies only. `eslint-plugin-react*` used to count here, but a lint plugin is
+  // TOOLING: this very repo depends on `eslint-plugin-react-refresh` to ship React rules to
+  // other projects, and was therefore read as a React app itself. No module in the monorepo
+  // carries an `eslint-plugin-react*` without also carrying react, so nothing loses detection.
+  { preset: "react", pattern: /^(react|react-dom|@types\/react)$/ },
   { preset: "svelte", pattern: /^svelte$|^@sveltejs\// },
   { preset: "nest", pattern: /^@nestjs\// }
 ];
@@ -6534,6 +6583,10 @@ function presetSignals(cwd) {
   }
   return signals;
 }
+function correctingSignal(detected, cwd) {
+  const [signal] = presetSignals(cwd);
+  return signal !== void 0 && signal.preset !== detected ? signal : void 0;
+}
 function presetContradiction(declared, cwd) {
   const signals = presetSignals(cwd);
   if (signals.length === 0) return void 0;
@@ -6614,8 +6667,8 @@ async function dispatch(opts) {
   }
   let effective = preset;
   if (opts.preset === void 0 && adapter.declaredPreset?.(opts.cwd) === void 0) {
-    const [signal] = presetSignals(opts.cwd);
-    if (signal !== void 0 && signal.preset !== preset) {
+    const signal = correctingSignal(preset, opts.cwd);
+    if (signal !== void 0) {
       effective = signal.preset;
       process.stderr.write(
         `  detected "${preset}" from dependencies, but ${signal.evidence}, so adopting as "${signal.preset}". Pass --preset to override.
@@ -6683,8 +6736,9 @@ export {
   PRESET_NAMES,
   palette,
   registerAdapters,
+  correctingSignal,
   describeFramework,
   detectFramework,
   dispatch
 };
-//# sourceMappingURL=chunk-Z5I6SEKF.js.map
+//# sourceMappingURL=chunk-676GBPMS.js.map

package/dist/index.js

@@ -7,7 +7,7 @@ import {
   registerAdapters,
   resolve,
   setDefaultRunner
-} from "./chunk-Z5I6SEKF.js";
+} from "./chunk-676GBPMS.js";
 export {
   BaseAdapter,
   all,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hublo/sentinel",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "One CLI that guards code health across Hublo repos: shared lint/typescript/build/test presets, static & dynamic analysis, and architecture checks.",
   "type": "module",
   "license": "MIT",