@hublo/sentinel 1.2.0-alpha.26 → 1.2.0-alpha.28

package/dist/bin/sentinel.js

@@ -22,7 +22,7 @@ import {
   registerAdapters,
   resolve,
   resolveBin
-} from "../chunk-O7OXACCN.js";
+} from "../chunk-LNSAUFIM.js";
 
 // bin/sentinel.ts
 import { program } from "commander";

package/dist/{chunk-O7OXACCN.js → chunk-LNSAUFIM.js}

@@ -241,9 +241,16 @@ function workspaceRootHops(cwd, target) {
 import { existsSync as existsSync5, readFileSync as readFileSync5 } from "fs";
 import { join as join5 } from "path";
 
-// src/roles/build/adoption-drift.ts
-import { existsSync as existsSync4, readFileSync as readFileSync4 } from "fs";
-import { join as join4 } from "path";
+// src/core/config/module-type.ts
+function esmReadiness(fileName, packageType) {
+  if (/\.(mts|mjs)$/.test(fileName)) return { kind: "ready" };
+  if (packageType === "module") return { kind: "ready" };
+  const rename = fileName.replace(/\.(ts|js)$/, ".mts");
+  return {
+    kind: "blocked",
+    why: `sentinel is ESM only, and this module ${packageType === void 0 ? 'declares no `"type"`' : `declares \`"type": "${packageType}"\``}, so Node loads ${fileName} as CommonJS and the import fails. Two remedies, and adoption takes neither by itself because both reach beyond this build: add \`"type": "module"\` to this module's package.json, which changes how EVERY \`.js\` here loads, or rename the config to \`${rename}\`, which settles it in the filename where nothing can undo it.`
+  };
+}
 
 // src/core/config/manifest.ts
 import { existsSync as existsSync3, readFileSync as readFileSync3 } from "fs";
@@ -406,7 +413,9 @@ var SENTINEL_OWNED_BUILD_PACKAGES = OWNED_PACKAGES.map(
   (entry) => entry.package
 );
 
-// src/roles/build/adoption-drift.ts
+// src/roles/build/project-json.ts
+import { existsSync as existsSync4, readFileSync as readFileSync4 } from "fs";
+import { join as join4 } from "path";
 function projectTargets(cwd) {
   const path = join4(cwd, "project.json");
   if (!existsSync4(path)) return void 0;
@@ -416,6 +425,8 @@ function projectTargets(cwd) {
     return void 0;
   }
 }
+
+// src/roles/build/adoption-drift.ts
 function buildAdoptionDrift(cwd) {
   const drift = [];
   const manifest = readProjectPackageJson(cwd);
@@ -457,6 +468,12 @@ function buildAdoptionDrift(cwd) {
       `still declares a \`${BUILD_SCRIPT_NAME}\` target in project.json beside the one in package.json, so the module has two and which runs depends on the caller`
     );
   }
+  const devScript = moduleScripts(cwd)[DEV_SCRIPT_NAME];
+  if (devScript?.includes(SENTINEL_DEV_COMMAND) === true && projectTargets(cwd)?.[DEV_SCRIPT_NAME] !== void 0) {
+    drift.push(
+      `runs its \`${DEV_SCRIPT_NAME}\` script through sentinel but still declares a \`${DEV_SCRIPT_NAME}\` target in project.json, so one dev server has two declarations and editing the target stops the script from being what runs`
+    );
+  }
   return drift;
 }
 
@@ -511,7 +528,10 @@ function readBuildAdoption(cwd) {
   } catch (error) {
     return NOT_ADOPTED(configFile, error instanceof Error ? error.message : String(error));
   }
-  if (!importsPreset(source)) return NOT_ADOPTED(configFile);
+  if (!importsPreset(source)) {
+    const esm = esmReadiness(configFile, readProjectPackageJson(cwd).type);
+    return NOT_ADOPTED(configFile, esm.kind === "blocked" ? esm.why : null);
+  }
   const manifest = readProjectPackageJson(cwd);
   const declared = { ...manifest.dependencies, ...manifest.devDependencies };
   const ownDeclarations = SENTINEL_OWNED_BUILD_PACKAGES.filter((name) => name in declared).map(
@@ -886,6 +906,43 @@ function composeDevScript(existing, command) {
   return chunks.join(CHAIN);
 }
 
+// src/roles/build/dev-target.ts
+var DELEGATION_KEYS = /* @__PURE__ */ new Set(["executor", "options"]);
+var DELEGATION_OPTION_KEYS = /* @__PURE__ */ new Set(["command", "cwd"]);
+function delegatesToScript(target, scriptName) {
+  if (typeof target !== "object" || target === null || Array.isArray(target)) return false;
+  const entries = target;
+  if (!Object.keys(entries).every((key) => DELEGATION_KEYS.has(key))) return false;
+  if (entries["executor"] !== "nx:run-commands") return false;
+  const options = entries["options"];
+  if (typeof options !== "object" || options === null || Array.isArray(options)) return false;
+  const declared = options;
+  if (!Object.keys(declared).every((key) => DELEGATION_OPTION_KEYS.has(key))) return false;
+  const command = declared["command"];
+  if (typeof command !== "string") return false;
+  return new RegExp(String.raw`(^|\s)run\s+${scriptName}$`).test(command.trim());
+}
+function devScriptIsAdopted(devScript) {
+  return devScript !== void 0 && devScript.includes(SENTINEL_DEV_COMMAND);
+}
+function devTargetOperations(cwd, devScript) {
+  if (!devScriptIsAdopted(devScript)) return { operations: [] };
+  const target = projectTargets(cwd)?.[DEV_SCRIPT_NAME];
+  if (target === void 0) return { operations: [] };
+  if (!delegatesToScript(target, DEV_SCRIPT_NAME)) {
+    return {
+      operations: [],
+      note: `left the \`${DEV_SCRIPT_NAME}\` target in project.json alone: it does more than call \`pnpm run ${DEV_SCRIPT_NAME}\`, so removing it would drop behaviour this role never declared. Move what it does into the script, or keep it and accept the second home.`
+    };
+  }
+  return {
+    operations: [
+      { kind: "remove-json-keys", path: "project.json", keys: [["targets", DEV_SCRIPT_NAME]] }
+    ],
+    note: `removed the \`${DEV_SCRIPT_NAME}\` target from project.json: it only called \`pnpm run ${DEV_SCRIPT_NAME}\`, which nx infers from the script itself. host-admin has run without that target all along.`
+  };
+}
+
 // src/roles/build/nest/adopt.ts
 import { existsSync as existsSync10, readFileSync as readFileSync8 } from "fs";
 import { join as join10 } from "path";
@@ -977,11 +1034,6 @@ function describeUnmet(preset, unmet) {
 // src/core/config/rewrite-imports.ts
 import { parseSync } from "oxc-parser";
 var movedSpecifiers = (toolchain) => new Set(toolchain.owned.map((entry) => entry.specifier));
-function esmBlocker(fileName, packageType) {
-  if (/\.(mts|mjs)$/.test(fileName)) return void 0;
-  if (packageType === "module") return void 0;
-  return `sentinel is ESM only, and this module does not declare \`"type": "module"\`, so Vite would load ${fileName} as CommonJS and fail to require it. Add \`"type": "module"\` to this module's package.json, or rename the config to \`${fileName.replace(/\.(ts|js)$/, ".m$1")}\`, then run this again.`;
-}
 var defaultExportNames = (toolchain) => Object.fromEntries(
   toolchain.owned.filter((entry) => entry.default !== void 0).map((entry) => [entry.specifier, entry.default])
 );
@@ -1152,8 +1204,8 @@ function plan(context) {
 function planReactApp(context, configFile) {
   const notes = [];
   const operations = [];
-  const notEsm = esmBlocker(configFile, readProjectPackageJson(context.cwd).type);
-  if (notEsm !== void 0) return { operations: [], skipped: notEsm };
+  const esm = esmReadiness(configFile, readProjectPackageJson(context.cwd).type);
+  if (esm.kind === "blocked") return { operations: [], skipped: esm.why };
   const rewrite = rewriteBuildImports(readConfigSource(context.cwd, configFile), configFile);
   if (rewrite.kind === "blocked") {
     return {
@@ -1182,7 +1234,8 @@ function planReactApp(context, configFile) {
       `${configFile} now imports ${rewrite.moved.join(", ")} from \`${BUILD_PRESET_SPECIFIER}\`. Only the import lines changed: every attribute, alias and path is untouched, so this build produces what it produced before.`
     );
   }
-  operations.push(manifestOperation(context.cwd, buildScripts(context.cwd)));
+  const scripts = buildScripts(context.cwd);
+  operations.push(manifestOperation(context.cwd, scripts));
   operations.push(
     ...nxTargetOperations({
       cwd: context.cwd,
@@ -1192,6 +1245,9 @@ function planReactApp(context, configFile) {
       })
     })
   );
+  const dev = devTargetOperations(context.cwd, scripts[DEV_SCRIPT_NAME]);
+  operations.push(...dev.operations);
+  if (dev.note !== void 0) notes.push(dev.note);
   const owned = ownedBuildDependencies(context.cwd);
   if (owned.length > 0) {
     operations.push({ kind: "remove-json-keys", path: "package.json", keys: owned });
@@ -6631,4 +6687,4 @@ export {
   detectFramework,
   dispatch
 };
-//# sourceMappingURL=chunk-O7OXACCN.js.map
+//# sourceMappingURL=chunk-LNSAUFIM.js.map

package/dist/index.js

@@ -7,7 +7,7 @@ import {
   registerAdapters,
   resolve,
   setDefaultRunner
-} from "./chunk-O7OXACCN.js";
+} from "./chunk-LNSAUFIM.js";
 export {
   BaseAdapter,
   all,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hublo/sentinel",
-  "version": "1.2.0-alpha.26",
+  "version": "1.2.0-alpha.28",
   "description": "One CLI that guards code health across Hublo repos: shared lint/typescript/build/test presets, static & dynamic analysis, and architecture checks.",
   "type": "module",
   "license": "MIT",