@hublo/sentinel 1.2.0-alpha.10 → 1.2.0-alpha.12

package/dist/bin/sentinel.js

@@ -22,7 +22,7 @@ import {
   registerAdapters,
   resolve,
   resolveBin
-} from "../chunk-7WB7MQHD.js";
+} from "../chunk-I4ATYZKK.js";
 
 // bin/sentinel.ts
 import { program } from "commander";
@@ -114,7 +114,7 @@ function resolveContext(cwd2, opts2) {
   );
 }
 
-// src/roles/build/scope.ts
+// src/roles/build/declined.ts
 import { existsSync as existsSync2, readFileSync as readFileSync2 } from "fs";
 import { join as join3 } from "path";
 var DEPRECATED_NX_BUILDER = "@nx/webpack:webpack";
@@ -128,7 +128,7 @@ function buildsWithDeprecatedExecutor(cwd2) {
     return false;
   }
 }
-function explainBuildScope(cwd2) {
+function explainDecline(cwd2) {
   if (buildConfigFile(cwd2) !== void 0) {
     return ` This module HAS a Vite config, so detection is the likely problem: the build toolchain is declared at the workspace root, which makes a front app detect as "node". Pass --preset to say what it is.`;
   }
@@ -176,7 +176,7 @@ async function runInit(ctx) {
     } catch (error) {
       if (error instanceof PresetUnsupportedError) {
         if (ctx.targetsExplicit) {
-          const hint = type === "build" ? explainBuildScope(module.root) : ` Pass --preset if it was detected wrongly (hoisted dependencies make detection fall back to "node").`;
+          const hint = type === "build" ? explainDecline(module.root) : ` Pass --preset if it was detected wrongly (hoisted dependencies make detection fall back to "node").`;
           process.stderr.write(
             `
 sentinel (${type}): this module's preset is "${error.preset}", and --${type} has no adapter for it.${hint}

package/dist/{chunk-7WB7MQHD.js → chunk-I4ATYZKK.js}

@@ -504,7 +504,7 @@ function composeDevScript(existing, command) {
   if (at === -1) return existing;
   const rest = (chunks[at] ?? "").replace(/^.*?(^|\s|\/)vite(\s|$)/, "");
   const options = appOptions(rest);
-  chunks[at] = options === "" ? command : `${command} -- ${options}`;
+  chunks[at] = options === "" ? `${command} --` : `${command} -- ${options}`;
   return chunks.join(CHAIN);
 }
 
@@ -656,6 +656,7 @@ var REACT_PLUGIN_SPECIFIERS = ["@vitejs/plugin-react", "@tanstack/react-start"];
 function declaredBuildPreset(cwd) {
   const source = readBuildConfigSource(cwd);
   if (source === void 0) {
+    if (buildConfigFile(cwd) !== void 0) return void 0;
     return webpackBuildTarget(cwd) === void 0 ? void 0 : "nest";
   }
   if (importsSpecifier(source, BUILD_PRESET_SPECIFIERS.nest)) return "nest";
@@ -857,9 +858,9 @@ function buildScripts(cwd) {
     const own2 = moduleName(cwd);
     scripts[DEV_SCRIPT_NAME] = composeDevScript(
       existingDev,
-      // Trailing `--` for the same reason as the build script: whatever the caller appends
-      // reaches Vite, not sentinel's parser. It goes after `--module`, which is sentinel's own.
-      `${selfCommand(cwd, "--run --dev") ?? SENTINEL_DEV_COMMAND} --module ${own2} --`
+      // No trailing `--` here: `composeDevScript` owns the separator, and adding one on both
+      // sides produced `-- --`, handing Vite an argument nobody wrote.
+      `${selfCommand(cwd, "--run --dev") ?? SENTINEL_DEV_COMMAND} --module ${own2}`
     );
   }
   return scripts;
@@ -873,75 +874,59 @@ function plan(context) {
   if (unmet.length > 0) {
     return { operations: [], skipped: describeUnmet(context.preset, unmet) };
   }
-  if (declaredBuildPreset(context.cwd) === void 0 && buildConfigFile(context.cwd) !== void 0) {
+  const declaredPreset2 = declaredBuildPreset(context.cwd);
+  const configFile = buildConfigFile(context.cwd);
+  if (declaredPreset2 === void 0 && configFile !== void 0) {
     return {
       operations: [],
-      skipped: `this module has a Vite config, but it does not build a React app (no @vitejs/plugin-react or @tanstack/react-start in it). The build role ships a React preset only.`
+      skipped: `this module has a Vite config, but it builds neither a React app (no @vitejs/plugin-react or @tanstack/react-start) nor a Nest service (no ${BUILD_PRESET_SPECIFIERS.nest}). Those are the two families this role serves.`
     };
   }
-  const notes = [];
-  const operations = [];
-  const configFile = buildConfigFile(context.cwd);
   const webpackTarget = webpackBuildTarget(context.cwd);
-  const isNest = declaredBuildPreset(context.cwd) === "nest" || webpackTarget !== void 0;
-  if (isNest) {
-    if (webpackTarget === void 0) {
-      return {
-        operations: [],
-        skipped: `already building through sentinel: ${configFile ?? NEST_CONFIG_FILE} imports the nest preset and the nx target runs it. Nothing to change.`
-      };
-    }
-    const refusal = refusalFor(context.cwd, webpackTarget);
-    if (refusal !== void 0) return { operations: [], blocked: refusal };
-    const dropped = Object.keys(webpackTarget.configurations ?? {});
-    return {
-      operations: nestAdoptionOperations(context.cwd, webpackTarget),
-      notes: [
-        `wrote ${NEST_CONFIG_FILE} and pointed the nx build target at sentinel. The target stays \`nx:run-commands\` with \`forwardAllArgs: false\`, so the image's \`--generatePackageJson\` still works and the Dockerfile needs no change.`,
-        ...dropped.length > 0 ? [
-          `dropped the \`${dropped.join("`, `")}\` configuration${dropped.length > 1 ? "s" : ""} from the build target: its fileReplacements point at files that do not exist, so it replaced nothing. A live one would have blocked this instead.`
-        ] : [],
-        `verify with \`nx run ${webpackTarget.project}:generate-swagger-file\` and \`git diff --exit-code\`: it runs the built bundle, so it proves the service boots AND that its published contract did not move.`
-      ]
-    };
+  if (declaredBuildPreset(context.cwd) === "nest" || webpackTarget !== void 0) {
+    return planNestService(context, configFile, webpackTarget);
   }
   if (configFile === void 0) {
     return {
       operations: [],
       skipped: `no Vite config in this module, so there is nothing to point at sentinel. This role moves an existing config's imports; it does not introduce a bundler. If this module builds another way (36 services here build through \`@nx/webpack\`), the build role does not apply to it.`
     };
-  } else {
-    const notEsm = esmBlocker(configFile, readProjectPackageJson(context.cwd).type);
-    if (notEsm !== void 0) return { operations: [], skipped: notEsm };
-    const rewrite = rewriteBuildImports(readConfigSource(context.cwd, configFile), configFile);
-    if (rewrite.kind === "blocked") {
-      return {
-        operations: [],
-        skipped: `${configFile} could not be pointed at sentinel, so nothing was written: ${rewrite.why}. Nothing here is broken; this needs a look before the role applies.`
-      };
-    }
-    if (rewrite.kind === "rewritten") {
-      operations.push({ kind: "write", path: configFile, contents: rewrite.source });
-    }
-    for (const name of COMPANION_CONFIG_FILES) {
-      const source = readConfigSource(context.cwd, name);
-      if (source === "") continue;
-      const companion = rewriteBuildImports(source, name);
-      if (companion.kind === "rewritten") {
-        operations.push({ kind: "write", path: name, contents: companion.source });
-        notes.push(`${name} now imports ${companion.moved.join(", ")} from sentinel too.`);
-      } else if (companion.kind === "blocked") {
-        notes.push(
-          `${name} imports the toolchain and could NOT be pointed at sentinel: ${companion.why}. It will stop resolving when the workspace root drops these packages, and it will fail your TESTS rather than your build.`
-        );
-      }
-    }
-    if (rewrite.kind === "rewritten") {
+  }
+  return planReactApp(context, configFile);
+}
+function planReactApp(context, configFile) {
+  const notes = [];
+  const operations = [];
+  const notEsm = esmBlocker(configFile, readProjectPackageJson(context.cwd).type);
+  if (notEsm !== void 0) return { operations: [], skipped: notEsm };
+  const rewrite = rewriteBuildImports(readConfigSource(context.cwd, configFile), configFile);
+  if (rewrite.kind === "blocked") {
+    return {
+      operations: [],
+      skipped: `${configFile} could not be pointed at sentinel, so nothing was written: ${rewrite.why}. Nothing here is broken; this needs a look before the role applies.`
+    };
+  }
+  if (rewrite.kind === "rewritten") {
+    operations.push({ kind: "write", path: configFile, contents: rewrite.source });
+  }
+  for (const name of COMPANION_CONFIG_FILES) {
+    const source = readConfigSource(context.cwd, name);
+    if (source === "") continue;
+    const companion = rewriteBuildImports(source, name);
+    if (companion.kind === "rewritten") {
+      operations.push({ kind: "write", path: name, contents: companion.source });
+      notes.push(`${name} now imports ${companion.moved.join(", ")} from sentinel too.`);
+    } else if (companion.kind === "blocked") {
       notes.push(
-        `${configFile} now imports ${rewrite.moved.join(", ")} from \`${BUILD_PRESET_SPECIFIER}\`. Only the import lines changed: every attribute, alias and path is untouched, so this build produces what it produced before.`
+        `${name} imports the toolchain and could NOT be pointed at sentinel: ${companion.why}. It will stop resolving when the workspace root drops these packages, and it will fail your TESTS rather than your build.`
       );
     }
   }
+  if (rewrite.kind === "rewritten") {
+    notes.push(
+      `${configFile} now imports ${rewrite.moved.join(", ")} from \`${BUILD_PRESET_SPECIFIER}\`. Only the import lines changed: every attribute, alias and path is untouched, so this build produces what it produced before.`
+    );
+  }
   operations.push(manifestOperation(context.cwd, buildScripts(context.cwd)));
   operations.push(...nxTargetOperations({ cwd: context.cwd, targets: buildTarget() }));
   const owned = ownedBuildDependencies(context.cwd);
@@ -953,6 +938,27 @@ function plan(context) {
   }
   return { operations, notes };
 }
+function planNestService(context, configFile, webpackTarget) {
+  if (webpackTarget === void 0) {
+    return {
+      operations: [],
+      skipped: `already building through sentinel: ${configFile ?? NEST_CONFIG_FILE} imports the nest preset and the nx target runs it. Nothing to change.`
+    };
+  }
+  const refusal = refusalFor(context.cwd, webpackTarget);
+  if (refusal !== void 0) return { operations: [], blocked: refusal };
+  const dropped = Object.keys(webpackTarget.configurations ?? {});
+  return {
+    operations: nestAdoptionOperations(context.cwd, webpackTarget),
+    notes: [
+      `wrote ${NEST_CONFIG_FILE} and pointed the nx build target at sentinel. The target stays \`nx:run-commands\` with \`forwardAllArgs: false\`, so the image's \`--generatePackageJson\` still works and the Dockerfile needs no change.`,
+      ...dropped.length > 0 ? [
+        `dropped the \`${dropped.join("`, `")}\` configuration${dropped.length > 1 ? "s" : ""} from the build target: its fileReplacements point at files that do not exist, so it replaced nothing. A live one would have blocked this instead.`
+      ] : [],
+      `verify with \`nx run ${webpackTarget.project}:generate-swagger-file\` and \`git diff --exit-code\`: it runs the built bundle, so it proves the service boots AND that its published contract did not move.`
+    ]
+  };
+}
 function readConfigSource(cwd, configFile) {
   if (!existsSync8(join8(cwd, configFile))) return "";
   try {
@@ -6427,4 +6433,4 @@ export {
   detectFramework,
   dispatch
 };
-//# sourceMappingURL=chunk-7WB7MQHD.js.map
+//# sourceMappingURL=chunk-I4ATYZKK.js.map

package/dist/index.js

@@ -7,7 +7,7 @@ import {
   registerAdapters,
   resolve,
   setDefaultRunner
-} from "./chunk-7WB7MQHD.js";
+} from "./chunk-I4ATYZKK.js";
 export {
   BaseAdapter,
   all,

package/dist/roles/build/nest/toolchain.js

@@ -93,8 +93,9 @@ var DEFAULT_PROVIDED_BY_IMAGE = ["@prisma"];
 var externalPackages = (bundle) => {
   const emitted = new Set(Object.keys(bundle));
   const packages = /* @__PURE__ */ new Set();
-  for (const chunk of Object.values(bundle)) {
-    for (const imported of chunk.imports ?? []) {
+  for (const emittedFile of Object.values(bundle)) {
+    if (emittedFile.type !== "chunk") continue;
+    for (const imported of emittedFile.imports) {
       if (emitted.has(imported)) continue;
       if (imported.startsWith(".") || imported.startsWith("/")) continue;
       if (isBuiltin(imported)) continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hublo/sentinel",
-  "version": "1.2.0-alpha.10",
+  "version": "1.2.0-alpha.12",
   "description": "One CLI that guards code health across Hublo repos: shared lint/typescript/build/test presets, static & dynamic analysis, and architecture checks.",
   "type": "module",
   "license": "MIT",