@html-validate/eslint-config 9.4.6 → 9.6.0

package/index.mjs

@@ -34,6 +34,20 @@ function filterRules(rules, predicate) {
 }
 
 export default [
+	defineConfig({
+		name: "@html-validate/eslint-config/global-ignore",
+		ignores: [
+			"**/.vscode-test/**", // @vscode/test-electron
+			"**/coverage/**",
+			"**/dist/**",
+			"**/node_modules/**",
+			"**/out/**", // vscode-html-validate
+			"**/public/assets/**",
+			"**/temp/**",
+			"**/public/*.hot-update.js", // webpack
+		],
+	}),
+
 	defineConfig({
 		name: "@html-validate/eslint-config/language-options",
 		languageOptions: {
@@ -96,9 +110,11 @@ export default [
 
 			/* enable eslint-plugin-unicorn */
 			...eslintPluginUnicorn.configs.recommended.rules,
-			"unicorn/better-dom-traversing": "error",
 			"unicorn/catch-error-name": "off",
+			"unicorn/comment-content": "error",
 			"unicorn/consistent-assert": "off",
+			"unicorn/consistent-boolean-name": "off", // while i would like this for variables I prefer not to force it on parameters, etc
+			"unicorn/consistent-class-member-order": "off",
 			"unicorn/consistent-compound-words": [
 				"error",
 				{
@@ -109,20 +125,14 @@ export default [
 					},
 				},
 			],
-			"unicorn/consistent-date-clone": "error",
 			"unicorn/consistent-empty-array-spread": "off",
-			"unicorn/consistent-existence-index-check": "error",
-			"unicorn/consistent-function-scoping": "error",
-			"unicorn/consistent-json-file-read": "error",
-			"unicorn/consistent-template-literal-escape": "error",
 			"unicorn/custom-error-definition": "error",
 			"unicorn/dom-node-dataset": "off",
-			"unicorn/error-message": "error",
 			"unicorn/escape-case": "off", // typically not useful for this organisation
 			"unicorn/expiring-todo-comments": "off", // could be useful later
 			"unicorn/explicit-length-check": ["error", { "non-zero": "greater-than" }],
 			"unicorn/filename-case": [
-				// enforce kebab-case in filenames
+				/* enforce kebab-case in filenames */
 				"error",
 				{
 					case: "kebabCase",
@@ -130,157 +140,62 @@ export default [
 				},
 			],
 			"unicorn/import-style": "off", // off for now
-			"unicorn/isolated-functions": "error",
-			"unicorn/new-for-builtins": "error",
 			"unicorn/no-abusive-eslint-disable": "off", // covered by eslint-plugin-eslint-comments
-			"unicorn/no-accessor-recursion": "error",
-			"unicorn/no-anonymous-default-export": "error",
-			"unicorn/no-array-callback-reference": "off", // opinionated, prefer to allow passing function references to array methods (and for most part typescript will handle this)
-			"unicorn/no-array-fill-with-reference-type": "error",
-			"unicorn/no-array-for-each": "error",
-			"unicorn/no-array-from-fill": "error",
-			"unicorn/no-array-method-this-argument": "error",
+			"unicorn/no-array-callback-reference": "off", // opinionated, prefer to allow passing function references to array methods (and for most part TypeScript will handle this)
 			"unicorn/no-array-reduce": "off", // allow usage of reduce()
-			"unicorn/no-array-reverse": "error", // prefer immutable .toReversed() (available in Node.js 20+)
-			"unicorn/no-array-sort": "error", // prefer immutable .toSorted() (available in Node.js 20+)
-			"unicorn/no-await-expression-member": "error",
-			"unicorn/no-await-in-promise-methods": "error",
-			"unicorn/no-blob-to-file": "error",
 			"unicorn/no-canvas-to-image": "off", // not really relevant for the html-validate projects
-			"unicorn/no-confusing-array-splice": "error",
-			"unicorn/no-console-spaces": "error",
 			"unicorn/no-document-cookie": "off", // typically not useful for this organisation
-			"unicorn/no-duplicate-set-values": "error",
 			"unicorn/no-empty-file": "off",
-			"unicorn/no-exports-in-scripts": "error",
-			"unicorn/no-for-loop": "error",
-			"unicorn/no-hex-escape": "error",
 			"unicorn/no-immediate-mutation": "off",
-			"unicorn/no-incorrect-query-selector": "error",
-			"unicorn/no-instanceof-builtins": "error",
-			"unicorn/no-invalid-fetch-options": "off", // let typescript and tests handle this
-			"unicorn/no-invalid-file-input-accept": "off",
-			"unicorn/no-invalid-remove-event-listener": "error",
-			"unicorn/no-late-current-target-access": "error",
-			"unicorn/no-magic-array-flat-depth": "error",
-			"unicorn/no-manually-wrapped-comments": "off",
-			"unicorn/no-named-default": "off", // named default is useful for vue
+			"unicorn/no-invalid-argument-count": "off", // does not respect optional parameters (e.g. jsdoc [param])
+			"unicorn/no-invalid-fetch-options": "off", // let TypeScript and tests handle this
+			"unicorn/no-named-default": "off", // named default is useful for Vue.js
 			"unicorn/no-negated-condition": "off", // mostly agree with the rule but sometimes its useful to have the common case first even if negated
 			"unicorn/no-negation-in-equality-check": "off",
-			"unicorn/no-new-array": "error",
-			"unicorn/no-new-buffer": "error",
 			"unicorn/no-null": "off", // prefer using null over undefined
-			"unicorn/no-object-as-default-parameter": "error",
 			"unicorn/no-process-exit": "off", // covered by n/no-process-exit (enabled by recommended-module preset)
 			"unicorn/no-single-promise-in-promise-methods": "warn",
 			"unicorn/no-static-only-class": "off",
 			"unicorn/no-thenable": "off",
-			"unicorn/no-this-assignment": "error",
 			"unicorn/no-this-outside-of-class": "off", // disagree somewhat with the rule, flags stateful objects
-			"unicorn/no-typeof-undefined": "error",
-			"unicorn/no-unnecessary-array-flat-depth": "error",
-			"unicorn/no-unnecessary-array-splice-count": "error",
-			"unicorn/no-unnecessary-await": "error",
-			"unicorn/no-unnecessary-nested-ternary": "error",
 			"unicorn/no-unnecessary-polyfills": "off",
-			"unicorn/no-unnecessary-slice-end": "error",
 			"unicorn/no-unreadable-array-destructuring": "off",
 			"unicorn/no-unreadable-iife": "off",
-			"unicorn/no-unused-array-method-return": "error",
-			"unicorn/no-useless-collection-argument": "error",
-			"unicorn/no-useless-error-capture-stack-trace": "error",
-			"unicorn/no-useless-fallback-in-spread": "error",
-			"unicorn/no-useless-iterator-to-array": "error",
-			"unicorn/no-useless-length-check": "error",
-			"unicorn/no-useless-promise-resolve-reject": "error",
-			"unicorn/no-useless-spread": "error",
 			"unicorn/no-useless-switch-case": "off",
 			"unicorn/no-useless-undefined": "off", // opinionated, I prefer to explicitly pass undefined
-			"unicorn/no-zero-fractions": "error",
 			"unicorn/number-literal-case": ["error", { hexadecimalValue: "lowercase" }],
 			"unicorn/numeric-separators-style": "off",
-			"unicorn/prefer-add-event-listener": "error",
-			"unicorn/prefer-array-find": "error",
-			"unicorn/prefer-array-flat": "error",
-			"unicorn/prefer-array-flat-map": "error",
-			"unicorn/prefer-array-index-of": "error",
-			"unicorn/prefer-array-last-methods": "error",
-			"unicorn/prefer-array-some": "error",
-			"unicorn/prefer-at": "error",
 			"unicorn/prefer-bigint-literals": "off",
-			"unicorn/prefer-blob-reading-methods": "error",
-			"unicorn/prefer-class-fields": "error",
 			"unicorn/prefer-classlist-toggle": "off",
-			"unicorn/prefer-code-point": "error",
-			"unicorn/prefer-date-now": "error",
-			"unicorn/prefer-default-parameters": "error",
 			"unicorn/prefer-dom-node-append": "off",
 			"unicorn/prefer-dom-node-remove": "off",
 			"unicorn/prefer-dom-node-text-content": "off",
 			"unicorn/prefer-event-target": "off",
-			"unicorn/prefer-export-from": "error",
-			"unicorn/prefer-get-or-insert-computed": "error",
 			"unicorn/prefer-global-this": "off",
-			"unicorn/prefer-https": "error",
 			"unicorn/prefer-import-meta-properties": "error",
-			"unicorn/prefer-includes": "error",
-			"unicorn/prefer-includes-over-repeated-comparisons": "error",
-			"unicorn/prefer-iterator-concat": "off",
-			"unicorn/prefer-iterator-to-array-at-end": "error",
-			"unicorn/prefer-keyboard-event-key": "error",
 			"unicorn/prefer-logical-operator-over-ternary": "off",
-			"unicorn/prefer-math-abs": "error",
-			"unicorn/prefer-math-min-max": "error",
-			"unicorn/prefer-math-trunc": "error",
 			"unicorn/prefer-modern-dom-apis": "off",
-			"unicorn/prefer-modern-math-apis": "error",
 			"unicorn/prefer-module": "off",
 			"unicorn/prefer-native-coercion-functions": "off",
-			"unicorn/prefer-negative-index": "error",
-			"unicorn/prefer-number-properties": "error",
-			"unicorn/prefer-object-from-entries": "error",
 			"unicorn/prefer-optional-catch-binding": "off", // covered by sonarjs/no-ignored-exceptions
-			"unicorn/prefer-prototype-methods": "error",
-			"unicorn/prefer-query-selector": "error",
 			"unicorn/prefer-queue-microtask": [
 				"error",
 				{ checkSetImmediate: true, checkSetTimeout: true },
 			],
-			"unicorn/prefer-reflect-apply": "error",
-			"unicorn/prefer-regexp-test": "error",
 			"unicorn/prefer-response-static-json": "off",
-			"unicorn/prefer-set-has": "error",
-			"unicorn/prefer-set-size": "error",
-			"unicorn/prefer-simple-condition-first": "error",
+			"unicorn/prefer-scoped-selector": "off",
+			"unicorn/prefer-short-arrow-method": "off",
 			"unicorn/prefer-single-call": "off",
-			"unicorn/prefer-split-limit": "error",
 			"unicorn/prefer-spread": "off", // for now
-			"unicorn/prefer-string-match-all": "error",
-			"unicorn/prefer-string-pad-start-end": "error",
 			"unicorn/prefer-string-raw": "off", // for now
-			"unicorn/prefer-string-repeat": "error",
-			"unicorn/prefer-string-replace-all": "error",
-			"unicorn/prefer-string-slice": "error",
-			"unicorn/prefer-string-starts-ends-with": "error",
-			"unicorn/prefer-string-trim-start-end": "error",
-			"unicorn/prefer-structured-clone": "error",
-			"unicorn/prefer-switch": "error",
 			"unicorn/prefer-ternary": "off",
-			"unicorn/prefer-top-level-await": "error",
-			"unicorn/prefer-type-error": "error",
 			"unicorn/prevent-abbreviations": "off",
 			"unicorn/relative-url-style": "warn",
-			"unicorn/require-array-join-separator": "error",
 			"unicorn/require-css-escape": "off", // would be useful but we dont have CSS.escape()
 			"unicorn/require-module-attributes": "off",
 			"unicorn/require-module-specifiers": "off",
-			"unicorn/require-number-to-fixed-digits-argument": "error",
-			"unicorn/require-passive-events": "error",
 			"unicorn/switch-case-braces": "off",
-			"unicorn/switch-case-break-position": "error",
 			"unicorn/text-encoding-identifier-case": "off",
-			"unicorn/throw-new-error": "error",
-			"unicorn/try-complexity": "off",
 			...filterRules(eslintConfigPrettier.rules, (rule) => {
 				return rule.startsWith("unicorn/");
 			}),
@@ -355,7 +270,7 @@ export default [
 			"import-x/no-duplicates": "error",
 
 			/* this is checked by compiler and without additional configuration does not
-			 * work with typescript */
+			 * work with TypeScript */
 			"n/no-missing-import": "off",
 			"n/no-missing-require": "off",
 
@@ -369,20 +284,22 @@ export default [
 			"security/detect-object-injection": "off", // produces more noise than useful errors
 			"security/detect-unsafe-regex": "error",
 
-			"sonarjs/argument-type": "off", // handled by typescript (and this rule is sometimes wrong)
+			"sonarjs/argument-type": "off", // handled by TypeScript (and this rule is sometimes wrong)
 			"sonarjs/arguments-order": "off", // another slow rule, would be nice to have enabled thought
+			"sonarjs/assertions-in-tests": "off", // could be useful but yields lots of false positives (e.g. node:test isn't recognized)
 			"sonarjs/cognitive-complexity": "off", // already covered by native complexity rule
 			"sonarjs/concise-regex": "off", // already covered by unicorn/better-regex
 			"sonarjs/deprecation": "off", // already covered by @typescript-eslint/no-deprecated
-			"sonarjs/function-return-type": "off", // overly broad and opinionated, let typescript deal with this
+			"sonarjs/function-return-type": "off", // overly broad and opinionated, let TypeScript deal with this
 			"sonarjs/no-commented-code": "off", // neat rule but is very very slow (over 50% of the total linting time)
 			"sonarjs/no-control-regex": "off", // already covered by no-control-regexp
 			"sonarjs/no-empty-test-file": "off", // could be useful but it does not handle it.each or similar constructs thus yields more false positives than its worth */
 			"sonarjs/no-redundant-optional": "off", // flags "foo?: string | undefined" as redundant even if `exactOptionalPropertyTypes` tsconfig is enabled */
 			"sonarjs/no-skipped-tests": "off", // covered by jest/no-disabled-tests and mocha/no-pending-tests
 			"sonarjs/no-small-switch": "off", // prefer to use small switches when the intention is to all more cases later
+			"sonarjs/no-trivial-assertions": "off", // produces a bit too much noise
 			"sonarjs/no-unused-vars": "off", // already coveredby @typescript-eslint/no-unused-vars
-			"sonarjs/prefer-nullish-coalescing": "off", // requires typescript and strictNullChecks, which is sane, but we also use @typescript-eslint/prefer-nullish-coalescing so this becomes redundant
+			"sonarjs/prefer-nullish-coalescing": "off", // requires TypeScript and strictNullChecks, which is sane, but we also use @typescript-eslint/prefer-nullish-coalescing so this becomes redundant
 			"sonarjs/prefer-regexp-exec": "off", // prefer @typescript-eslint/prefer-regexp-exec
 			"sonarjs/prefer-single-boolean-return": "off", // prefer to use multiple returns even for booleans (looks better and can yield performance increase
 			"sonarjs/redundant-type-aliases": "off", // "redundant" type aliases helps with self-documenting code
@@ -392,7 +309,7 @@ export default [
 			"sonarjs/use-type-alias": "off", // overly broad, lets leave this to the discretion of the author
 			"sonarjs/void-use": "off", // used to silence warnings about unawaited promises
 
-			/* disable sonarjs aws related rules as we dont use aws */
+			/* disable sonarjs AWS related rules as we dont use AWS */
 			"sonarjs/aws-apigateway-public-api": "off",
 			"sonarjs/aws-ec2-rds-dms-public": "off",
 			"sonarjs/aws-ec2-unencrypted-ebs-volume": "off",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@html-validate/eslint-config",
-  "version": "9.4.6",
+  "version": "9.6.0",
   "description": "Eslint sharable config used by the various HTML-validate packages",
   "keywords": [
     "eslint"
@@ -49,8 +49,8 @@
     "eslint-plugin-prettier": "5.5.6",
     "eslint-plugin-regexp": "3.1.0",
     "eslint-plugin-security": "4.0.1",
-    "eslint-plugin-sonarjs": "4.0.3",
-    "eslint-plugin-unicorn": "65.0.1",
+    "eslint-plugin-sonarjs": "4.1.0",
+    "eslint-plugin-unicorn": "67.0.0",
     "find-up": "8.0.0",
     "globals": "17.3.0",
     "nunjucks": "3.2.4"
@@ -65,5 +65,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f0f0c8079b25c34f7ad7e96247b6b303ce4e1ca5"
+  "gitHead": "c70650aefb15e854e7de2837f52979a06d779da7"
 }

package/template/eslint.config.mjs.njk

@@ -25,18 +25,6 @@ import vueConfig from "@html-validate/eslint-config-vue";
 {% endif %}
 
 export default [
-	{
-		name: "Ignored files",
-		ignores: [
-			"**/coverage/**",
-			"**/dist/**",
-			"**/node_modules/**",
-			"**/out/**",
-			"**/public/assets/**",
-			"**/temp/**"
-		],
-	},
-
 	...defaultConfig,
 {% if typescript %}