@html-validate/eslint-config 6.8.2 → 6.10.0

package/eslint.mjs

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 
-import path from "node:path";
 import { spawn } from "node:child_process";
 import { createRequire } from "node:module";
+import path from "node:path";
 
 const require = createRequire(import.meta.url);
 const pkgPath = path.dirname(require.resolve("eslint/package.json"));

package/index.mjs

@@ -1,14 +1,14 @@
 import { fileURLToPath } from "node:url";
 import js from "@eslint/js";
-import globals from "globals";
 import eslintConfigPrettier from "eslint-config-prettier";
+import eslintPluginArrayFunc from "eslint-plugin-array-func";
 import eslintPluginEslintComments from "eslint-plugin-eslint-comments";
-import eslintPluginPrettier from "eslint-plugin-prettier";
 import eslintPluginImport from "eslint-plugin-import";
 import eslintPluginN from "eslint-plugin-n";
-import eslintPluginArrayFunc from "eslint-plugin-array-func";
+import eslintPluginPrettier from "eslint-plugin-prettier";
 import eslintPluginSecurity from "eslint-plugin-security";
 import eslintPluginSonarjs from "eslint-plugin-sonarjs";
+import globals from "globals";
 
 /**
  * @typedef {import("eslint").Linter.Config} Config
@@ -22,6 +22,15 @@ function defineConfig(config) {
 	return config;
 }
 
+/**
+ * @param {RulesRecord} rules
+ * @param {(rule: string) => boolean} predicate
+ * @returns {RulesRecord}
+ */
+function filterRules(rules, predicate) {
+	return Object.fromEntries(Object.entries(rules).filter(([key]) => predicate(key)));
+}
+
 export default [
 	defineConfig({
 		name: "@html-validate/eslint-config/language-options",
@@ -60,7 +69,27 @@ export default [
 		rules: {
 			...js.configs.recommended.rules,
 			...eslintPluginEslintComments.configs.recommended.rules,
-			...eslintConfigPrettier.rules,
+			...filterRules(eslintConfigPrettier.rules, (rule) => {
+				if (rule.startsWith("@stylistic/")) {
+					return false;
+				}
+				if (rule.startsWith("@babel/") || rule.startsWith("babel/")) {
+					return false;
+				}
+				if (rule.startsWith("flowtype/")) {
+					return false;
+				}
+				if (rule.startsWith("react/")) {
+					return false;
+				}
+				if (rule.startsWith("standard/")) {
+					return false;
+				}
+				if (rule.startsWith("unicorn/")) {
+					return false;
+				}
+				return true;
+			}),
 			...eslintPluginPrettier.configs.recommended.rules,
 			...eslintPluginImport.configs.errors.rules,
 			...eslintPluginN.configs["recommended-module"].rules,
@@ -116,7 +145,19 @@ export default [
 			"import/no-mutable-exports": "error",
 			"import/no-named-default": "error",
 			"import/no-useless-path-segments": "error",
-			"import/order": "error",
+			"import/order": [
+				"warn",
+				{
+					alphabetize: {
+						order: "asc",
+						orderImportKind: "asc",
+					},
+					named: {
+						enabled: true,
+						types: "types-first",
+					},
+				},
+			],
 			"import/no-named-as-default": "error",
 			"import/no-named-as-default-member": "error",
 			"import/no-duplicates": "error",
@@ -126,6 +167,9 @@ export default [
 			"n/no-missing-import": "off",
 			"n/no-missing-require": "off",
 
+			/* prefer "node:foo" over "foo" */
+			"n/prefer-node-protocol": "error",
+
 			"security/detect-child-process": "off", // produces more noise than useful errors
 			"security/detect-non-literal-fs-filename": "off", // html-validate reads files, don't want to acknowledge all occurrences
 			"security/detect-non-literal-regexp": "error",
@@ -133,19 +177,47 @@ export default [
 			"security/detect-object-injection": "off", // produces more noise than useful errors
 			"security/detect-unsafe-regex": "error",
 
+			"sonarjs/argument-type": "off", // handled by typescript (and this rule is sometimes wrong)
+			"sonarjs/arguments-order": "off", // another slow rule, would be nice to have enabled thought
 			"sonarjs/cognitive-complexity": "off", // already covered by native complexity rule
 			"sonarjs/deprecation": "off", // already covered by @typescript-eslint/no-deprecated
 			"sonarjs/function-return-type": "off", // overly broad and opinionated, let typescript deal with this
+			"sonarjs/no-commented-code": "off", // neat rule but is very very slow (over 50% of the total linting time)
+			"sonarjs/no-control-regex": "off", // already covered by no-control-regexp
 			"sonarjs/no-empty-test-file": "off", // could be useful but it does not handle it.each or similar constructs thus yields more false positives than its worth */
+			"sonarjs/no-skipped-tests": "off", // covered by jest/no-disabled-tests and mocha/no-pending-tests
 			"sonarjs/no-small-switch": "off", // prefer to use small switches when the intention is to all more cases later
 			"sonarjs/no-unused-vars": "off", // already coveredby @typescript-eslint/no-unused-vars
-			"sonarjs/unused-import": "off", // already covered by @typescript-eslint/no-unused-vars
 			"sonarjs/prefer-nullish-coalescing": "off", // requires typescript and strictNullChecks, which is sane, but we also use @typescript-eslint/prefer-nullish-coalescing so this becomes redundant
-			"sonarjs/prefer-single-boolean-return": "off", // prefer to use multiple returns even for booleans (looks better and can yield performance increase
-			"sonarjs/no-control-regex": "off", // already covered by no-control-regexp
 			"sonarjs/prefer-regexp-exec": "off", // prefer @typescript-eslint/prefer-regexp-exec
+			"sonarjs/prefer-single-boolean-return": "off", // prefer to use multiple returns even for booleans (looks better and can yield performance increase
+			"sonarjs/redundant-type-aliases": "off", // "redundant" type aliases helps with self-documenting code
 			"sonarjs/todo-tag": "off", // want to be able to leave todo tasks
+			"sonarjs/unused-import": "off", // already covered by @typescript-eslint/no-unused-vars
+			"sonarjs/unused-named-groups": "off", // named groups can help readability even if not used
+			"sonarjs/use-type-alias": "off", // overly broad, lets leave this to the discretion of the author
 			"sonarjs/void-use": "off", // used to silence warnings about unawaited promises
+
+			/* disable sonarjs aws related rules as we dont use aws */
+			"sonarjs/aws-apigateway-public-api": "off",
+			"sonarjs/aws-ec2-rds-dms-public": "off",
+			"sonarjs/aws-ec2-unencrypted-ebs-volume": "off",
+			"sonarjs/aws-efs-unencrypted": "off",
+			"sonarjs/aws-iam-all-privileges": "off",
+			"sonarjs/aws-iam-all-resources-accessible": "off",
+			"sonarjs/aws-iam-privilege-escalation": "off",
+			"sonarjs/aws-iam-public-access": "off",
+			"sonarjs/aws-opensearchservice-domain": "off",
+			"sonarjs/aws-rds-unencrypted-databases": "off",
+			"sonarjs/aws-restricted-ip-admin-access": "off",
+			"sonarjs/aws-s3-bucket-granted-access": "off",
+			"sonarjs/aws-s3-bucket-insecure-http": "off",
+			"sonarjs/aws-s3-bucket-public-access": "off",
+			"sonarjs/aws-s3-bucket-server-encryption": "off",
+			"sonarjs/aws-s3-bucket-versioning": "off",
+			"sonarjs/aws-sagemaker-unencrypted-notebook": "off",
+			"sonarjs/aws-sns-unencrypted-topics": "off",
+			"sonarjs/aws-sqs-unencrypted-queue": "off",
 		},
 	}),
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@html-validate/eslint-config",
-  "version": "6.8.2",
+  "version": "6.10.0",
   "description": "Eslint sharable config used by the various HTML-validate packages",
   "keywords": [
     "eslint"
@@ -64,5 +64,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b69afeeca8b352197fa28261583b5d585e850b9a"
+  "gitHead": "3387d5569fb64ddcf5ca5e8c8dd20645bba42381"
 }

package/template/eslint.config.mjs.njk

@@ -6,27 +6,30 @@ import path from "node:path";
 import { fileURLToPath } from "node:url";
 {% endif %}
 import defaultConfig from "@html-validate/eslint-config";
-{% if typescript %}
-import typescriptConfig from "@html-validate/eslint-config-typescript";
-{% endif %}
-{% if typeinfo %}
-import typescriptTypeinfoConfig from "@html-validate/eslint-config-typescript-typeinfo";
-{% endif %}
 {% if angularjs %}
 import angularjsConfig from "@html-validate/eslint-config-angularjs";
 {% endif %}
-{% if vue %}
-import vueConfig from "@html-validate/eslint-config-vue";
+{% if cypress %}
+import cypressConfig from "@html-validate/eslint-config-cypress";
 {% endif %}
 {% if jest %}
 import jestConfig from "@html-validate/eslint-config-jest";
 {% endif %}
-{% if cypress %}
-import cypressConfig from "@html-validate/eslint-config-cypress";
-{% endif %}
 {% if protractor %}
 import protractorConfig from "@html-validate/eslint-config-protractor";
 {% endif %}
+{% if typescript %}
+import typescriptConfig from "@html-validate/eslint-config-typescript";
+{% endif %}
+{% if typeinfo %}
+import typescriptTypeinfoConfig from "@html-validate/eslint-config-typescript-typeinfo";
+{% endif %}
+{% if vitest %}
+import vitestConfig from "@html-validate/eslint-config-vitest";
+{% endif %}
+{% if vue %}
+import vueConfig from "@html-validate/eslint-config-vue";
+{% endif %}
 
 {% if typeinfo %}
 const rootDir = path.dirname(fileURLToPath(import.meta.url));
@@ -94,6 +97,15 @@ export default [
 		...jestConfig,
 	},
 {% endif %}
+{% if vitest %}
+
+	{
+		name: "@html-validate/eslint-config-vitest",
+		files: ["**/*.spec.[jt]s"],
+		ignores: ["cypress/**", "tests/e2e/**"],
+		...vitestConfig,
+	},
+{% endif %}
 {% if cypress %}
 
 	{