@html-next/vertical-collection 3.0.0 → 3.1.0

package/.github/workflows/ci.yml

@@ -7,24 +7,24 @@ jobs:
   test:
     name: Run Tests
     runs-on: ubuntu-latest
-    timeout-minutes: 12
+    timeout-minutes: 8
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
-      - name: Use Node 14
-        uses: actions/setup-node@v2-beta
-        with:
-          node-version: 14.x
+      - name: Use Volta
+        uses: volta-cli/action@v1
 
       - name: Node Modules Cache
-        uses: actions/cache@v2
+        id: cache-npm
+        uses: actions/cache@v3
         with:
           path: '**/node_modules'
-          key: ci-yarn-${{ hashFiles('**/yarn.lock') }}
+          key: ci-yarn-${{ hashFiles('yarn.lock') }}
 
       - name: Install Dependencies
+        if: steps.cache-npm.outputs.cache-hit != 'true'
         run: yarn install --frozen-lockfile
 
       - name: Lint
@@ -38,7 +38,7 @@ jobs:
   test-ember-try:
     name: Run Tests
     runs-on: ubuntu-latest
-    timeout-minutes: 14
+    timeout-minutes: 15
 
     strategy:
       fail-fast: false
@@ -53,6 +53,8 @@ jobs:
             ember-lts-3.20,
             ember-lts-3.24,
             ember-lts-3.28,
+            ember-lts-4.4,
+            ember-4.5,
             ember-release,
             ember-beta,
             ember-canary,
@@ -60,21 +62,34 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
-      - name: Use Node 14
-        uses: actions/setup-node@v2-beta
-        with:
-          node-version: 14.x
+      - name: Use Volta
+        uses: volta-cli/action@v1
+
+      - name: Stash yarn.lock for cache key
+        run: cp yarn.lock __cache-key
 
       - name: Node Modules Cache
-        uses: actions/cache@v2
+        id: cache-npm
+        uses: actions/cache@v3
         with:
-          path: '**/node_modules'
-          key: ci-yarn-${{ matrix.ember-version }}-${{ hashFiles('**/yarn.lock') }}
+          path: |
+            node_modules
+            package.json
+            yarn.lock
+            __env
+          key: ci-yarn-v3-${{ matrix.ember-version }}-${{ hashFiles('config/ember-try.js', '__cache-key') }}
+          restore-keys: |
+            ci-yarn-${{ hashFiles('yarn.lock') }}
+
+      - name: Install Dependencies
+        if: steps.cache-npm.outputs.cache-hit != 'true'
+        run: yarn install --frozen-lockfile
 
-      - name: Install
-        run: yarn install --frozen-lockfile --ignore-engines
+      - name: Ember-Try Setup
+        if: steps.cache-npm.outputs.cache-hit != 'true'
+        run: node_modules/.bin/ember try:one ${{ matrix.ember-version }} --skip-cleanup --- bin/stash-env.sh
 
       - name: Run Tests
-        run: node_modules/.bin/ember try:one ${{ matrix.ember-version }} --skip-cleanup --- bin/run-tests-with-retry.sh
+        run: . bin/restore-env.sh && bin/run-tests-with-retry.sh

package/CHANGELOG.md

@@ -1,6 +1,21 @@
 Changelog
 =========
 
+
+## v3.1.0 (2022-08-04)
+
+#### :rocket: Enhancement
+* [#380](https://github.com/html-next/vertical-collection/pull/380) fix: enable parallel builds ([@runspired](https://github.com/runspired))
+
+#### :bug: Bug Fix
+* [#380](https://github.com/html-next/vertical-collection/pull/380) fix: enable parallel builds ([@runspired](https://github.com/runspired))
+* [#358](https://github.com/html-next/vertical-collection/pull/358) Delete virtual element ([@Atrue](https://github.com/Atrue))
+
+#### Committers: 3
+- Chris Thoburn ([@runspired](https://github.com/runspired))
+- Matthew Beale ([@mixonic](https://github.com/mixonic))
+- [@Atrue](https://github.com/Atrue)
+
 ## v3.0.0 (2022-05-03)
 
 

package/addon/-private/data-view/radar/radar.js

@@ -1,6 +1,7 @@
 import { A } from '@ember/array';
 import { set, get } from '@ember/object';
 import { assert } from '@ember/debug';
+import { run } from '@ember/runloop';
 import { DEBUG } from '@glimmer/env';
 
 import { Token, scheduler } from 'ember-raf-scheduler';
@@ -530,11 +531,19 @@ export default class Radar {
     if (_componentPool.length > 0) {
       if (shouldRecycle === true) {
         // Grab the DOM of the remaining components and move it to temporary node disconnected from
-        // the body. If we end up using these components again, we'll grab their DOM and put it back
-        for (let i = 0; i < _componentPool.length; i++) {
+        // the body if the item can be reused later otherwise delete the component to avoid virtual re-rendering of the
+        // deleted item. If we end up using these components again, we'll grab their DOM and put it back
+        for (let i = _componentPool.length - 1; i >= 0; i--) {
           const component = _componentPool[i];
-
-          insertRangeBefore(this._domPool, null, component.realUpperBound, component.realLowerBound);
+          const item = objectAt(items, component.index);
+          if (item) {
+            insertRangeBefore(this._domPool, null, component.realUpperBound, component.realLowerBound);
+          } else {
+            run(() => {
+              virtualComponents.removeObject(component);
+            });
+            _componentPool.splice(i, 1);
+          }
         }
       } else {
         virtualComponents.removeObjects(_componentPool);

package/bin/restore-env.sh

@@ -0,0 +1 @@
+export EMBER_OPTIONAL_FEATURES=$(cat __env)

package/bin/run-tests-with-retry.sh

@@ -24,4 +24,4 @@ function retry {
     fi
 }
 
-retry yarn test:ember
+yarn run ember build && retry yarn run ember test --path=dist

package/bin/stash-env.sh

@@ -0,0 +1 @@
+ printf '%s' "$EMBER_OPTIONAL_FEATURES" > __env

package/index.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const StripClassCallCheckPlugin = require('babel6-plugin-strip-class-callcheck');
+const StripClassCallCheckPlugin = require.resolve('babel6-plugin-strip-class-callcheck');
 const Funnel = require('broccoli-funnel');
 const Rollup = require('broccoli-rollup');
 const merge = require('broccoli-merge-trees');
@@ -138,7 +138,7 @@ module.exports = {
     const opts = {
       loose: true,
       plugins,
-      postTransformPlugins: [StripClassCallCheckPlugin]
+      postTransformPlugins: [[StripClassCallCheckPlugin, {}]]
     };
 
     return opts;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@html-next/vertical-collection",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "infinite-scroll, done right. done.",
   "keywords": [
     "occlusion",