@html-eslint/eslint-plugin 0.34.0-alpha.0 → 0.34.0

package/lib/rules/id-naming-convention.js

@@ -12,11 +12,7 @@ const {
   isPascalCase,
   isKebabCase,
 } = require("./utils/naming");
-const {
-  findAttr,
-  isAttributesEmpty,
-  isExpressionInTemplate,
-} = require("./utils/node");
+const { findAttr, isAttributesEmpty, hasTemplate } = require("./utils/node");
 const { createVisitors } = require("./utils/visitors");
 
 const MESSAGE_IDS = {
@@ -94,7 +90,12 @@ module.exports = {
         return;
       }
       const idAttr = findAttr(node, "id");
-      if (idAttr && idAttr.value && !checkNaming(idAttr.value.value)) {
+      if (
+        idAttr &&
+        idAttr.value &&
+        !hasTemplate(idAttr.value) &&
+        !checkNaming(idAttr.value.value)
+      ) {
         context.report({
           node: idAttr,
           data: {
@@ -117,7 +118,7 @@ module.exports = {
       if (
         idAttr &&
         idAttr.value &&
-        !isExpressionInTemplate(idAttr.value) &&
+        !hasTemplate(idAttr.value) &&
         !checkNaming(idAttr.value.value)
       ) {
         context.report({

package/lib/rules/no-duplicate-attrs.js

@@ -41,7 +41,7 @@ module.exports = {
       if (Array.isArray(node.attributes)) {
         const attrsSet = new Set();
         node.attributes.forEach((attr) => {
-          if (attr.key && attrsSet.has(attr.key.value)) {
+          if (attr.key && attrsSet.has(attr.key.value.toLowerCase())) {
             context.report({
               node: attr,
               data: {
@@ -50,7 +50,7 @@ module.exports = {
               messageId: MESSAGE_IDS.DUPLICATE_ATTRS,
             });
           } else {
-            attrsSet.add(attr.key.value);
+            attrsSet.add(attr.key.value.toLowerCase());
           }
         });
       }

package/lib/rules/utils/node.js

@@ -69,7 +69,7 @@ function isOverlapWithTemplates(templates, range) {
 }
 
 /**
- * @param {AttributeKey} node
+ * @param {AttributeKey | AttributeValue} node
  * @returns {boolean}
  */
 function hasTemplate(node) {
@@ -150,17 +150,6 @@ function getLocBetween(before, after) {
   };
 }
 
-/**
- * @param {AttributeValue} node
- * @return {boolean}
- */
-function isExpressionInTemplate(node) {
-  if (node.type === NODE_TYPES.AttributeValue) {
-    return node.value.indexOf("${") === 0;
-  }
-  return false;
-}
-
 /**
  * @param {AnyNode} node
  * @returns {node is Tag}
@@ -257,7 +246,6 @@ module.exports = {
   splitToLineNodes,
   getLocBetween,
   findParent,
-  isExpressionInTemplate,
   isTag,
   isComment,
   isText,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@html-eslint/eslint-plugin",
-  "version": "0.34.0-alpha.0",
+  "version": "0.34.0",
   "description": "ESLint plugin for html",
   "author": "yeonjuan",
   "homepage": "https://github.com/yeonjuan/html-eslint#readme",
@@ -45,11 +45,11 @@
     "accessibility"
   ],
   "dependencies": {
-    "@html-eslint/template-parser": "^0.33.0",
-    "@html-eslint/template-syntax-parser": "^0.34.0-alpha.0"
+    "@html-eslint/template-parser": "^0.34.0",
+    "@html-eslint/template-syntax-parser": "^0.34.0"
   },
   "devDependencies": {
-    "@html-eslint/parser": "^0.34.0-alpha.0",
+    "@html-eslint/parser": "^0.34.0",
     "@types/eslint": "^9.6.1",
     "@types/estree": "^0.0.47",
     "es-html-parser": "^1.0.0-alpha.4",
@@ -57,5 +57,5 @@
     "espree": "^10.3.0",
     "typescript": "^5.7.2"
   },
-  "gitHead": "4c4b4673a068ddc2f37bb2581048bdbfd09b34b2"
+  "gitHead": "f0401cc30d1510d6f5c7511280c0a6b9779fea0c"
 }

package/types/rules/id-naming-convention.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"id-naming-convention.d.ts","sourceRoot":"","sources":["../../lib/rules/id-naming-convention.js"],"names":[],"mappings":";;;wBAyCU,UAAU;;kBAxCN,OAAO,UAAU,EAAE,UAAU;WAC7B,OAAO,UAAU,EAAE,GAAG;iBACtB,OAAO,UAAU,EAAE,SAAS;gBAC5B,OAAO,UAAU,EAAE,QAAQ"}
+{"version":3,"file":"id-naming-convention.d.ts","sourceRoot":"","sources":["../../lib/rules/id-naming-convention.js"],"names":[],"mappings":";;;wBAqCU,UAAU;;kBApCN,OAAO,UAAU,EAAE,UAAU;WAC7B,OAAO,UAAU,EAAE,GAAG;iBACtB,OAAO,UAAU,EAAE,SAAS;gBAC5B,OAAO,UAAU,EAAE,QAAQ"}

package/types/rules/utils/node.d.ts

@@ -53,11 +53,6 @@ export function getLocBetween(before: {
  * @returns {null | AnyNode}
  */
 export function findParent(node: Exclude<AnyNode, Line>, predicate: (node: AnyNode) => boolean): null | AnyNode;
-/**
- * @param {AttributeValue} node
- * @return {boolean}
- */
-export function isExpressionInTemplate(node: AttributeValue): boolean;
 /**
  * @param {AnyNode} node
  * @returns {node is Tag}
@@ -108,8 +103,8 @@ export function isRangesOverlap(rangeA: Range, rangeB: Range): boolean;
  */
 export function getTemplateTokens(tokens: AnyToken[]): ((CommentContent | Text)["templates"][number])[];
 /**
- * @param {AttributeKey} node
+ * @param {AttributeKey | AttributeValue} node
  * @returns {boolean}
  */
-export function hasTemplate(node: AttributeKey): boolean;
+export function hasTemplate(node: AttributeKey | AttributeValue): boolean;
 //# sourceMappingURL=node.d.ts.map

package/types/rules/utils/node.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"node.d.ts","sourceRoot":"","sources":["../../../lib/rules/utils/node.js"],"names":[],"mappings":"wBACc,OAAO,aAAa,EAAE,SAAS;kBAC/B,OAAO,aAAa,EAAE,GAAG;wBACzB,OAAO,aAAa,EAAE,SAAS;uBAC/B,OAAO,aAAa,EAAE,QAAQ;mBAC9B,OAAO,aAAa,EAAE,IAAI;mBAC1B,OAAO,aAAa,EAAE,IAAI;6BAC1B,OAAO,aAAa,EAAE,cAAc;sBACpC,OAAO,aAAa,EAAE,OAAO;sBAC7B,OAAO,aAAa,EAAE,OAAO;6BAC7B,OAAO,aAAa,EAAE,cAAc;2BACpC,OAAO,aAAa,EAAE,YAAY;oBAClC,OAAO,QAAQ,EAAE,GAAG,CAAC,KAAK;6BAC1B,OAAO,QAAQ,EAAE,GAAG,CAAC,cAAc;uBACnC,OAAO,gBAAgB,EAAE,QAAQ;AAM/C;;;;GAIG;AACH,+BAJW,GAAG,GAAG,SAAS,GAAG,QAAQ,OAC1B,MAAM,GACJ,SAAS,GAAG,SAAS,CAMjC;AAED;;;;GAIG;AACH,wCAHW,GAAG,GAAG,SAAS,GAAG,QAAQ,GACxB,OAAO,CAInB;AAED;;;;GAIG;AACH,6CAHW,OAAO,GACL,OAAO,CAInB;AA+BD;;;;GAIG;AACH,uCAHW,IAAI,GAAG,cAAc,GACnB,IAAI,EAAE,CAwDlB;AAED;;;;;GAKG;AACH,sCAJW;IAAC,GAAG,EAAE,cAAc,CAAA;CAAC,SACrB;IAAC,GAAG,EAAE,cAAc,CAAA;CAAC,GACnB,cAAc,CAO1B;AA+DD;;;;GAIG;AACH,iCAJW,OAAO,CAAC,OAAO,EAAE,IAAI,CAAC,aACtB,CAAC,IAAI,EAAE,OAAO,KAAK,OAAO,GACxB,IAAI,GAAG,OAAO,CAgB1B;AAhFD;;;GAGG;AACH,6CAHW,cAAc,GACb,OAAO,CAOlB;AAED;;;GAGG;AACH,4BAHW,OAAO,GACL,IAAI,IAAI,GAAG,CAIvB;AAUD;;;GAGG;AACH,gCAHW,OAAO,GACL,IAAI,IAAI,OAAO,CAI3B;AAED;;;GAGG;AACH,6BAHW,OAAO,GACL,IAAI,IAAI,IAAI,CAIxB;AAED;;;GAGG;AACH,6BAHW,OAAO,GAAG,IAAI,GACZ,IAAI,IAAI,IAAI,CAIxB;AA9BD;;;GAGG;AACH,+BAHW,OAAO,GACL,IAAI,IAAI,SAAS,CAI7B;AAtHD;;;;GAIG;AACH,kDAJW,CAAC,IAAI,GAAG,cAAc,CAAC,CAAC,WAAW,CAAC,SACpC,KAAK,GACH,OAAO,CAMnB;AAyID;;;GAGG;AACH,oCAHW,MAAM,GACJ,MAAM,EAAE,CAIpB;AAlKD;;;;;GAKG;AACH,wCAJW,KAAK,UACL,KAAK,GACH,OAAO,CAInB;AAiLD;;;;GAIG;AACH,0CAHW,QAAQ,EAAE,GACR,CAAC,CAAC,cAAc,GAAG,IAAI,CAAC,CAAC,WAAW,CAAC,CAAC,MAAM,CAAC,CAAC,EAAE,CAa5D;AApLD;;;GAGG;AACH,kCAHW,YAAY,GACV,OAAO,CAInB"}
+{"version":3,"file":"node.d.ts","sourceRoot":"","sources":["../../../lib/rules/utils/node.js"],"names":[],"mappings":"wBACc,OAAO,aAAa,EAAE,SAAS;kBAC/B,OAAO,aAAa,EAAE,GAAG;wBACzB,OAAO,aAAa,EAAE,SAAS;uBAC/B,OAAO,aAAa,EAAE,QAAQ;mBAC9B,OAAO,aAAa,EAAE,IAAI;mBAC1B,OAAO,aAAa,EAAE,IAAI;6BAC1B,OAAO,aAAa,EAAE,cAAc;sBACpC,OAAO,aAAa,EAAE,OAAO;sBAC7B,OAAO,aAAa,EAAE,OAAO;6BAC7B,OAAO,aAAa,EAAE,cAAc;2BACpC,OAAO,aAAa,EAAE,YAAY;oBAClC,OAAO,QAAQ,EAAE,GAAG,CAAC,KAAK;6BAC1B,OAAO,QAAQ,EAAE,GAAG,CAAC,cAAc;uBACnC,OAAO,gBAAgB,EAAE,QAAQ;AAM/C;;;;GAIG;AACH,+BAJW,GAAG,GAAG,SAAS,GAAG,QAAQ,OAC1B,MAAM,GACJ,SAAS,GAAG,SAAS,CAMjC;AAED;;;;GAIG;AACH,wCAHW,GAAG,GAAG,SAAS,GAAG,QAAQ,GACxB,OAAO,CAInB;AAED;;;;GAIG;AACH,6CAHW,OAAO,GACL,OAAO,CAInB;AA+BD;;;;GAIG;AACH,uCAHW,IAAI,GAAG,cAAc,GACnB,IAAI,EAAE,CAwDlB;AAED;;;;;GAKG;AACH,sCAJW;IAAC,GAAG,EAAE,cAAc,CAAA;CAAC,SACrB;IAAC,GAAG,EAAE,cAAc,CAAA;CAAC,GACnB,cAAc,CAO1B;AAoDD;;;;GAIG;AACH,iCAJW,OAAO,CAAC,OAAO,EAAE,IAAI,CAAC,aACtB,CAAC,IAAI,EAAE,OAAO,KAAK,OAAO,GACxB,IAAI,GAAG,OAAO,CAgB1B;AArED;;;GAGG;AACH,4BAHW,OAAO,GACL,IAAI,IAAI,GAAG,CAIvB;AAUD;;;GAGG;AACH,gCAHW,OAAO,GACL,IAAI,IAAI,OAAO,CAI3B;AAED;;;GAGG;AACH,6BAHW,OAAO,GACL,IAAI,IAAI,IAAI,CAIxB;AAED;;;GAGG;AACH,6BAHW,OAAO,GAAG,IAAI,GACZ,IAAI,IAAI,IAAI,CAIxB;AA9BD;;;GAGG;AACH,+BAHW,OAAO,GACL,IAAI,IAAI,SAAS,CAI7B;AA3GD;;;;GAIG;AACH,kDAJW,CAAC,IAAI,GAAG,cAAc,CAAC,CAAC,WAAW,CAAC,SACpC,KAAK,GACH,OAAO,CAMnB;AA8HD;;;GAGG;AACH,oCAHW,MAAM,GACJ,MAAM,EAAE,CAIpB;AAvJD;;;;;GAKG;AACH,wCAJW,KAAK,UACL,KAAK,GACH,OAAO,CAInB;AAsKD;;;;GAIG;AACH,0CAHW,QAAQ,EAAE,GACR,CAAC,CAAC,cAAc,GAAG,IAAI,CAAC,CAAC,WAAW,CAAC,CAAC,MAAM,CAAC,CAAC,EAAE,CAa5D;AAzKD;;;GAGG;AACH,kCAHW,YAAY,GAAG,cAAc,GAC3B,OAAO,CAInB"}