@htekdev/actions-debugger 1.0.84 → 1.0.85
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/errors/caching-artifacts/docker-buildx-gha-cache-mode-min-partial-layers.yml +91 -0
- package/errors/concurrency-timing/schedule-cron-no-concurrency-run-overlap.yml +87 -0
- package/errors/permissions-auth/github-token-no-cross-org-private-action-access.yml +95 -0
- package/errors/yaml-syntax/step-output-boolean-string-coercion-if-condition.yml +100 -0
- package/package.json +1 -1
|
@@ -0,0 +1,91 @@
|
|
|
1
|
+
id: caching-artifacts-049
|
|
2
|
+
title: 'Docker buildx GHA cache mode:min only caches final layer — rebuilds remain slow'
|
|
3
|
+
category: caching-artifacts
|
|
4
|
+
severity: silent-failure
|
|
5
|
+
tags:
|
|
6
|
+
- docker
|
|
7
|
+
- buildx
|
|
8
|
+
- gha-cache
|
|
9
|
+
- layer-cache
|
|
10
|
+
- mode-min
|
|
11
|
+
- silent-failure
|
|
12
|
+
patterns:
|
|
13
|
+
- regex: 'cache-to.*type=gha'
|
|
14
|
+
flags: 'i'
|
|
15
|
+
- regex: 'importing\s+cache\s+manifest\s+from\s+ghcr\.io'
|
|
16
|
+
flags: 'i'
|
|
17
|
+
- regex: 'exporting\s+cache\s+.*\s+type=gha'
|
|
18
|
+
flags: 'i'
|
|
19
|
+
error_messages:
|
|
20
|
+
- 'cache-to: type=gha'
|
|
21
|
+
- 'exporting cache to GitHub Actions Cache Service'
|
|
22
|
+
- 'CACHED [stage 2/4]'
|
|
23
|
+
root_cause: |
|
|
24
|
+
docker/build-push-action uses cache-to: type=gha with mode=min by default when
|
|
25
|
+
no explicit mode is specified. In min mode, BuildKit exports ONLY the layers of
|
|
26
|
+
the final image (the last build stage), discarding all intermediate layer cache
|
|
27
|
+
data. This means:
|
|
28
|
+
|
|
29
|
+
- Multi-stage Dockerfiles get no benefit from the GHA cache for base/dependency
|
|
30
|
+
stages (the expensive ones) — only the final artifact stage is cached.
|
|
31
|
+
- Subsequent runs re-execute all intermediate stages from scratch while the
|
|
32
|
+
cache appears to "work" (export/import steps succeed in the logs).
|
|
33
|
+
- Developers see 80-90% cache miss rates and slow builds despite believing the
|
|
34
|
+
GHA cache is active.
|
|
35
|
+
|
|
36
|
+
The silent aspect: the workflow logs show cache export and import succeeding,
|
|
37
|
+
and BuildKit reports "CACHED" for layers it finds, with no warning that intermediate
|
|
38
|
+
stages were excluded from the cache.
|
|
39
|
+
fix: |
|
|
40
|
+
Explicitly set mode=max on the cache-to option. This instructs BuildKit to export
|
|
41
|
+
ALL layer metadata — including every intermediate build stage — into the GHA cache.
|
|
42
|
+
Combined with cache-from: type=gha, all previously-built stages will be restored
|
|
43
|
+
on the next run.
|
|
44
|
+
|
|
45
|
+
Note: mode=max requires more GHA cache storage (subject to the 10 GB repository
|
|
46
|
+
limit). Use separate cache scopes per Dockerfile or build target to prevent
|
|
47
|
+
cross-contamination and LRU eviction pressure.
|
|
48
|
+
fix_code:
|
|
49
|
+
- language: yaml
|
|
50
|
+
label: 'Set mode=max for full layer caching in multi-stage builds'
|
|
51
|
+
code: |
|
|
52
|
+
- name: Build and push
|
|
53
|
+
uses: docker/build-push-action@v6
|
|
54
|
+
with:
|
|
55
|
+
context: .
|
|
56
|
+
push: true
|
|
57
|
+
tags: ghcr.io/${{ github.repository }}:latest
|
|
58
|
+
cache-from: type=gha,scope=main
|
|
59
|
+
cache-to: type=gha,scope=main,mode=max
|
|
60
|
+
- language: yaml
|
|
61
|
+
label: 'Use separate scopes per Dockerfile to isolate caches'
|
|
62
|
+
code: |
|
|
63
|
+
- name: Build API image
|
|
64
|
+
uses: docker/build-push-action@v6
|
|
65
|
+
with:
|
|
66
|
+
context: ./api
|
|
67
|
+
push: true
|
|
68
|
+
tags: ghcr.io/${{ github.repository }}/api:latest
|
|
69
|
+
cache-from: type=gha,scope=api
|
|
70
|
+
cache-to: type=gha,scope=api,mode=max
|
|
71
|
+
|
|
72
|
+
- name: Build Frontend image
|
|
73
|
+
uses: docker/build-push-action@v6
|
|
74
|
+
with:
|
|
75
|
+
context: ./frontend
|
|
76
|
+
push: true
|
|
77
|
+
tags: ghcr.io/${{ github.repository }}/frontend:latest
|
|
78
|
+
cache-from: type=gha,scope=frontend
|
|
79
|
+
cache-to: type=gha,scope=frontend,mode=max
|
|
80
|
+
prevention:
|
|
81
|
+
- 'Always explicitly set mode=max in cache-to: type=gha for multi-stage Dockerfiles'
|
|
82
|
+
- 'Use the scope= parameter to isolate caches per Dockerfile or build target'
|
|
83
|
+
- 'Monitor cache size with the GitHub Actions Cache API if approaching the 10 GB repository limit'
|
|
84
|
+
- 'Verify cache effectiveness by checking that intermediate build stages show CACHED in buildx output'
|
|
85
|
+
docs:
|
|
86
|
+
- url: 'https://docs.docker.com/build/cache/backends/gha/'
|
|
87
|
+
label: 'Docker BuildKit — GitHub Actions cache backend'
|
|
88
|
+
- url: 'https://github.com/docker/build-push-action#cache'
|
|
89
|
+
label: 'docker/build-push-action — Cache inputs'
|
|
90
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy'
|
|
91
|
+
label: 'GitHub Actions — Cache usage limits and eviction policy'
|
|
@@ -0,0 +1,87 @@
|
|
|
1
|
+
id: concurrency-timing-043
|
|
2
|
+
title: 'Scheduled cron jobs overlap when no concurrency group is configured'
|
|
3
|
+
category: concurrency-timing
|
|
4
|
+
severity: silent-failure
|
|
5
|
+
tags:
|
|
6
|
+
- schedule
|
|
7
|
+
- cron
|
|
8
|
+
- overlap
|
|
9
|
+
- race-condition
|
|
10
|
+
- concurrency
|
|
11
|
+
- data-corruption
|
|
12
|
+
patterns:
|
|
13
|
+
- regex: 'on:\s*schedule'
|
|
14
|
+
flags: 'i'
|
|
15
|
+
- regex: 'triggered by:\s*schedule'
|
|
16
|
+
flags: 'i'
|
|
17
|
+
error_messages:
|
|
18
|
+
- 'Multiple workflow runs triggered by schedule are running concurrently'
|
|
19
|
+
- 'triggered by: schedule'
|
|
20
|
+
root_cause: |
|
|
21
|
+
When a scheduled workflow has no concurrency group configured, GitHub Actions
|
|
22
|
+
starts a new run at each scheduled time regardless of whether a previous run is
|
|
23
|
+
still in progress. Two conditions make this especially common:
|
|
24
|
+
|
|
25
|
+
1. The job takes longer than the cron interval (e.g., a 10-minute job on a
|
|
26
|
+
every-5-minute schedule).
|
|
27
|
+
2. GitHub's scheduler fires queued runs in rapid succession after a platform
|
|
28
|
+
outage or maintenance window, catching up on missed intervals.
|
|
29
|
+
|
|
30
|
+
Both scenarios result in multiple simultaneous runs sharing external resources—
|
|
31
|
+
databases, S3 buckets, deployment targets, or branch state—causing race
|
|
32
|
+
conditions, duplicate data writes, and data corruption. No error is surfaced
|
|
33
|
+
in the workflow logs; the runs both appear green while the downstream system
|
|
34
|
+
silently degrades.
|
|
35
|
+
fix: |
|
|
36
|
+
Add a concurrency group to the scheduled workflow. The correct cancel-in-progress
|
|
37
|
+
value depends on whether the job is idempotent:
|
|
38
|
+
|
|
39
|
+
- Non-idempotent jobs (database migrations, state mutations): set
|
|
40
|
+
cancel-in-progress: false to queue runs sequentially.
|
|
41
|
+
- Idempotent jobs (report generation, cache refreshes): set
|
|
42
|
+
cancel-in-progress: true to drop stale queued runs and keep only the latest.
|
|
43
|
+
fix_code:
|
|
44
|
+
- language: yaml
|
|
45
|
+
label: 'Queue scheduled runs for non-idempotent jobs (e.g., database migrations)'
|
|
46
|
+
code: |
|
|
47
|
+
on:
|
|
48
|
+
schedule:
|
|
49
|
+
- cron: '*/5 * * * *'
|
|
50
|
+
|
|
51
|
+
concurrency:
|
|
52
|
+
group: ${{ github.workflow }}-scheduled
|
|
53
|
+
cancel-in-progress: false
|
|
54
|
+
|
|
55
|
+
jobs:
|
|
56
|
+
migrate:
|
|
57
|
+
runs-on: ubuntu-latest
|
|
58
|
+
steps:
|
|
59
|
+
- uses: actions/checkout@v4
|
|
60
|
+
- run: ./scripts/db-migrate.sh
|
|
61
|
+
- language: yaml
|
|
62
|
+
label: 'Cancel stale runs for idempotent jobs (e.g., report generation)'
|
|
63
|
+
code: |
|
|
64
|
+
on:
|
|
65
|
+
schedule:
|
|
66
|
+
- cron: '*/5 * * * *'
|
|
67
|
+
|
|
68
|
+
concurrency:
|
|
69
|
+
group: ${{ github.workflow }}-scheduled
|
|
70
|
+
cancel-in-progress: true
|
|
71
|
+
|
|
72
|
+
jobs:
|
|
73
|
+
report:
|
|
74
|
+
runs-on: ubuntu-latest
|
|
75
|
+
steps:
|
|
76
|
+
- uses: actions/checkout@v4
|
|
77
|
+
- run: ./scripts/generate-report.sh
|
|
78
|
+
prevention:
|
|
79
|
+
- 'Add a concurrency group to every workflow with an on.schedule trigger'
|
|
80
|
+
- 'For jobs longer than the cron interval, always use cancel-in-progress: false to serialize execution'
|
|
81
|
+
- 'Monitor the Actions tab for multiple simultaneous scheduled runs as an early warning sign'
|
|
82
|
+
- 'Use actionlint to audit workflows that have on.schedule but no concurrency group'
|
|
83
|
+
docs:
|
|
84
|
+
- url: 'https://docs.github.com/en/actions/using-jobs/using-concurrency'
|
|
85
|
+
label: 'GitHub Actions — Using concurrency'
|
|
86
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule'
|
|
87
|
+
label: 'GitHub Actions — Schedule event'
|
|
@@ -0,0 +1,95 @@
|
|
|
1
|
+
id: permissions-auth-049
|
|
2
|
+
title: 'GITHUB_TOKEN cannot resolve private actions from a different organization'
|
|
3
|
+
category: permissions-auth
|
|
4
|
+
severity: error
|
|
5
|
+
tags:
|
|
6
|
+
- github-token
|
|
7
|
+
- cross-org
|
|
8
|
+
- private-action
|
|
9
|
+
- enterprise
|
|
10
|
+
- repository-not-found
|
|
11
|
+
patterns:
|
|
12
|
+
- regex: 'Unable to resolve action .* repository not found'
|
|
13
|
+
flags: 'i'
|
|
14
|
+
- regex: 'Error: Unable to resolve action `[^`]+`'
|
|
15
|
+
flags: 'i'
|
|
16
|
+
- regex: 'remote: Repository not found'
|
|
17
|
+
flags: 'i'
|
|
18
|
+
error_messages:
|
|
19
|
+
- "Error: Unable to resolve action `other-org/private-action@v1`, repository not found."
|
|
20
|
+
- "Error: remote: Repository not found."
|
|
21
|
+
- "fatal: repository 'https://github.com/other-org/private-action/' not found"
|
|
22
|
+
root_cause: |
|
|
23
|
+
GITHUB_TOKEN is automatically scoped to the repository where the workflow runs.
|
|
24
|
+
It cannot authenticate against repositories in a different GitHub organization,
|
|
25
|
+
even when both organizations are in the same GitHub Enterprise instance.
|
|
26
|
+
|
|
27
|
+
When a workflow references a private action from a different org
|
|
28
|
+
(e.g., uses: other-org/my-action@v1), the Actions runner attempts to clone
|
|
29
|
+
that action repository during the job setup phase using GITHUB_TOKEN. The
|
|
30
|
+
clone fails with "repository not found" because the token has no cross-org
|
|
31
|
+
read access. This is not a permissions: block misconfiguration — no amount of
|
|
32
|
+
permissions granted in the workflow YAML will fix it, since the token is
|
|
33
|
+
fundamentally scoped to the calling org.
|
|
34
|
+
|
|
35
|
+
This also affects actions/checkout when checking out code from a private repo
|
|
36
|
+
in another org unless a suitable alternative token is provided.
|
|
37
|
+
fix: |
|
|
38
|
+
Choose the appropriate strategy based on your setup:
|
|
39
|
+
|
|
40
|
+
1. Make the action repository public — simplest if the action contains no secrets.
|
|
41
|
+
2. Vendor the action into your organization — copy the action code into a repo
|
|
42
|
+
in the same org or into .github/actions/ in the calling repo and reference it
|
|
43
|
+
as a local path action.
|
|
44
|
+
3. Use a GitHub App installation token with cross-org permissions for
|
|
45
|
+
actions/checkout calls to cross-org repos (does NOT fix job-level uses: loading).
|
|
46
|
+
4. Use a Personal Access Token (PAT) with access to both orgs for checkout
|
|
47
|
+
(same limitation: cannot fix uses: loading, only checkout steps).
|
|
48
|
+
|
|
49
|
+
Note: The uses: field at the job-steps level (for external actions) is resolved
|
|
50
|
+
before the workflow starts executing, so token injection via steps is not possible
|
|
51
|
+
for the action loading stage — vendoring or making the action public is the only
|
|
52
|
+
reliable fix for job-level uses:.
|
|
53
|
+
fix_code:
|
|
54
|
+
- language: yaml
|
|
55
|
+
label: 'Vendor private action as a local path action'
|
|
56
|
+
code: |
|
|
57
|
+
# Copy the action code to .github/actions/my-action/ in your repo.
|
|
58
|
+
# Then reference it as a local action — no cross-org token required:
|
|
59
|
+
jobs:
|
|
60
|
+
build:
|
|
61
|
+
runs-on: ubuntu-latest
|
|
62
|
+
steps:
|
|
63
|
+
- uses: actions/checkout@v4
|
|
64
|
+
- uses: ./.github/actions/my-action
|
|
65
|
+
with:
|
|
66
|
+
param: value
|
|
67
|
+
- language: yaml
|
|
68
|
+
label: 'Use GitHub App token for cross-org repository checkout (not uses: loading)'
|
|
69
|
+
code: |
|
|
70
|
+
jobs:
|
|
71
|
+
cross-org-checkout:
|
|
72
|
+
runs-on: ubuntu-latest
|
|
73
|
+
steps:
|
|
74
|
+
- uses: actions/create-github-app-token@v2
|
|
75
|
+
id: app-token
|
|
76
|
+
with:
|
|
77
|
+
app-id: ${{ vars.APP_ID }}
|
|
78
|
+
private-key: ${{ secrets.APP_PRIVATE_KEY }}
|
|
79
|
+
owner: other-org
|
|
80
|
+
- uses: actions/checkout@v4
|
|
81
|
+
with:
|
|
82
|
+
repository: other-org/private-repo
|
|
83
|
+
token: ${{ steps.app-token.outputs.token }}
|
|
84
|
+
prevention:
|
|
85
|
+
- 'Prefer public actions for shared tooling to avoid cross-org token scope issues'
|
|
86
|
+
- 'Vendor private cross-org actions into .github/actions/ in the calling repo'
|
|
87
|
+
- 'Create an internal shared-actions org accessible to all teams where GITHUB_TOKEN works'
|
|
88
|
+
- 'Document which repos depend on cross-org private actions and track them for access reviews'
|
|
89
|
+
docs:
|
|
90
|
+
- url: 'https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token'
|
|
91
|
+
label: 'GitHub Actions — Automatic token authentication permissions'
|
|
92
|
+
- url: 'https://docs.github.com/en/actions/sharing-automations/creating-actions/sharing-actions-and-workflows-with-your-organization'
|
|
93
|
+
label: 'GitHub Actions — Sharing actions with your organization'
|
|
94
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses'
|
|
95
|
+
label: 'GitHub Actions — Workflow syntax for uses'
|
|
@@ -0,0 +1,100 @@
|
|
|
1
|
+
id: yaml-syntax-053
|
|
2
|
+
title: 'Step output boolean string coercion — comparing to bare true/false silently never matches'
|
|
3
|
+
category: yaml-syntax
|
|
4
|
+
severity: silent-failure
|
|
5
|
+
tags:
|
|
6
|
+
- step-outputs
|
|
7
|
+
- GITHUB_OUTPUT
|
|
8
|
+
- boolean
|
|
9
|
+
- string-coercion
|
|
10
|
+
- if-condition
|
|
11
|
+
- silent-failure
|
|
12
|
+
patterns:
|
|
13
|
+
- regex: 'outputs\.[a-z_][a-z0-9_]*\s*==\s*true\b'
|
|
14
|
+
flags: 'i'
|
|
15
|
+
- regex: 'outputs\.[a-z_][a-z0-9_]*\s*==\s*false\b'
|
|
16
|
+
flags: 'i'
|
|
17
|
+
- regex: 'needs\.[a-z_][a-z0-9_-]*\.outputs\.[a-z_]+ ==\s*(true|false)\b'
|
|
18
|
+
flags: 'i'
|
|
19
|
+
error_messages:
|
|
20
|
+
- "if: steps.check.outputs.changed == true"
|
|
21
|
+
- "if: needs.build.outputs.has_changes == false"
|
|
22
|
+
- "if: steps.detect.outputs.skip == true"
|
|
23
|
+
root_cause: |
|
|
24
|
+
All values written to GITHUB_OUTPUT (via echo "key=value" >> $GITHUB_OUTPUT) are
|
|
25
|
+
stored and transmitted as strings, regardless of the intended type. When a step
|
|
26
|
+
outputs a boolean-like value such as echo "changed=true" >> $GITHUB_OUTPUT, the
|
|
27
|
+
output steps.id.outputs.changed is the string 'true', not the boolean true.
|
|
28
|
+
|
|
29
|
+
In GitHub Actions expression syntax, type comparison is strict:
|
|
30
|
+
- 'true' == true → false (string 'true' does not equal boolean true)
|
|
31
|
+
- 'false' == false → false (string 'false' does not equal boolean false)
|
|
32
|
+
- '' == false → true (empty string does equal boolean false — a separate gotcha)
|
|
33
|
+
|
|
34
|
+
This means if: steps.check.outputs.changed == true silently evaluates to false
|
|
35
|
+
even when the output is the string "true", and the step is silently skipped with
|
|
36
|
+
no error. The workflow log shows the step as skipped with no indication that the
|
|
37
|
+
condition evaluation was the cause.
|
|
38
|
+
|
|
39
|
+
The same pattern applies to job outputs (needs.job.outputs.flag) passed between
|
|
40
|
+
jobs via the outputs: block.
|
|
41
|
+
fix: |
|
|
42
|
+
Always compare step and job outputs as strings using single-quoted string literals:
|
|
43
|
+
- For true check: == 'true'
|
|
44
|
+
- For false check: != 'true' (preferred over == 'false' because empty string also needs handling)
|
|
45
|
+
- For numeric outputs: use fromJSON() to parse before arithmetic comparison
|
|
46
|
+
|
|
47
|
+
For boolean output authors: document that consumers must compare as strings, or
|
|
48
|
+
use '1'/'0' string conventions to make the string nature explicit.
|
|
49
|
+
fix_code:
|
|
50
|
+
- language: yaml
|
|
51
|
+
label: 'Correct: compare step outputs as strings'
|
|
52
|
+
code: |
|
|
53
|
+
steps:
|
|
54
|
+
- id: check
|
|
55
|
+
run: echo "changed=true" >> $GITHUB_OUTPUT
|
|
56
|
+
|
|
57
|
+
# WRONG — silently skipped because 'true' != true (string != boolean)
|
|
58
|
+
# - if: steps.check.outputs.changed == true
|
|
59
|
+
# run: echo "This never runs"
|
|
60
|
+
|
|
61
|
+
# CORRECT — compare output string to string literal
|
|
62
|
+
- if: steps.check.outputs.changed == 'true'
|
|
63
|
+
run: echo "Files changed, running deploy"
|
|
64
|
+
|
|
65
|
+
# CORRECT — inverse check
|
|
66
|
+
- if: steps.check.outputs.changed != 'true'
|
|
67
|
+
run: echo "No changes, skipping deploy"
|
|
68
|
+
- language: yaml
|
|
69
|
+
label: 'Job-to-job boolean output — compare as string in downstream job'
|
|
70
|
+
code: |
|
|
71
|
+
jobs:
|
|
72
|
+
detect:
|
|
73
|
+
outputs:
|
|
74
|
+
has_changes: ${{ steps.diff.outputs.has_changes }}
|
|
75
|
+
runs-on: ubuntu-latest
|
|
76
|
+
steps:
|
|
77
|
+
- id: diff
|
|
78
|
+
run: |
|
|
79
|
+
# Output is always a string
|
|
80
|
+
echo "has_changes=true" >> $GITHUB_OUTPUT
|
|
81
|
+
|
|
82
|
+
deploy:
|
|
83
|
+
needs: detect
|
|
84
|
+
# CORRECT: compare job output as string literal
|
|
85
|
+
if: needs.detect.outputs.has_changes == 'true'
|
|
86
|
+
runs-on: ubuntu-latest
|
|
87
|
+
steps:
|
|
88
|
+
- run: echo "Deploying"
|
|
89
|
+
prevention:
|
|
90
|
+
- "Always use single-quoted string literals in if: conditions when comparing step or job outputs: == 'true' not == true"
|
|
91
|
+
- 'Use fromJSON() to parse numeric step outputs before arithmetic or numeric comparisons'
|
|
92
|
+
- 'Audit workflows for bare == true or == false comparisons on steps.*.outputs.* and needs.*.outputs.*'
|
|
93
|
+
- 'Use actionlint — it detects type mismatches in expression comparisons involving outputs'
|
|
94
|
+
docs:
|
|
95
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs'
|
|
96
|
+
label: 'GitHub Actions — Passing information between jobs'
|
|
97
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#literals'
|
|
98
|
+
label: 'GitHub Actions — Expression literals and type coercion'
|
|
99
|
+
- url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/setting-an-output-parameter'
|
|
100
|
+
label: 'GitHub Actions — Setting an output parameter'
|
package/package.json
CHANGED