@htekdev/actions-debugger 1.0.42 → 1.0.43

package/errors/caching-artifacts/upload-artifact-v4-duplicate-name-hard-error.yml

@@ -0,0 +1,114 @@
+id: caching-artifacts-033
+title: 'upload-artifact@v4 requires unique artifact names per run — duplicate name is a hard error'
+category: caching-artifacts
+severity: error
+tags:
+  - upload-artifact
+  - v4
+  - duplicate-name
+  - breaking-change
+  - matrix
+patterns:
+  - regex: 'An artifact with this name already exists on the workflow run'
+    flags: 'i'
+  - regex: 'Failed to CreateArtifact.*already exists'
+    flags: 'i'
+error_messages:
+  - 'An artifact with this name already exists on the workflow run'
+  - 'Failed to CreateArtifact: Artifact already exists'
+root_cause: |
+  actions/upload-artifact@v4 changed artifact name uniqueness enforcement from v3:
+
+  v3 behavior: uploading with a duplicate name silently merged the new files
+  into the existing artifact, potentially overwriting same-named files.
+
+  v4 behavior: uploading with a name that already exists in the same workflow
+  run is a hard error. The step fails immediately with:
+    "An artifact with this name already exists on the workflow run"
+
+  Common triggers:
+  1. Matrix jobs all writing to a fixed artifact name (e.g., name: build-output)
+     without including a matrix dimension in the name.
+  2. Multiple upload-artifact steps in the same job with the same name: value.
+  3. Reusable workflows invoked multiple times in one run using identical names.
+  4. Two upload steps with no name: parameter — both default to "artifact".
+
+  Workflows that relied on v3's merge behavior and were silently uploading
+  duplicate names will fail immediately after upgrading to v4.
+fix: |
+  Include a unique identifier in the artifact name for each upload step.
+  For matrix jobs, include a matrix dimension value. For independent parallel
+  jobs, include the job name or a specific run-scoped identifier.
+
+  If you need to consolidate artifacts from multiple sources, have each job
+  upload with a unique name, then use a final consolidation job that downloads
+  all artifacts and re-uploads a merged set.
+fix_code:
+  - language: yaml
+    label: 'Matrix jobs — include matrix dimension in artifact name'
+    code: |
+      strategy:
+        matrix:
+          os: [ubuntu-latest, windows-latest, macos-latest]
+
+      steps:
+        - name: Build
+          run: make build
+
+        - uses: actions/upload-artifact@v4
+          with:
+            name: build-output-${{ matrix.os }}   # Unique per matrix cell
+            path: dist/
+  - language: yaml
+    label: 'Multiple upload steps — use distinct explicit names'
+    code: |
+      steps:
+        - uses: actions/upload-artifact@v4
+          with:
+            name: test-results       # Distinct name
+            path: test-output/
+
+        - uses: actions/upload-artifact@v4
+          with:
+            name: coverage-report    # Different name — no conflict
+            path: coverage/
+  - language: yaml
+    label: 'Merge artifacts across matrix jobs in a downstream job'
+    code: |
+      jobs:
+        build:
+          strategy:
+            matrix:
+              os: [ubuntu-latest, windows-latest]
+          steps:
+            - uses: actions/upload-artifact@v4
+              with:
+                name: dist-${{ matrix.os }}
+                path: dist/
+
+        package:
+          needs: build
+          runs-on: ubuntu-latest
+          steps:
+            - uses: actions/download-artifact@v4
+              with:
+                pattern: dist-*
+                merge-multiple: true
+                path: all-dist/
+
+            - uses: actions/upload-artifact@v4
+              with:
+                name: final-package
+                path: all-dist/
+prevention:
+  - 'Always specify an explicit name: for each upload-artifact step rather than relying on the default "artifact"'
+  - 'For matrix jobs, include at least one matrix variable in the artifact name'
+  - 'Audit workflows being migrated from v3 to v4 for any step that omits name: or uses the same name twice'
+  - 'Two steps with no name: both default to "artifact" and will always conflict in v4'
+docs:
+  - url: 'https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md'
+    label: 'upload-artifact v3 to v4 migration guide'
+  - url: 'https://github.com/actions/upload-artifact'
+    label: 'actions/upload-artifact repository'
+  - url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts'
+    label: 'GitHub Docs — Storing workflow data as artifacts'

package/errors/permissions-auth/job-level-permissions-replaces-workflow-level.yml

@@ -0,0 +1,123 @@
+id: permissions-auth-034
+title: 'Job-level permissions: block replaces workflow-level permissions — undeclared scopes are silently removed'
+category: permissions-auth
+severity: silent-failure
+tags:
+  - permissions
+  - GITHUB_TOKEN
+  - job-level
+  - workflow-level
+  - 403
+patterns:
+  - regex: 'Resource not accessible by integration'
+    flags: 'i'
+  - regex: 'HttpError.*403'
+    flags: 'i'
+error_messages:
+  - 'Resource not accessible by integration'
+  - 'HttpError: Resource not accessible by integration'
+  - '403 Forbidden'
+root_cause: |
+  The permissions: block in GitHub Actions is a REPLACEMENT at the scope where
+  it is applied — it does NOT inherit or merge with permissions defined at a
+  parent scope.
+
+  Example: if a workflow defines top-level permissions:
+    permissions:
+      contents: write
+      issues: write
+      pull-requests: write
+
+  And a job within that workflow also defines permissions:
+    permissions:
+      deployments: write
+
+  Then that job's GITHUB_TOKEN has ONLY deployments: write. The
+  contents: write, issues: write, and pull-requests: write scopes are
+  completely dropped for that job.
+
+  Developers expect job-level permissions to be ADDITIVE (adding new
+  permissions on top of the workflow-level set). The actual behavior is the
+  opposite: job-level permissions creates an entirely new permission set for
+  that job, discarding all workflow-level grants not re-declared.
+
+  The failure is silent — no warning is emitted about the permission reduction.
+  Steps produce 403 or "Resource not accessible by integration" only when
+  they actually attempt to use the silently-removed permission.
+fix: |
+  When using a job-level permissions: block, re-declare ALL permissions
+  that the job needs — not just the new ones you want to add.
+
+  Alternatively, if all jobs in the workflow need the same permission set,
+  set permissions only at the workflow level and omit job-level overrides.
+
+  Best practice: prefer job-level permissions over workflow-level for the
+  principle of least privilege — each job explicitly declares only what it
+  needs, with no inheritance confusion.
+fix_code:
+  - language: yaml
+    label: 'Wrong: job-level block silently drops workflow-level grants'
+    code: |
+      # Workflow level
+      permissions:
+        contents: write
+        issues: write
+
+      jobs:
+        deploy:
+          permissions:
+            deployments: write   # This REPLACES the above — contents and issues are now GONE
+          steps:
+            - name: Comment on issue
+              uses: actions/github-script@v7
+              with:
+                script: |
+                  # This will 403 — issues: write was silently removed
+                  await github.rest.issues.createComment({ issue_number: 1, body: 'deployed' })
+  - language: yaml
+    label: 'Correct: re-declare all needed permissions at job level'
+    code: |
+      # No workflow-level permissions block needed when using job-level
+
+      jobs:
+        deploy:
+          permissions:
+            contents: write      # Re-declared (was at workflow level)
+            issues: write        # Re-declared (was at workflow level)
+            deployments: write   # New permission added
+          steps:
+            - name: Comment on issue
+              uses: actions/github-script@v7
+              with:
+                script: |
+                  await github.rest.issues.createComment({ issue_number: 1, body: 'deployed' })
+  - language: yaml
+    label: 'Minimal job permissions — each job declares only what it needs'
+    code: |
+      # No workflow-level permissions block — all scoped to jobs
+
+      jobs:
+        test:
+          permissions:
+            checks: write
+            contents: read
+          steps:
+            - uses: actions/checkout@v4
+
+        deploy:
+          permissions:
+            contents: read
+            deployments: write
+            id-token: write
+          steps:
+            - run: echo "deploying"
+prevention:
+  - 'When adding a job-level permissions block, start by listing every permission the job needs from scratch'
+  - 'Do not assume any permissions flow down from the workflow level when a job block is present'
+  - 'Prefer defining all permissions at the job level (not workflow level) to make the permission set explicit'
+  - 'The GitHub Docs explicitly state: permissions at the job level override the workflow-level setting'
+docs:
+  - url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token'
+    label: 'GitHub Docs — Controlling permissions for GITHUB_TOKEN'
+  - url: 'https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions'
+    label: 'GitHub Docs — jobs.<job_id>.permissions syntax'

package/errors/silent-failures/composite-action-outputs-not-propagated.yml

@@ -0,0 +1,99 @@
+id: silent-failures-048
+title: 'Composite action outputs not propagated — outputs: declaration required in action.yml'
+category: silent-failures
+severity: silent-failure
+tags:
+  - composite
+  - outputs
+  - action.yml
+  - step-outputs
+  - empty-string
+patterns:
+  - regex: 'steps\.\w+\.outputs\.'
+    flags: 'i'
+error_messages: []
+root_cause: |
+  In composite actions, step outputs from internal steps are NOT automatically
+  visible to the action's callers. The composite action's action.yml must
+  declare an outputs: block that explicitly maps each output name to a value
+  expression referencing an internal step's output:
+
+    outputs:
+      my-result:
+        description: "The result"
+        value: ${{ steps.build.outputs.result }}
+
+  Without this declaration, ${{ steps.my-action.outputs.my-result }} in the
+  calling workflow evaluates to empty string with no error or warning.
+
+  This is different from regular workflow jobs, where step outputs are
+  accessible within the same job via steps.<id>.outputs.<name> without any
+  explicit mapping. Composite actions require explicit wiring because the
+  action boundary creates an isolation layer — internal step IDs are not
+  exposed to callers.
+
+  Common mistake pattern: developer tests the composite action, sees that
+  internal steps set outputs correctly, but the caller always receives "".
+  The action.yml outputs: block is missing or references a wrong step id.
+fix: |
+  1. Open the composite action's action.yml file.
+  2. Add an outputs: block (after the inputs: block if present).
+  3. For each output you need to expose, add an entry with:
+       value: ${{ steps.<internal-step-id>.outputs.<output-name> }}
+  4. Ensure the referenced internal step has a matching id: field.
+  5. Ensure the internal step writes outputs via GITHUB_OUTPUT:
+       echo "result=value" >> $GITHUB_OUTPUT
+fix_code:
+  - language: yaml
+    label: 'action.yml — declare outputs with value expressions'
+    code: |
+      # .github/actions/my-build/action.yml
+      name: 'My Build Action'
+      description: 'Builds the project and returns the version'
+
+      outputs:
+        build-version:
+          description: 'The version that was built'
+          value: ${{ steps.get-version.outputs.version }}
+        artifact-path:
+          description: 'Path to the built artifact'
+          value: ${{ steps.build.outputs.artifact }}
+
+      runs:
+        using: composite
+        steps:
+          - id: get-version
+            shell: bash
+            run: echo "version=$(cat version.txt)" >> $GITHUB_OUTPUT
+
+          - id: build
+            shell: bash
+            run: |
+              make build
+              echo "artifact=dist/app.tar.gz" >> $GITHUB_OUTPUT
+  - language: yaml
+    label: 'Calling workflow — accessing composite action outputs'
+    code: |
+      jobs:
+        release:
+          runs-on: ubuntu-latest
+          steps:
+            - uses: actions/checkout@v4
+
+            - id: build
+              uses: ./.github/actions/my-build
+
+            - name: Use outputs
+              run: |
+                echo "Version: ${{ steps.build.outputs.build-version }}"
+                echo "Artifact: ${{ steps.build.outputs.artifact-path }}"
+prevention:
+  - 'Every composite action output must have a corresponding entry in the outputs: block of action.yml'
+  - 'Internal steps must have an id: field for the outputs value: expression to reference'
+  - 'The step id in the value: expression must exactly match the internal step id: value'
+  - 'Add a debug step in the action to print $GITHUB_OUTPUT contents when troubleshooting'
+docs:
+  - url: 'https://docs.github.com/en/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#outputs-for-composite-actions'
+    label: 'GitHub Docs — Outputs for composite actions'
+  - url: 'https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs'
+    label: 'GitHub Docs — Passing information between jobs'

package/errors/triggers/workflow-run-name-mismatch-silent-never-triggers.yml

@@ -0,0 +1,96 @@
+id: triggers-032
+title: 'on.workflow_run.workflows matches name: field not filename — mismatch silently never triggers'
+category: triggers
+severity: warning
+tags:
+  - workflow_run
+  - trigger
+  - name-mismatch
+  - silent
+  - filename
+patterns:
+  - regex: 'workflow_run'
+    flags: ''
+error_messages: []
+root_cause: |
+  The on.workflow_run.workflows: array matches against the target workflow's
+  top-level name: field — NOT the workflow's filename.
+
+  If the target workflow contains:
+    name: CI Pipeline
+
+  then the triggering workflow must specify:
+    on:
+      workflow_run:
+        workflows: ["CI Pipeline"]
+
+  Using the filename ("build.yml", "ci.yml", or ".github/workflows/ci.yml")
+  never matches when a name: field is present. The comparison is case-sensitive:
+  "CI" != "ci" != "Ci".
+
+  Secondary rule: if the target workflow has no name: field, GitHub uses the
+  workflow file path relative to the repo root as the match string (e.g.,
+  ".github/workflows/build.yml").
+
+  No error or warning is produced on mismatch — the triggering workflow
+  silently never fires. This is one of the most common workflow_run
+  misconfiguration patterns on Stack Overflow.
+fix: |
+  1. Open the target workflow file.
+  2. Find the top-level name: field. If absent, note the repo-relative path.
+  3. Use that exact string (case-sensitive) in the workflows: array.
+  4. Merge/deploy the triggering workflow to the default branch — workflow_run
+     only fires when the trigger configuration itself is on the default branch.
+fix_code:
+  - language: yaml
+    label: 'Correct: match the target workflow name: field exactly'
+    code: |
+      # Target workflow file: .github/workflows/ci.yml
+      name: CI Pipeline    # <-- this is what workflow_run matches on
+
+      on: [push]
+      jobs:
+        build:
+          runs-on: ubuntu-latest
+          steps:
+            - run: echo "building"
+
+      ---
+      # Triggering workflow file: .github/workflows/deploy.yml
+      on:
+        workflow_run:
+          workflows: ["CI Pipeline"]   # Must match name: exactly (not "ci.yml")
+          types: [completed]
+      jobs:
+        deploy:
+          if: ${{ github.event.workflow_run.conclusion == 'success' }}
+          runs-on: ubuntu-latest
+          steps:
+            - run: echo "deploying"
+  - language: yaml
+    label: 'When target workflow has no name: field, use the file path'
+    code: |
+      # Target workflow has no name: field at .github/workflows/build.yml
+      on: [push]
+      jobs:
+        build:
+          runs-on: ubuntu-latest
+          steps:
+            - run: echo "building"
+
+      ---
+      # Triggering workflow must use the repo-relative path
+      on:
+        workflow_run:
+          workflows: [".github/workflows/build.yml"]
+          types: [completed]
+prevention:
+  - 'Always add a name: field to every workflow you intend to reference in workflow_run'
+  - 'Copy the name: value exactly (including capitalization and spaces) into workflows:'
+  - 'Add a comment in the triggering workflow citing which file the name came from'
+  - 'workflow_run silently never fires on name mismatches — no diagnostic is emitted'
+docs:
+  - url: 'https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run'
+    label: 'GitHub Docs — workflow_run trigger'
+  - url: 'https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#name'
+    label: 'GitHub Docs — Workflow name: field'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@htekdev/actions-debugger",
-  "version": "1.0.42",
+  "version": "1.0.43",
   "description": "65+ real GitHub Actions errors, queryable by agents. CLI + MCP server + Copilot skills + error database.",
   "type": "module",
   "main": "./dist/index.js",