@hs-x/cli 0.4.9 → 0.4.11

package/dist/commands/deploy.js

@@ -571,6 +571,7 @@ function createDeployProgress(input) {
                 },
                 fail: (detail) => {
                     tally.fail += 1;
+                    input.onStepFail?.(label, detail);
                     handle.fail(detail);
                 },
                 warn: (detail) => {
@@ -582,6 +583,54 @@ function createDeployProgress(input) {
         counts: () => ({ ...tally }),
     };
 }
+function createDeployFailureSink() {
+    let context;
+    let projectId;
+    let deployId;
+    let failure;
+    let flushed = false;
+    return {
+        arm(next) {
+            context = next;
+        },
+        setProject(next) {
+            projectId = next;
+        },
+        setDeployId(next) {
+            deployId = next;
+        },
+        noteStepFailure(step, detail) {
+            if (!failure)
+                failure = { step, ...(detail ? { detail } : {}) };
+        },
+        async flush(fallbackDetail) {
+            if (flushed || !context || !projectId)
+                return;
+            flushed = true;
+            try {
+                const provenance = await collectDeployProvenance(context.userId);
+                await hostedHttp({
+                    url: new URL('/v1/deploys/failures', context.controlPlaneUrl),
+                    method: 'POST',
+                    headers: await controlPlaneAuthHeaders(context.userId, undefined, context.accountId),
+                    body: {
+                        accountId: context.accountId,
+                        projectId,
+                        ...(deployId ? { deployId } : {}),
+                        failedStep: failure?.step ?? 'deploy',
+                        errorExcerpt: (failure?.detail ?? fallbackDetail).slice(0, 2000),
+                        ...(provenance.gitCommit ? { gitCommit: provenance.gitCommit } : {}),
+                        ...(provenance.gitBranch ? { gitBranch: provenance.gitBranch } : {}),
+                        ...(provenance.cliVersion ? { cliVersion: provenance.cliVersion } : {}),
+                    },
+                });
+            }
+            catch {
+                // Best-effort; the deploy's own failure is the outcome that matters.
+            }
+        },
+    };
+}
 /** ADR-007 source summaries for the human transcript (`Sources: …`). */
 function workerSourceSummaries(workers) {
     return workers.flatMap((worker) => worker.capabilities.flatMap((capability) => capability.kind === 'sync' && capability.source
@@ -1047,6 +1096,23 @@ async function executeHubSpotDirectDeployCommand({ argv, root, json, }) {
     }
 }
 export async function deployCommand({ argv, root, json, }) {
+    // Failure boundary: a linked deploy that dies — thrown or via a non-zero
+    // exit — reports itself to the control plane (deploy-failed email) before
+    // the error propagates. Ctrl-C (130) is not a failure.
+    const failureSink = createDeployFailureSink();
+    try {
+        const result = await runDeploy({ argv, root, json, failureSink });
+        if (result.exitCode !== 0 && result.exitCode !== 130) {
+            await failureSink.flush(`deploy failed (exit ${result.exitCode})`);
+        }
+        return result;
+    }
+    catch (error) {
+        await failureSink.flush(firstErrorLine(error));
+        throw error;
+    }
+}
+async function runDeploy({ argv, root, json, failureSink, }) {
     // Stamp the whole invocation up front: the human summary reporter is created
     // late (render time), so without this "Deployed … in 1ms" measured only the
     // summary step rather than the deploy itself.
@@ -1083,7 +1149,13 @@ export async function deployCommand({ argv, root, json, }) {
     // `echo` additionally gates the inline info/warn stream to human/plain: the
     // ndjson stream keeps emitting those lines from the final summary (its
     // pre-existing event order), so wiring steps stays purely additive there.
-    const progress = json ? undefined : createDeployProgress({ argv, startedAt: commandStartedAt });
+    const progress = json
+        ? undefined
+        : createDeployProgress({
+            argv,
+            startedAt: commandStartedAt,
+            onStepFail: (step, detail) => failureSink.noteStepFailure(step, detail),
+        });
     const echo = progress && progress.reporter.mode !== 'ndjson' ? progress.reporter : undefined;
     progress?.reporter.header(basename(root));
     const planOnly = argv.includes('--plan') || argv.includes('--dry-run');
@@ -1132,8 +1204,15 @@ export async function deployCommand({ argv, root, json, }) {
             progress?.reporter.warn('HSX_W_DEPLOY_ACCOUNT_OVERRIDE', `This project is bound to ${resolvedAcct.overrodeBinding}; deploying under ${accountId} for this run only (binding unchanged).`);
         }
     }
+    // Failure reports only make sense for a linked deploy headed at a hosted
+    // control plane; a plan/no-record run never emails.
+    if (linked && controlPlaneUrl && accountId && !planOnly && !noRecord) {
+        failureSink.arm({ controlPlaneUrl, userId, accountId });
+    }
     const explicitProjectId = resolveFlag(argv, '--project-id') ?? process.env.HSX_PROJECT_ID;
     let projectId = explicitProjectId;
+    if (projectId)
+        failureSink.setProject(projectId);
     const validateStep = progress?.step('Validating project');
     const validation = await validateProject({ root });
     const workers = await discoverWorkerManifests(root, { noManageSchema });
@@ -1388,6 +1467,8 @@ export async function deployCommand({ argv, root, json, }) {
             });
         }
     }
+    if (controlPlaneRequest)
+        failureSink.setProject(controlPlaneRequest.projectId);
     if (echo && controlPlaneRequest) {
         echo.info(`Control plane: ready to POST /v1/deploys/plan for ${controlPlaneRequest.projectId}`);
     }
@@ -1423,6 +1504,8 @@ export async function deployCommand({ argv, root, json, }) {
     const controlPlaneBackedPlan = Boolean(controlPlanePlan && controlPlaneRequest && (localControlPlane || controlPlaneUrl));
     const unlinkedDeployPlan = Boolean(controlPlanePlan && !controlPlaneBackedPlan);
     if (controlPlanePlan) {
+        if (controlPlaneBackedPlan)
+            failureSink.setDeployId(controlPlanePlan.deployId);
         controlPlanePlanStep?.ok(controlPlanePlan.deployId);
         if (echo) {
             if (unlinkedDeployPlan)
@@ -1508,6 +1591,7 @@ export async function deployCommand({ argv, root, json, }) {
             argv,
             root,
             local: localHubspotUpload,
+            useControlPlaneLease: controlPlaneBackedPlan,
             uploadOnly: hubspotUploadOnly,
             ...(progress
                 ? {
@@ -4683,7 +4767,7 @@ function runCloudflareCommand(command, options) {
         },
     })));
 }
-async function executeHubSpotOnlyUpload({ argv, root, local, persistBinding = true, uploadOnly, prepared, progress, }) {
+async function executeHubSpotOnlyUpload({ argv, root, local, useControlPlaneLease = true, persistBinding = true, uploadOnly, prepared, progress, }) {
     // The HubSpot project name must match the name baked into the generated
     // bundle (hsproject.json + app-hsmeta uid), not the on-disk directory name.
     // Using basename(root) breaks when the project lives in a generic dir (e.g.
@@ -4741,6 +4825,7 @@ async function executeHubSpotOnlyUpload({ argv, root, local, persistBinding = tr
             argv,
             local,
             allowedOperations: ['hubspot-project-upload'],
+            useControlPlaneLease,
             cwd: root,
         });
     const hsproject = await readHubSpotProjectConfig(root);