@hs-x/cli 0.4.2-next.1 → 0.4.3

package/dist/commands/dev.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dev.d.ts","sourceRoot":"","sources":["../../src/commands/dev.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,OAAO,MAAM,qBAAqB,CAAC;AAI/C,OAAO,EAAU,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,KAAK,QAAQ,EAAY,MAAM,iBAAiB,CAAC;AA0C1D,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,sBAAsB,CAAC;AACrD,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAC9C,OAAO,EAAE,GAAG,EAAE,MAAM,oBAAoB,CAAC;AAyvBzC,wBAAsB,UAAU,CAAC,EAC/B,IAAI,EACJ,IAAI,EACJ,IAAI,EACJ,QAAQ,GACT,EAAE;IACD,QAAQ,CAAC,IAAI,EAAE,SAAS,MAAM,EAAE,CAAC;IACjC,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,QAAQ,CAAC,IAAI,EAAE,OAAO,CAAC;IACvB,QAAQ,CAAC,QAAQ,CAAC,EAAE,QAAQ,CAAC;CAC9B,GAAG,OAAO,CAAC,SAAS,CAAC,CAuErB;AA+lFD,eAAO,MAAM,MAAM;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EAiJlB,CAAC"}
+{"version":3,"file":"dev.d.ts","sourceRoot":"","sources":["../../src/commands/dev.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,OAAO,MAAM,qBAAqB,CAAC;AAI/C,OAAO,EAAU,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,KAAK,QAAQ,EAAY,MAAM,iBAAiB,CAAC;AA2C1D,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,sBAAsB,CAAC;AACrD,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAC9C,OAAO,EAAE,GAAG,EAAE,MAAM,oBAAoB,CAAC;AAuzBzC,wBAAsB,UAAU,CAAC,EAC/B,IAAI,EACJ,IAAI,EACJ,IAAI,EACJ,QAAQ,GACT,EAAE;IACD,QAAQ,CAAC,IAAI,EAAE,SAAS,MAAM,EAAE,CAAC;IACjC,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,QAAQ,CAAC,IAAI,EAAE,OAAO,CAAC;IACvB,QAAQ,CAAC,QAAQ,CAAC,EAAE,QAAQ,CAAC;CAC9B,GAAG,OAAO,CAAC,SAAS,CAAC,CAuErB;AAmnFD,eAAO,MAAM,MAAM;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EAiJlB,CAAC"}

package/dist/commands/dev.js

@@ -16,7 +16,7 @@ import { formatConfigUrl, loadCliConfig } from '../config.js';
 import { CLI_VERSION } from '../constants.js';
 import { controlPlaneAuthHeaders } from '../control-plane-fetch.js';
 import { selectHubSpotDirectDevAccounts } from '../dev/account-selection.js';
-import { listHubSpotDevComponentCandidates, resolveHubSpotDevComponentSelectors, } from '../dev/component-selection.js';
+import { listHubSpotDevComponentCandidates, resolveHubSpotDevComponentSelectors, resolveHubSpotDevSessionApp, } from '../dev/component-selection.js';
 import { createManagedDevEventWriter, createManagedDevSession, markManagedDevSessionReady, markManagedDevSessionState, prepareManagedDevSessionRestart, publicManagedDevSession, readManagedDevEvents, readManagedDevSession, reconcileManagedDevSession, setManagedDevSessionPid, stopManagedDevSessionProcess, waitForManagedDevSessionOwner, } from '../dev/managed-session.js';
 import { findListeningProcess, isHubSpotDevPortConflict, stopProcessCommand, terminateProcessGracefully, } from '../dev/port-process.js';
 import { executeCliHttp } from '../effect-http.js';
@@ -44,6 +44,22 @@ function isRecord(value) {
 function isErrnoException(value) {
     return value instanceof Error && typeof value.code === 'string';
 }
+/**
+ * One heartbeat failure is noise (HubSpot hiccups; the next tick retries).
+ * Three in a row is ~90s of a session HubSpot no longer acknowledges, which is
+ * when cards stop loading — say so once, then again every ten ticks so a long
+ * outage keeps getting a line without flooding the stream.
+ */
+function describeHeartbeatFailure(failure, portalId) {
+    const streak = failure.consecutiveFailures;
+    if (streak < 3 || (streak > 3 && (streak - 3) % 10 !== 0))
+        return undefined;
+    const detail = failure.status !== undefined ? `HTTP ${failure.status}` : failure.message;
+    const hint = failure.status === 401 || failure.status === 403
+        ? `HubSpot rejected the credential for testing account ${portalId} — run \`hs account auth\` for that account, then restart \`hs-x dev\`.`
+        : `HubSpot may have dropped session ${failure.sessionId}; restart \`hs-x dev\` if cards stop loading.`;
+    return `HubSpot dev-session heartbeat failed ${streak} times in a row (${detail}). ${hint}`;
+}
 function describeDevSessionFailure(cause) {
     const error = isRecord(cause) ? cause : undefined;
     const message = cause instanceof Error ? cause.message : String(cause);
@@ -385,17 +401,29 @@ async function hubSpotDirectDevCommand({ argv, root, json, }) {
     });
     const requestedComponents = resolveFlags(argv, '--component');
     const resolvedComponents = resolveHubSpotDevComponentSelectors(uiExtensionNodes?.candidates ?? [], requestedComponents);
-    if (!resolvedComponents.ok) {
+    const requestedAppCheck = resolvedComponents.ok && requestedComponents.length > 0
+        ? resolveHubSpotDevSessionApp(uiExtensionNodes?.candidates ?? [], resolvedComponents.uids)
+        : undefined;
+    const componentsProblem = !resolvedComponents.ok
+        ? { code: 'HSX_E_DEV_SESSION_NO_NODES', message: resolvedComponents.message }
+        : requestedAppCheck && !requestedAppCheck.ok
+            ? { code: 'HSX_E_DEV_SESSION_MULTI_APP', message: requestedAppCheck.message }
+            : undefined;
+    if (componentsProblem || !resolvedComponents.ok) {
+        const problem = componentsProblem ?? {
+            code: 'HSX_E_DEV_SESSION_NO_NODES',
+            message: 'No HubSpot dev components resolved.',
+        };
         if (json) {
             write(`${JSON.stringify({
                 schema_version: 1,
                 command: 'dev',
                 ok: false,
-                error: { code: 'HSX_E_DEV_SESSION_NO_NODES', message: resolvedComponents.message },
+                error: { code: problem.code, message: problem.message },
             }, null, 2)}\n`);
         }
         else {
-            reporter.error('HSX_E_DEV_SESSION_NO_NODES', resolvedComponents.message);
+            reporter.error(problem.code, problem.message);
             reporter.done(undefined, 1);
         }
         return { exitCode: 1 };
@@ -408,11 +436,16 @@ async function hubSpotDirectDevCommand({ argv, root, json, }) {
         uiExtensionNodes.candidates.length > 1 &&
         !json &&
         isInteractive()) {
+        const pickerCandidates = uiExtensionNodes.candidates;
         const picked = await promptMultiSelect({
             message: `Which HubSpot components should run in dev mode? (testing account ${testingAccount.portalId})`,
             initial: [],
             minSelected: 1,
-            options: uiExtensionNodes.candidates.map((candidate) => ({
+            validate: (selection) => {
+                const check = resolveHubSpotDevSessionApp(pickerCandidates, selection);
+                return check.ok ? undefined : check.message;
+            },
+            options: pickerCandidates.map((candidate) => ({
                 value: candidate.uid,
                 label: candidate.label,
                 description: candidate.description,
@@ -462,6 +495,23 @@ async function hubSpotDirectDevCommand({ argv, root, json, }) {
         projectDir: root,
         ...(selectedNodeUids ? { selectedNodeUids } : {}),
         ...(profile ? { profile } : {}),
+        onHeartbeatError: (failure) => {
+            const warning = describeHeartbeatFailure(failure, testingAccount.portalId);
+            if (!warning)
+                return;
+            if (directDevLogStream) {
+                directDevLogStream.bus.emit({
+                    lane: 'hubspot',
+                    level: 'warn',
+                    ts: failure.at.getTime(),
+                    msg: warning,
+                    source: 'dev-session',
+                });
+            }
+            else if (!json) {
+                reporter.warn('HSX_W_DEV_SESSION_HEARTBEAT', warning);
+            }
+        },
         ...(directDevLogStream
             ? {
                 onFrontendLog: (entry) => {
@@ -615,6 +665,13 @@ async function hubSpotDirectDevCommand({ argv, root, json, }) {
             try {
                 await session.cleanup();
             }
+            catch (error) {
+                // Shutdown is best-effort: a HubSpot-side failure (an expired token
+                // on the session delete, say) is worth one line, not a crash trace.
+                if (!json) {
+                    reporter.warn('HSX_W_DEV_SESSION_CLEANUP', `HubSpot dev session was not cleaned up: ${describeDevSessionFailure(error)} HubSpot expires idle sessions on its own.`);
+                }
+            }
             finally {
                 try {
                     await directDevLogStream?.cleanup();
@@ -753,17 +810,24 @@ async function devCommandCore({ argv, root, json, }) {
     }
     const workers = await discoverWorkerManifests(root);
     await generateProjectArtifacts({ root, workers });
-    let portalId = resolveFlag(argv, '--portal');
+    const noHubSpot = argv.includes('--no-hubspot');
+    // `--no-hubspot` is an explicit local-only posture. It must win over both
+    // an accidental --portal flag and any account discovered from local CLI
+    // state, otherwise dev tries to register a provider override before the
+    // existing HubSpot dev-session guard gets a chance to skip that work.
+    let portalId = noHubSpot ? undefined : resolveFlag(argv, '--portal');
     const targetOrigin = resolveFlag(argv, '--target-origin');
     const telemetryOrigin = resolveFlag(argv, '--telemetry-origin');
     const forceDevOverride = argv.includes('--force');
-    const resolvedDevAcct = await resolveAccountIdOrPrompt({
-        argv,
-        json,
-        purpose: 'this dev session',
-        root,
-    });
-    const accountId = resolvedDevAcct.accountId;
+    const resolvedDevAcct = noHubSpot
+        ? undefined
+        : await resolveAccountIdOrPrompt({
+            argv,
+            json,
+            purpose: 'this dev session',
+            root,
+        });
+    const accountId = resolvedDevAcct?.accountId;
     const devCliConfig = loadCliConfig(argv);
     // Portal id: HubSpot account ids in our store look like `portal-46993937`;
     // strip the prefix when the user didn't pass --portal explicitly.
@@ -806,16 +870,18 @@ async function devCommandCore({ argv, root, json, }) {
         reporter.done(undefined, 10);
         return { exitCode: 10 };
     }
-    if (!portalId) {
+    if (!noHubSpot && !portalId) {
         portalId = await resolveDefaultPortalId({ root, accountId });
     }
     // Probe the HubSpot project IR up front so the picker can show UI-extension
     // nodes alongside HS-X capabilities. No-op if hsproject.json isn't present.
-    const uiExtensionNodes = await probeHubSpotUiNodes({
-        root,
-        portalIdFlag: portalId,
-        accountId,
-    });
+    const uiExtensionNodes = noHubSpot
+        ? undefined
+        : await probeHubSpotUiNodes({
+            root,
+            portalIdFlag: portalId,
+            accountId,
+        });
     let capabilityIds = selectedCapabilities.length > 0 ? selectedCapabilities : allCapabilityIds;
     let selectedUiNodeUids = uiExtensionNodes && uiExtensionNodes.uids.length > 0 ? uiExtensionNodes.uids : undefined;
     // Unified picker: ask once over HS-X capabilities + HubSpot UI nodes.
@@ -845,6 +911,10 @@ async function devCommandCore({ argv, root, json, }) {
             message: `Which components should run in dev mode? (portal ${portalId})`,
             initial,
             minSelected: 1,
+            validate: (selection) => {
+                const check = resolveHubSpotDevSessionApp(uiExtensionNodes?.candidates ?? [], selection.filter((v) => v.startsWith(UI_PREFIX)).map((v) => v.slice(UI_PREFIX.length)));
+                return check.ok ? undefined : check.message;
+            },
             options,
         });
         if (picked === undefined)
@@ -861,7 +931,7 @@ async function devCommandCore({ argv, root, json, }) {
     // We register a dev override whenever the user has a HubSpot portal in
     // play. `hs-x connect` gives us the portal id implicitly; only edge cases
     // (no connected account, no --portal flag) skip registration.
-    const shouldRegisterOverride = Boolean(portalId);
+    const shouldRegisterOverride = !noHubSpot && Boolean(portalId);
     if (shouldRegisterOverride) {
         const portalIdForOverride = portalId;
         if (!portalIdForOverride) {
@@ -1317,7 +1387,7 @@ async function devCommandCore({ argv, root, json, }) {
             ? [{ status: 'ok', key: 'telemetry', value: telemetryOrigin }]
             : []),
     ]);
-    if (!portalId) {
+    if (!noHubSpot && !portalId) {
         reporter.info('No HubSpot portal found — running local-only. Pass `--portal <id>` (or set a default with `hs auth` / `hs-x login`) to mirror a live portal.');
     }
     // The pinned status line carries the key map (incl. quit); repeating it in
@@ -2145,6 +2215,11 @@ async function maybeStartHubSpotDevSession(input) {
             projectDir: input.root,
             selectedNodeUids: input.selectedNodeUids,
             ...(profile ? { profile } : {}),
+            onHeartbeatError: (failure) => {
+                const warning = describeHeartbeatFailure(failure, portalId);
+                if (warning && !input.json)
+                    input.reporter.warn('HSX_W_DEV_SESSION_HEARTBEAT', warning);
+            },
         });
         input.reporter
             .step('HubSpot UI-extension session')