@hs-web-team/eslint-config-node 5.2.0 → 5.3.0

package/cypress/rate-limit-429.js

@@ -20,6 +20,10 @@ let currentOutline = null;
 /** @type {string | null} */
 let rateLimited429Outline = null;
 
+// URLs whose path doesn't end in a media/download extension; skips media that scripts fetch (best-effort).
+const NOT_MEDIA_OR_DOWNLOAD_URL =
+  /^(?![^?#]*\.(?:mp3|m4a|aac|wav|ogg|oga|opus|flac|mp4|m4v|mov|webm|mkv|m3u8|mpd|ts|m4s|pdf|zip)(?:[?#]|$))/i;
+
 // cy.state('runnable') is an internal API
 const currentRunnable = () => cy.state('runnable');
 
@@ -41,11 +45,15 @@ const disableRetriesForCurrentTest = () => {
 beforeEach(() => {
   rateLimit429Hit = null; // to ensure each scenario starts clean, in case a previous afterEach was skipped
 
-  // Observe every response (middleware:true never modifies). Genuine Cloudflare 429s
+  // Observe responses (middleware:true never modifies). Genuine Cloudflare 429s
   // carry a cf-ray header; third-party 429s (Google c2dm, pixels, etc.) don't, so ignore
   // those — otherwise we'd wrongly disable retries / skip an outline. Gate on the header,
   // not the host, since the suite may hit several Cloudflare-fronted hosts.
-  cy.intercept({ url: '**/*', middleware: true }, req => {
+  //
+  // Only document/fetch/xhr: Cypress sends each matched response body to the driver over CDP,
+  // and large media bodies overflow Chrome's 100 MB buffer and hang the run. A Cloudflare 429
+  // blocks the whole IP, so page loads and API calls still see it.
+  cy.intercept({ url: NOT_MEDIA_OR_DOWNLOAD_URL, resourceType: /^(document|fetch|xhr)$/, middleware: true }, req => {
     req.on('response', res => {
       const ray = res.headers['cf-ray'];
       if (res.statusCode === 429 && ray) {

package/examples/cypress-usage.md

@@ -131,6 +131,11 @@ IP block, so a retry can't pass — it just burns the limited request budget. Th
 Detection is gated on Cloudflare's `cf-ray` response header, so unrelated third-party 429s
 (pixels, analytics, etc.) don't trigger it.
 
+The handler only watches `document`, `fetch` and `xhr` responses, and skips URLs ending in a
+media or download extension (`.mp3`, `.mp4`, `.m3u8`, `.pdf`, …). Cypress sends every watched
+response body to the driver, and large media can overflow Chrome's 100 MB DevTools buffer and
+hang the run. A Cloudflare 429 blocks the whole IP, so page loads and API calls still catch it.
+
 ### Enabling it
 
 Add **one file inside your `stepDefinitions` glob** (commonly
@@ -155,7 +160,7 @@ dependency your suite satisfies.
 
 Real Cloudflare 429s are intermittent, so to confirm the handler fires, force one in a
 throwaway/smoke spec with a **dynamic-reply** intercept — point it at a request the page
-actually makes (a browser `fetch`/XHR, not `cy.request`):
+actually makes (a page load or browser `fetch`/XHR, not `cy.request` or a static asset):
 
 ```js
 cy.intercept('GET', '**/your-endpoint', req =>
@@ -163,7 +168,7 @@ cy.intercept('GET', '**/your-endpoint', req =>
 );
 ```
 
-The handler's `**/*` middleware intercept runs first and observes the response, so the test
+The handler's middleware intercept runs first and observes the response, so the test
 fails once (no retry), carries the `[RATE-LIMIT-429]` marker, and — in a Scenario Outline —
 the remaining examples are skipped. Use a dynamic `req.reply(...)`, not a static stub object:
 a static stub doesn't reliably drive the response lifecycle the middleware observes.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hs-web-team/eslint-config-node",
-  "version": "5.2.0",
+  "version": "5.3.0",
   "description": "HubSpot Marketing WebTeam shared configurations for ESLint, Prettier, Stylelint, and Cypress",
   "files": [
     ".prettierrc.json",
@@ -110,36 +110,19 @@
     "prettier": "3.9.6",
     "prettier-plugin-gherkin": "4.0.0",
     "strip-json-comments": "5.0.3",
+    "stylelint": "^17.1.1",
+    "stylelint-config-standard": "^40.0.0",
+    "stylelint-config-standard-scss": "^17.0.0",
+    "stylelint-declaration-strict-value": "^1.11.1",
     "typescript-eslint": "8.68.0"
   },
   "peerDependencies": {
     "@badeball/cypress-cucumber-preprocessor": "^24.0.1",
-    "cypress": "^15.21.0",
-    "stylelint": "^17.1.1",
-    "stylelint-config-standard": "^40.0.0",
-    "stylelint-config-standard-scss": "^17.0.0",
-    "stylelint-declaration-strict-value": "^1.11.1"
+    "cypress": "^15.21.0"
   },
   "peerDependenciesMeta": {
-    "stylelint": {
-      "optional": true
-    },
-    "stylelint-config-standard": {
-      "optional": true
-    },
-    "stylelint-config-standard-scss": {
-      "optional": true
-    },
-    "stylelint-declaration-strict-value": {
-      "optional": true
-    },
     "cypress": {
       "optional": true
     }
-  },
-  "devDependencies": {
-    "stylelint": "17.15.0",
-    "stylelint-config-standard-scss": "17.0.0",
-    "stylelint-declaration-strict-value": "1.12.1"
   }
 }