@hs-web-team/eslint-config-node 4.0.2 → 4.2.1

package/.githooks/commit-msg

@@ -0,0 +1,28 @@
+#!/bin/sh
+
+commit_msg=$(head -1 "$1")
+
+# Skip merge and revert commits (auto-generated messages)
+case "$commit_msg" in
+  Merge\ *|Revert\ *) exit 0 ;;
+esac
+
+pattern="^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\([a-zA-Z0-9_/-]+\))?!?: .+"
+
+if ! echo "$commit_msg" | grep -qE "$pattern"; then
+  echo ""
+  echo "ERROR: Commit message does not follow Conventional Commits format."
+  echo ""
+  echo "  Expected:  type(optional-scope): description"
+  echo "  Types:     feat | fix | docs | style | refactor | test | chore | ci | perf | revert | build"
+  echo ""
+  echo "  Examples:"
+  echo "    feat: add new rule for import order"
+  echo "    fix: correct comma-dangle config for browser"
+  echo "    feat!: drop support for Node 18  (breaking change -> major bump)"
+  echo "    feat(browser): add React 19 support"
+  echo ""
+  echo "  See: https://www.conventionalcommits.org"
+  echo ""
+  exit 1
+fi

package/.github/workflows/release-please.yml

@@ -0,0 +1,44 @@
+name: Release Please
+
+on:
+  push:
+    branches: [main]
+
+permissions:
+  contents: write
+  pull-requests: write
+  id-token: write  # Required for OIDC npm publish
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+    steps:
+      - uses: googleapis/release-please-action@v5
+        id: release
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+  publish:
+    needs: release-please
+    if: ${{ needs.release-please.outputs.release_created == 'true' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
+        with:
+          node-version: 24
+          registry-url: 'https://registry.npmjs.org'
+      - run: npm ci
+      - run: npm run build --if-present
+      - name: Publish to npm
+        run: |
+          VERSION=$(node -p "require('./package.json').version")
+          if [[ "$VERSION" =~ -next\. ]] || [[ "$VERSION" =~ -(alpha|beta|rc)\. ]]; then
+            echo "Publishing prerelease $VERSION with tag 'next'"
+            npm publish --tag next
+          else
+            echo "Publishing stable $VERSION"
+            npm publish
+          fi

package/.release-please-manifest.json

@@ -0,0 +1,3 @@
+{
+  ".": "4.2.1"
+}

package/.stylelintrc.json

@@ -1,6 +1,15 @@
 {
   "extends": "stylelint-config-standard-scss",
+  "plugins": ["stylelint-declaration-strict-value"],
   "rules": {
+    "scale-unlimited/declaration-strict-value": [
+      ["/color/", "fill", "stroke", "font-size", "font-weight"],
+      {
+        "ignoreValues": ["inherit", "initial", "normal", "unset", "revert", "currentColor", "transparent"],
+        "message": "Expected a CSS custom property (var(--token)) or Sass variable ($var). For color opacity variants, use color-mix(in srgb, var(--token) 80%, transparent) instead of rgba().",
+        "severity": "warning"
+      }
+    ],
     "length-zero-no-unit": null,
     "declaration-empty-line-before": null,
     "no-empty-source": null,
@@ -11,7 +20,13 @@
       }
     ],
     "scss/dollar-variable-pattern": null,
-    "selector-class-pattern": null,
+    "selector-class-pattern": [
+      "^-?[a-z0-9]([a-z0-9]|-(?!-))*$",
+      {
+        "message": "Class names should only contain lowercase alphanumeric characters and hyphens, with no consecutive hyphens",
+        "severity": "warning"
+      }
+    ],
     "declaration-block-no-redundant-longhand-properties": null,
     "alpha-value-notation": null,
     "scss/percent-placeholder-pattern": null,
@@ -33,6 +48,13 @@
       {
         "camelCaseSvgKeywords": true
       }
+    ],
+    "selector-disallowed-list": [
+      ["/(?:^|[\\s>+~])\\s*\\.-[a-z]/i"],
+      {
+        "message": "Modifier classes (starting with '-') must not be standalone selectors; always combine with a base class (e.g., .prefix-element.-modifier or &.-modifier in nested rules)",
+        "severity": "error"
+      }
     ]
   }
 }

package/CHANGELOG.md

@@ -0,0 +1,15 @@
+# Changelog
+
+## [4.2.1](https://github.com/HubSpotWebTeam/wt-eslint-node/compare/v4.2.0...v4.2.1) (2026-06-05)
+
+
+### Bug Fixes
+
+* re-trigger publish after release-please CI fix ([45fe949](https://github.com/HubSpotWebTeam/wt-eslint-node/commit/45fe94930c06d61e6f8f3015bc4e6518e187aaa1))
+
+## [4.2.0](https://github.com/HubSpotWebTeam/wt-eslint-node/compare/v4.1.0...v4.2.0) (2026-06-05)
+
+
+### Features
+
+* warn on hardcoded color, font-size, and font-weight values ([#37](https://github.com/HubSpotWebTeam/wt-eslint-node/issues/37)) ([783a320](https://github.com/HubSpotWebTeam/wt-eslint-node/commit/783a320a3d0e858cd370670be452aaa847ba9c39))

package/README.md

@@ -13,6 +13,7 @@ This package provides ESLint rules and configurations for **Hubspot Marketing We
 - [Accessibility Testing](#accessibility-testing-optional)
 - [Where to use it](#where-to-use-it)
 - [Using the Prettier Scripts](#using-the-prettier-scripts)
+- [Contributing](#contributing)
 <!-- index-end -->
 
 ## Node.js Setup
@@ -199,3 +200,57 @@ See [MIGRATION-V2.md](./docs/MIGRATION-V2.md)
 ## Migration from v2 to v3
 
 See [MIGRATION-V3.md](./docs/MIGRATION-V3.md)
+
+## Contributing
+
+### Conventional Commits
+
+This repo uses [Conventional Commits](https://www.conventionalcommits.org) for all commit messages. A `commit-msg` git hook validates the format automatically — run `npm install` once to activate it.
+
+**Format:** `type(optional-scope): description`
+
+| Type | Use for | Version bump |
+|------|---------|-------------|
+| `feat` | New feature or config rule | Minor (`4.0.0` → `4.1.0`) |
+| `fix` | Bug fix or rule correction | Patch (`4.0.0` → `4.0.1`) |
+| `feat!` or `BREAKING CHANGE:` footer | Breaking API/config change | Major (`4.0.0` → `5.0.0`) |
+| `chore` | Dependency updates, tooling | No release |
+| `docs` | Documentation only | No release |
+| `refactor` | Internal restructuring | No release |
+| `ci` | CI/CD changes | No release |
+| `test` | Test changes | No release |
+
+**Examples:**
+
+```
+feat: add import/order rule to Node config
+fix: align browser comma-dangle with prettier defaults
+feat(browser): add React 19 peer dep support
+feat!: drop Node 18 support — requires Node 24+
+chore: bump typescript-eslint to v8.60
+docs: update Cypress usage examples
+```
+
+A breaking change can also be indicated by adding a `BREAKING CHANGE:` footer to any commit type:
+
+```
+feat: remove deprecated stylelint rules
+
+BREAKING CHANGE: Removed rules that were dropped in stylelint-scss@7.
+Projects relying on those rules must update their configs before upgrading.
+```
+
+### Release Process
+
+Releases are automated via [release-please](https://github.com/googleapis/release-please). No manual version bumping or GitHub release creation is needed.
+
+**How it works:**
+
+1. Merge PRs to `main` using conventional commit messages (see above).
+2. After each merge, release-please opens or updates a **Release PR** (titled `chore(main): release X.Y.Z`) that accumulates all unreleased changes, bumps `package.json`, and generates a `CHANGELOG.md` entry.
+3. When you are ready to publish, **merge the Release PR**.
+4. release-please creates a GitHub release and git tag automatically.
+5. The `release.yml` workflow fires on the new release and publishes to npm.
+
+**To release a prerelease (`-next.N`):**  
+Update the version in `package.json` manually on a branch (e.g. `4.1.0-next.0`) and create a GitHub release by hand — the existing `release.yml` workflow will publish it with the `next` tag on npm. Prereleases are not yet managed by release-please in this repo.

package/bin/check-peer-deps.cjs

@@ -0,0 +1,78 @@
+#!/usr/bin/env node
+
+const fs = require('fs');
+const path = require('path');
+
+const projectRoot = process.env.INIT_CWD || process.env.npm_config_local_prefix;
+
+// Skip if we can't determine the consuming project's root, or if postinstall
+// is running inside this package's own development environment.
+if (!projectRoot || projectRoot === path.resolve(__dirname, '..')) {
+  process.exit(0);
+}
+
+const ownPkg = require('../package.json');
+
+const stylelintPeers = Object.entries(ownPkg.peerDependencies || {}).filter(([name]) =>
+  name.startsWith('stylelint')
+);
+
+// Extracts the minimum required major version from a semver range like ^17.0.0 or >=17.1.1.
+const minMajor = (range) => {
+  const match = range.match(/(\d+)/);
+  return match ? parseInt(match[1], 10) : 0;
+};
+
+const isInstalled = (pkg) =>
+  fs.existsSync(path.join(projectRoot, 'node_modules', pkg, 'package.json'));
+
+// Only warn about missing stylelint plugins if stylelint itself is installed —
+// consumers who don't use stylelint at all don't need any of these.
+const stylelintInUse = isInstalled('stylelint');
+
+const outdated = [];
+const missing = [];
+
+for (const [pkg, requiredRange] of stylelintPeers) {
+  const pkgJsonPath = path.join(projectRoot, 'node_modules', pkg, 'package.json');
+
+  if (!fs.existsSync(pkgJsonPath)) {
+    if (stylelintInUse && pkg !== 'stylelint') {
+      missing.push({ pkg, requiredRange });
+    }
+    continue;
+  }
+
+  const { version } = JSON.parse(fs.readFileSync(pkgJsonPath, 'utf8'));
+  const installedMajor = parseInt(version.split('.')[0], 10);
+
+  if (installedMajor < minMajor(requiredRange)) {
+    outdated.push({ pkg, version, requiredRange });
+  }
+}
+
+if (outdated.length === 0 && missing.length === 0) process.exit(0);
+
+const pkgName = ownPkg.name;
+
+if (missing.length > 0) {
+  console.warn(`\n⚠️  ${pkgName}: missing stylelint peer dependencies.\n`);
+  console.warn('   These packages are required for stylelint to work correctly:');
+  for (const { pkg, requiredRange } of missing) {
+    console.warn(`   • ${pkg}  (required: ${requiredRange})`);
+  }
+  const installCmd = missing.map(({ pkg, requiredRange }) => `${pkg}@"${requiredRange}"`).join(' ');
+  console.warn(`\n   Run: npm install --save-dev ${installCmd}`);
+  console.warn('   Linting will fail without these packages.\n');
+}
+
+if (outdated.length > 0) {
+  console.warn(`\n⚠️  ${pkgName}: outdated stylelint peer dependencies detected.\n`);
+  console.warn('   These packages are installed at versions that are no longer compatible:');
+  for (const { pkg, version, requiredRange } of outdated) {
+    console.warn(`   • ${pkg}@${version}  →  required: ${requiredRange}`);
+  }
+  const upgradeCmd = outdated.map(({ pkg, requiredRange }) => `${pkg}@"${requiredRange}"`).join(' ');
+  console.warn(`\n   Run: npm install ${upgradeCmd}`);
+  console.warn('   Failure to upgrade may cause unexpected lint errors.\n');
+}

package/examples/stylelint-usage.md

@@ -7,7 +7,7 @@ This package provides a shared Stylelint configuration for SCSS/CSS linting in H
 1. Install the package and stylelint dependencies:
 
 ```bash
-npm install --save-dev @hs-web-team/eslint-config-node stylelint stylelint-config-standard-scss
+npm install --save-dev @hs-web-team/eslint-config-node stylelint stylelint-config-standard-scss stylelint-declaration-strict-value
 ```
 
 ## Usage
@@ -136,7 +136,7 @@ To override rules for your project, add them to your `.stylelintrc.json`:
 If you get a module not found error, ensure you have installed all dependencies:
 
 ```bash
-npm install --save-dev stylelint stylelint-config-standard-scss
+npm install --save-dev stylelint stylelint-config-standard-scss stylelint-declaration-strict-value
 ```
 
 ### Conflicts with Prettier

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hs-web-team/eslint-config-node",
-  "version": "4.0.2",
+  "version": "4.2.1",
   "description": "HubSpot Marketing WebTeam shared configurations for ESLint, Prettier, Stylelint, and Cypress",
   "main": "index.js",
   "type": "module",
@@ -29,8 +29,10 @@
     }
   },
   "scripts": {
+    "postinstall": "node bin/check-peer-deps.cjs",
     "lint": "npx eslint -c ./index.js *.js --fix",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "prepare": "git rev-parse --git-dir > /dev/null 2>&1 && git config core.hooksPath .githooks || true"
   },
   "engines": {
     "node": ">=24"
@@ -82,7 +84,8 @@
     "cypress": "^15.16.0",
     "stylelint": "^17.1.1",
     "stylelint-config-standard": "^40.0.0",
-    "stylelint-config-standard-scss": "^17.0.0"
+    "stylelint-config-standard-scss": "^17.0.0",
+    "stylelint-declaration-strict-value": "^1.11.1"
   },
   "peerDependenciesMeta": {
     "stylelint": {
@@ -94,6 +97,9 @@
     "stylelint-config-standard-scss": {
       "optional": true
     },
+    "stylelint-declaration-strict-value": {
+      "optional": true
+    },
     "cypress": {
       "optional": true
     }

package/release-please-config.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
+  "release-type": "node",
+  "include-component-in-tag": false,
+  "packages": {
+    ".": {}
+  }
+}

package/.github/workflows/release.yml

@@ -1,34 +0,0 @@
-name: Publish Package to npmjs
-on:
-  release:
-    types: [created]
-
-permissions:
-  id-token: write  # Required for OIDC
-  contents: read
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v6
-      - uses: actions/setup-node@v6
-        with:
-          node-version: 24
-          registry-url: 'https://registry.npmjs.org'
-      - run: npm ci
-      - run: npm run build --if-present
-      - name: Publish to npm
-        run: |
-          VERSION=$(node -p "require('./package.json').version")
-          if [[ "$VERSION" =~ -next\. ]]; then
-            echo "Publishing prerelease version $VERSION with tag 'next'"
-            npm publish --tag next
-          elif [[ "$VERSION" =~ -(alpha|beta|rc)\. ]]; then
-            echo "Publishing prerelease version $VERSION with tag 'next'"
-            npm publish --tag next
-          else
-            echo "Publishing stable version $VERSION"
-            npm publish
-          fi