@hs-web-team/eslint-config-node 2.1.2 → 3.0.0-next.4

package/.github/workflows/main.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [20, 22]
+        node: [24]
 
     name: Node ${{ matrix.node }} sample
     steps:

package/.github/workflows/pr.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [20, 22]
+        node: [24]
 
     name: Node ${{ matrix.node }} sample
     steps:

package/.github/workflows/release.yml

@@ -10,9 +10,21 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: 24
           registry-url: 'https://registry.npmjs.org'
       - run: npm install
-      - run: npm publish
+      - name: Publish to npm
+        run: |
+          VERSION=$(node -p "require('./package.json').version")
+          if [[ "$VERSION" =~ -next\. ]]; then
+            echo "Publishing prerelease version $VERSION with tag 'next'"
+            npm publish --tag next
+          elif [[ "$VERSION" =~ -(alpha|beta|rc)\. ]]; then
+            echo "Publishing prerelease version $VERSION with tag 'next'"
+            npm publish --tag next
+          else
+            echo "Publishing stable version $VERSION"
+            npm publish
+          fi
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

package/README.md

@@ -19,23 +19,36 @@ This is a list of ESLint rules that are recommended for use with **Hubspot Marke
     npm i -D @hs-web-team/eslint-config-node@latest
     ```
 
-2. Add to `.eslintrc` in project root directory
+2. Add to `eslint.config.js` in project root directory
 
-    ```json
-    {
-      "extends": "@hs-web-team/eslint-config-node"
-    }
-    ```
+    ```typescript
+    import { defineConfig } from 'eslint/config';
+    import wtConfig from '@hs-web-team/eslint-config-node';
 
-3. Extend the eslint on a project basis by adding rules to `.eslintrc` e.g.
+    export default defineConfig([
+      ...wtConfig,
+    ]);
+    ```
 
-    ```json
-    {
-      "extends": "@hs-web-team/eslint-config-node",
-      "settings": {
-        "import/resolver": "webpack"
-      }
-    }
+3. Extend the eslint on a project basis by adding rules to `eslint.config.js` e.g.
+
+    ```typescript
+    import { defineConfig } from 'eslint/config';
+    import wtConfig from '@hs-web-team/eslint-config-node';
+
+    export default defineConfig([
+      // Add project-specific ignores here
+      {
+        ignores: ['dist/**'],
+      },
+      // Add project-specific rules here
+      {
+        rules: {
+          'no-console': 'error',
+        },
+      },
+      ...wtConfig, // This will include the shared rules from @hs-web-team/eslint-config-node
+    ]);
     ```
 
 ## Where to use it
@@ -67,3 +80,7 @@ This package includes a utility script to automatically add Prettier configurati
 ## Migration from v1 to v2
 
 See [MIGRATION-V2.md](./docs/MIGRATION-V2.md)
+
+## Migration from v2 to v3
+
+See [MIGRATION-V3.md](./docs/MIGRATION-V3.md)

package/docs/MIGRATION-V3.md

@@ -0,0 +1,24 @@
+# Migration from v2 to v3
+
+## Steps to migrate
+
+> **Note**
+>
+> This migration requires a manual review of the changes and also that you run your project in Node.js v22 or higher.
+
+- [ ] Upgrade to Node.js v22 or higher
+- [ ] Upgrade all dependencies to the latest version
+- [ ] Update the package `npm install @hs-web-team/eslint-config-node@latest`
+- [ ] Run the script `npx @eslint/migrate-config .eslintrc`
+- [ ] Run `npm run lint` to check for any errors
+- [ ] Commit the changes
+- [ ] Create a PR
+- [ ] Get it approved
+- [ ] Merge it into `main`
+- [ ] Test everything in QA
+- [ ] Celebrate! 🎉
+
+> **Important**
+>
+> Bear in mind that this migration will remove the `.eslintrc` file and replace it with `eslint.config.js`.
+> Also the automated migration might fail to migrate some of the rules, so you may need to manually adjust the `eslint.config.js` file.

package/index.js

@@ -1,45 +1,56 @@
-module.exports = {
-  env: {
-    commonjs: true,
-    es2021: true,
-    node: true,
-  },
-  ignorePatterns: ['/node_modules/', '/.serverless/', '/.eslintrc.js', '/.webpack/'],
-  extends: ['airbnb-base'],
-  parserOptions: {
-    ecmaVersion: 'latest',
-  },
-  rules: {
-    'no-console': [
-      'error',
-      {
-        allow: ['info', 'warn', 'error'],
-      },
+import js from '@eslint/js';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+import { defineConfig } from 'eslint/config';
+
+export default defineConfig([
+  {
+    files: ['**/*.{js,mjs,cjs,ts,mts,cts}'],
+    plugins: { js },
+    extends: ['js/recommended'],
+    languageOptions: {
+      globals: {...globals.node, ...globals.es2022},
+    },
+    ignores: [
+      '**/node_modules/**',
+      '**/.serverless/**',
+      '**/.webpack/**',
+      '**/dist/**',
+      'eslint.config.js',
     ],
-    camelcase: 0,
-    'comma-dangle': 1,
-    'arrow-parens': 0,
-    'no-plusplus': 0,
-    'no-underscore-dangle': 0,
-    'no-confusing-arrow': 0,
-    'import/no-unresolved': 0,
-    'import/prefer-default-export': 0,
-    'no-trailing-spaces': [2, { skipBlankLines: true }],
-    'no-unused-expressions': [1, { allowTernary: true }],
-    'max-len': [
-      2,
-      {
-        code: 120,
-        ignoreStrings: true,
-        ignoreTemplateLiterals: true,
-      },
-    ],
-    'operator-linebreak': 0,
-    'implicit-arrow-linebreaks': 0,
-    'implicit-arrow-linebreak': 0,
-    'object-curly-newline': 0,
-    'newline-per-chained-call': 0,
-    indent: 0,
-    'function-paren-newline': 0,
+    rules: {
+      'no-console': [
+      'error',
+        {
+          allow: ['info', 'warn', 'error'],
+        },
+      ],
+      camelcase: 'off',
+      'comma-dangle': ['warn', 'always-multiline'],
+      'arrow-parens': 0,
+      'no-plusplus': 0,
+      'no-underscore-dangle': 0,
+      'no-confusing-arrow': 0,
+      'import/no-unresolved': 0,
+      'import/prefer-default-export': 0,
+      'no-trailing-spaces': ['error', { skipBlankLines: true }],
+      'no-unused-expressions': ['warn', { allowTernary: true }],
+      'max-len': [
+        2,
+        {
+          code: 120,
+          ignoreStrings: true,
+          ignoreTemplateLiterals: true,
+        },
+      ],
+      'operator-linebreak': 0,
+      'implicit-arrow-linebreaks': 0,
+      'implicit-arrow-linebreak': 0,
+      'object-curly-newline': 0,
+      'newline-per-chained-call': 0,
+      indent: 0,
+      'function-paren-newline': 0,
+    },
   },
-};
+  tseslint.configs.recommended,
+]);

package/package.json

@@ -1,8 +1,9 @@
 {
   "name": "@hs-web-team/eslint-config-node",
-  "version": "2.1.2",
+  "version": "3.0.0-next.4",
   "description": "HubSpot Marketing WebTeam ESLint rules for Node.js",
   "main": "index.js",
+  "type": "module",
   "scripts": {
     "lint": "npx eslint -c ./index.js *.js --fix",
     "test": "echo \"Error: no test specified\" && exit 1"
@@ -11,7 +12,7 @@
     "node": ">=22"
   },
   "bin": {
-    "add-prettier": "./bin/add-prettier-scripts.js"
+    "add-prettier": "bin/add-prettier-scripts.js"
   },
   "repository": {
     "type": "git",
@@ -27,9 +28,13 @@
   },
   "homepage": "https://github.com/HubSpotWebTeam/wt-eslint-node#readme",
   "dependencies": {
-    "eslint": "^8.57.1",
-    "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-plugin-import": "^2.32.0",
-    "prettier": "^3.6.2"
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.39.1",
+    "@typescript-eslint/eslint-plugin": "^8.46.3",
+    "@typescript-eslint/parser": "^8.46.3",
+    "globals": "^16.5.0",
+    "prettier": "^3.6.2",
+    "jiti": "^2.6.1",
+    "typescript-eslint": "^8.46.3"
   }
 }