@howells/lint 0.2.4 → 0.2.6

package/README.md

@@ -69,7 +69,7 @@ Node or non-React TypeScript package:
 
 ```json
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.15/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json",
   "extends": ["@howells/lint/biome/core"],
   "root": true
 }
@@ -79,7 +79,7 @@ React package:
 
 ```json
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.15/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json",
   "extends": ["@howells/lint/biome/core", "@howells/lint/biome/react"],
   "root": true
 }
@@ -89,12 +89,8 @@ Next.js app:
 
 ```json
 {
-  "$schema": "https://biomejs.dev/schemas/2.4.15/schema.json",
-  "extends": [
-    "@howells/lint/biome/core",
-    "@howells/lint/biome/react",
-    "@howells/lint/biome/next"
-  ],
+  "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json",
+  "extends": ["@howells/lint/biome/core", "@howells/lint/biome/react", "@howells/lint/biome/next"],
   "root": true
 }
 ```
@@ -103,7 +99,9 @@ Next.js app:
 
 Use this lane when a project wants Oxlint and Oxfmt instead of Biome. React and Next presets stack the relevant Ultracite Ox rules with [React Doctor](https://react.doctor) rules in one config.
 
-React Doctor severities are passed through as published by React Doctor. Native Oxlint Next.js severities come from Oxlint's official `nextjs` plugin via Ultracite's Next preset. `@howells/lint` adds canonical Howells policy on top for file naming, barrel files, env access, and tests.
+React Doctor severities are passed through as published by React Doctor. Native Oxlint Next.js severities come from Oxlint's official `nextjs` plugin via Ultracite's Next preset. `@howells/lint` adds canonical Howells policy on top for file naming, barrel files, env access, file size, function size, complexity, and tests.
+
+The core Oxlint preset enables native Oxlint rules that keep code files navigable: `max-lines` errors above 600 non-comment, non-blank lines; `max-lines-per-function` errors above 120 non-comment, non-blank lines; `max-statements` errors above 45 statements per function; and `complexity` errors above cyclomatic complexity 15. Test files keep the file-level `max-lines` guard but disable function-size, statement-count, and complexity limits, because test framework callbacks naturally wrap many independent cases. Generated files should be ignored at the project level; rare intentional exceptions should use an exact-file override with a short refactor note.
 
 Choose the closest preset:
 

package/bin/env.mjs

@@ -0,0 +1,3 @@
+/* oxlint-disable no-restricted-properties -- CLI wrappers intentionally pass the caller environment to child processes. */
+
+export const inheritedEnv = () => process.env;

package/bin/howells-format.mjs

@@ -3,9 +3,6 @@
 import { runPackageBin } from "./run-package-bin.mjs";
 
 const targets = process.argv.slice(2);
-const args =
-	targets.length > 0
-		? ["check", "--write", ...targets]
-		: ["check", "--write", "."];
+const args = targets.length > 0 ? ["check", "--write", ...targets] : ["check", "--write", "."];
 
 runPackageBin("@biomejs/biome", "biome", args);

package/bin/howells-lint-strict.mjs

@@ -4,39 +4,38 @@ import { runPackageBin } from "./run-package-bin.mjs";
 
 const args = process.argv.slice(2);
 const passthroughOptions = new Set(["--help", "-h", "--version", "-V"]);
-const targets =
-	args.length === 0 || args[0].startsWith("-") ? [".", ...args] : args;
+const targets = args.length === 0 || args[0].startsWith("-") ? [".", ...args] : args;
 
 const strictRuleOptions = [
-	"--only=security",
-	"--skip=security/noSecrets",
-	"--only=correctness/noConstAssign",
-	"--only=correctness/noUnreachable",
-	"--only=correctness/noInvalidConstructorSuper",
-	"--only=correctness/noSetterReturn",
-	"--only=correctness/noUnsafeFinally",
-	"--only=correctness/noUnsafeOptionalChaining",
-	"--only=correctness/noGlobalObjectCalls",
-	"--only=correctness/noSelfAssign",
-	"--only=correctness/noSwitchDeclarations",
-	"--only=suspicious/noDebugger",
-	"--only=suspicious/noDoubleEquals",
-	"--only=suspicious/noExplicitAny",
-	"--only=suspicious/noCatchAssign",
-	"--only=suspicious/noFunctionAssign",
-	"--only=suspicious/noGlobalAssign",
-	"--only=suspicious/noRedeclare",
-	"--only=suspicious/noSparseArray",
-	"--only=suspicious/noVar",
-	"--only=suspicious/noDuplicateCase",
-	"--only=suspicious/noDuplicateObjectKeys",
-	"--only=suspicious/noDuplicateParameters",
-	"--only=suspicious/noFallthroughSwitchClause",
-	"--only=suspicious/noFocusedTests",
+  "--only=security",
+  "--skip=security/noSecrets",
+  "--only=correctness/noConstAssign",
+  "--only=correctness/noUnreachable",
+  "--only=correctness/noInvalidConstructorSuper",
+  "--only=correctness/noSetterReturn",
+  "--only=correctness/noUnsafeFinally",
+  "--only=correctness/noUnsafeOptionalChaining",
+  "--only=correctness/noGlobalObjectCalls",
+  "--only=correctness/noSelfAssign",
+  "--only=correctness/noSwitchDeclarations",
+  "--only=suspicious/noDebugger",
+  "--only=suspicious/noDoubleEquals",
+  "--only=suspicious/noExplicitAny",
+  "--only=suspicious/noCatchAssign",
+  "--only=suspicious/noFunctionAssign",
+  "--only=suspicious/noGlobalAssign",
+  "--only=suspicious/noRedeclare",
+  "--only=suspicious/noSparseArray",
+  "--only=suspicious/noVar",
+  "--only=suspicious/noDuplicateCase",
+  "--only=suspicious/noDuplicateObjectKeys",
+  "--only=suspicious/noDuplicateParameters",
+  "--only=suspicious/noFallthroughSwitchClause",
+  "--only=suspicious/noFocusedTests",
 ];
 
 const resolvedArgs = passthroughOptions.has(args[0])
-	? args
-	: ["lint", ...strictRuleOptions, ...targets];
+  ? args
+  : ["lint", ...strictRuleOptions, ...targets];
 
 runPackageBin("@biomejs/biome", "biome", resolvedArgs);

package/bin/howells-lint.mjs

@@ -4,33 +4,41 @@ import { runPackageBin } from "./run-package-bin.mjs";
 
 const args = process.argv.slice(2);
 const biomeCommands = new Set([
-	"version",
-	"rage",
-	"start",
-	"stop",
-	"check",
-	"lint",
-	"format",
-	"ci",
-	"init",
-	"migrate",
-	"search",
-	"explain",
-	"clean",
-	"daemon",
-	"lsp-proxy",
+  "version",
+  "rage",
+  "start",
+  "stop",
+  "check",
+  "lint",
+  "format",
+  "ci",
+  "init",
+  "migrate",
+  "search",
+  "explain",
+  "clean",
+  "daemon",
+  "lsp-proxy",
 ]);
 const passthroughOptions = new Set(["--help", "-h", "--version", "-V"]);
 
-const resolvedArgs =
-	args.length === 0
-		? ["check", "."]
-		: biomeCommands.has(args[0])
-			? args
-			: passthroughOptions.has(args[0])
-				? args
-				: args[0].startsWith("-")
-					? ["check", ".", ...args]
-					: ["check", ...args];
+const resolveBiomeArgs = (inputArgs) => {
+  if (inputArgs.length === 0) {
+    return ["check", "."];
+  }
+
+  const [firstArg] = inputArgs;
+  if (biomeCommands.has(firstArg) || passthroughOptions.has(firstArg)) {
+    return inputArgs;
+  }
+
+  if (firstArg.startsWith("-")) {
+    return ["check", ".", ...inputArgs];
+  }
+
+  return ["check", ...inputArgs];
+};
+
+const resolvedArgs = resolveBiomeArgs(args);
 
 runPackageBin("@biomejs/biome", "biome", resolvedArgs);

package/bin/howells-ox-check.mjs

@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 
 import { spawnSync } from "node:child_process";
+import { inheritedEnv } from "./env.mjs";
 import { resolvePackageBin } from "./run-package-bin.mjs";
 
 const args = process.argv.slice(2);
@@ -8,21 +9,21 @@ const targets = args.filter((arg) => !arg.startsWith("-"));
 const oxlintOptions = args.filter((arg) => arg.startsWith("-"));
 const resolvedTargets = targets.length > 0 ? targets : ["."];
 
-function run(packageName, binName, commandArgs) {
-	const binPath = resolvePackageBin(packageName, binName);
-	const result = spawnSync(binPath, commandArgs, {
-		stdio: "inherit",
-		env: process.env,
-	});
+const run = (packageName, binName, commandArgs) => {
+  const binPath = resolvePackageBin(packageName, binName);
+  const result = spawnSync(binPath, commandArgs, {
+    env: inheritedEnv(),
+    stdio: "inherit",
+  });
 
-	if (result.error) {
-		throw result.error;
-	}
+  if (result.error) {
+    throw result.error;
+  }
 
-	if ((result.status ?? 1) !== 0) {
-		process.exit(result.status ?? 1);
-	}
-}
+  if ((result.status ?? 1) !== 0) {
+    process.exit(result.status ?? 1);
+  }
+};
 
 run("oxfmt", "oxfmt", ["--check", ...resolvedTargets]);
 run("oxlint", "oxlint", [...oxlintOptions, ...resolvedTargets]);

package/bin/howells-ox-fix.mjs

@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 
 import { spawnSync } from "node:child_process";
+import { inheritedEnv } from "./env.mjs";
 import { resolvePackageBin } from "./run-package-bin.mjs";
 
 const args = process.argv.slice(2);
@@ -10,25 +11,25 @@ const targets = filteredArgs.filter((arg) => !arg.startsWith("-"));
 const oxlintOptions = filteredArgs.filter((arg) => arg.startsWith("-"));
 const resolvedTargets = targets.length > 0 ? targets : ["."];
 
-function run(packageName, binName, commandArgs) {
-	const binPath = resolvePackageBin(packageName, binName);
-	const result = spawnSync(binPath, commandArgs, {
-		stdio: "inherit",
-		env: process.env,
-	});
+const run = (packageName, binName, commandArgs) => {
+  const binPath = resolvePackageBin(packageName, binName);
+  const result = spawnSync(binPath, commandArgs, {
+    env: inheritedEnv(),
+    stdio: "inherit",
+  });
 
-	if (result.error) {
-		throw result.error;
-	}
+  if (result.error) {
+    throw result.error;
+  }
 
-	if ((result.status ?? 1) !== 0) {
-		process.exit(result.status ?? 1);
-	}
-}
+  if ((result.status ?? 1) !== 0) {
+    process.exit(result.status ?? 1);
+  }
+};
 
 run("oxfmt", "oxfmt", ["--write", ...resolvedTargets]);
 run("oxlint", "oxlint", [
-	useDangerousFixes ? "--fix-dangerously" : "--fix",
-	...oxlintOptions,
-	...resolvedTargets,
+  useDangerousFixes ? "--fix-dangerously" : "--fix",
+  ...oxlintOptions,
+  ...resolvedTargets,
 ]);

package/bin/howells-workspace-check.mjs

@@ -7,19 +7,19 @@ import { runWorkspacePreflight } from "./workspace-preflight.mjs";
 const args = process.argv.slice(2);
 
 if (handleManypkgMetadataCommand("check", args)) {
-	process.exit(0);
+  process.exit(0);
 }
 
 const errors = runWorkspacePreflight();
 
 if (errors.length > 0) {
-	console.error("Workspace hygiene check failed:");
+  console.error("Workspace hygiene check failed:");
 
-	for (const error of errors) {
-		console.error(`- ${error}`);
-	}
+  for (const error of errors) {
+    console.error(`- ${error}`);
+  }
 
-	process.exit(1);
+  process.exit(1);
 }
 
 runPackageBin("@manypkg/cli", "manypkg", ["check", ...args]);

package/bin/run-manypkg-command.mjs

@@ -7,34 +7,34 @@ const require = createRequire(import.meta.url);
 const helpOptions = new Set(["--help", "-h"]);
 const versionOptions = new Set(["--version", "-V"]);
 
-export function printManypkgCommandHelp(command) {
-	console.log(`Usage: howells-workspace-${command} [options]\n`);
-	console.log(`Runs: manypkg ${command} [options]`);
-}
-
-export function printManypkgCliVersion() {
-	const { version } = require("@manypkg/cli/package.json");
-	console.log(version);
-}
-
-export function handleManypkgMetadataCommand(command, args) {
-	if (helpOptions.has(args[0])) {
-		printManypkgCommandHelp(command);
-		return true;
-	}
-
-	if (versionOptions.has(args[0])) {
-		printManypkgCliVersion();
-		return true;
-	}
-
-	return false;
-}
-
-export function runManypkgCommand(command, args) {
-	if (handleManypkgMetadataCommand(command, args)) {
-		process.exit(0);
-	}
-
-	runPackageBin("@manypkg/cli", "manypkg", [command, ...args]);
-}
+export const printManypkgCommandHelp = (command) => {
+  console.log(`Usage: howells-workspace-${command} [options]\n`);
+  console.log(`Runs: manypkg ${command} [options]`);
+};
+
+export const printManypkgCliVersion = () => {
+  const { version } = require("@manypkg/cli/package.json");
+  console.log(version);
+};
+
+export const handleManypkgMetadataCommand = (command, args) => {
+  if (helpOptions.has(args[0])) {
+    printManypkgCommandHelp(command);
+    return true;
+  }
+
+  if (versionOptions.has(args[0])) {
+    printManypkgCliVersion();
+    return true;
+  }
+
+  return false;
+};
+
+export const runManypkgCommand = (command, args) => {
+  if (handleManypkgMetadataCommand(command, args)) {
+    process.exit(0);
+  }
+
+  runPackageBin("@manypkg/cli", "manypkg", [command, ...args]);
+};

package/bin/run-package-bin.mjs

@@ -4,75 +4,65 @@ import { spawnSync } from "node:child_process";
 import { existsSync, readFileSync } from "node:fs";
 import { createRequire } from "node:module";
 import { dirname, join } from "node:path";
-import { fileURLToPath } from "node:url";
+import { inheritedEnv } from "./env.mjs";
 
 const require = createRequire(import.meta.url);
-const currentDir = dirname(fileURLToPath(import.meta.url));
-
-function resolvePackageJsonPath(packageName) {
-	try {
-		return require.resolve(`${packageName}/package.json`);
-	} catch {
-		const packageSegments = packageName.split("/");
-		let searchDir = currentDir;
-
-		while (true) {
-			const candidate = join(
-				searchDir,
-				"..",
-				"node_modules",
-				...packageSegments,
-				"package.json",
-			);
-
-			if (existsSync(candidate)) {
-				return candidate;
-			}
-
-			const parentDir = dirname(searchDir);
-
-			if (parentDir === searchDir) {
-				break;
-			}
-
-			searchDir = parentDir;
-		}
-	}
-
-	throw new Error(
-		`Could not resolve package.json for package '${packageName}'.`,
-	);
-}
-
-export function resolvePackageBin(packageName, binName) {
-	const packageJsonPath = resolvePackageJsonPath(packageName);
-	const packageJson = JSON.parse(readFileSync(packageJsonPath, "utf8"));
-	const packageDir = dirname(packageJsonPath);
-	const binField = packageJson.bin;
-
-	if (typeof binField === "string") {
-		return join(packageDir, binField);
-	}
-
-	if (binField && typeof binField === "object" && binField[binName]) {
-		return join(packageDir, binField[binName]);
-	}
-
-	throw new Error(
-		`Could not resolve bin '${binName}' for package '${packageName}'.`,
-	);
-}
-
-export function runPackageBin(packageName, binName, args) {
-	const binPath = resolvePackageBin(packageName, binName);
-	const result = spawnSync(binPath, args, {
-		stdio: "inherit",
-		env: process.env,
-	});
-
-	if (result.error) {
-		throw result.error;
-	}
-
-	process.exit(result.status ?? 1);
-}
+const currentDir = import.meta.dirname;
+
+const resolvePackageJsonPath = (packageName) => {
+  try {
+    return require.resolve(`${packageName}/package.json`);
+  } catch {
+    const packageSegments = packageName.split("/");
+    let searchDir = currentDir;
+
+    while (true) {
+      const candidate = join(searchDir, "..", "node_modules", ...packageSegments, "package.json");
+
+      if (existsSync(candidate)) {
+        return candidate;
+      }
+
+      const parentDir = dirname(searchDir);
+
+      if (parentDir === searchDir) {
+        break;
+      }
+
+      searchDir = parentDir;
+    }
+  }
+
+  throw new Error(`Could not resolve package.json for package '${packageName}'.`);
+};
+
+export const resolvePackageBin = (packageName, binName) => {
+  const packageJsonPath = resolvePackageJsonPath(packageName);
+  const packageJson = JSON.parse(readFileSync(packageJsonPath, "utf-8"));
+  const packageDir = dirname(packageJsonPath);
+  const binField = packageJson.bin;
+
+  if (typeof binField === "string") {
+    return join(packageDir, binField);
+  }
+
+  if (binField && typeof binField === "object" && binField[binName]) {
+    return join(packageDir, binField[binName]);
+  }
+
+  throw new Error(`Could not resolve bin '${binName}' for package '${packageName}'.`);
+};
+
+export const runPackageBin = (packageName, binName, args) => {
+  const binPath = resolvePackageBin(packageName, binName);
+  const result = spawnSync(binPath, args, {
+    env: inheritedEnv(),
+    stdio: "inherit",
+  });
+
+  if (result.error) {
+    throw result.error;
+  }
+
+  process.exit(result.status ?? 1);
+};