@howells/husky 0.2.2 → 0.2.5

package/README.md

@@ -18,7 +18,7 @@ In `package.json`:
     "prepare": "howells-husky"
   },
   "lint-staged": {
-    "*.{js,ts,jsx,tsx,json,jsonc,css}": "howells-fix"
+    "*.{js,ts,jsx,tsx,json,jsonc,css,md,mdx}": "howells-oxfmt --write"
   }
 }
 ```
@@ -31,7 +31,20 @@ That's it. On `pnpm install`, the hooks are installed automatically.
 
 ### Pre-commit
 
-Runs `pnpm lint-staged` — formats staged files with the configured Howells formatter. Use `howells-fix`. The older names `howells-ox-fix` and `howells-format` are still accepted (legacy) for projects mid-migration.
+Runs `pnpm lint-staged` — formats staged files with the configured Howells formatter. Use `howells-oxfmt --write`.
+
+**Staging is format-only. Never put `howells-fix` in lint-staged.** Formatting only moves whitespace, so it is safe to apply to a file you are already committing. `howells-fix` also runs `oxlint --fix`, and four rules that ultracite enables at error severity rewrite test assertions under that supposedly safe tier:
+
+| Rule | Rewrites |
+| --- | --- |
+| `vitest/prefer-strict-equal` | `toEqual` → `toStrictEqual` |
+| `vitest/prefer-to-be-truthy` | `toBe(true)` → `toBeTruthy()` |
+| `vitest/prefer-to-be-falsy` | `toBe(false)` → `toBeFalsy()` |
+| `vitest/prefer-describe-function-title` | the string title of a `describe` block |
+
+The first three weaken what the assertion checks: `toBeTruthy()` passes on `1`, `"0"` and `{}`, which `toBe(true)` rejects. Applied on commit, they rewrite tests silently, in files the author already reviewed, and the commit still looks like the diff that was staged. One repository had 121 assertions changed this way before anyone noticed. This is an oxlint defect — `--fix` is documented as the tier that does not change behaviour — but until it is fixed, keep lint out of the commit hook. Pre-push runs the full lint and reports these as findings, which is where they belong.
+
+The older names `howells-ox-fix` and `howells-format` are still accepted (legacy) for projects mid-migration; both format only.
 
 ### Pre-push
 
@@ -63,7 +76,7 @@ Your `package.json` must have:
 - a `"prepush"` script appropriate to the repository, or both:
   - a `"typecheck"` script (e.g. `tsc --noEmit` or `turbo run typecheck`)
   - a `"lint"` script (e.g. `howells-lint` or `turbo run lint`)
-- inline or standard external lint-staged configuration; static inline commands use `howells-fix` (`howells-ox-fix` and `howells-format` remain accepted for projects mid-migration)
+- inline or standard external lint-staged configuration appropriate to the project, running a formatter only
 
 ## Why a package?
 

package/bin/detect.mjs

@@ -5,16 +5,16 @@
  * around behaviour that is unit-testable in isolation.
  */
 
-// `howells-fix` is the current canonical @howells/lint fixer; `howells-ox-fix`
-// and `howells-format` are earlier names still in use by repos mid-migration.
-// Accept all three so a correct lint-staged config never draws a false warning.
-export const lintStagedFormatterCommands = [
-  "howells-fix",
-  "howells-ox-fix",
-  "howells-format",
-];
+// Staging formats and nothing else. `howells-fix` also runs `oxlint --fix`,
+// and four vitest rules that ultracite enables at error severity rewrite test
+// assertions under that tier — `toBe(true)` becomes `toBeTruthy()`, which
+// passes on values the original rejected. Applied on commit that happens
+// silently, inside files the author has already reviewed. Linting belongs in
+// pre-push, where it reports rather than rewrites.
+export const recommendedLintStagedCommand = "howells-oxfmt --write";
 
-export const recommendedLintStagedCommand = "howells-fix";
+export const recommendedLintStagedGlob =
+  "*.{js,ts,jsx,tsx,json,jsonc,css,md,mdx}";
 
 // Standard configuration names supported by lint-staged. Package-level files
 // in a monorepo are discovered by lint-staged itself; the installer only needs
@@ -37,31 +37,6 @@ export function findLintStagedConfigFile(exists) {
   return lintStagedConfigFileNames.find((file) => exists(file));
 }
 
-/**
- * Flatten a lint-staged config object into the list of command strings it runs.
- * Values may be a single command string or an array of them.
- */
-export function lintStagedCommandValues(config) {
-  return Object.values(config).flatMap((value) => {
-    if (typeof value === "string") {
-      return [value];
-    }
-    if (Array.isArray(value)) {
-      return value.filter((item) => typeof item === "string");
-    }
-    return [];
-  });
-}
-
-/**
- * True when a single lint-staged command invokes a supported Howells formatter.
- */
-export function usesSupportedFormatter(command) {
-  return lintStagedFormatterCommands.some((formatter) =>
-    command.includes(formatter)
-  );
-}
-
 /**
  * Decide whether the primary `husky` spawn failed to launch and we should
  * fall back to `npx husky`. A spawn that launched but exited non-zero is not a

package/bin/howells-husky.mjs

@@ -28,10 +28,9 @@ import path from "node:path";
 import {
   fallbackFailed,
   findLintStagedConfigFile,
-  lintStagedCommandValues,
   recommendedLintStagedCommand,
+  recommendedLintStagedGlob,
   shouldUseNpxFallback,
-  usesSupportedFormatter,
 } from "./detect.mjs";
 
 const scriptDir = import.meta.dirname;
@@ -127,26 +126,10 @@ if (existsSync(packageJsonPath)) {
       "[@howells/husky] Warning: no inline or external lint-staged config found."
     );
     console.warn(
-      `  Add: "lint-staged": { "*.{js,ts,jsx,tsx,json,jsonc,css}": "${recommendedLintStagedCommand}" }`
+      `  Add: "lint-staged": { "${recommendedLintStagedGlob}": "${recommendedLintStagedCommand}" }`
     );
   }
 
-  // Inline static configs can be checked directly. External JavaScript configs
-  // may compute commands dynamically, so lint-staged owns their validation.
-  const lsConfig = packageJson["lint-staged"];
-  if (lsConfig) {
-    const commands = lintStagedCommandValues(lsConfig);
-    const usesHowells = commands.some(usesSupportedFormatter);
-    if (!usesHowells) {
-      console.warn(
-        "[@howells/husky] Warning: lint-staged should use a supported Howells formatter."
-      );
-      console.warn(
-        `  Expected: "*.{js,ts,jsx,tsx,json,jsonc,css}": "${recommendedLintStagedCommand}"`
-      );
-    }
-  }
-
   // Projects can own an appropriately scoped pre-push gate. Older projects
   // retain the package's typecheck + lint fallback until they add one.
   const scripts = packageJson.scripts || {};
@@ -162,4 +145,4 @@ if (existsSync(packageJsonPath)) {
   }
 }
 
-console.log("[@howells/husky] Hooks installed.");
+console.error("[@howells/husky] Hooks installed.");

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@howells/husky",
-  "version": "0.2.2",
+  "version": "0.2.5",
   "description": "Standardised git hooks for Howells projects. Immutable pre-commit and pre-push configuration.",
   "license": "MIT",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/commoninstruments/husky.git"
+    "url": "git+https://github.com/howells/husky.git"
   },
   "bin": {
     "howells-husky": "bin/howells-husky.mjs"
@@ -22,11 +22,14 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "husky": "^9.1.7",
-    "lint-staged": "^16.4.0"
+    "husky": "^9.1.7"
   },
   "devDependencies": {
-    "@howells/lint": "^1.1.0"
+    "@howells/lint": "^1.1.0",
+    "lint-staged": "^16.4.0"
+  },
+  "lint-staged": {
+    "*.{js,mjs,cjs,ts,tsx,json,jsonc,css,md}": "howells-oxfmt --write"
   },
   "engines": {
     "node": ">=24.15.0"
@@ -35,6 +38,7 @@
     "lint": "howells-check --config=oxlint.config.ts package.json bin hooks README.md oxlint.config.ts oxfmt.config.ts",
     "lint:fix": "howells-fix --config=oxlint.config.ts package.json bin hooks README.md oxlint.config.ts oxfmt.config.ts",
     "format": "howells-oxfmt --write package.json bin hooks README.md oxlint.config.ts oxfmt.config.ts",
-    "test": "node --test bin/detect.test.mjs bin/pre-push.test.mjs"
+    "test": "node --test bin/detect.test.mjs bin/pre-push.test.mjs",
+    "prepush": "pnpm lint && pnpm test"
   }
 }