@howaboua/pi-subagent-review 0.2.24 → 0.2.25

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,9 @@
1
1
  # @howaboua/pi-subagent-review
2
2
 
3
+ ## 0.2.25
4
+
5
+ - Reviewer prompts now request evidence-backed findings without issue-count targets.
6
+
3
7
  ## 0.2.24
4
8
 
5
9
  - GPT-6 Sol and Luna now share Astra's Codex support.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@howaboua/pi-subagent-review",
3
- "version": "0.2.24",
3
+ "version": "0.2.25",
4
4
  "description": "Pi extension that adds /review via an isolated review subagent.",
5
5
  "type": "module",
6
6
  "main": "index.ts",
@@ -40,7 +40,7 @@
40
40
  ]
41
41
  },
42
42
  "peerDependencies": {
43
- "@howaboua/pi-codex-conversion": ">=3.0.37",
43
+ "@howaboua/pi-codex-conversion": ">=3.0.40",
44
44
  "@earendil-works/pi-ai": ">=0.84.3",
45
45
  "@earendil-works/pi-coding-agent": ">=0.87.0",
46
46
  "@earendil-works/pi-tui": ">=0.84.3"
@@ -59,9 +59,9 @@
59
59
  "format": "biome check --write ."
60
60
  },
61
61
  "devDependencies": {
62
- "@howaboua/pi-codex-conversion": "3.0.37",
63
- "@earendil-works/pi-ai": "0.87.0",
64
- "@earendil-works/pi-coding-agent": "0.87.0",
62
+ "@howaboua/pi-codex-conversion": "3.0.40",
63
+ "@earendil-works/pi-ai": "0.99.1",
64
+ "@earendil-works/pi-coding-agent": "0.99.1",
65
65
  "@types/node": "^26.2.0",
66
66
  "typescript": "^7.0.2",
67
67
  "@biomejs/biome": "^2.5.10"
package/review.prompt.md CHANGED
@@ -1,24 +1,19 @@
1
- You are the Review Subagent, an isolated code-review specialist.
1
+ You are the Review Subagent, a code-review specialist.
2
2
 
3
3
  Rules:
4
4
  - Stay strictly in review mode.
5
5
  - You do not inherit the parent agent's prior conversation, plan, or hidden context. Treat the provided task as the entire brief.
6
- - Do not edit files.
6
+ - Do not edit files or propose implementation plans beyond concise fixes.
7
7
  - You are the subagent: do not spawn other subagents; perform the reviewer duties yourself.
8
8
  - Use the selected VCS commands from the task, targeted file reads, and concrete evidence over assumptions.
9
- - Focus on actionable findings, not broad summaries.
9
+ - Review the full requested scope; report only concrete, actionable findings, including lower-severity issues.
10
10
  - Prioritize correctness, regressions, security, data loss, performance, concurrency, and missing tests.
11
- - Be slightly lenient: include lower-severity but still concrete, actionable issues when they are supported by evidence.
12
- - Do not stop after finding only one or two issues; keep looking for additional credible findings.
13
- - Aim to surface roughly 10-20 issues if the diff supports that many, but never pad or invent findings.
14
11
  - Reference specific file paths and line ranges when possible.
15
12
  - Suggest the smallest credible fix when helpful.
16
- - If there are no actionable issues worth flagging, say that clearly.
17
13
 
18
14
  Output format:
19
15
  # Review Findings
20
16
  - `[high|medium|low] path/to/file:start-end` - issue, why it matters, and the concrete fix
21
- - ...continue with as many issue bullets as are warranted by the evidence
22
17
 
23
18
  If there are no actionable issues, output exactly:
24
19
 
@@ -70,9 +70,7 @@ export function buildReviewTask(
70
70
  "Required inspection steps:",
71
71
  `1. Run \`git diff --stat ${review.mergeBase}\``,
72
72
  `2. Run \`git diff ${review.mergeBase}\``,
73
- `3. Run \`git diff --stat ${review.baseBranch}...HEAD\``,
74
- `4. Run \`git diff ${review.baseBranch}...HEAD\``,
75
- "5. Use targeted file diffs or reads where needed.",
73
+ "3. Use targeted file diffs or reads where needed.",
76
74
  );
77
75
  } else {
78
76
  sections.push(
@@ -86,27 +84,13 @@ export function buildReviewTask(
86
84
  );
87
85
  }
88
86
 
89
- if (review.status) {
87
+ if (review.status && review.baseBranch && review.mergeBase) {
90
88
  sections.push(
91
89
  "",
92
- "Because the worktree is not clean, also inspect:",
93
- "- `git diff --cached`",
94
- "- `git diff`",
95
- "- any relevant untracked files reported by status",
90
+ "Inspect relevant untracked files reported by status. Use staged or unstaged diffs only to answer questions not covered by the checkout comparison.",
96
91
  );
97
92
  }
98
93
 
99
- sections.push(
100
- "",
101
- "Return prioritized, actionable findings only.",
102
- "Be slightly lenient: include lower-severity but still concrete, actionable issues when supported by evidence.",
103
- "Do not stop after finding only one or two issues; keep looking for additional credible findings.",
104
- "Aim for roughly 10-20 issues if the diff supports that many, but do not pad or invent findings.",
105
- "Focus on correctness, regressions, security, data loss, performance, concurrency, and missing tests.",
106
- "Reference specific files and line ranges when possible.",
107
- "If there are no actionable issues worth flagging, say that clearly.",
108
- );
109
-
110
94
  if (extraFocus.trim()) {
111
95
  sections.push("", `Additional user focus: ${extraFocus.trim()}`);
112
96
  }
package/src/subagent.ts CHANGED
@@ -44,13 +44,6 @@ export async function runReviewSubagent(
44
44
  REVIEW_PROMPT_PATH,
45
45
  ],
46
46
  });
47
- const prompt = [
48
- "Run as the Review Subagent inside an isolated no-session RPC subprocess.",
49
- "Stay strictly in review mode. Do not edit files or propose implementation plans beyond concise fixes.",
50
- "Do not stop after one or two findings; keep looking for additional credible issues, aiming for roughly 10-20 if warranted.",
51
- "Mode: review",
52
- `Task: ${task}`,
53
- ].join("\n\n");
54
47
  const abort = () => {
55
48
  void client.abort().catch(() => undefined);
56
49
  };
@@ -64,7 +57,7 @@ export async function runReviewSubagent(
64
57
  await client.setAutoRetry(true);
65
58
  if (signal?.aborted) throw new Error(`${REVIEW_LABEL} aborted.`);
66
59
  const events = await client.promptAndWait(
67
- prompt,
60
+ `Task: ${task}`,
68
61
  undefined,
69
62
  REVIEW_TIMEOUT_MS,
70
63
  );