@howaboua/pi-ask 0.0.7 → 0.0.8

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @howaboua/pi-ask
 
+## 0.0.8
+
+- Shepherdr now discovers and answers waiting questions invoked inside Code and Notebook Mode.
+
 ## 0.0.7
 
 - The `ask` tool now supports steering questions that return immediately, preserve the full response panel, and deliver answers at the next safe boundary using the developer role under active Pi Codex Responses.

package/ask/coordinator.ts

@@ -17,6 +17,7 @@ export interface AskCoordinatorOptions {
 }
 
 interface PresentAskOptions {
+	onActiveChange?: (active: boolean) => void;
 	handoff?: boolean;
 	steering?: boolean;
 	signal?: AbortSignal;
@@ -42,23 +43,33 @@ export function createAskCoordinator({
 	const present = (
 		ctx: ExtensionContext,
 		prompts: AskPrompt[],
-		{ handoff = false, steering = false, signal }: PresentAskOptions = {},
+		{
+			handoff = false,
+			steering = false,
+			signal,
+			onActiveChange,
+		}: PresentAskOptions = {},
 	): Promise<unknown> => {
 		const run = async () => {
 			if (signal?.aborted) return null;
-			return askInComposer
-				? await askInComposer(prompts, signal)
-				: ctx.mode === "tui"
-					? await askInTui(ctx, prompts, {
-							handoff,
-							steering,
-							...(signal ? { signal } : {}),
-						})
-					: await askWithPiUi(ctx, prompts, {
-							handoff,
-							steering,
-							...(signal ? { signal } : {}),
-						});
+			try {
+				onActiveChange?.(true);
+				return askInComposer
+					? await askInComposer(prompts, signal)
+					: ctx.mode === "tui"
+						? await askInTui(ctx, prompts, {
+								handoff,
+								steering,
+								...(signal ? { signal } : {}),
+							})
+						: await askWithPiUi(ctx, prompts, {
+								handoff,
+								steering,
+								...(signal ? { signal } : {}),
+							});
+			} finally {
+				onActiveChange?.(false);
+			}
 		};
 		const result = presentationTail.then(run, run);
 		presentationTail = result.then(

package/ask/tool.ts

@@ -1,6 +1,6 @@
 import { defineTool } from "@earendil-works/pi-coding-agent";
 import { Text } from "@earendil-works/pi-tui";
-import { AskParameters } from "./contracts.js";
+import { AskParameters, type AskPrompt } from "./contracts.js";
 import {
 	type AskCoordinatorOptions,
 	createAskCoordinator,
@@ -18,6 +18,8 @@ interface BlockedState {
 	active: boolean;
 	label: string;
 	prompt: string;
+	handoff: boolean;
+	prompts: AskPrompt[];
 }
 
 type OnBlockedChange = (state: BlockedState) => void;
@@ -79,24 +81,22 @@ export function createAskRuntime({
 			const blockedState = {
 				id: toolCallId,
 				active: true,
+				handoff,
+				prompts,
 				label: handoff ? "Human action needed" : "Waiting for input",
 				prompt: handoff
 					? "The user needs to complete an action before the active work can continue. Please announce this briefly in your natural voice."
 					: "User input is required before the active work can continue. Please announce this briefly in your natural voice.",
 			};
-			onBlockedChange?.(blockedState);
-			let rawResponses: unknown;
-			try {
-				const presentationSignal = signal
-					? AbortSignal.any([signal, coordinator.sessionSignal])
-					: coordinator.sessionSignal;
-				rawResponses = await coordinator.present(ctx, prompts, {
-					handoff,
-					signal: presentationSignal,
-				});
-			} finally {
-				onBlockedChange?.({ ...blockedState, active: false });
-			}
+			const presentationSignal = signal
+				? AbortSignal.any([signal, coordinator.sessionSignal])
+				: coordinator.sessionSignal;
+			const rawResponses = await coordinator.present(ctx, prompts, {
+				handoff,
+				signal: presentationSignal,
+				onActiveChange: (active) =>
+					onBlockedChange?.({ ...blockedState, active }),
+			});
 			const responses = normalizeResponses(prompts, rawResponses);
 			if (!responses) {
 				return {

package/index.ts

@@ -29,15 +29,35 @@ export default async function humanInTheLoop(pi: ExtensionAPI): Promise<void> {
 	const askRuntime = createAskRuntime({
 		deliverSteer: createSteerDelivery(pi, trySendCodexDeveloperMessage),
 		onBlockedChange: (state) => {
-			pi.events.emit(REALTIME_VOICE_PROMPT_CHANNEL, {
-				id: state.id,
-				active: state.active,
-				prompt: state.prompt,
-			});
-			pi.events.emit("herdr:blocked", {
-				active: state.active,
-				label: state.label,
-			});
+			const notify = () => {
+				pi.events.emit(REALTIME_VOICE_PROMPT_CHANNEL, {
+					id: state.id,
+					active: state.active,
+					prompt: state.prompt,
+				});
+				pi.events.emit("herdr:blocked", {
+					active: state.active,
+					label: state.label,
+				});
+			};
+			// Publish before Herdr reports blocked, including calls nested inside exec.
+			try {
+				pi.appendEntry(
+					"pi-ask-active",
+					state.active
+						? {
+								version: 1,
+								state: "active",
+								id: state.id,
+								handoff: state.handoff,
+								prompts: state.prompts,
+							}
+						: { version: 1, state: "closed", id: state.id },
+				);
+			} finally {
+				if (!state.active) notify();
+			}
+			if (state.active) notify();
 		},
 		onPendingChange: (update) => {
 			pi.appendEntry(PENDING_ASK_ENTRY_TYPE, update);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@howaboua/pi-ask",
-	"version": "0.0.7",
+	"version": "0.0.8",
 	"description": "Interactive decisions, review triage, and human handoffs for Pi.",
 	"type": "module",
 	"license": "MIT",
@@ -45,7 +45,7 @@
 		]
 	},
 	"peerDependencies": {
-		"@howaboua/pi-codex-conversion": ">=3.0.26",
+		"@howaboua/pi-codex-conversion": ">=3.0.30",
 		"@earendil-works/pi-ai": ">=0.84.3",
 		"@earendil-works/pi-coding-agent": ">=0.84.3",
 		"@earendil-works/pi-tui": ">=0.84.3",
@@ -57,11 +57,11 @@
 		}
 	},
 	"devDependencies": {
-		"@howaboua/pi-codex-conversion": "3.0.26",
+		"@howaboua/pi-codex-conversion": "3.0.30",
 		"@biomejs/biome": "^2.5.10",
-		"@earendil-works/pi-ai": "0.85.0",
-		"@earendil-works/pi-coding-agent": "0.85.0",
-		"@earendil-works/pi-tui": "0.85.0",
+		"@earendil-works/pi-ai": "0.85.1",
+		"@earendil-works/pi-coding-agent": "0.85.1",
+		"@earendil-works/pi-tui": "0.85.1",
 		"typebox": "1.3.18",
 		"typescript": "^7.0.2"
 	},