@howaboua/pi-ask 0.0.10 → 0.0.11

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @howaboua/pi-ask
 
+## 0.0.11
+
+- Parents can receive and answer asynchronous questions through Shepherdr while workers continue.
+
 ## 0.0.10
 
 - Requires Pi 1.0.0 or later.

package/ask/coordinator.ts

@@ -1,5 +1,5 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import type { AskPrompt, PendingAsk } from "./contracts.js";
+import type { AskPrompt, AskResponse, PendingAsk } from "./contracts.js";
 import { normalizeResponses, summarizeResponses } from "./normalize.js";
 import type { PendingAskUpdate } from "./pending.js";
 import { askWithPiUi } from "./pi-ui.js";
@@ -14,6 +14,7 @@ export interface AskCoordinatorOptions {
 	askInComposer?: AskInComposer;
 	deliverSteer?: (message: string) => void;
 	onPendingChange?: (update: PendingAskUpdate) => void;
+	onSteerActiveChange?: (request: PendingAsk, active: boolean) => void;
 }
 
 interface PresentAskOptions {
@@ -34,11 +35,13 @@ export function createAskCoordinator({
 	askInComposer,
 	deliverSteer,
 	onPendingChange,
+	onSteerActiveChange,
 }: AskCoordinatorOptions = {}) {
 	let generation = 0;
 	let sessionAbort = new AbortController();
 	let presentationTail = Promise.resolve();
 	const activeSteers = new Set<string>();
+	let presentedSteer: PendingAsk | undefined;
 
 	const present = (
 		ctx: ExtensionContext,
@@ -95,10 +98,19 @@ export function createAskCoordinator({
 		}
 	};
 
-	const close = (ctx: ExtensionContext, id: string) => {
+	const close = (
+		ctx: ExtensionContext,
+		id: string,
+		responses?: AskResponse[],
+	) => {
 		activeSteers.delete(id);
 		try {
-			onPendingChange?.({ version: 1, state: "closed", id });
+			onPendingChange?.({
+				version: 1,
+				state: "closed",
+				id,
+				...(responses ? { responses } : { dismissed: true }),
+			});
 		} catch (error) {
 			notifyFailure(ctx, error);
 		}
@@ -123,12 +135,22 @@ export function createAskCoordinator({
 		void present(ctx, request.prompts, {
 			steering: true,
 			signal: sessionAbort.signal,
+			onActiveChange: (active) => {
+				if (requestGeneration === generation && !sessionAbort.signal.aborted) {
+					presentedSteer = active ? request : undefined;
+					onSteerActiveChange?.(request, active);
+				}
+			},
 		}).then(
 			(responses) => {
 				if (requestGeneration !== generation || sessionAbort.signal.aborted)
 					return;
 				if (deliver(ctx, steerResponse(request.prompts, responses)))
-					close(ctx, request.id);
+					close(
+						ctx,
+						request.id,
+						normalizeResponses(request.prompts, responses) ?? undefined,
+					);
 			},
 			(error: unknown) => {
 				if (requestGeneration !== generation || sessionAbort.signal.aborted)
@@ -153,6 +175,7 @@ export function createAskCoordinator({
 		},
 		restorePending(pending: readonly PendingAsk[], ctx: ExtensionContext) {
 			generation++;
+			presentedSteer = undefined;
 			sessionAbort.abort();
 			sessionAbort = new AbortController();
 			presentationTail = Promise.resolve();
@@ -161,9 +184,14 @@ export function createAskCoordinator({
 			for (const request of pending) startSteer(request, ctx, false);
 		},
 		shutdown() {
-			generation++;
-			sessionAbort.abort();
-			activeSteers.clear();
+			try {
+				if (presentedSteer) onSteerActiveChange?.(presentedSteer, false);
+			} finally {
+				presentedSteer = undefined;
+				generation++;
+				sessionAbort.abort();
+				activeSteers.clear();
+			}
 		},
 		get sessionSignal(): AbortSignal {
 			return sessionAbort.signal;

package/ask/pending.ts

@@ -1,12 +1,18 @@
 import type { SessionEntry } from "@earendil-works/pi-coding-agent";
-import type { AskPrompt, PendingAsk } from "./contracts.js";
+import type { AskPrompt, AskResponse, PendingAsk } from "./contracts.js";
 import { normalizeAskInput } from "./normalize.js";
 
 export const PENDING_ASK_ENTRY_TYPE = "pi-ask-pending";
 
 export type PendingAskUpdate =
 	| { version: 1; state: "pending"; id: string; prompts: AskPrompt[] }
-	| { version: 1; state: "closed"; id: string };
+	| {
+			version: 1;
+			state: "closed";
+			id: string;
+			responses?: AskResponse[];
+			dismissed?: boolean;
+	  };
 
 function isRecord(value: unknown): value is Record<string, unknown> {
 	return typeof value === "object" && value !== null;

package/ask/tool.ts

@@ -33,11 +33,13 @@ export function createAskRuntime({
 	deliverSteer,
 	onBlockedChange,
 	onPendingChange,
+	onSteerActiveChange,
 }: AskToolOptions = {}) {
 	const coordinator = createAskCoordinator({
 		...(askInComposer ? { askInComposer } : {}),
 		...(deliverSteer ? { deliverSteer } : {}),
 		...(onPendingChange ? { onPendingChange } : {}),
+		...(onSteerActiveChange ? { onSteerActiveChange } : {}),
 	});
 
 	const tool = defineTool({
@@ -70,7 +72,7 @@ export function createAskRuntime({
 				return {
 					content: [
 						textContent(
-							"Question presented. Continue working; the response will arrive as steering.",
+							"Question queued. Continue working; the response will arrive as steering.",
 						),
 					],
 					details: { kind: "prompt", pending: true, id: toolCallId },

package/index.ts

@@ -62,6 +62,20 @@ export default async function humanInTheLoop(pi: ExtensionAPI): Promise<void> {
 		onPendingChange: (update) => {
 			pi.appendEntry(PENDING_ASK_ENTRY_TYPE, update);
 		},
+		onSteerActiveChange: (request, active) => {
+			pi.appendEntry(
+				"pi-ask-active",
+				active
+					? {
+							version: 1,
+							state: "active",
+							id: request.id,
+							delivery: "steer",
+							prompts: request.prompts,
+						}
+					: { version: 1, state: "closed", id: request.id },
+			);
+		},
 	});
 	const ask = askRuntime.tool;
 	const restorePending = (ctx: ExtensionContext) => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@howaboua/pi-ask",
-	"version": "0.0.10",
+	"version": "0.0.11",
 	"description": "Interactive decisions, review triage, and human handoffs for Pi.",
 	"type": "module",
 	"license": "MIT",
@@ -45,7 +45,7 @@
 		]
 	},
 	"peerDependencies": {
-		"@howaboua/pi-codex-conversion": ">=3.0.43",
+		"@howaboua/pi-codex-conversion": ">=3.0.46",
 		"@earendil-works/pi-ai": ">=1.0.0",
 		"@earendil-works/pi-coding-agent": ">=1.0.0",
 		"@earendil-works/pi-tui": ">=1.0.0",
@@ -57,11 +57,11 @@
 		}
 	},
 	"devDependencies": {
-		"@howaboua/pi-codex-conversion": "3.0.43",
+		"@howaboua/pi-codex-conversion": "3.0.46",
 		"@biomejs/biome": "^2.5.10",
-		"@earendil-works/pi-ai": "1.0.0",
-		"@earendil-works/pi-coding-agent": "1.0.0",
-		"@earendil-works/pi-tui": "1.0.0",
+		"@earendil-works/pi-ai": "1.0.4",
+		"@earendil-works/pi-coding-agent": "1.0.4",
+		"@earendil-works/pi-tui": "1.0.4",
 		"typebox": "1.3.18",
 		"typescript": "^7.0.2"
 	},