@hover-dev/core 0.2.0 → 0.2.1

package/dist/playwright/cdpStatus.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cdpStatus.d.ts","sourceRoot":"","sources":["../../src/playwright/cdpStatus.ts"],"names":[],"mappings":"AAgBA,MAAM,MAAM,QAAQ,GAAG,aAAa,GAAG,cAAc,GAAG,QAAQ,CAAC;AAEjE,MAAM,WAAW,eAAe;IAC9B,KAAK,EAAE,QAAQ,CAAC;IAChB,yCAAyC;IACzC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,8EAA8E;IAC9E,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,yEAAyE;IACzE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,qDAAqD;IACrD,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAeD,wBAAsB,cAAc,CAClC,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,GACd,OAAO,CAAC,eAAe,CAAC,CA4B1B;AAED;;;;;;;GAOG;AACH,wBAAsB,aAAa,CACjC,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,GACd,OAAO,CAAC;IAAE,EAAE,EAAE,IAAI,CAAC;IAAC,UAAU,EAAE,MAAM,CAAA;CAAE,GAAG;IAAE,EAAE,EAAE,KAAK,CAAC;IAAC,MAAM,EAAE,MAAM,CAAA;CAAE,CAAC,CAiC3E"}
+{"version":3,"file":"cdpStatus.d.ts","sourceRoot":"","sources":["../../src/playwright/cdpStatus.ts"],"names":[],"mappings":"AAiBA,MAAM,MAAM,QAAQ,GAAG,aAAa,GAAG,cAAc,GAAG,QAAQ,CAAC;AAEjE,MAAM,WAAW,eAAe;IAC9B,KAAK,EAAE,QAAQ,CAAC;IAChB,yCAAyC;IACzC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,8EAA8E;IAC9E,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,yEAAyE;IACzE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,qDAAqD;IACrD,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAeD,wBAAsB,cAAc,CAClC,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,GACd,OAAO,CAAC,eAAe,CAAC,CA4B1B;AAED;;;;;;;GAOG;AACH,wBAAsB,aAAa,CACjC,MAAM,EAAE,MAAM,EACd,OAAO,EAAE,MAAM,GACd,OAAO,CAAC;IAAE,EAAE,EAAE,IAAI,CAAC;IAAC,UAAU,EAAE,MAAM,CAAA;CAAE,GAAG;IAAE,EAAE,EAAE,KAAK,CAAC;IAAC,MAAM,EAAE,MAAM,CAAA;CAAE,CAAC,CA8C3E"}

package/dist/playwright/cdpStatus.js

@@ -13,6 +13,7 @@
  */
 import { chromium } from 'playwright-core';
 import { preflightCDP } from './preflight.js';
+import { findCdpPid, raiseChromeWindow } from './raiseWindow.js';
 /**
  * Parse a page URL down to its origin (protocol + host + port). We compare
  * by origin, not full URL — the user might be on /login while the debug
@@ -72,25 +73,47 @@ export async function focusDebugTab(cdpUrl, pageUrl) {
         const msg = err instanceof Error ? err.message : String(err);
         return { ok: false, reason: `couldn't connect to CDP at ${cdpUrl}: ${msg}` };
     }
+    let focusedUrl;
     try {
         const pages = browser.contexts().flatMap(c => c.pages());
         const match = pages.find(p => originOf(p.url()) === wantOrigin);
         if (match) {
             await match.bringToFront();
-            return { ok: true, focusedUrl: match.url() };
+            focusedUrl = match.url();
+        }
+        else {
+            // No tab on the dev origin yet — open one so the widget appears.
+            const context = browser.contexts()[0] ?? (await browser.newContext());
+            const page = await context.newPage();
+            await page.goto(pageUrl, { waitUntil: 'domcontentloaded' });
+            await page.bringToFront();
+            focusedUrl = page.url();
         }
-        // No tab on the dev origin yet — open one so the widget appears.
-        const context = browser.contexts()[0] ?? (await browser.newContext());
-        const page = await context.newPage();
-        await page.goto(pageUrl, { waitUntil: 'domcontentloaded' });
-        await page.bringToFront();
-        return { ok: true, focusedUrl: page.url() };
     }
     catch (err) {
+        await browser.close().catch(() => { });
         const msg = err instanceof Error ? err.message : String(err);
         return { ok: false, reason: `bringToFront failed: ${msg}` };
     }
-    finally {
-        await browser.close().catch(() => { });
+    await browser.close().catch(() => { });
+    // CDP-level bringToFront only activates the tab inside the Chrome process;
+    // on macOS in particular the Chrome *window* stays buried if it wasn't
+    // foreground already. Raise the OS window too. Best-effort, never fatal.
+    const port = portFromCdpUrl(cdpUrl);
+    if (port !== null) {
+        const pid = await findCdpPid(port);
+        if (pid !== null)
+            await raiseChromeWindow(pid);
+    }
+    return { ok: true, focusedUrl };
+}
+function portFromCdpUrl(cdpUrl) {
+    try {
+        const u = new URL(cdpUrl);
+        const port = Number.parseInt(u.port, 10);
+        return Number.isInteger(port) && port > 0 ? port : null;
+    }
+    catch {
+        return null;
     }
 }

package/dist/playwright/raiseWindow.d.ts

@@ -0,0 +1,10 @@
+/**
+ * Find the OS PID of the process listening on the given TCP port.
+ * Returns null if nothing is listening or the lookup tool isn't available.
+ */
+export declare function findCdpPid(port: number): Promise<number | null>;
+/**
+ * Raise the Chrome window owned by `pid` to the OS foreground. Best-effort.
+ */
+export declare function raiseChromeWindow(pid: number): Promise<void>;
+//# sourceMappingURL=raiseWindow.d.ts.map

package/dist/playwright/raiseWindow.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"raiseWindow.d.ts","sourceRoot":"","sources":["../../src/playwright/raiseWindow.ts"],"names":[],"mappings":"AAyBA;;;GAGG;AACH,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,CA8BrE;AAED;;GAEG;AACH,wBAAsB,iBAAiB,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAwClE"}

package/dist/playwright/raiseWindow.js

@@ -0,0 +1,124 @@
+/**
+ * Raise the OS-level Chrome window to the foreground.
+ *
+ * Why this exists: CDP's `Page.bringToFront()` and `Target.activateTarget`
+ * only reorder tabs *inside* the Chrome process — they do not raise the
+ * Chrome application window in the OS's window stack. When the user clicks
+ * "Switch me to it" from a widget hosted in a different window, the tab
+ * activates correctly inside the (possibly background) debug Chrome, but
+ * the window stays buried. The user then has to manually click the Chrome
+ * Dock icon / Alt-Tab to it, which defeats the point of the button.
+ *
+ * Fix: after `bringToFront()`, run an OS-specific command that raises the
+ * specific Chrome *process* (matched by PID, found from the CDP port via
+ * `lsof` / `netstat`). PID-matching is critical — the user's own primary
+ * Chrome and Hover's debug Chrome are both "Google Chrome" to AppleScript,
+ * so raising by app name would risk activating the wrong window.
+ *
+ * Best-effort and non-blocking — if the helper fails, we still leave the
+ * tab correctly focused inside the debug Chrome and the user can click
+ * over manually like before. Logging is to stderr only; this never throws
+ * back to the caller.
+ */
+import { spawn } from 'node:child_process';
+import { platform } from 'node:os';
+/**
+ * Find the OS PID of the process listening on the given TCP port.
+ * Returns null if nothing is listening or the lookup tool isn't available.
+ */
+export async function findCdpPid(port) {
+    const os = platform();
+    if (os === 'darwin' || os === 'linux') {
+        // -t prints just PIDs, -sTCP:LISTEN filters to listeners (otherwise
+        // every client connection's PID would show up too).
+        const out = await runCapture('lsof', ['-tiTCP:' + port, '-sTCP:LISTEN']);
+        if (!out)
+            return null;
+        // lsof may print multiple lines if forked workers also hold the port;
+        // take the first numeric one.
+        for (const line of out.split('\n')) {
+            const pid = Number.parseInt(line.trim(), 10);
+            if (Number.isInteger(pid) && pid > 0)
+                return pid;
+        }
+        return null;
+    }
+    if (os === 'win32') {
+        // `netstat -ano` columns: Proto Local Foreign State PID
+        const out = await runCapture('netstat', ['-ano']);
+        if (!out)
+            return null;
+        for (const line of out.split('\n')) {
+            // Match `TCP    127.0.0.1:9222    0.0.0.0:0    LISTENING    1234`
+            const m = line.match(/^\s*TCP\s+\S+:(\d+)\s+\S+\s+LISTENING\s+(\d+)\s*$/i);
+            if (m && Number(m[1]) === port)
+                return Number(m[2]);
+        }
+        return null;
+    }
+    return null;
+}
+/**
+ * Raise the Chrome window owned by `pid` to the OS foreground. Best-effort.
+ */
+export async function raiseChromeWindow(pid) {
+    const os = platform();
+    try {
+        if (os === 'darwin') {
+            // System Events can frontmost any process by its unix PID, regardless
+            // of app bundle. This works even when several "Google Chrome"
+            // processes coexist (user's primary + Hover's debug).
+            await runDetached('osascript', [
+                '-e',
+                `tell application "System Events" to set frontmost of (first process whose unix id is ${pid}) to true`,
+            ]);
+            return;
+        }
+        if (os === 'linux') {
+            // wmctrl is the most common helper for X11; not always installed,
+            // but the alternative (xdotool) needs the same dependency story.
+            // We try wmctrl with the PID match; if it isn't installed the
+            // outer try/catch swallows the ENOENT and we degrade gracefully.
+            await runDetached('wmctrl', ['-ia', String(pid)]);
+            return;
+        }
+        if (os === 'win32') {
+            // PowerShell is bundled with Windows 10+. AppActivate is best-effort:
+            // it requires the target to have a visible main window, which a
+            // headless-less Chrome with a tab open satisfies.
+            const ps = `$p = Get-Process -Id ${pid} -ErrorAction SilentlyContinue; ` +
+                `if ($p) { ` +
+                `  Add-Type -AssemblyName Microsoft.VisualBasic; ` +
+                `  [Microsoft.VisualBasic.Interaction]::AppActivate($p.Id) ` +
+                `}`;
+            await runDetached('powershell', ['-NoProfile', '-Command', ps]);
+            return;
+        }
+    }
+    catch {
+        // Best-effort. CDP-level bringToFront already ran; user can still
+        // click the Chrome window manually.
+    }
+}
+function runCapture(cmd, args) {
+    return new Promise(resolve => {
+        let out = '';
+        const child = spawn(cmd, args, { stdio: ['ignore', 'pipe', 'ignore'] });
+        child.stdout.on('data', chunk => {
+            out += chunk.toString();
+        });
+        child.on('error', () => resolve(null));
+        child.on('close', code => resolve(code === 0 ? out : null));
+    });
+}
+function runDetached(cmd, args) {
+    return new Promise((resolve, reject) => {
+        const child = spawn(cmd, args, { stdio: 'ignore' });
+        child.on('error', reject);
+        child.on('close', code => {
+            // Don't treat non-zero as fatal — caller already wraps in try/catch.
+            resolve();
+            void code;
+        });
+    });
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hover-dev/core",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Hover's local Node service: agent invocation, Playwright CDP preflight, WebSocket bridge.",
   "license": "Apache-2.0",
   "author": "Hyperyond",