@houwert/conductor 0.33.1 → 0.33.2

package/dist/commands/screenshot.js

@@ -4,6 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.HELP = void 0;
+exports.captureScreen = captureScreen;
 exports.screenshot = screenshot;
 exports.HELP = `  take-screenshot [<element>] [--output <path>] [--full-page] [--display <panel>]
                                        Take screenshot (--full-page: web only, capture entire scrollable page)
@@ -39,8 +40,8 @@ const roku_js_1 = require("../drivers/roku.js");
 const wait_js_1 = require("../drivers/wait.js");
 const direct_ios_selector_js_1 = require("../drivers/direct-ios-selector.js");
 const png_crop_js_1 = require("../png-crop.js");
-const DEFAULT_MARGIN_PX = 8;
 const exec = (0, util_1.promisify)(child_process_1.execFile);
+const DEFAULT_MARGIN_PX = 8;
 /**
  * Grab the screen, pointing at the right panel on a multi-display device.
  *
@@ -50,15 +51,23 @@ const exec = (0, util_1.promisify)(child_process_1.execFile);
  * the live one through simctl instead. Ordinary devices keep the driver path.
  */
 async function captureScreen(driver, opts, displayOverride) {
-    const deviceId = driver instanceof ios_js_1.IOSDriver ? driver.deviceId : undefined;
-    if (!deviceId || (!displayOverride && !(driver instanceof ios_js_1.IOSDriver))) {
-        return await driver.screenshot(opts);
+    if (!(driver instanceof ios_js_1.IOSDriver)) {
+        if (displayOverride) {
+            throw new Error('--display is iOS-only; other platforms expose a single screen');
+        }
+        return { buffer: await driver.screenshot(opts), redirected: false };
+    }
+    const deviceId = driver.deviceId;
+    if (!deviceId) {
+        if (displayOverride)
+            throw new Error('--display needs a device to query for its displays');
+        return { buffer: await driver.screenshot(opts), redirected: false };
     }
     const displays = await (0, devicectl_js_1.listDisplays)(deviceId).catch(() => []);
     if (!displays.length) {
         if (displayOverride)
             throw new Error("could not read this device's displays");
-        return await driver.screenshot(opts);
+        return { buffer: await driver.screenshot(opts), redirected: false };
     }
     const choice = (0, ios_displays_js_1.pickCaptureDisplay)(displays, displayOverride);
     if (choice.error)
@@ -66,7 +75,7 @@ async function captureScreen(driver, opts, displayOverride) {
     const primary = displays.find((d) => d.primary);
     // Nothing to redirect: the driver already captures the primary panel.
     if (choice.displayId === null || (primary && choice.displayId === primary.displayId)) {
-        return await driver.screenshot(opts);
+        return { buffer: await driver.screenshot(opts), redirected: false };
     }
     const file = path_1.default.join(os_1.default.tmpdir(), `conductor-shot-${Date.now()}.png`);
     try {
@@ -79,7 +88,10 @@ async function captureScreen(driver, opts, displayOverride) {
             String(choice.displayId),
             file,
         ]);
-        return await promises_1.default.readFile(file);
+        return { buffer: await promises_1.default.readFile(file), redirected: true };
+    }
+    catch (err) {
+        throw new Error(`could not capture display ${choice.displayId}: ${err instanceof Error ? err.message : String(err)}`);
     }
     finally {
         await promises_1.default.unlink(file).catch(() => { });
@@ -115,8 +127,13 @@ async function screenshot(outputPath, opts = {}, sessionName = 'default', fullPa
                 : '';
     const margin = flags.margin ?? DEFAULT_MARGIN_PX;
     const result = await (0, runner_js_1.runDirect)(async (driver) => {
-        const buf = await captureScreen(driver, { fullPage }, flags.display);
+        const { buffer: buf, redirected } = await captureScreen(driver, { fullPage }, flags.display);
         let out = buf;
+        if (sel && redirected) {
+            throw new Error('cropping to an element is not supported on this display yet — the panel is ' +
+                'rotated relative to the accessibility coordinate space. Re-run with ' +
+                '--display cover, or fold the device, to crop against the main panel.');
+        }
         if (sel) {
             let el;
             let hierarchyW;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@houwert/conductor",
-  "version": "0.33.1",
+  "version": "0.33.2",
   "description": "CLI tool for mobile app interactions — optimized for AI agents",
   "license": "MIT",
   "repository": {

package/skills/conductor-device-setup/SKILL.md

@@ -45,6 +45,11 @@ Pass `--display cover` or `--display inner` to pin it to one panel, or a display
 id for anything else the device has attached (CarPlay, an external screen). An
 unknown value lists that device's displays with their ids.
 
+Cropping a screenshot to an element (`take-screenshot <element>`) only works
+against the main panel: the inner panel's framebuffer is rotated relative to the
+accessibility coordinate space, so conductor refuses the crop there instead of
+returning the wrong region. Fold the device or pass `--display cover` to crop.
+
 Angles are in degrees, 0 (shut) to 180 (flat). `closed`/`book`/`open` map to
 0/130/180. Named poses always swap the display; an arbitrary mid-way angle sets
 the hinge but may leave the cover display active, because the system decides