@hot-updater/react-native 1.0.0-rc.15 → 1.0.0-rc.17

package/src/notifyAppReadyInsights.boundary.spec.ts

@@ -1,242 +0,0 @@
-import { beforeEach, describe, expect, it, vi } from "vitest";
-
-import type {
-  ActiveUpdateState,
-  NotifyAppReadyInsightsEvent,
-  NotifyAppReadyResult,
-} from "./native";
-import {
-  createNotifyReadResult,
-  stubNotifyFrame,
-} from "./notifyAppReadyInsights.test-utils";
-
-const platformState = vi.hoisted((): { OS: "ios" | "android" } => ({
-  OS: "ios",
-}));
-
-vi.mock("react-native", () => ({
-  NativeEventEmitter: class {},
-  Platform: platformState,
-}));
-
-const nativePersistence = vi.hoisted(() => {
-  let persistedInstallId = "install-persisted";
-
-  return {
-    getConstants: vi.fn(() => ({
-      APP_VERSION: "1.0.0",
-      CHANNEL: "production",
-      DEFAULT_CHANNEL: "production",
-      FINGERPRINT_HASH: null,
-      MIN_BUNDLE_ID: "min-bundle-id",
-    })),
-    getInstallId: vi.fn(() => persistedInstallId),
-    setPersistedInstallId: (installId: string) => {
-      persistedInstallId = installId;
-    },
-  };
-});
-
-const mocks = vi.hoisted(() => ({
-  addListener: vi.fn(() => () => {}),
-  checkForUpdate: vi.fn(),
-  getAppVersion: vi.fn<() => string | undefined>(() => "1.0.0"),
-  getBundleId: vi.fn<() => string | undefined>(() => "bundle-id"),
-  getChannel: vi.fn(() => "production"),
-  getActiveUpdateState: vi.fn<() => ActiveUpdateState>(),
-  getCohort: vi.fn(() => "123"),
-  getFingerprintHash: vi.fn(() => "fingerprint-hash"),
-  getInstallId: vi.fn<() => string | undefined>(() => "install-id"),
-  getPersistedUserIdentity: vi.fn(() => ({})),
-  readNotifyAppReady: vi.fn<
-    () => {
-      insightsEvent: NotifyAppReadyInsightsEvent | null;
-      pending: boolean;
-      result: NotifyAppReadyResult;
-    }
-  >(() => createNotifyReadResult()),
-  reload: vi.fn(),
-}));
-
-vi.mock("./checkForUpdate", () => ({
-  checkForUpdate: mocks.checkForUpdate,
-}));
-
-vi.mock("./native", () => ({
-  addListener: mocks.addListener,
-  getAppVersion: mocks.getAppVersion,
-  getBundleId: mocks.getBundleId,
-  getChannel: mocks.getChannel,
-  getActiveUpdateState: mocks.getActiveUpdateState,
-  getCohort: mocks.getCohort,
-  getFingerprintHash: mocks.getFingerprintHash,
-  getInstallId: mocks.getInstallId,
-  getPersistedUserIdentity: mocks.getPersistedUserIdentity,
-  readNotifyAppReady: mocks.readNotifyAppReady,
-  reload: mocks.reload,
-}));
-
-vi.mock("./specs/NativeHotUpdater", () => ({
-  default: nativePersistence,
-}));
-
-const createClient = () => {
-  const sendInsightsEvent = vi.fn().mockResolvedValue(undefined);
-  return {
-    client: {
-      createSession: vi.fn(async () => ({
-        fetchReleaseCatalog: vi.fn(),
-        resolveArtifact: vi.fn(),
-        sendInsightsEvent,
-      })),
-    },
-    sendInsightsEvent,
-  };
-};
-
-describe("automatic notifyAppReady insights boundaries", () => {
-  beforeEach(() => {
-    vi.resetModules();
-    vi.unstubAllGlobals();
-    vi.useRealTimers();
-    platformState.OS = "ios";
-
-    for (const mock of Object.values(mocks)) {
-      mock.mockReset();
-    }
-
-    mocks.addListener.mockReturnValue(() => {});
-    mocks.getAppVersion.mockReturnValue("1.0.0");
-    mocks.getBundleId.mockReturnValue("bundle-id");
-    mocks.getChannel.mockReturnValue("production");
-    mocks.getActiveUpdateState.mockReturnValue({
-      activeSelection: null,
-      stableSelection: null,
-      verificationPending: false,
-    });
-    mocks.getCohort.mockReturnValue("123");
-    mocks.getFingerprintHash.mockReturnValue("fingerprint-hash");
-    mocks.getInstallId.mockReturnValue("install-id");
-    mocks.getPersistedUserIdentity.mockReturnValue({});
-    mocks.readNotifyAppReady.mockReturnValue(createNotifyReadResult());
-    nativePersistence.getConstants.mockClear();
-    nativePersistence.getInstallId.mockClear();
-    nativePersistence.setPersistedInstallId("install-persisted");
-  });
-
-  it("warns when the private HTTP session fails and preserves readiness", async () => {
-    stubNotifyFrame();
-    const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
-    const onError = vi.fn();
-    const onNotifyAppReady = vi.fn();
-    const { init } = await import("./wrap");
-
-    init({
-      insights: true,
-      client: {
-        createSession: vi.fn(async () => {
-          throw new Error("baseURL unavailable");
-        }),
-      },
-      onError,
-      onNotifyAppReady,
-    });
-    await vi.runOnlyPendingTimersAsync();
-
-    expect(onError).not.toHaveBeenCalled();
-    expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
-    expect(warn).toHaveBeenCalledWith(
-      "[HotUpdater] Automatic notifyAppReady insights failed:",
-      expect.objectContaining({
-        message: "baseURL unavailable",
-      }),
-    );
-    warn.mockRestore();
-  });
-
-  it.each([
-    { label: "throws", value: new Error("native install id unavailable") },
-    { label: "returns no identity", value: undefined },
-  ])(
-    "warns for a missing native install identity when it $label",
-    async ({ value }) => {
-      stubNotifyFrame();
-      const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
-      const onError = vi.fn();
-      const onNotifyAppReady = vi.fn();
-      if (value instanceof Error) {
-        mocks.getInstallId.mockImplementation(() => {
-          throw value;
-        });
-      } else {
-        mocks.getInstallId.mockReturnValue(value);
-      }
-      const { client, sendInsightsEvent } = createClient();
-      const { init } = await import("./wrap");
-
-      init({ insights: true, client, onError, onNotifyAppReady });
-      await vi.runOnlyPendingTimersAsync();
-
-      expect(sendInsightsEvent).not.toHaveBeenCalled();
-      expect(onError).not.toHaveBeenCalled();
-      expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
-      expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady insights failed:",
-        expect.any(Error),
-      );
-      warn.mockRestore();
-    },
-  );
-
-  it.each([
-    { label: "throws", value: new Error("native bundle id unavailable") },
-    { label: "returns no bundle", value: undefined },
-  ])(
-    "warns for a missing current bundle when getBundleId $label",
-    async ({ value }) => {
-      stubNotifyFrame();
-      const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
-      const onError = vi.fn();
-      const onNotifyAppReady = vi.fn();
-      if (value instanceof Error) {
-        mocks.getBundleId.mockImplementation(() => {
-          throw value;
-        });
-      } else {
-        mocks.getBundleId.mockReturnValue(value);
-      }
-      const { client, sendInsightsEvent } = createClient();
-      const { init } = await import("./wrap");
-
-      init({ insights: true, client, onError, onNotifyAppReady });
-      await vi.runOnlyPendingTimersAsync();
-
-      expect(sendInsightsEvent).not.toHaveBeenCalled();
-      expect(onError).not.toHaveBeenCalled();
-      expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
-      expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady insights failed:",
-        expect.any(Error),
-      );
-      warn.mockRestore();
-    },
-  );
-
-  it.each(["ios", "android"] as const)(
-    "reads persisted install id through native.ts across JS module resets on %s",
-    async (platform) => {
-      platformState.OS = platform;
-      nativePersistence.setPersistedInstallId("install-persisted");
-      const native =
-        await vi.importActual<typeof import("./native")>("./native");
-
-      expect(native.getInstallId()).toBe("install-persisted");
-      vi.resetModules();
-      const nativeAfterReset =
-        await vi.importActual<typeof import("./native")>("./native");
-
-      expect(nativeAfterReset.getInstallId()).toBe("install-persisted");
-      expect(nativePersistence.getInstallId).toHaveBeenCalledTimes(2);
-    },
-  );
-});

package/src/notifyAppReadyInsights.spec.ts

@@ -1,362 +0,0 @@
-import { beforeEach, describe, expect, it, vi } from "vitest";
-
-import type {
-  ActiveUpdateState,
-  NotifyAppReadyInsightsEvent,
-  NotifyAppReadyResult,
-} from "./native";
-import {
-  createNotifyReadResult,
-  stubNotifyFrame,
-} from "./notifyAppReadyInsights.test-utils";
-
-vi.mock("react-native", () => ({
-  Platform: { OS: "ios" },
-}));
-
-const mocks = vi.hoisted(() => ({
-  addListener: vi.fn(() => () => {}),
-  checkForUpdate: vi.fn(),
-  getAppVersion: vi.fn(() => "1.0.0"),
-  getBundleId: vi.fn(() => "bundle-id"),
-  getChannel: vi.fn(() => "production"),
-  getActiveUpdateState: vi.fn<() => ActiveUpdateState>(),
-  getCohort: vi.fn(() => "123"),
-  getFingerprintHash: vi.fn(() => "fingerprint-hash"),
-  getInstallId: vi.fn(() => "install-id"),
-  getPersistedUserIdentity: vi.fn(() => ({})),
-  readNotifyAppReady: vi.fn<
-    () => {
-      insightsEvent: NotifyAppReadyInsightsEvent | null;
-      pending: boolean;
-      result: NotifyAppReadyResult;
-    }
-  >(() => createNotifyReadResult()),
-  reload: vi.fn(),
-}));
-
-vi.mock("./checkForUpdate", () => ({
-  checkForUpdate: mocks.checkForUpdate,
-}));
-
-vi.mock("./native", () => ({
-  addListener: mocks.addListener,
-  getAppVersion: mocks.getAppVersion,
-  getBundleId: mocks.getBundleId,
-  getChannel: mocks.getChannel,
-  getActiveUpdateState: mocks.getActiveUpdateState,
-  getCohort: mocks.getCohort,
-  getFingerprintHash: mocks.getFingerprintHash,
-  getInstallId: mocks.getInstallId,
-  getPersistedUserIdentity: mocks.getPersistedUserIdentity,
-  readNotifyAppReady: mocks.readNotifyAppReady,
-  reload: mocks.reload,
-}));
-
-const createClient = () => {
-  const sendInsightsEvent = vi.fn().mockResolvedValue(undefined);
-  return {
-    client: {
-      createSession: vi.fn(async () => ({
-        fetchReleaseCatalog: vi.fn(),
-        resolveArtifact: vi.fn(),
-        sendInsightsEvent,
-      })),
-    },
-    sendInsightsEvent,
-  };
-};
-
-describe("automatic notifyAppReady insights", () => {
-  beforeEach(() => {
-    vi.resetModules();
-    vi.unstubAllGlobals();
-    vi.useRealTimers();
-
-    for (const mock of Object.values(mocks)) {
-      mock.mockReset();
-    }
-
-    mocks.getAppVersion.mockReturnValue("1.0.0");
-    mocks.addListener.mockReturnValue(() => {});
-    mocks.getBundleId.mockReturnValue("bundle-id");
-    mocks.getChannel.mockReturnValue("production");
-    mocks.getActiveUpdateState.mockReturnValue({
-      activeSelection: null,
-      stableSelection: null,
-      verificationPending: false,
-    });
-    mocks.getCohort.mockReturnValue("123");
-    mocks.getFingerprintHash.mockReturnValue("fingerprint-hash");
-    mocks.getInstallId.mockReturnValue("install-id");
-    mocks.getPersistedUserIdentity.mockReturnValue({});
-    mocks.readNotifyAppReady.mockReturnValue(createNotifyReadResult());
-  });
-
-  it.each([
-    {
-      label: "running selection",
-      pending: false,
-      channel: "production",
-      expected: "release-running",
-    },
-    {
-      label: "staged selection",
-      pending: true,
-      channel: "production",
-      expected: "release-running",
-    },
-    {
-      label: "another channel",
-      pending: false,
-      channel: "preview",
-      expected: null,
-    },
-  ])(
-    "attributes an unchanged launch with $label",
-    async ({ pending, channel, expected }) => {
-      const running = {
-        kind: "BUNDLE" as const,
-        releaseId: "release-running",
-        bundleId: "bundle-id",
-        channel,
-      };
-      mocks.getActiveUpdateState.mockReturnValue({
-        activeSelection: pending
-          ? {
-              ...running,
-              releaseId: "release-pending",
-              bundleId: "bundle-pending",
-            }
-          : running,
-        stableSelection: pending ? running : null,
-        verificationPending: pending,
-      });
-      const { reportNoChange } = await import("./notifyAppReadyInsights");
-      const { client, sendInsightsEvent } = createClient();
-      await reportNoChange({ client, insights: true });
-      expect(sendInsightsEvent).toHaveBeenCalledWith(
-        expect.objectContaining({
-          type: "UNCHANGED",
-          toBundleId: "bundle-id",
-          toReleaseId: expected,
-        }),
-      );
-    },
-  );
-
-  it("orders download after in-flight startup reporting and suppresses a later no-change report", async () => {
-    const { handleNotifyAppReady, reportBundleDownloaded, reportNoChange } =
-      await import("./notifyAppReadyInsights");
-    const { client, sendInsightsEvent } = createClient();
-    let finishStartup!: () => void;
-    sendInsightsEvent.mockImplementationOnce(
-      () =>
-        new Promise<void>((resolve) => {
-          finishStartup = resolve;
-        }),
-    );
-    const options = { client, insights: true };
-    const startup = handleNotifyAppReady(options);
-    await vi.waitFor(() => expect(sendInsightsEvent).toHaveBeenCalledOnce());
-    const download = reportBundleDownloaded(options, {
-      fromBundleId: "bundle-id",
-      fromReleaseId: null,
-      toBundleId: "next-bundle",
-      toReleaseId: "next-release",
-      channel: "production",
-      updateStrategy: "appVersion",
-    });
-    await Promise.resolve();
-    expect(sendInsightsEvent).toHaveBeenCalledOnce();
-    finishStartup();
-    await Promise.all([startup, download]);
-    await reportNoChange(options);
-    expect(sendInsightsEvent.mock.calls.map(([params]) => params.type)).toEqual(
-      ["UNCHANGED", "UPDATE_DOWNLOADED"],
-    );
-  });
-
-  it("reports selecting a previous download again after a different pending bundle", async () => {
-    const { reportBundleDownloaded } = await import("./notifyAppReadyInsights");
-    const { client, sendInsightsEvent } = createClient();
-    const transition = {
-      fromBundleId: "bundle-id",
-      fromReleaseId: null,
-      toBundleId: "next-bundle",
-      toReleaseId: "next-release",
-      channel: "production",
-      updateStrategy: "appVersion" as const,
-    };
-    await reportBundleDownloaded({ client, insights: true }, transition);
-    await reportBundleDownloaded({ client, insights: true }, transition);
-    await reportBundleDownloaded(
-      { client, insights: true },
-      {
-        ...transition,
-        toBundleId: "other-bundle",
-        toReleaseId: "other-release",
-      },
-    );
-    await reportBundleDownloaded({ client, insights: true }, transition);
-    expect(
-      sendInsightsEvent.mock.calls.map(([params]) => params.toBundleId),
-    ).toEqual(["next-bundle", "other-bundle", "next-bundle"]);
-  });
-
-  it("sends UPDATE_APPLIED with transition metadata and invokes readiness", async () => {
-    stubNotifyFrame();
-    mocks.getPersistedUserIdentity.mockReturnValue({
-      userId: "user-123",
-      username: "alice",
-    });
-    mocks.readNotifyAppReady.mockReturnValue(
-      createNotifyReadResult(
-        {
-          fromBundleId: "bundle-a",
-          status: "UPDATE_APPLIED",
-          toBundleId: "bundle-b",
-        },
-        {
-          fromBundleId: "bundle-a",
-          toBundleId: "bundle-b",
-          type: "UPDATE_APPLIED",
-          updateStrategy: "fingerprint",
-        },
-      ),
-    );
-
-    const { client, sendInsightsEvent } = createClient();
-    const onNotifyAppReady = vi.fn();
-    const { init } = await import("./wrap");
-
-    init({
-      insights: true,
-      onNotifyAppReady,
-      requestHeaders: { Authorization: "Bearer token" },
-      requestTimeout: 1000,
-      client,
-    });
-    await vi.runOnlyPendingTimersAsync();
-
-    expect(sendInsightsEvent).toHaveBeenCalledWith({
-      appVersion: "1.0.0",
-      channel: "production",
-      cohort: "123",
-      fingerprintHash: "fingerprint-hash",
-      fromBundleId: "bundle-a",
-      fromReleaseId: null,
-      installId: "install-id",
-      platform: "ios",
-      requestHeaders: { Authorization: "Bearer token" },
-      requestTimeout: 1000,
-      toBundleId: "bundle-b",
-      toReleaseId: null,
-      type: "UPDATE_APPLIED",
-      updateStrategy: "fingerprint",
-      userId: "user-123",
-      username: "alice",
-    });
-    expect(onNotifyAppReady).toHaveBeenCalledWith({
-      fromBundleId: "bundle-a",
-      status: "UPDATE_APPLIED",
-      toBundleId: "bundle-b",
-    });
-  });
-
-  it("sends RECOVERED with directional ids and invokes readiness", async () => {
-    stubNotifyFrame();
-    mocks.readNotifyAppReady.mockReturnValue(
-      createNotifyReadResult(
-        {
-          fromBundleId: "bundle-b",
-          status: "RECOVERED",
-          toBundleId: "bundle-a",
-        },
-        {
-          fromBundleId: "bundle-b",
-          toBundleId: "bundle-a",
-          type: "RECOVERED",
-          updateStrategy: "appVersion",
-        },
-      ),
-    );
-    const { client, sendInsightsEvent } = createClient();
-    const onNotifyAppReady = vi.fn();
-    const { init } = await import("./wrap");
-
-    init({ insights: true, client, onNotifyAppReady });
-    await vi.runOnlyPendingTimersAsync();
-
-    expect(sendInsightsEvent).toHaveBeenCalledWith({
-      appVersion: "1.0.0",
-      channel: "production",
-      cohort: "123",
-      fingerprintHash: "fingerprint-hash",
-      fromBundleId: "bundle-b",
-      fromReleaseId: null,
-      installId: "install-id",
-      platform: "ios",
-      requestHeaders: undefined,
-      requestTimeout: undefined,
-      toBundleId: "bundle-a",
-      toReleaseId: null,
-      type: "RECOVERED",
-      updateStrategy: "appVersion",
-    });
-    expect(onNotifyAppReady).toHaveBeenCalledWith({
-      fromBundleId: "bundle-b",
-      status: "RECOVERED",
-      toBundleId: "bundle-a",
-    });
-  });
-
-  it("sends one UNCHANGED event for repeated init calls", async () => {
-    stubNotifyFrame();
-    const { client, sendInsightsEvent } = createClient();
-    const onNotifyAppReady = vi.fn();
-    const { init } = await import("./wrap");
-
-    init({ insights: true, client, onNotifyAppReady });
-    init({ insights: true, client, onNotifyAppReady });
-    await vi.runOnlyPendingTimersAsync();
-
-    expect(sendInsightsEvent).toHaveBeenCalledTimes(1);
-    expect(sendInsightsEvent).toHaveBeenCalledWith({
-      appVersion: "1.0.0",
-      channel: "production",
-      cohort: "123",
-      fingerprintHash: "fingerprint-hash",
-      fromBundleId: null,
-      fromReleaseId: null,
-      installId: "install-id",
-      platform: "ios",
-      requestHeaders: undefined,
-      requestTimeout: undefined,
-      toBundleId: "bundle-id",
-      toReleaseId: null,
-      type: "UNCHANGED",
-      updateStrategy: null,
-    });
-    expect(onNotifyAppReady).toHaveBeenCalledTimes(2);
-    expect(onNotifyAppReady).toHaveBeenNthCalledWith(1, {
-      status: "UNCHANGED",
-    });
-    expect(onNotifyAppReady).toHaveBeenNthCalledWith(2, {
-      status: "UNCHANGED",
-    });
-  });
-
-  it("skips automatic insights when disabled while preserving readiness", async () => {
-    stubNotifyFrame();
-    const { client, sendInsightsEvent } = createClient();
-    const onNotifyAppReady = vi.fn();
-    const { init } = await import("./wrap");
-
-    init({ insights: false, client, onNotifyAppReady });
-    await vi.runOnlyPendingTimersAsync();
-
-    expect(sendInsightsEvent).not.toHaveBeenCalled();
-    expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
-  });
-});