@hot-updater/react-native 1.0.0-rc.1 → 1.0.0-rc.3

package/src/index.spec.ts

@@ -22,7 +22,7 @@ const mocks = vi.hoisted(() => {
     })),
     getAppVersion: vi.fn(() => "1.0.0"),
     getBaseURL: vi.fn(() => null),
-    getBundleId: vi.fn(() => "bundle-id"),
+    getUpdateId: vi.fn(() => "release-id"),
     getChannel: vi.fn(() => "production"),
     getCohort: vi.fn(() => "123"),
     getCrashHistory: vi.fn(() => []),
@@ -31,7 +31,6 @@ const mocks = vi.hoisted(() => {
     getInstallId: vi.fn(() => "install-id"),
     getManifest: vi.fn(() => null),
     getMinBundleId: vi.fn(() => "min-bundle-id"),
-    getReleaseId: vi.fn(async () => null),
     init: vi.fn(),
     isChannelSwitched: vi.fn(() => false),
     notifyAppReady: vi.fn(() => ({ status: "UNCHANGED" as const })),
@@ -59,7 +58,7 @@ vi.mock("./native", () => ({
   getPublicActiveUpdateState: mocks.getActiveUpdateState,
   getAppVersion: mocks.getAppVersion,
   getBaseURL: mocks.getBaseURL,
-  getBundleId: mocks.getBundleId,
+  getUpdateId: mocks.getUpdateId,
   getChannel: mocks.getChannel,
   getCohort: mocks.getCohort,
   getCrashHistory: mocks.getCrashHistory,
@@ -68,7 +67,6 @@ vi.mock("./native", () => ({
   getInstallId: mocks.getInstallId,
   getManifest: mocks.getManifest,
   getMinBundleId: mocks.getMinBundleId,
-  getReleaseId: mocks.getReleaseId,
   isChannelSwitched: mocks.isChannelSwitched,
   notifyAppReady: mocks.notifyAppReady,
   reload: mocks.reload,
@@ -97,13 +95,21 @@ describe("HotUpdater client initialization", () => {
     mocks.wrap.mockImplementation((Component: unknown) => Component);
   });
 
+  it("exposes the console ID through the existing getter only", async () => {
+    const HotUpdater = await importHotUpdater();
+
+    expect(HotUpdater.getBundleId()).toBe("release-id");
+    expect(HotUpdater).not.toHaveProperty("getReleaseId");
+    expect(HotUpdater).not.toHaveProperty("getUpdateId");
+  });
+
   it("initializes a private HTTP client from the required baseURL", async () => {
     const client = { createSession: vi.fn() };
     mocks.createHttpClient.mockReturnValue(client as never);
     const HotUpdater = await importHotUpdater();
 
     HotUpdater.init({
-      analytics: true,
+      insights: true,
       baseURL: "https://updates.example.com",
       requestHeaders: { Authorization: "Bearer token" },
       requestTimeout: 1000,
@@ -113,7 +119,7 @@ describe("HotUpdater client initialization", () => {
       "https://updates.example.com",
     );
     expect(mocks.init).toHaveBeenCalledWith({
-      analytics: true,
+      insights: true,
       client,
       requestHeaders: { Authorization: "Bearer token" },
       requestTimeout: 1000,
@@ -130,6 +136,44 @@ describe("HotUpdater client initialization", () => {
     expect(resolveBaseURL).not.toHaveBeenCalled();
   });
 
+  it("enables insights by default for init and wrap", async () => {
+    const HotUpdater = await importHotUpdater();
+
+    HotUpdater.init({ baseURL: "https://updates.example.com" });
+    HotUpdater.wrap({
+      baseURL: "https://updates.example.com",
+      updateStrategy: "appVersion",
+    });
+
+    expect(mocks.init).toHaveBeenCalledWith(
+      expect.objectContaining({ insights: true }),
+    );
+    expect(mocks.wrap).toHaveBeenCalledWith(
+      expect.objectContaining({ insights: true }),
+    );
+  });
+
+  it("preserves an explicit insights opt-out", async () => {
+    const HotUpdater = await importHotUpdater();
+
+    HotUpdater.init({
+      baseURL: "https://updates.example.com",
+      insights: false,
+    });
+    HotUpdater.wrap({
+      baseURL: "https://updates.example.com",
+      insights: false,
+      updateStrategy: "appVersion",
+    });
+
+    expect(mocks.init).toHaveBeenCalledWith(
+      expect.objectContaining({ insights: false }),
+    );
+    expect(mocks.wrap).toHaveBeenCalledWith(
+      expect.objectContaining({ insights: false }),
+    );
+  });
+
   it("requires baseURL and rejects the removed resolver shape", async () => {
     const HotUpdater = await importHotUpdater();
 
@@ -171,13 +215,13 @@ describe("HotUpdater client initialization", () => {
     expect(wrapOptions.updateStrategy).toBe("appVersion");
   });
 
-  it("merges settings and carries the analytics gate to checks", async () => {
+  it("merges settings and carries the insights gate to checks", async () => {
     const client = { createSession: vi.fn() };
     mocks.createHttpClient.mockReturnValue(client as never);
     const checkOnError = vi.fn();
     const HotUpdater = await importHotUpdater();
     HotUpdater.init({
-      analytics: true,
+      insights: true,
       baseURL: "https://updates.example.com",
       requestHeaders: { Authorization: "Bearer token" },
       requestTimeout: 1000,
@@ -190,7 +234,7 @@ describe("HotUpdater client initialization", () => {
     });
 
     expect(mocks.checkForUpdate).toHaveBeenCalledWith({
-      analytics: true,
+      insights: true,
       client,
       onError: checkOnError,
       requestHeaders: {
@@ -208,13 +252,13 @@ describe("HotUpdater client initialization", () => {
     const HotUpdater = await importHotUpdater();
 
     HotUpdater.wrap({
-      analytics: true,
+      insights: true,
       baseURL: "https://updates.example.com",
       updateStrategy: "appVersion",
     });
 
     expect(mocks.wrap).toHaveBeenCalledWith({
-      analytics: true,
+      insights: true,
       client,
       updateStrategy: "appVersion",
     });

package/src/index.ts

@@ -10,7 +10,7 @@ import {
   clearCrashHistory,
   getAppVersion,
   getBaseURL,
-  getBundleId,
+  getUpdateId,
   getChannel,
   getCohort,
   getCrashHistory,
@@ -19,7 +19,6 @@ import {
   getInstallId,
   getManifest,
   getMinBundleId,
-  getReleaseId,
   isChannelSwitched,
   notifyAppReady,
   reload,
@@ -101,12 +100,13 @@ function createHotUpdaterClient() {
 
   // Global configuration stored from wrap
   const globalConfig: {
-    analytics?: boolean;
+    insights: boolean;
     client: HotUpdaterHttpClient | null;
     requestHeaders?: Record<string, string>;
     requestTimeout?: number;
     onError?: (error: unknown) => void;
   } = {
+    insights: true,
     client: null,
   };
 
@@ -158,6 +158,7 @@ function createHotUpdaterClient() {
       const { baseURL, ...rest } = autoOptions;
       return {
         ...rest,
+        insights: rest.insights ?? true,
         client: createHttpClient(baseURL),
       };
     }
@@ -177,6 +178,7 @@ function createHotUpdaterClient() {
       const { baseURL, ...baseURLRest } = rest;
       return {
         ...baseURLRest,
+        insights: baseURLRest.insights ?? true,
         client: createHttpClient(baseURL),
       };
     }
@@ -188,7 +190,7 @@ function createHotUpdaterClient() {
     normalizedOptions: InternalInitOptions | InternalWrapOptions,
     options: HotUpdaterOptions | HotUpdaterInitOptions,
   ) => {
-    globalConfig.analytics = normalizedOptions.analytics;
+    globalConfig.insights = normalizedOptions.insights ?? true;
     globalConfig.client = normalizedOptions.client;
     globalConfig.requestHeaders = options.requestHeaders;
     globalConfig.requestTimeout = options.requestTimeout;
@@ -333,16 +335,14 @@ function createHotUpdaterClient() {
     getActiveUpdateState: async () => getPublicActiveUpdateState(),
 
     /**
-     * Fetches the current bundle ID of the app.
+     * Returns the selected update ID, matching the ID shown in the console.
+     * A staged update can change this ID before the app reloads.
      */
-    getBundleId,
+    getBundleId: getUpdateId,
 
     /** Returns the minimum bundle ID based on the native app build time. */
     getMinBundleId,
 
-    /** Returns the active Release identity, or null for BUILTIN/legacy state. */
-    getReleaseId,
-
     /**
      * Fetches the current manifest for the active bundle.
      */
@@ -448,7 +448,7 @@ function createHotUpdaterClient() {
 
       const mergedConfig: InternalCheckForUpdateOptions = {
         ...config,
-        analytics: globalConfig.analytics,
+        insights: globalConfig.insights,
         client,
         requestHeaders: {
           ...globalConfig.requestHeaders,

package/src/native.spec.ts

@@ -52,6 +52,13 @@ vi.mock("./specs/NativeHotUpdater", () => ({
 describe("notifyAppReady", () => {
   beforeEach(() => {
     vi.resetModules();
+    nativeModuleMock.getActiveUpdateState.mockReset();
+    nativeModuleMock.getActiveUpdateState.mockReturnValue({
+      activeSelection: null,
+      stableSelection: null,
+      verificationPending: false,
+      highestSeenCatalogs: {},
+    });
     nativeModuleMock.notifyAppReady.mockReset();
     nativeModuleMock.getBaseURL.mockReset();
     nativeModuleMock.getBundleId.mockReset();
@@ -122,6 +129,89 @@ describe("notifyAppReady", () => {
     });
   });
 
+  it("tracks same-file promotions without changing artifact or crash identities", async () => {
+    const state = {
+      activeSelection: {
+        kind: "BUNDLE",
+        bundleId: "bundle-123",
+        releaseId: "release-1",
+      },
+    };
+    nativeModuleMock.getActiveUpdateState.mockImplementation(() => state);
+    nativeModuleMock.getBundleId.mockReturnValue("bundle-123");
+    nativeModuleMock.getManifest.mockReturnValue({ assets: {} });
+    nativeModuleMock.getCrashHistory.mockReturnValue(["bundle-failed"]);
+    const { getUpdateId, getBundleId, getManifest, getCrashHistory } =
+      await import("./native");
+
+    expect(getUpdateId()).toBe("release-1");
+    state.activeSelection.releaseId = "release-2";
+    expect(getUpdateId()).toBe("release-2");
+    expect(getBundleId()).toBe("bundle-123");
+    expect(getManifest().bundleId).toBe("bundle-123");
+    expect(getCrashHistory()).toEqual(["bundle-failed"]);
+  });
+
+  it.each([
+    [null, "min-bundle-id"],
+    ["legacy-bundle", "legacy-bundle"],
+  ])(
+    "preserves the fallback ID for native bundle %s",
+    async (bundleId, expected) => {
+      nativeModuleMock.getBundleId.mockReturnValue(bundleId);
+      const { getUpdateId } = await import("./native");
+
+      expect(getUpdateId()).toBe(expected);
+    },
+  );
+
+  it("reports a staged update while the manifest still identifies the running file", async () => {
+    const runningSelection = {
+      kind: "BUNDLE",
+      bundleId: "running-file",
+      releaseId: "running-update",
+    };
+    const state = {
+      activeSelection: runningSelection,
+      stableSelection: runningSelection,
+    };
+    nativeModuleMock.getActiveUpdateState.mockImplementation(() => state);
+    nativeModuleMock.getBundleId.mockReturnValue("running-file");
+    nativeModuleMock.getManifest.mockReturnValue({
+      assets: {},
+      bundleId: "running-file",
+    });
+    const { getUpdateId, getBundleId, getManifest } = await import("./native");
+
+    expect(getUpdateId()).toBe("running-update");
+    state.activeSelection = {
+      kind: "BUNDLE",
+      bundleId: "staged-file",
+      releaseId: "staged-update",
+    };
+
+    expect(getUpdateId()).toBe("staged-update");
+    expect(getBundleId()).toBe("running-file");
+    expect(getManifest().bundleId).toBe("running-file");
+  });
+
+  it("reports an explicit built-in rollback by its update ID", async () => {
+    nativeModuleMock.getActiveUpdateState.mockReturnValue(
+      JSON.stringify({
+        activeSelection: {
+          kind: "EMBEDDED",
+          releaseId: "rollback-1",
+          bundleId: "min-bundle-id",
+        },
+      }),
+    );
+    nativeModuleMock.getBundleId.mockReturnValue(null);
+    const { getUpdateId, getBundleId } = await import("./native");
+
+    expect(getUpdateId()).toBe("rollback-1");
+    expect(getBundleId()).toBe("min-bundle-id");
+  });
+
   it("normalizes legacy PROMOTED launch reports to UPDATE_APPLIED", async () => {
     nativeModuleMock.notifyAppReady.mockReturnValue(
       JSON.stringify({
@@ -157,7 +247,7 @@ describe("notifyAppReady", () => {
       toBundleId: "bundle-122",
     });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: {
+      insightsEvent: {
         fromBundleId: "bundle-123",
         toBundleId: "bundle-122",
         type: "RECOVERED",
@@ -184,13 +274,13 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
   });
 
-  it("returns UNCHANGED when automatic analytics metadata is incomplete", async () => {
+  it("returns UNCHANGED when automatic insights metadata is incomplete", async () => {
     nativeModuleMock.notifyAppReady.mockReturnValue({
       status: "UPDATE_APPLIED",
     });
@@ -199,7 +289,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
@@ -212,7 +302,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
@@ -225,7 +315,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: true,
       result: { status: "UNCHANGED" },
     });
@@ -728,6 +818,20 @@ describe("notifyAppReady", () => {
     expect(getInstallId()).toBe("install-123");
   });
 
+  it("normalizes an omitted native fingerprint constant to null", async () => {
+    nativeModuleMock.getConstants.mockReturnValue({
+      APP_VERSION: null,
+      CHANNEL: "production",
+      DEFAULT_CHANNEL: "production",
+      FINGERPRINT_HASH: undefined as unknown as null,
+      MIN_BUNDLE_ID: "min-bundle-id",
+    });
+
+    const { getFingerprintHash } = await import("./native");
+
+    expect(getFingerprintHash()).toBeNull();
+  });
+
   it("throws when native SDK does not expose getInstallId", async () => {
     const nativeModule = nativeModuleMock as typeof nativeModuleMock & {
       getInstallId?: typeof nativeModuleMock.getInstallId;

package/src/native.ts

@@ -599,8 +599,9 @@ export const getMinBundleId = (): string => {
   return constants.MIN_BUNDLE_ID;
 };
 
-export const getReleaseId = async (): Promise<string | null> =>
-  getActiveUpdateState().activeSelection?.releaseId ?? null;
+/** Returns the selected update ID shown in the console, including staged updates. */
+export const getUpdateId = (): string =>
+  getActiveUpdateState().activeSelection?.releaseId ?? getBundleId();
 
 /**
  * Fetches the current bundle version id.
@@ -687,7 +688,7 @@ export const isChannelSwitched = (): boolean => {
  */
 export const getFingerprintHash = (): string | null => {
   const constants = HotUpdaterNative.getConstants();
-  return constants.FINGERPRINT_HASH;
+  return constants.FINGERPRINT_HASH ?? null;
 };
 
 export const getInstallId = (): string => {
@@ -783,7 +784,7 @@ export type NotifyAppReadyResult =
       toReleaseId?: string;
     };
 
-export type NotifyAppReadyAnalyticsEvent = {
+export type NotifyAppReadyInsightsEvent = {
   type: "UPDATE_APPLIED" | "RECOVERED";
   fromBundleId: string;
   toBundleId: string;
@@ -891,9 +892,9 @@ const getNotifyAppReadyTransition = (
   return null;
 };
 
-const getNotifyAppReadyAnalyticsEvent = (
+const getNotifyAppReadyInsightsEvent = (
   result: RawNotifyAppReadyResult,
-): NotifyAppReadyAnalyticsEvent | null => {
+): NotifyAppReadyInsightsEvent | null => {
   const transition = getNotifyAppReadyTransition(result);
 
   if (!transition || !isPersistedUpdateStrategy(result.updateStrategy)) {
@@ -938,14 +939,14 @@ const normalizeNotifyAppReadyResult = (
 
 export const readNotifyAppReady = (): {
   result: NotifyAppReadyResult;
-  analyticsEvent: NotifyAppReadyAnalyticsEvent | null;
+  insightsEvent: NotifyAppReadyInsightsEvent | null;
   pending: boolean;
 } => {
   const rawResult = readRawNotifyAppReadyResult();
 
   return {
     result: normalizeNotifyAppReadyResult(rawResult),
-    analyticsEvent: getNotifyAppReadyAnalyticsEvent(rawResult),
+    insightsEvent: getNotifyAppReadyInsightsEvent(rawResult),
     pending: rawResult.status === "PENDING",
   };
 };

package/src/{notifyAppReadyAnalytics.boundary.spec.ts → notifyAppReadyInsights.boundary.spec.ts}

@@ -1,13 +1,13 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 
 import type {
-  NotifyAppReadyAnalyticsEvent,
+  NotifyAppReadyInsightsEvent,
   NotifyAppReadyResult,
 } from "./native";
 import {
   createNotifyReadResult,
   stubNotifyFrame,
-} from "./notifyAppReadyAnalytics.test-utils";
+} from "./notifyAppReadyInsights.test-utils";
 
 const platformState = vi.hoisted((): { OS: "ios" | "android" } => ({
   OS: "ios",
@@ -48,7 +48,7 @@ const mocks = vi.hoisted(() => ({
   getPersistedUserIdentity: vi.fn(() => ({})),
   readNotifyAppReady: vi.fn<
     () => {
-      analyticsEvent: NotifyAppReadyAnalyticsEvent | null;
+      insightsEvent: NotifyAppReadyInsightsEvent | null;
       pending: boolean;
       result: NotifyAppReadyResult;
     }
@@ -78,20 +78,20 @@ vi.mock("./specs/NativeHotUpdater", () => ({
 }));
 
 const createClient = () => {
-  const sendAnalyticsEvent = vi.fn().mockResolvedValue(undefined);
+  const sendInsightsEvent = vi.fn().mockResolvedValue(undefined);
   return {
     client: {
       createSession: vi.fn(async () => ({
         fetchReleaseCatalog: vi.fn(),
         resolveArtifact: vi.fn(),
-        sendAnalyticsEvent,
+        sendInsightsEvent,
       })),
     },
-    sendAnalyticsEvent,
+    sendInsightsEvent,
   };
 };
 
-describe("automatic notifyAppReady analytics boundaries", () => {
+describe("automatic notifyAppReady insights boundaries", () => {
   beforeEach(() => {
     vi.resetModules();
     vi.unstubAllGlobals();
@@ -124,7 +124,7 @@ describe("automatic notifyAppReady analytics boundaries", () => {
     const { init } = await import("./wrap");
 
     init({
-      analytics: true,
+      insights: true,
       client: {
         createSession: vi.fn(async () => {
           throw new Error("baseURL unavailable");
@@ -138,7 +138,7 @@ describe("automatic notifyAppReady analytics boundaries", () => {
     expect(onError).not.toHaveBeenCalled();
     expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
     expect(warn).toHaveBeenCalledWith(
-      "[HotUpdater] Automatic notifyAppReady analytics failed:",
+      "[HotUpdater] Automatic notifyAppReady insights failed:",
       expect.objectContaining({
         message: "baseURL unavailable",
       }),
@@ -163,17 +163,17 @@ describe("automatic notifyAppReady analytics boundaries", () => {
       } else {
         mocks.getInstallId.mockReturnValue(value);
       }
-      const { client, sendAnalyticsEvent } = createClient();
+      const { client, sendInsightsEvent } = createClient();
       const { init } = await import("./wrap");
 
-      init({ analytics: true, client, onError, onNotifyAppReady });
+      init({ insights: true, client, onError, onNotifyAppReady });
       await vi.runOnlyPendingTimersAsync();
 
-      expect(sendAnalyticsEvent).not.toHaveBeenCalled();
+      expect(sendInsightsEvent).not.toHaveBeenCalled();
       expect(onError).not.toHaveBeenCalled();
       expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
       expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady analytics failed:",
+        "[HotUpdater] Automatic notifyAppReady insights failed:",
         expect.any(Error),
       );
       warn.mockRestore();
@@ -197,17 +197,17 @@ describe("automatic notifyAppReady analytics boundaries", () => {
       } else {
         mocks.getBundleId.mockReturnValue(value);
       }
-      const { client, sendAnalyticsEvent } = createClient();
+      const { client, sendInsightsEvent } = createClient();
       const { init } = await import("./wrap");
 
-      init({ analytics: true, client, onError, onNotifyAppReady });
+      init({ insights: true, client, onError, onNotifyAppReady });
       await vi.runOnlyPendingTimersAsync();
 
-      expect(sendAnalyticsEvent).not.toHaveBeenCalled();
+      expect(sendInsightsEvent).not.toHaveBeenCalled();
       expect(onError).not.toHaveBeenCalled();
       expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
       expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady analytics failed:",
+        "[HotUpdater] Automatic notifyAppReady insights failed:",
         expect.any(Error),
       );
       warn.mockRestore();