@hot-updater/react-native 1.0.0-rc.1 → 1.0.0-rc.15

package/src/native.spec.ts

@@ -52,6 +52,13 @@ vi.mock("./specs/NativeHotUpdater", () => ({
 describe("notifyAppReady", () => {
   beforeEach(() => {
     vi.resetModules();
+    nativeModuleMock.getActiveUpdateState.mockReset();
+    nativeModuleMock.getActiveUpdateState.mockReturnValue({
+      activeSelection: null,
+      stableSelection: null,
+      verificationPending: false,
+      highestSeenCatalogs: {},
+    });
     nativeModuleMock.notifyAppReady.mockReset();
     nativeModuleMock.getBaseURL.mockReset();
     nativeModuleMock.getBundleId.mockReset();
@@ -122,6 +129,89 @@ describe("notifyAppReady", () => {
     });
   });
 
+  it("tracks same-file promotions without changing artifact or crash identities", async () => {
+    const state = {
+      activeSelection: {
+        kind: "BUNDLE",
+        bundleId: "bundle-123",
+        releaseId: "release-1",
+      },
+    };
+    nativeModuleMock.getActiveUpdateState.mockImplementation(() => state);
+    nativeModuleMock.getBundleId.mockReturnValue("bundle-123");
+    nativeModuleMock.getManifest.mockReturnValue({ assets: {} });
+    nativeModuleMock.getCrashHistory.mockReturnValue(["bundle-failed"]);
+    const { getUpdateId, getBundleId, getManifest, getCrashHistory } =
+      await import("./native");
+
+    expect(getUpdateId()).toBe("release-1");
+    state.activeSelection.releaseId = "release-2";
+    expect(getUpdateId()).toBe("release-2");
+    expect(getBundleId()).toBe("bundle-123");
+    expect(getManifest().bundleId).toBe("bundle-123");
+    expect(getCrashHistory()).toEqual(["bundle-failed"]);
+  });
+
+  it.each([
+    [null, "min-bundle-id"],
+    ["legacy-bundle", "legacy-bundle"],
+  ])(
+    "preserves the fallback ID for native bundle %s",
+    async (bundleId, expected) => {
+      nativeModuleMock.getBundleId.mockReturnValue(bundleId);
+      const { getUpdateId } = await import("./native");
+
+      expect(getUpdateId()).toBe(expected);
+    },
+  );
+
+  it("reports a staged update while the manifest still identifies the running file", async () => {
+    const runningSelection = {
+      kind: "BUNDLE",
+      bundleId: "running-file",
+      releaseId: "running-update",
+    };
+    const state = {
+      activeSelection: runningSelection,
+      stableSelection: runningSelection,
+    };
+    nativeModuleMock.getActiveUpdateState.mockImplementation(() => state);
+    nativeModuleMock.getBundleId.mockReturnValue("running-file");
+    nativeModuleMock.getManifest.mockReturnValue({
+      assets: {},
+      bundleId: "running-file",
+    });
+    const { getUpdateId, getBundleId, getManifest } = await import("./native");
+
+    expect(getUpdateId()).toBe("running-update");
+    state.activeSelection = {
+      kind: "BUNDLE",
+      bundleId: "staged-file",
+      releaseId: "staged-update",
+    };
+
+    expect(getUpdateId()).toBe("staged-update");
+    expect(getBundleId()).toBe("running-file");
+    expect(getManifest().bundleId).toBe("running-file");
+  });
+
+  it("reports an explicit built-in rollback by its update ID", async () => {
+    nativeModuleMock.getActiveUpdateState.mockReturnValue(
+      JSON.stringify({
+        activeSelection: {
+          kind: "EMBEDDED",
+          releaseId: "rollback-1",
+          bundleId: "min-bundle-id",
+        },
+      }),
+    );
+    nativeModuleMock.getBundleId.mockReturnValue(null);
+    const { getUpdateId, getBundleId } = await import("./native");
+
+    expect(getUpdateId()).toBe("rollback-1");
+    expect(getBundleId()).toBe("min-bundle-id");
+  });
+
   it("normalizes legacy PROMOTED launch reports to UPDATE_APPLIED", async () => {
     nativeModuleMock.notifyAppReady.mockReturnValue(
       JSON.stringify({
@@ -157,7 +247,7 @@ describe("notifyAppReady", () => {
       toBundleId: "bundle-122",
     });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: {
+      insightsEvent: {
         fromBundleId: "bundle-123",
         toBundleId: "bundle-122",
         type: "RECOVERED",
@@ -184,13 +274,13 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
   });
 
-  it("returns UNCHANGED when automatic analytics metadata is incomplete", async () => {
+  it("returns UNCHANGED when automatic insights metadata is incomplete", async () => {
     nativeModuleMock.notifyAppReady.mockReturnValue({
       status: "UPDATE_APPLIED",
     });
@@ -199,7 +289,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
@@ -212,7 +302,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: false,
       result: { status: "UNCHANGED" },
     });
@@ -225,7 +315,7 @@ describe("notifyAppReady", () => {
 
     expect(notifyAppReady()).toEqual({ status: "UNCHANGED" });
     expect(readNotifyAppReady()).toEqual({
-      analyticsEvent: null,
+      insightsEvent: null,
       pending: true,
       result: { status: "UNCHANGED" },
     });
@@ -448,13 +538,20 @@ describe("notifyAppReady", () => {
     expect(getBaseURL()).toBe("file:///bundle-123");
 
     await updateBundle({
+      assets: {},
       bundleId: "bundle-456",
-      fileHash: null,
-      fileUrl: "https://example.com/bundle.zip",
+      archiveUrl: "https://example.com/bundle.tar.br",
+      manifestFileHash: "manifest-hash",
+      manifestUrl: "https://example.com/manifest.json",
       status: "UPDATE",
     });
 
     expect(getBundleId()).toBe("bundle-123");
+    expect(nativeModuleMock.updateBundle).toHaveBeenCalledWith(
+      expect.objectContaining({
+        archiveUrl: "https://example.com/bundle.tar.br",
+      }),
+    );
     expect(getManifest()).toEqual({
       assets: {},
       bundleId: "bundle-123",
@@ -481,9 +578,10 @@ describe("notifyAppReady", () => {
     const { getBundleId, updateBundle } = await import("./native");
 
     await updateBundle({
+      assets: {},
       bundleId: "00000000-0000-0000-0000-000000000003",
-      fileHash: null,
-      fileUrl: "https://example.com/bundle.zip",
+      manifestFileHash: "manifest-hash",
+      manifestUrl: "https://example.com/manifest.json",
       status: "UPDATE",
     });
 
@@ -496,9 +594,10 @@ describe("notifyAppReady", () => {
 
     await expect(
       updateBundle({
+        assets: {},
         bundleId: "00000000-0000-0000-0000-000000000003",
-        fileHash: null,
-        fileUrl: "https://example.com/bundle.zip",
+        manifestFileHash: "manifest-hash",
+        manifestUrl: "https://example.com/manifest.json",
         status: "UPDATE",
       }),
     ).resolves.toBe(true);
@@ -522,9 +621,10 @@ describe("notifyAppReady", () => {
     const { updateBundle } = await import("./native");
 
     await updateBundle({
+      assets: {},
       bundleId: "00000000-0000-0000-0000-000000000003",
-      fileHash: null,
-      fileUrl: "https://example.com/bundle.zip",
+      manifestFileHash: "manifest-hash",
+      manifestUrl: "https://example.com/manifest.json",
       status: "UPDATE",
     });
 
@@ -534,9 +634,10 @@ describe("notifyAppReady", () => {
 
     await expect(
       updateBundle({
+        assets: {},
         bundleId: "00000000-0000-0000-0000-000000000003",
-        fileHash: null,
-        fileUrl: "https://example.com/bundle.zip",
+        manifestFileHash: "manifest-hash",
+        manifestUrl: "https://example.com/manifest.json",
         status: "UPDATE",
       }),
     ).resolves.toBe(true);
@@ -552,7 +653,7 @@ describe("notifyAppReady", () => {
 
     await updateBundle({
       bundleId: "bundle-789",
-      changedAssets: {
+      assets: {
         "index.ios.bundle": {
           file: {
             compression: "br",
@@ -568,8 +669,6 @@ describe("notifyAppReady", () => {
           },
         },
       },
-      fileHash: "sig:archive",
-      fileUrl: "https://example.com/bundle.zip",
       manifestFileHash: "sig:manifest",
       manifestUrl: "https://example.com/manifest.json",
       status: "UPDATE",
@@ -577,7 +676,7 @@ describe("notifyAppReady", () => {
 
     expect(nativeModuleMock.updateBundle).toHaveBeenCalledWith({
       bundleId: "bundle-789",
-      changedAssets: {
+      assets: {
         "index.ios.bundle": {
           file: {
             compression: "br",
@@ -594,8 +693,6 @@ describe("notifyAppReady", () => {
         },
       },
       channel: undefined,
-      fileHash: "sig:archive",
-      fileUrl: "https://example.com/bundle.zip",
       manifestFileHash: "sig:manifest",
       manifestUrl: "https://example.com/manifest.json",
     });
@@ -728,6 +825,20 @@ describe("notifyAppReady", () => {
     expect(getInstallId()).toBe("install-123");
   });
 
+  it("normalizes an omitted native fingerprint constant to null", async () => {
+    nativeModuleMock.getConstants.mockReturnValue({
+      APP_VERSION: null,
+      CHANNEL: "production",
+      DEFAULT_CHANNEL: "production",
+      FINGERPRINT_HASH: undefined as unknown as null,
+      MIN_BUNDLE_ID: "min-bundle-id",
+    });
+
+    const { getFingerprintHash } = await import("./native");
+
+    expect(getFingerprintHash()).toBeNull();
+  });
+
   it("throws when native SDK does not expose getInstallId", async () => {
     const nativeModule = nativeModuleMock as typeof nativeModuleMock & {
       getInstallId?: typeof nativeModuleMock.getInstallId;

package/src/native.ts

@@ -1,5 +1,5 @@
 import {
-  type ChangedAsset,
+  type ArtifactAsset,
   type CatalogHighWater,
   INVALID_COHORT_ERROR_MESSAGE,
   isValidCohort,
@@ -234,7 +234,7 @@ const getReloadProcess = (): (() => Promise<void>) | null => {
     : null;
 };
 
-export type HotUpdaterProgressArtifactType = "archive" | "diff";
+export type HotUpdaterProgressArtifactType = "diff";
 
 export type HotUpdaterDiffFileStatus =
   | "pending"
@@ -286,18 +286,11 @@ export interface HotUpdaterDiffProgressDetails {
   files: HotUpdaterDiffFileSnapshot[];
 }
 
-export type HotUpdaterProgressEvent =
-  | {
-      progress: number;
-      artifactType: "archive";
-      downloadedBytes?: number;
-      totalBytes?: number;
-    }
-  | {
-      progress: number;
-      artifactType: "diff";
-      details: HotUpdaterDiffProgressDetails;
-    };
+export type HotUpdaterProgressEvent = {
+  progress: number;
+  artifactType: "diff";
+  details: HotUpdaterDiffProgressDetails;
+};
 
 export type HotUpdaterEvent = {
   onProgress: HotUpdaterProgressEvent;
@@ -434,8 +427,6 @@ export const commitReleaseSelection = async (input: {
 export async function updateBundle(params: UpdateParams): Promise<boolean> {
   const updateBundleId = params.bundleId;
   const status = params.status;
-  const targetFileUrl = params.fileUrl;
-
   const currentBundleId = status === "UPDATE" ? getFreshBundleId() : undefined;
 
   // If native is still on the same bundle we installed in this session,
@@ -467,11 +458,10 @@ export async function updateBundle(params: UpdateParams): Promise<boolean> {
   const existing = sessionState.getInflightUpdate(updateBundleId);
   if (existing) return existing;
 
-  const targetFileHash = params.fileHash;
   const targetChannel = params.channel;
   const targetManifestUrl = params.manifestUrl;
   const targetManifestFileHash = params.manifestFileHash;
-  const targetChangedAssets = params.changedAssets;
+  const targetAssets = params.assets;
 
   const promise = (async () => {
     try {
@@ -479,12 +469,10 @@ export async function updateBundle(params: UpdateParams): Promise<boolean> {
       const ok = await HotUpdaterNative.updateBundle({
         bundleId: updateBundleId,
         channel: targetChannel,
-        changedAssets:
-          (targetChangedAssets as Record<string, ChangedAsset> | null) ?? null,
-        fileUrl: targetFileUrl,
-        fileHash: targetFileHash ?? null,
-        manifestFileHash: targetManifestFileHash ?? null,
-        manifestUrl: targetManifestUrl ?? null,
+        assets: targetAssets as Record<string, ArtifactAsset>,
+        manifestFileHash: targetManifestFileHash,
+        manifestUrl: targetManifestUrl,
+        ...(params.archiveUrl ? { archiveUrl: params.archiveUrl } : {}),
         ...(selection === undefined ? {} : { selection }),
       });
       if (ok) {
@@ -599,8 +587,9 @@ export const getMinBundleId = (): string => {
   return constants.MIN_BUNDLE_ID;
 };
 
-export const getReleaseId = async (): Promise<string | null> =>
-  getActiveUpdateState().activeSelection?.releaseId ?? null;
+/** Returns the selected update ID shown in the console, including staged updates. */
+export const getUpdateId = (): string =>
+  getActiveUpdateState().activeSelection?.releaseId ?? getBundleId();
 
 /**
  * Fetches the current bundle version id.
@@ -687,7 +676,7 @@ export const isChannelSwitched = (): boolean => {
  */
 export const getFingerprintHash = (): string | null => {
   const constants = HotUpdaterNative.getConstants();
-  return constants.FINGERPRINT_HASH;
+  return constants.FINGERPRINT_HASH ?? null;
 };
 
 export const getInstallId = (): string => {
@@ -783,7 +772,7 @@ export type NotifyAppReadyResult =
       toReleaseId?: string;
     };
 
-export type NotifyAppReadyAnalyticsEvent = {
+export type NotifyAppReadyInsightsEvent = {
   type: "UPDATE_APPLIED" | "RECOVERED";
   fromBundleId: string;
   toBundleId: string;
@@ -891,9 +880,9 @@ const getNotifyAppReadyTransition = (
   return null;
 };
 
-const getNotifyAppReadyAnalyticsEvent = (
+const getNotifyAppReadyInsightsEvent = (
   result: RawNotifyAppReadyResult,
-): NotifyAppReadyAnalyticsEvent | null => {
+): NotifyAppReadyInsightsEvent | null => {
   const transition = getNotifyAppReadyTransition(result);
 
   if (!transition || !isPersistedUpdateStrategy(result.updateStrategy)) {
@@ -938,14 +927,14 @@ const normalizeNotifyAppReadyResult = (
 
 export const readNotifyAppReady = (): {
   result: NotifyAppReadyResult;
-  analyticsEvent: NotifyAppReadyAnalyticsEvent | null;
+  insightsEvent: NotifyAppReadyInsightsEvent | null;
   pending: boolean;
 } => {
   const rawResult = readRawNotifyAppReadyResult();
 
   return {
     result: normalizeNotifyAppReadyResult(rawResult),
-    analyticsEvent: getNotifyAppReadyAnalyticsEvent(rawResult),
+    insightsEvent: getNotifyAppReadyInsightsEvent(rawResult),
     pending: rawResult.status === "PENDING",
   };
 };

package/src/{notifyAppReadyAnalytics.boundary.spec.ts → notifyAppReadyInsights.boundary.spec.ts}

@@ -1,13 +1,14 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 
 import type {
-  NotifyAppReadyAnalyticsEvent,
+  ActiveUpdateState,
+  NotifyAppReadyInsightsEvent,
   NotifyAppReadyResult,
 } from "./native";
 import {
   createNotifyReadResult,
   stubNotifyFrame,
-} from "./notifyAppReadyAnalytics.test-utils";
+} from "./notifyAppReadyInsights.test-utils";
 
 const platformState = vi.hoisted((): { OS: "ios" | "android" } => ({
   OS: "ios",
@@ -42,13 +43,14 @@ const mocks = vi.hoisted(() => ({
   getAppVersion: vi.fn<() => string | undefined>(() => "1.0.0"),
   getBundleId: vi.fn<() => string | undefined>(() => "bundle-id"),
   getChannel: vi.fn(() => "production"),
+  getActiveUpdateState: vi.fn<() => ActiveUpdateState>(),
   getCohort: vi.fn(() => "123"),
   getFingerprintHash: vi.fn(() => "fingerprint-hash"),
   getInstallId: vi.fn<() => string | undefined>(() => "install-id"),
   getPersistedUserIdentity: vi.fn(() => ({})),
   readNotifyAppReady: vi.fn<
     () => {
-      analyticsEvent: NotifyAppReadyAnalyticsEvent | null;
+      insightsEvent: NotifyAppReadyInsightsEvent | null;
       pending: boolean;
       result: NotifyAppReadyResult;
     }
@@ -65,6 +67,7 @@ vi.mock("./native", () => ({
   getAppVersion: mocks.getAppVersion,
   getBundleId: mocks.getBundleId,
   getChannel: mocks.getChannel,
+  getActiveUpdateState: mocks.getActiveUpdateState,
   getCohort: mocks.getCohort,
   getFingerprintHash: mocks.getFingerprintHash,
   getInstallId: mocks.getInstallId,
@@ -78,20 +81,20 @@ vi.mock("./specs/NativeHotUpdater", () => ({
 }));
 
 const createClient = () => {
-  const sendAnalyticsEvent = vi.fn().mockResolvedValue(undefined);
+  const sendInsightsEvent = vi.fn().mockResolvedValue(undefined);
   return {
     client: {
       createSession: vi.fn(async () => ({
         fetchReleaseCatalog: vi.fn(),
         resolveArtifact: vi.fn(),
-        sendAnalyticsEvent,
+        sendInsightsEvent,
       })),
     },
-    sendAnalyticsEvent,
+    sendInsightsEvent,
   };
 };
 
-describe("automatic notifyAppReady analytics boundaries", () => {
+describe("automatic notifyAppReady insights boundaries", () => {
   beforeEach(() => {
     vi.resetModules();
     vi.unstubAllGlobals();
@@ -106,6 +109,11 @@ describe("automatic notifyAppReady analytics boundaries", () => {
     mocks.getAppVersion.mockReturnValue("1.0.0");
     mocks.getBundleId.mockReturnValue("bundle-id");
     mocks.getChannel.mockReturnValue("production");
+    mocks.getActiveUpdateState.mockReturnValue({
+      activeSelection: null,
+      stableSelection: null,
+      verificationPending: false,
+    });
     mocks.getCohort.mockReturnValue("123");
     mocks.getFingerprintHash.mockReturnValue("fingerprint-hash");
     mocks.getInstallId.mockReturnValue("install-id");
@@ -124,7 +132,7 @@ describe("automatic notifyAppReady analytics boundaries", () => {
     const { init } = await import("./wrap");
 
     init({
-      analytics: true,
+      insights: true,
       client: {
         createSession: vi.fn(async () => {
           throw new Error("baseURL unavailable");
@@ -138,7 +146,7 @@ describe("automatic notifyAppReady analytics boundaries", () => {
     expect(onError).not.toHaveBeenCalled();
     expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
     expect(warn).toHaveBeenCalledWith(
-      "[HotUpdater] Automatic notifyAppReady analytics failed:",
+      "[HotUpdater] Automatic notifyAppReady insights failed:",
       expect.objectContaining({
         message: "baseURL unavailable",
       }),
@@ -163,17 +171,17 @@ describe("automatic notifyAppReady analytics boundaries", () => {
       } else {
         mocks.getInstallId.mockReturnValue(value);
       }
-      const { client, sendAnalyticsEvent } = createClient();
+      const { client, sendInsightsEvent } = createClient();
       const { init } = await import("./wrap");
 
-      init({ analytics: true, client, onError, onNotifyAppReady });
+      init({ insights: true, client, onError, onNotifyAppReady });
       await vi.runOnlyPendingTimersAsync();
 
-      expect(sendAnalyticsEvent).not.toHaveBeenCalled();
+      expect(sendInsightsEvent).not.toHaveBeenCalled();
       expect(onError).not.toHaveBeenCalled();
       expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
       expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady analytics failed:",
+        "[HotUpdater] Automatic notifyAppReady insights failed:",
         expect.any(Error),
       );
       warn.mockRestore();
@@ -197,17 +205,17 @@ describe("automatic notifyAppReady analytics boundaries", () => {
       } else {
         mocks.getBundleId.mockReturnValue(value);
       }
-      const { client, sendAnalyticsEvent } = createClient();
+      const { client, sendInsightsEvent } = createClient();
       const { init } = await import("./wrap");
 
-      init({ analytics: true, client, onError, onNotifyAppReady });
+      init({ insights: true, client, onError, onNotifyAppReady });
       await vi.runOnlyPendingTimersAsync();
 
-      expect(sendAnalyticsEvent).not.toHaveBeenCalled();
+      expect(sendInsightsEvent).not.toHaveBeenCalled();
       expect(onError).not.toHaveBeenCalled();
       expect(onNotifyAppReady).toHaveBeenCalledWith({ status: "UNCHANGED" });
       expect(warn).toHaveBeenCalledWith(
-        "[HotUpdater] Automatic notifyAppReady analytics failed:",
+        "[HotUpdater] Automatic notifyAppReady insights failed:",
         expect.any(Error),
       );
       warn.mockRestore();