@hot-updater/console 1.0.0-rc.9 → 1.0.0

package/src/components/features/remote-config/ConditionsCard.tsx

@@ -0,0 +1,247 @@
+import {
+  ArrowDown,
+  ArrowUp,
+  GitBranch,
+  Pencil,
+  Plus,
+  Trash2,
+} from "lucide-react";
+import { type MouseEvent, useState } from "react";
+
+import {
+  AlertDialog,
+  AlertDialogAction,
+  AlertDialogCancel,
+  AlertDialogContent,
+  AlertDialogDescription,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogTitle,
+} from "@/components/ui/alert-dialog";
+import { Button } from "@/components/ui/button";
+import {
+  Card,
+  CardContent,
+  CardDescription,
+  CardHeader,
+  CardTitle,
+} from "@/components/ui/card";
+import {
+  Empty,
+  EmptyContent,
+  EmptyDescription,
+  EmptyHeader,
+  EmptyMedia,
+  EmptyTitle,
+} from "@/components/ui/empty";
+import {
+  parametersUsing,
+  type RemoteConfigCondition,
+  type RemoteConfigTemplate,
+} from "@/lib/remote-config-draft";
+import { useDialogTarget } from "@/lib/use-dialog-target";
+
+import { ConditionDialog } from "./ConditionDialog";
+import { RuleSummary } from "./RuleSummary";
+import { useDateTimeText } from "./useDateTimeText";
+
+/** The draft's conditions in priority order: the first match decides a value. */
+export function ConditionsCard({
+  template,
+  onSaveCondition,
+  onRemoveCondition,
+  onMoveCondition,
+}: {
+  readonly template: RemoteConfigTemplate;
+  readonly onSaveCondition: (
+    previousName: string | null,
+    condition: RemoteConfigCondition,
+  ) => void;
+  readonly onRemoveCondition: (name: string) => void;
+  readonly onMoveCondition: (index: number, offset: -1 | 1) => void;
+}) {
+  // What each dialog shows is taken when it opens, so it holds still while
+  // it animates closed after the draft changed.
+  const [editing, setEditing] = useState<{
+    readonly condition: RemoteConfigCondition | null;
+  } | null>(null);
+  const [removing, setRemoving] = useState<{
+    readonly name: string;
+    readonly users: readonly string[];
+  } | null>(null);
+  const shownEditing = useDialogTarget(editing);
+  const shownRemoving = useDialogTarget(removing);
+  const { dateTimeText } = useDateTimeText();
+  const { conditions } = template;
+  const editingName = shownEditing?.condition?.name ?? null;
+
+  const remove = (name: string) => {
+    const users = parametersUsing(template, name);
+    if (users.length === 0) onRemoveCondition(name);
+    else setRemoving({ name, users });
+  };
+
+  return (
+    <Card className="overflow-hidden shadow-sm">
+      <CardHeader className="flex-row flex-wrap items-center justify-between gap-3 space-y-0 border-b px-4 py-3 sm:px-6">
+        <div className="min-w-0">
+          <CardTitle className="text-sm">
+            <h2>Conditions</h2>
+          </CardTitle>
+          <CardDescription className="text-xs">
+            Listed by priority: when several match a device, the first wins.
+          </CardDescription>
+        </div>
+        <Button
+          className="min-h-11 sm:min-h-7"
+          onClick={() => setEditing({ condition: null })}
+        >
+          <Plus data-icon="inline-start" />
+          Add condition
+        </Button>
+      </CardHeader>
+      <CardContent className="p-0">
+        {conditions.length === 0 ? (
+          <Empty className="py-10">
+            <EmptyHeader>
+              <EmptyMedia variant="icon">
+                <GitBranch />
+              </EmptyMedia>
+              <EmptyTitle>No conditions</EmptyTitle>
+              <EmptyDescription>
+                Add a condition to give some devices other values: a platform,
+                channel, app version range, cohort, or a share of installs.
+              </EmptyDescription>
+            </EmptyHeader>
+            <EmptyContent>
+              <Button
+                className="min-h-11 sm:min-h-7"
+                onClick={() => setEditing({ condition: null })}
+              >
+                <Plus data-icon="inline-start" />
+                Add condition
+              </Button>
+            </EmptyContent>
+          </Empty>
+        ) : (
+          <ol aria-label="Conditions" className="divide-y">
+            {conditions.map((condition, index) => {
+              const users = parametersUsing(template, condition.name);
+              return (
+                <li
+                  className="grid gap-3 px-4 py-3 sm:px-6 md:grid-cols-[auto_minmax(0,1fr)_auto] md:items-center"
+                  key={condition.name}
+                >
+                  <span
+                    aria-label={`Priority ${index + 1}`}
+                    className="flex size-6 items-center justify-center rounded-md bg-muted text-xs font-medium tabular-nums"
+                  >
+                    {index + 1}
+                  </span>
+                  <div className="min-w-0">
+                    <p className="truncate text-sm font-medium">
+                      {condition.name}
+                    </p>
+                    <RuleSummary
+                      condition={condition}
+                      dateTimeText={dateTimeText}
+                    />
+                    <p className="mt-1 text-xs text-muted-foreground">
+                      {users.length === 0
+                        ? "No parameter uses it yet"
+                        : `Sets ${users.length === 1 ? "1 parameter" : `${users.length} parameters`}: ${users.slice(0, 3).join(", ")}${users.length > 3 ? "…" : ""}`}
+                    </p>
+                  </div>
+                  <div className="flex flex-wrap gap-1 md:justify-end">
+                    <Button
+                      aria-label={`Move ${condition.name} up`}
+                      className="size-11 md:size-7"
+                      disabled={index === 0}
+                      onClick={() => onMoveCondition(index, -1)}
+                      size="icon"
+                      variant="ghost"
+                    >
+                      <ArrowUp />
+                    </Button>
+                    <Button
+                      aria-label={`Move ${condition.name} down`}
+                      className="size-11 md:size-7"
+                      disabled={index === conditions.length - 1}
+                      onClick={() => onMoveCondition(index, 1)}
+                      size="icon"
+                      variant="ghost"
+                    >
+                      <ArrowDown />
+                    </Button>
+                    <Button
+                      aria-label={`Edit ${condition.name}`}
+                      className="min-h-11 md:min-h-7"
+                      onClick={() => setEditing({ condition })}
+                      size="sm"
+                      variant="outline"
+                    >
+                      <Pencil data-icon="inline-start" />
+                      Edit
+                    </Button>
+                    <Button
+                      aria-label={`Delete ${condition.name}`}
+                      className="size-11 md:size-7"
+                      onClick={() => remove(condition.name)}
+                      size="icon"
+                      variant="ghost"
+                    >
+                      <Trash2 />
+                    </Button>
+                  </div>
+                </li>
+              );
+            })}
+          </ol>
+        )}
+      </CardContent>
+      <ConditionDialog
+        condition={shownEditing?.condition ?? null}
+        onOpenChange={(open) => {
+          if (!open) setEditing(null);
+        }}
+        onSave={(condition) => onSaveCondition(editingName, condition)}
+        open={editing !== null}
+        takenNames={conditions
+          .map(({ name }) => name)
+          .filter((name) => name !== editingName)}
+      />
+      <AlertDialog
+        onOpenChange={(open) => {
+          if (!open) setRemoving(null);
+        }}
+        open={removing !== null}
+      >
+        <AlertDialogContent>
+          <AlertDialogHeader>
+            <AlertDialogTitle>Delete {shownRemoving?.name}?</AlertDialogTitle>
+            <AlertDialogDescription>
+              {shownRemoving?.users.length === 1
+                ? "1 parameter has a value for it"
+                : `${shownRemoving?.users.length} parameters have a value for it`}{" "}
+              ({shownRemoving?.users.join(", ")}). Those values are removed too,
+              so matching devices get the default value after you publish.
+            </AlertDialogDescription>
+          </AlertDialogHeader>
+          <AlertDialogFooter>
+            <AlertDialogCancel>Cancel</AlertDialogCancel>
+            <AlertDialogAction
+              onClick={(event: MouseEvent<HTMLButtonElement>) => {
+                event.preventDefault();
+                if (removing !== null) onRemoveCondition(removing.name);
+                setRemoving(null);
+              }}
+              variant="destructive"
+            >
+              Delete condition
+            </AlertDialogAction>
+          </AlertDialogFooter>
+        </AlertDialogContent>
+      </AlertDialog>
+    </Card>
+  );
+}

package/src/components/features/remote-config/ParameterDialog.tsx

@@ -0,0 +1,426 @@
+import { Plus, X } from "lucide-react";
+import { type FormEvent, useId, useState } from "react";
+
+import { Button } from "@/components/ui/button";
+import {
+  Dialog,
+  DialogContent,
+  DialogDescription,
+  DialogFooter,
+  DialogHeader,
+  DialogTitle,
+} from "@/components/ui/dialog";
+import {
+  Field,
+  FieldDescription,
+  FieldError,
+  FieldGroup,
+  FieldLabel,
+  FieldLegend,
+  FieldSet,
+} from "@/components/ui/field";
+import { Input } from "@/components/ui/input";
+import {
+  Select,
+  SelectContent,
+  SelectGroup,
+  SelectItem,
+  SelectTrigger,
+  SelectValue,
+} from "@/components/ui/select";
+import {
+  conditionalValueFor,
+  parameterKeyError,
+  type RemoteConfigCondition,
+  type RemoteConfigParameter,
+  type RemoteConfigParameterValue,
+  type RemoteConfigValueType,
+  VALUE_TYPE_LABELS,
+} from "@/lib/remote-config-draft";
+import { useOpenSession } from "@/lib/use-dialog-target";
+
+import { ConditionDialog } from "./ConditionDialog";
+import { RuleSummary } from "./RuleSummary";
+import { useDateTimeText } from "./useDateTimeText";
+import {
+  initialValueText,
+  parameterValueError,
+  ValueInput,
+} from "./ValueInput";
+
+const VALUE_TYPES = Object.keys(VALUE_TYPE_LABELS) as RemoteConfigValueType[];
+
+/** How the app reads a value of each type; JSON arrives as text to parse. */
+const READ_METHODS: Readonly<Record<RemoteConfigValueType, string>> = {
+  STRING: "getString",
+  NUMBER: "getNumber",
+  BOOLEAN: "getBoolean",
+  JSON: "getString",
+};
+
+/** A value converted to another type: kept when it still fits, reset when not. */
+const retype = (
+  value: RemoteConfigParameterValue,
+  valueType: RemoteConfigValueType,
+): RemoteConfigParameterValue =>
+  "value" in value && parameterValueError(valueType, value) !== null
+    ? { value: initialValueText(valueType) }
+    : value;
+
+/**
+ * Adds or edits a parameter: its key, type, default value, and a value for
+ * any of the template's conditions, which it can also add on the spot.
+ */
+export function ParameterDialog({
+  open,
+  onOpenChange,
+  parameterKey,
+  parameter,
+  takenKeys,
+  conditions,
+  onSave,
+  onAddCondition,
+}: {
+  readonly open: boolean;
+  readonly onOpenChange: (open: boolean) => void;
+  /** The key of the parameter to edit, or null for a new one. */
+  readonly parameterKey: string | null;
+  readonly parameter: RemoteConfigParameter | null;
+  readonly takenKeys: readonly string[];
+  readonly conditions: readonly RemoteConfigCondition[];
+  readonly onSave: (key: string, parameter: RemoteConfigParameter) => void;
+  readonly onAddCondition: (condition: RemoteConfigCondition) => void;
+}) {
+  // The form stays while the dialog animates closed, and starts over on
+  // each opening.
+  const session = useOpenSession(open);
+  return (
+    <Dialog onOpenChange={onOpenChange} open={open}>
+      <DialogContent className="max-h-[calc(100svh-2rem)] overflow-y-auto data-nested-dialog-open:after:absolute data-nested-dialog-open:after:inset-0 data-nested-dialog-open:after:rounded-xl data-nested-dialog-open:after:bg-background/70 sm:max-w-2xl">
+        <ParameterForm
+          conditions={conditions}
+          key={session}
+          onAddCondition={onAddCondition}
+          onCancel={() => onOpenChange(false)}
+          onSave={(key, next) => {
+            onSave(key, next);
+            onOpenChange(false);
+          }}
+          parameter={parameter}
+          parameterKey={parameterKey}
+          takenKeys={takenKeys}
+        />
+      </DialogContent>
+    </Dialog>
+  );
+}
+
+function ParameterForm({
+  parameterKey,
+  parameter,
+  takenKeys,
+  conditions,
+  onSave,
+  onCancel,
+  onAddCondition,
+}: {
+  readonly parameterKey: string | null;
+  readonly parameter: RemoteConfigParameter | null;
+  readonly takenKeys: readonly string[];
+  readonly conditions: readonly RemoteConfigCondition[];
+  readonly onSave: (key: string, parameter: RemoteConfigParameter) => void;
+  readonly onCancel: () => void;
+  readonly onAddCondition: (condition: RemoteConfigCondition) => void;
+}) {
+  const id = useId();
+  const { dateTimeText } = useDateTimeText();
+  const [key, setKey] = useState(parameterKey ?? "");
+  const [valueType, setValueType] = useState<RemoteConfigValueType>(
+    parameter?.valueType ?? "STRING",
+  );
+  const [description, setDescription] = useState(parameter?.description ?? "");
+  // Saved trimmed, as the server stores it.
+  const descriptionTooLong = description.trim().length > 256;
+  const [defaultValue, setDefaultValue] = useState<RemoteConfigParameterValue>(
+    parameter?.defaultValue ?? { value: "" },
+  );
+  const [conditionalValues, setConditionalValues] = useState<
+    Readonly<Record<string, RemoteConfigParameterValue>>
+  >(parameter?.conditionalValues ?? {});
+  // Values removed in this edit, so a condition added back gets its value
+  // again instead of an empty one.
+  const [removedValues, setRemovedValues] = useState<
+    Readonly<Record<string, RemoteConfigParameterValue>>
+  >({});
+  const [submitted, setSubmitted] = useState(false);
+  const [addingCondition, setAddingCondition] = useState(false);
+
+  const keyError = parameterKeyError(key.trim(), takenKeys);
+  const valued = conditions.filter(
+    ({ name }) => conditionalValueFor(conditionalValues, name) !== undefined,
+  );
+  const unvalued = conditions.filter(
+    ({ name }) => conditionalValueFor(conditionalValues, name) === undefined,
+  );
+  const invalid =
+    keyError !== null ||
+    descriptionTooLong ||
+    [defaultValue, ...Object.values(conditionalValues)].some(
+      (value) => parameterValueError(valueType, value) !== null,
+    );
+
+  const changeType = (next: RemoteConfigValueType) => {
+    setValueType(next);
+    setDefaultValue(retype(defaultValue, next));
+    setConditionalValues(
+      Object.fromEntries(
+        Object.entries(conditionalValues).map(([name, value]) => [
+          name,
+          retype(value, next),
+        ]),
+      ),
+    );
+  };
+
+  const addValueFor = (name: string) => {
+    const removed = conditionalValueFor(removedValues, name);
+    setConditionalValues({
+      ...conditionalValues,
+      [name]:
+        removed === undefined
+          ? { value: initialValueText(valueType) }
+          : retype(removed, valueType),
+    });
+  };
+
+  const removeValueFor = (name: string) => {
+    const { [name]: removed, ...rest } = conditionalValues;
+    if (removed !== undefined) {
+      setRemovedValues({ ...removedValues, [name]: removed });
+    }
+    setConditionalValues(rest);
+  };
+
+  const submit = (event: FormEvent<HTMLFormElement>) => {
+    event.preventDefault();
+    setSubmitted(true);
+    if (invalid) return;
+    const kept = Object.fromEntries(
+      valued.map(({ name }) => [
+        name,
+        conditionalValueFor(conditionalValues, name)!,
+      ]),
+    );
+    onSave(key.trim(), {
+      valueType,
+      defaultValue,
+      ...(Object.keys(kept).length === 0 ? {} : { conditionalValues: kept }),
+      ...(description.trim().length === 0
+        ? {}
+        : { description: description.trim() }),
+    });
+  };
+
+  return (
+    <>
+      <form className="flex flex-col gap-4" noValidate onSubmit={submit}>
+        <DialogHeader>
+          <DialogTitle>
+            {parameterKey === null ? "Add parameter" : "Edit parameter"}
+          </DialogTitle>
+          <DialogDescription>
+            The app reads it with{" "}
+            <code className="font-mono">
+              hotUpdater.remoteConfig.{READ_METHODS[valueType]}("
+              {key.trim() || "key"}")
+            </code>
+            , which is null when neither the server nor the app's defaults have
+            a value.
+          </DialogDescription>
+        </DialogHeader>
+        <FieldGroup>
+          <div className="grid gap-4 sm:grid-cols-[minmax(0,1fr)_11rem]">
+            <Field data-invalid={(submitted && keyError !== null) || undefined}>
+              <FieldLabel htmlFor={`${id}-key`}>Key</FieldLabel>
+              <Input
+                autoComplete="off"
+                className="min-h-11 font-mono sm:min-h-9"
+                id={`${id}-key`}
+                maxLength={257}
+                onChange={(event) => setKey(event.target.value)}
+                placeholder="welcome_message"
+                spellCheck={false}
+                value={key}
+              />
+              <FieldError>{submitted ? keyError : null}</FieldError>
+            </Field>
+            <Field>
+              <FieldLabel htmlFor={`${id}-type`}>Type</FieldLabel>
+              <Select
+                items={VALUE_TYPE_LABELS}
+                onValueChange={(value) => {
+                  if (value !== null)
+                    changeType(value as RemoteConfigValueType);
+                }}
+                value={valueType}
+              >
+                <SelectTrigger
+                  className="min-h-11 w-full sm:min-h-9"
+                  id={`${id}-type`}
+                >
+                  <SelectValue />
+                </SelectTrigger>
+                <SelectContent>
+                  <SelectGroup>
+                    {VALUE_TYPES.map((type) => (
+                      <SelectItem key={type} value={type}>
+                        {VALUE_TYPE_LABELS[type]}
+                      </SelectItem>
+                    ))}
+                  </SelectGroup>
+                </SelectContent>
+              </Select>
+            </Field>
+          </div>
+          <Field data-invalid={descriptionTooLong || undefined}>
+            <FieldLabel htmlFor={`${id}-description`}>Description</FieldLabel>
+            <Input
+              autoComplete="off"
+              className="min-h-11 sm:min-h-9"
+              id={`${id}-description`}
+              onChange={(event) => setDescription(event.target.value)}
+              placeholder="Optional: what the app does with it"
+              value={description}
+            />
+            <FieldError>
+              {descriptionTooLong ? "Use 256 characters or fewer." : null}
+            </FieldError>
+          </Field>
+          <ValueInput
+            id={`${id}-default`}
+            label="Default value"
+            onChange={setDefaultValue}
+            showErrors={submitted}
+            value={defaultValue}
+            valueType={valueType}
+          />
+          <FieldSet>
+            <FieldLegend variant="label">Conditional values</FieldLegend>
+            <FieldDescription>
+              Devices that match a condition get its value. When several match,
+              the first in the Conditions list wins. Removing a value keeps the
+              condition, and its devices get the default value.
+            </FieldDescription>
+            {valued.length > 0 ? (
+              <ul className="flex flex-col gap-3">
+                {valued.map((condition) => (
+                  <li className="rounded-lg border p-3" key={condition.name}>
+                    <div className="mb-2 flex items-start justify-between gap-2">
+                      <div className="min-w-0">
+                        <p className="truncate text-sm font-medium">
+                          {condition.name}
+                        </p>
+                        <RuleSummary
+                          condition={condition}
+                          dateTimeText={dateTimeText}
+                        />
+                      </div>
+                      <Button
+                        aria-label={`Remove the value for ${condition.name}`}
+                        className="min-h-11 shrink-0 text-muted-foreground sm:min-h-7"
+                        onClick={() => removeValueFor(condition.name)}
+                        size="sm"
+                        type="button"
+                        variant="ghost"
+                      >
+                        <X data-icon="inline-start" />
+                        Remove value
+                      </Button>
+                    </div>
+                    <ValueInput
+                      id={`${id}-${condition.name}`}
+                      label={
+                        <>
+                          Value
+                          <span className="sr-only"> for {condition.name}</span>
+                        </>
+                      }
+                      onChange={(value) =>
+                        setConditionalValues({
+                          ...conditionalValues,
+                          [condition.name]: value,
+                        })
+                      }
+                      showErrors={submitted}
+                      value={
+                        conditionalValueFor(conditionalValues, condition.name)!
+                      }
+                      valueType={valueType}
+                    />
+                  </li>
+                ))}
+              </ul>
+            ) : null}
+            <div className="flex flex-wrap gap-2">
+              {unvalued.length > 0 ? (
+                <Select
+                  items={Object.fromEntries(
+                    unvalued.map(({ name }) => [name, name]),
+                  )}
+                  onValueChange={(value) => {
+                    if (value !== null) addValueFor(value);
+                  }}
+                  value={null}
+                >
+                  <SelectTrigger
+                    aria-label="Add a value for a condition"
+                    className="min-h-11 w-full sm:min-h-9 sm:w-64"
+                  >
+                    <Plus aria-hidden="true" className="size-3.5" />
+                    <SelectValue placeholder="Add a value for a condition" />
+                  </SelectTrigger>
+                  <SelectContent alignItemWithTrigger={false}>
+                    <SelectGroup>
+                      {unvalued.map(({ name }) => (
+                        <SelectItem key={name} value={name}>
+                          {name}
+                        </SelectItem>
+                      ))}
+                    </SelectGroup>
+                  </SelectContent>
+                </Select>
+              ) : null}
+              <Button
+                className="min-h-11 sm:min-h-9"
+                onClick={() => setAddingCondition(true)}
+                type="button"
+                variant="outline"
+              >
+                <Plus data-icon="inline-start" />
+                New condition
+              </Button>
+            </div>
+          </FieldSet>
+        </FieldGroup>
+        <DialogFooter>
+          <Button onClick={onCancel} type="button" variant="outline">
+            Cancel
+          </Button>
+          <Button type="submit">
+            {parameterKey === null ? "Add parameter" : "Save parameter"}
+          </Button>
+        </DialogFooter>
+      </form>
+      <ConditionDialog
+        condition={null}
+        onOpenChange={setAddingCondition}
+        onSave={(condition) => {
+          onAddCondition(condition);
+          addValueFor(condition.name);
+        }}
+        open={addingCondition}
+        takenNames={conditions.map(({ name }) => name)}
+      />
+    </>
+  );
+}