@hopla/claude-setup 1.8.0 → 1.8.1

package/cli.js

@@ -80,6 +80,14 @@ async function uninstall() {
         fs.statSync(path.join(FILES_DIR, "commands", f)).isDirectory()
     );
 
+    // Also include any hopla-* files in ~/.claude/commands/ not in current source
+    // (leftovers from previous versions)
+    const installedHoplaFiles = fs.existsSync(COMMANDS_DIR)
+        ? fs.readdirSync(COMMANDS_DIR).filter((f) =>
+            f.startsWith("hopla-") && fs.statSync(path.join(COMMANDS_DIR, f)).isFile() && !srcFiles.includes(f)
+        )
+        : [];
+
     const itemsToRemove = [
         { dest: path.join(CLAUDE_DIR, "CLAUDE.md"), label: "~/.claude/CLAUDE.md", isDir: false },
         ...srcFiles.map((file) => ({
@@ -87,6 +95,11 @@ async function uninstall() {
             label: `~/.claude/commands/${file}`,
             isDir: false,
         })),
+        ...installedHoplaFiles.map((file) => ({
+            dest: path.join(COMMANDS_DIR, file),
+            label: `~/.claude/commands/${file}`,
+            isDir: false,
+        })),
         ...srcDirs.map((dir) => ({
             dest: path.join(COMMANDS_DIR, dir),
             label: `~/.claude/commands/${dir}/`,
@@ -149,7 +162,6 @@ function removeStaleCommands(currentCommandFiles) {
 
 const PLANNING_COMMANDS = [
     "hopla-init-project.md",
-    "hopla-prime.md",
     "hopla-create-prd.md",
     "hopla-plan-feature.md",
     "hopla-review-plan.md",

package/files/skills/hopla-code-review/SKILL.md

@@ -89,3 +89,8 @@ If no issues found: "Code review passed. No technical issues detected."
 - Focus on real bugs, not style preferences (linting handles that)
 - Flag security issues as `critical`
 - Suggest fixes, don't just identify problems
+
+## Next Step
+
+After the review, suggest:
+> "Code review saved to `.agents/code-reviews/[name].md`. If issues were found, run `/hopla-code-review-fix .agents/code-reviews/[name].md` to fix them. If the review passed clean, proceed to `/hopla-execution-report`."

package/files/skills/hopla-execution-report/SKILL.md

@@ -110,3 +110,8 @@ Based on this implementation, what should change for next time?
 - Plan command improvements: [suggestions]
 - Execute command improvements: [suggestions]
 - CLAUDE.md additions: [suggestions]
+
+## Next Step
+
+After the report is saved, suggest:
+> "Execution report saved to `.agents/execution-reports/[name].md`. Run `/hopla-git-commit` to commit your changes."

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hopla/claude-setup",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "Hopla team agentic coding system for Claude Code",
   "type": "module",
   "bin": {

package/files/commands/hopla-code-review.md

@@ -1,96 +0,0 @@
----
-description: Technical code review on recently changed files
-argument-hint: "[optional: branch or commit range, defaults to HEAD]"
----
-
-> 🌐 **Language:** All user-facing output must match the user's language. Code, paths, and commands stay in English.
-
-Perform a technical code review focused on finding real bugs and issues.
-
-## Step 1: Load Context
-
-Read `CLAUDE.md` or `AGENTS.md` to understand project standards and patterns.
-
-If `.agents/guides/` exists, read any guides relevant to the files being reviewed (e.g. `@.agents/guides/api-guide.md` when reviewing API changes). These guides define the expected patterns for specific task types.
-
-If `.agents/guides/review-checklist.md` exists, read it and apply the project-specific checks it defines in addition to the standard checks below. Project-specific checklists cover framework gotchas and domain anti-patterns unique to the project (e.g., AG Grid stale closures, Hono route ordering).
-
-## Step 2: Identify Changed Files
-
-```bash
-git diff --stat HEAD
-git diff HEAD
-git ls-files --others --exclude-standard
-```
-
-Read each changed or new file in its entirety — not just the diff.
-
-## Step 3: Analyze for Issues
-
-For each changed file, look for:
-
-**1. Logic Errors**
-- Off-by-one errors, incorrect conditionals
-- Missing error handling, unhandled edge cases
-- Race conditions or async issues
-- Stale closures — callbacks passed to imperative APIs (grids, charts, maps) that capture stale state instead of using refs or stable references
-- Unhandled promise rejections — `.then()` without `.catch()`, async calls without `try/catch` in non-void contexts
-- Side effects inside JSX render — mutations of arrays/objects inside `.map()` in JSX (breaks React strict mode, causes double-execution bugs)
-
-**2. Security Issues**
-- Exposed secrets or API keys
-- SQL/command injection vulnerabilities
-- Missing input validation on API endpoints — required fields, format constraints (regex, length), payload size limits
-- Insecure data handling — raw user input in queries, responses exposing internal data or stack traces
-- XSS vulnerabilities (frontend)
-
-**3. Performance Problems**
-- Unnecessary re-renders (React)
-- N+1 queries or redundant API calls
-- Memory leaks
-
-**4. Code Quality**
-- DRY violations — before flagging, search for similar functions/constants elsewhere in the codebase; suggest extraction to a shared module if the same logic exists in multiple places
-- Poor naming or overly complex functions
-- Missing TypeScript types or `any` usage
-
-**5. Pattern Adherence**
-- Follows project conventions from CLAUDE.md
-- Consistent with existing codebase style
-
-**6. Route & Middleware Ordering**
-- Static routes defined AFTER parameterized routes (e.g., `/users/all` after `/users/:id`) causing shadowing — the parameterized route captures requests meant for the static one
-- Middleware applied in incorrect order (e.g., auth after route handler, CORS after response sent)
-
-## Step 4: Verify Issues Are Real
-
-Before reporting, confirm each issue is legitimate:
-- Run relevant tests if applicable
-- Check if the pattern is intentional based on context
-
-## Step 5: Output Report
-
-Save to `.agents/code-reviews/[descriptive-name].md`
-
-**Format for each issue:**
-```
-severity: critical | high | medium | low
-file: path/to/file.ts
-line: 42
-issue: [one-line description]
-detail: [why this is a problem]
-suggestion: [how to fix it]
-```
-
-If no issues found: "Code review passed. No technical issues detected."
-
-**Rules:**
-- Be specific — line numbers, not vague complaints
-- Focus on real bugs, not style preferences (linting handles that)
-- Flag security issues as `critical`
-- Suggest fixes, don't just identify problems
-
-## Next Step
-
-After the review, suggest:
-> "Code review saved to `.agents/code-reviews/[name].md`. If issues were found, run `/hopla-code-review-fix .agents/code-reviews/[name].md` to fix them. If the review passed clean, proceed to `/hopla-execution-report`."

package/files/commands/hopla-execution-report.md

@@ -1,116 +0,0 @@
----
-description: Generate an implementation report for system review
----
-
-> 🌐 **Language:** All user-facing output must match the user's language. Code, paths, and commands stay in English.
-
-Review and document the implementation you just completed. Run this immediately after finishing a feature — before committing or starting the next task.
-
-## Step 1: Gather Implementation Data
-
-```bash
-git diff HEAD --stat
-git diff HEAD
-git ls-files --others --exclude-standard
-```
-
-Also check for recent code reviews:
-
-```bash
-ls -t .agents/code-reviews/ 2>/dev/null | head -5
-```
-
-If a code review exists for this feature, note its path for the Code Review Findings section below.
-
-## Step 2: Generate Report
-
-Save to: `.agents/execution-reports/[feature-name].md`
-
-Use the following structure:
-
----
-
-### Meta Information
-
-- **Plan file:** [path to the plan that guided this implementation]
-- **Files added:** [list with paths]
-- **Files modified:** [list with paths]
-- **Lines changed:** +X -Y
-
-### Validation Results
-
-- Syntax & Linting: ✓/✗ [details if failed]
-- Type Checking: ✓/✗ [details if failed]
-- Unit Tests: ✓/✗ [X passed, Y failed]
-- Integration Tests: ✓/✗ [X passed, Y failed]
-
-### Code Review Findings
-
-- **Code review file:** [path to `.agents/code-reviews/[name].md`, or "Not run"]
-- **Issues found:** [count by severity: X critical, Y high, Z medium, W low]
-- **Issues fixed before this report:** [count]
-- **Key findings:** [1-2 sentence summary of the most significant issues found]
-
-### What Went Well
-
-List specific things that worked smoothly:
-- [concrete examples]
-
-### Challenges Encountered
-
-List specific difficulties encountered:
-- [what was difficult and why]
-
-### Bugs Encountered
-
-Categorize each bug found during implementation:
-
-| Bug | Category | Found By | Severity |
-|-----|----------|----------|----------|
-| [description] | stale closure / validation / race condition / styling / scope mismatch / type error / route ordering / other | lint / types / tests / code review / manual testing | critical / high / medium / low |
-
-If no bugs were encountered, write "No bugs encountered during implementation."
-
-### Divergences from Plan
-
-For each divergence from the original plan:
-
-**[Divergence Title]**
-- **Planned:** [what the plan specified]
-- **Actual:** [what was implemented instead]
-- **Reason:** [why this divergence occurred]
-- **Type:** Better approach found | Plan assumption wrong | Security concern | Performance issue | Other
-
-### Scope Assessment
-
-- **Planned tasks:** [number of tasks in the original plan]
-- **Executed tasks:** [number of tasks actually completed]
-- **Unplanned additions:** [count and brief description of work not in the original plan]
-- **Scope accuracy:** On target | Under-scoped (took more work than planned) | Over-scoped (simpler than expected)
-
-### Skipped Items
-
-List anything from the plan that was not implemented:
-- [what was skipped] — Reason: [why]
-
-### Technical Patterns Discovered
-
-New gotchas, patterns, or conventions learned during this implementation that should be documented:
-
-- **Pattern/Gotcha:** [description]
-- **Where it applies:** [what type of feature or context triggers this]
-- **Suggested documentation:** [which file should capture this: CLAUDE.md, `.agents/guides/review-checklist.md`, or a new guide]
-
-If nothing new was discovered, write "No new patterns discovered."
-
-### Recommendations
-
-Based on this implementation, what should change for next time?
-- Plan command improvements: [suggestions]
-- Execute command improvements: [suggestions]
-- CLAUDE.md additions: [suggestions]
-
-## Next Step
-
-After the report is saved, suggest:
-> "Execution report saved to `.agents/execution-reports/[name].md`. Run `/hopla-git-commit` to commit your changes."

package/files/commands/hopla-prime.md

@@ -1,60 +0,0 @@
----
-description: Load project context at the start of a session
----
-
-> 🌐 **Language:** All user-facing output must match the user's language. Code, paths, and commands stay in English.
-
-Get oriented in this project before doing any work.
-
-## Step 1: Project Structure
-
-Use the Glob tool to list project files (up to 60):
-- Pattern: `**/*` with head_limit: 60
-
-Use the Glob tool to find key config files:
-- `**/CLAUDE.md`
-- `**/AGENTS.md`
-- `**/README.md`
-
-## Step 2: Read Key Files
-
-Read in this order:
-1. `CLAUDE.md` or `AGENTS.md` at project root (project-specific rules)
-2. `README.md` (project overview)
-3. `package.json` or `pyproject.toml` (dependencies and scripts)
-
-## Step 3: Understand Git State
-
-```bash
-git branch --show-current
-git log --oneline -10
-git status
-```
-
-## Step 4: Check Pending Work
-
-Use the Glob tool to check for pending plans:
-- Pattern: `.agents/plans/*.md`
-
-If `.agents/plans/` exists, identify:
-- `.draft.md` files — unfinished drafts waiting for review
-- `.md` files (without `.draft`) — finalized plans ready to execute
-
-## Step 5: Summary Report
-
-Write a short, conversational message addressed directly to the user. Mention:
-- What the project is and what it does
-- The current branch and what it's for
-- Whether there are uncommitted changes or pending work
-- The command to start the project (if available)
-
-If there are pending plans, list them clearly after the prose summary:
-```
-Pending plans:
-- inventory-page.draft.md ← draft, not finalized yet
-- add-user-authentication.md ← ready to execute with /hopla-execute
-```
-
-End with a sentence like: "All caught up — what are we working on today?"
-
-Do NOT use headers in the prose summary. Write it as natural, friendly prose, then the pending plans list if applicable.